From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D67B5C25B48 for ; Thu, 26 Oct 2023 15:53:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67C7A8D002C; Thu, 26 Oct 2023 11:53:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 604308D0001; Thu, 26 Oct 2023 11:53:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A5188D002C; Thu, 26 Oct 2023 11:53:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 37A618D0001 for ; Thu, 26 Oct 2023 11:53:40 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1272340B58 for ; Thu, 26 Oct 2023 15:53:40 +0000 (UTC) X-FDA: 81388057800.05.EEAC606 Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) by imf18.hostedemail.com (Postfix) with ESMTP id 1A5F11C0021 for ; Thu, 26 Oct 2023 15:53:37 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=dabbelt-com.20230601.gappssmtp.com header.s=20230601 header.b=Gs8fYJQg; spf=pass (imf18.hostedemail.com: domain of palmer@dabbelt.com designates 209.85.160.46 as permitted sender) smtp.mailfrom=palmer@dabbelt.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698335618; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=7hynPC3scdZ40zr3lj72+b2FKOXBK+Y3Zgo5uOul25Y=; b=BPKL4XlUNgYSB488xAeha2FD3gGg/p8lYLYZyZAkwBDSpP9ub3T9M73JhzX7d1Oh0kPNHz 9O6UruDwc1McFjTQglWdi29V5PwiKMOvEko6ilMtmyb5fZBhq/KPWM5euzeT+r5XCRp+rB mCq/xDEzass5aGQvGKEvdwNwymJZcNc= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=dabbelt-com.20230601.gappssmtp.com header.s=20230601 header.b=Gs8fYJQg; spf=pass (imf18.hostedemail.com: domain of palmer@dabbelt.com designates 209.85.160.46 as permitted sender) smtp.mailfrom=palmer@dabbelt.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698335618; a=rsa-sha256; cv=none; b=SgtazSewVIB72o2e9VO7pUkAxB6WiknGsnJjJ1iQXfYZmThLQFai3IrmI4AkfPQDR9GJuT OKJdOXbihkRtr7cUx/PBrGsaSBna5MhpJZlIpiKSF/laTTMsCWzca3Zoc5UTIUzFmVca7B e3FYtK08Yo/4rpIHUtmY1+PfN8alGdw= Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-1e9c42fc0c9so560583fac.1 for ; Thu, 26 Oct 2023 08:53:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20230601.gappssmtp.com; s=20230601; t=1698335617; x=1698940417; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=7hynPC3scdZ40zr3lj72+b2FKOXBK+Y3Zgo5uOul25Y=; b=Gs8fYJQgFYKwRIWYt4yaVkJ22NntunRlNN0/5s/Bzb8pQZ+ZRxIsdOAK02ZzIUHlvR PDSmaPPLDTMrDcD5eaAYbgg8KWrPccE/9esPt4HA0AIfg0vUED9W9mL79mOSSmiEjEQD 7TjHrVnp9XsujPy4zi9JlIphhaT9L9jst0omKKsVr7DpKjXfPrE2LSIccpBgF6CBOfYv gSiR0Ij1fVRHKNOusOaWiiElJyzkEqQFR34UGORMUD14U/zwknB3jT/4RMAyOjp8WYWN tQnbMrNSe48mPjeUlKJK6YlI409SPuRFHQR8jWnYZVB4dK46mA5hn6lA+jCOtsNPmEyi Ls+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698335617; x=1698940417; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7hynPC3scdZ40zr3lj72+b2FKOXBK+Y3Zgo5uOul25Y=; b=FhFea7ecCDBdDLtAms/PQbcSaY/R16e/EPMAg0FYJ2f0rZRqI80qKBkSt1bFhVfTc6 HE08H+7EjRdfW/QN12yQM0Aly2sd7MRFH9IKabdA6JeuRFeiDlxA83fBDpqles93WMDF EiG6ELDxAsU+17IN/xPrXqrtYKcHJLvh+i5MNi4w3NB0Rd9/C1PiYK9me++xW1Il9OG4 QYjjVtb0PQurDS2dlqXBUTZQjOK7ywMXflZZ7q233E8gcdZybtgNvsUB68hWfJPX0gsN IsI73RmtUk8ZjmKSliKZZCLrL0JgIKiBRo8qlVklTGayHEKsPBRNJtE7DgLJ/Z4rsVi2 SyjQ== X-Gm-Message-State: AOJu0YzvPHKiuOvJzFn/b3IqC/fcEdRbPx/U5Ep7vKThPClCC2Pq37qy otrv9GnJ4DbhnXvThZ3GLxxJgg== X-Google-Smtp-Source: AGHT+IEeyHg1dUDgFZE6ROA2MlEUvrjJFouNC+lSWthpjwRsuxTpjV+ibRRLmcvAGnBUWfF0nMVdlg== X-Received: by 2002:a05:6870:2b15:b0:1e0:eb36:a7ed with SMTP id ld21-20020a0568702b1500b001e0eb36a7edmr22601245oab.29.1698335616806; Thu, 26 Oct 2023 08:53:36 -0700 (PDT) Received: from localhost ([192.184.165.199]) by smtp.gmail.com with ESMTPSA id dd4-20020a056871c80400b001ef459c9a72sm479351oac.29.2023.10.26.08.53.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 08:53:36 -0700 (PDT) Date: Thu, 26 Oct 2023 08:53:36 -0700 (PDT) X-Google-Original-Date: Thu, 26 Oct 2023 08:49:23 PDT (-0700) Subject: Re: [PATCH 6/7] riscv: mm: Always flush a single MM context by ASID In-Reply-To: <20230910-haggler-barrier-421cefb0cc79@spud> CC: samuel@sholland.org, alexghiti@rivosinc.com, linux-riscv@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org From: Palmer Dabbelt To: Conor Dooley Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 1A5F11C0021 X-Rspam-User: X-Stat-Signature: fbn18in9a9mb3qsnxc9k768nuod7axn7 X-Rspamd-Server: rspam01 X-HE-Tag: 1698335617-703706 X-HE-Meta: U2FsdGVkX18BXfGJ0En99ZK6c+OI/LhYt+PdKvhHZoEKmr1wg2AmoUDjF/uOIN60xtWpjY2AlyO52p+QNsbGiwX8giNRBJCjedDNL2ZahVGqa6AJ2LrrIowwzGEQLisL6leD6oyelOWEvx1TPuqkuzqSacxtKICsiNIFjJ0ZGd8eE7okxxnOk0JHTN2mM1mDA/f6GIX+fpua4x3mMUXuJE4LApv6Z68HHmiNMfiTGMJ04A351BioqrqPRRLNxgB2gW7UPA6N60KOV8XJuASec4W/SG5dXmBNx2N71tBuDingoMurFsnprkXbYsOnJhSm3fO9xFJ5rvEVDffLdVIvapWO0fk8Hg5gBUj65QieySJn4ysJJWdEWxzf/vDOI6aKLhSs6GiLhhrbcQ1AT+oVMC6jqETD3f6esJDWHwJK+FRL9QgpMZ1rPLnqNS90C4p/cZn/XdVOejTw4g3JXBaunY1r7YvHLUk7wjt9vFsZpv3XUShFuU62H7aouvACbuazL8A5fxgg/wDeCbz1jFvSFvwLFkKSPM6XVrt3nL7oNTjtW239pFwGP5pTuD8gP1pRpi8yuChcyHGxsy673jqZ0AP3Oz8CpOaSHE9Ry5iZ/DlvMSYvpD9hiAtb8G9+jOpYTxTTdSMxqAMFzpUpMSLLnWmWkNLNJVRgqYry2q+TZjmdT4vr71ACGPEIF9bngjXWHiyNKT+zHJb29PkxNQUyshCzeKmKosOUMSNvQqhlV38lIPxBfy6+OGpIOoxi/X9uCKdaHvj3bzSQ+4r3KKjz09o8ivEU/5wXLWBm1fjvchaHI8JSzC3VrNyobdktynUJgu6s2dRm7wpCkXkr85jN+00M3ETaBz9jfB4WGU6Mmy01MpHYlKT5EPu6YhoIqkda3SLLLdgbTLOXGA1DeEgOszJF+kZ+PvgjCY5Qq7svCSNzXezne5MDHgZQgb1eQBA95SbIZMAjf2erJ0vRrMm GpchdbGb B+I3mzWeqfuJIGy27hmGf5q2rv/W/hXK8b1juIKyzf4mLlk47IftFUiJzgQesZEREixty7ODlKQBEwG9hhltCCRSY+IdjXOhCSbLWizCHngLQsnVQgvAlYA9ZikRhCd6vQSW1LQ+/h/GFZN0x+KT4mw6yRrMj/YSp5mdvFfK6/anOXz4OVMdIf605K9UisKxB/ZoqnLXp5VlNMycTiVUHeMeOQk9Km5KZ5rIzBVxP05T0c9pBTgl5DyWyL7biOJufdB758hXwfnbgWMAkO1CTO4PmzjbceqzXsCwhO77Z2yWgq14nwRFp0geeVYTXDzQrwLOx3WfZiv5B2ClNiEKlegx2084lNxvS4G1t+dBGCl353XhLQUF5EVZCmwvz49Mxa4Ue5kuq3YNVEPU9kMonjvADAFNCQtf5HvSsxc2L4wwxJFqsjokaWblk2Yui3bppoxcjWDhZmkoEDSp/jU+Cuw7wSIHXbbEbbUYCD/XXu7TqbBetV9PY6B44WA8G1PR/9nk7tR0v7hgigDhqik2wN2mM+nKISzhwnWOCYZENoxvG3OLW3rqbN/LfvNuCxdDYA/duBMKboaQdy2z+8lL7p6XSsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.421816, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 10 Sep 2023 12:46:38 PDT (-0700), Conor Dooley wrote: > On Sat, Sep 09, 2023 at 03:16:34PM -0500, Samuel Holland wrote: >> Even if ASIDs are not supported, using the single-ASID variant of the >> sfence.vma instruction preserves TLB entries for global (kernel) pages. >> So it is always most efficient to use the single-ASID code path. >> >> Signed-off-by: Samuel Holland > > On nommu: > arch/riscv/include/asm/tlbflush.h:59:69: error: 'mm_context_t' has no member named 'id' > arch/riscv/include/asm/tlbflush.h:61:9: error: implicit declaration of function 'local_flush_tlb_all_asid'; did you mean 'local_flush_tlb_all'? [-Werror=implicit-function-declaration] I'm getting a few more build issues as well. One's over here https://lore.kernel.org/r/20231026145516.25866-1-palmer@rivosinc.com , but I'm also getting In file included from /scratch/merges/ko-linux-next/linux/arch/riscv/include/asm/pgalloc.h:11, from /scratch/merges/ko-linux-next/linux/arch/riscv/include/asm/efi.h:13, from /scratch/merges/ko-linux-next/linux/arch/riscv/kernel/setup.c:40: /scratch/merges/ko-linux-next/linux/arch/riscv/include/asm/tlb.h: In function 'tlb_flush': /scratch/merges/ko-linux-next/linux/arch/riscv/include/asm/tlb.h:18:9: error: implicit declaration of function 'flush_tlb_mm'; did you mean 'flush_tlb_all'? [-Werror=implicit-function-declaration] 18 | flush_tlb_mm(tlb->mm); | ^~~~~~~~~~~~ | flush_tlb_all /scratch/merges/ko-linux-next/linux/arch/riscv/include/asm/tlb.h:18:25: error: invalid use of undefined type 'struct mmu_gather' 18 | flush_tlb_mm(tlb->mm); | ^~ cc1: some warnings being treated as errors > > Cheers, > Conor.