From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7F45CE8E6A for ; Thu, 24 Oct 2024 18:00:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C4C26B008C; Thu, 24 Oct 2024 14:00:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 14E9D6B0092; Thu, 24 Oct 2024 14:00:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F31106B009C; Thu, 24 Oct 2024 14:00:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CE9EE6B008C for ; Thu, 24 Oct 2024 14:00:45 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2D75F81441 for ; Thu, 24 Oct 2024 18:00:29 +0000 (UTC) X-FDA: 82709260914.11.FF54AAD Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf30.hostedemail.com (Postfix) with ESMTP id C3D448001B for ; Thu, 24 Oct 2024 18:00:07 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=dabbelt-com.20230601.gappssmtp.com header.s=20230601 header.b=Iu8L3sN3; dmarc=none; spf=pass (imf30.hostedemail.com: domain of palmer@dabbelt.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=palmer@dabbelt.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729792791; a=rsa-sha256; cv=none; b=WDDNlKFugXqNlzPxpgaZoa6VBz1kJUokeNrMTNfAmaONYoNwYCoGUH5lNOGT07r5/UNBCv I4DBzg7DkIUtuEcg8fHLWY/ubg7YP21DFLNnx4CNAt15v/c6UVkh9Hnnr84tmj5qRRKPco OnTxbqIk7/Ah6EZOeiIkXOvbCv3Lpto= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=dabbelt-com.20230601.gappssmtp.com header.s=20230601 header.b=Iu8L3sN3; dmarc=none; spf=pass (imf30.hostedemail.com: domain of palmer@dabbelt.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=palmer@dabbelt.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729792791; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=U/q1WiGJcS/tkbhu37qaq0jxibdm+CvDbpDg/bK1kAU=; b=ShSM4UjqwNl2/8aivchC5B2WPp1Q5GheMriBgdj4Ak6Z7hswQapuVihoF0SOn/8A0cunMy XF9OGq2Q/x3QNjmmTigUhIM3rph4MCpXqMViUjcEYpjjo8IXD/Uhsuq470XT0hSlizEVXB WSf9jDYoGhm2oqjOv0kNkE2tu9akYpI= Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-720519c4e2eso117198b3a.0 for ; Thu, 24 Oct 2024 11:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20230601.gappssmtp.com; s=20230601; t=1729792841; x=1730397641; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=U/q1WiGJcS/tkbhu37qaq0jxibdm+CvDbpDg/bK1kAU=; b=Iu8L3sN3tgQpyYwRg4fMqJ01ghSyLSKSi2G7gRSWRIseWYSYPB96g4VjCx5/timp+5 p791rrimLaHNn74a50ZZnKNgGn+3CHJk2hOxglT3+PDLkM8GM9xF8tCezxiD0MetAFYH IBhMdmgt7znU9Nhyd/MTDyg6GSmyndYt15Ybl2GXpeEWXScf0ZiT+nkdktOd4d64O9+o iccvzEu0ksqBMZkIsjcOaksX5IQxph+gAyN67NK+lYt0WbCQZ3TKP79VdLu706VgkJK0 K+uXqeDBPN2Ro63yqca3ZpSeOBesDqoENAOyNaMl2P6XH0SmCNgpIH6uM7D7wLyLzpk2 po3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729792841; x=1730397641; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U/q1WiGJcS/tkbhu37qaq0jxibdm+CvDbpDg/bK1kAU=; b=eQWoC4kKoF44HOkjeN1c7rlagssDxP/3N5enX5wHhRcLJpqYWruveITC3SiQRLOdKQ ijo5xR4ueML/PnNTqu7koXOF7GAoZ44x+pQi0JacYOAzP8LQiJ2Sb+o4/KIhHTQI9cPe Br2jq9ihsKMWBHfDYNSJGflsbhvPBJbJeAgHlZitsHwCrH9E0Ia1szrU4oteBp3oPtYS BNbHmpYiZ/UJNQRHziIK2KcBzQJqcLlrO2CR7W73tfzWalhDR35PEjCnP96b9WJDySZQ A4utyQIXE7SPe4zJANZQXdoUE1mEClgawgAOb5tON0vKAbyacExzGOVHiFxHTko19AWR juow== X-Forwarded-Encrypted: i=1; AJvYcCW/4lwUK/0dq8P6jXGxlObk6eX00M8o+/NVo/50bz4ft41pWFLhGwuvimuFvHuPF/FFGTFEWEXpzw==@kvack.org X-Gm-Message-State: AOJu0Yw5MCD3Qn8zZKeRN/weT+sc0uz0FBWaOAXLN/VMbLgt4C+Lgj7T DD2BtwoTItWjehFJsDCNq1RG8vyeT3bUZATILofq5Nahun7+gCPdBg0eS90zAr0= X-Google-Smtp-Source: AGHT+IEWB1udhSviA9LAWrRVloAe7iAHeKwlFuxSRB7lYrklQRgkKc7BVJq9iQgQFB+GNpPYe7xzxw== X-Received: by 2002:a05:6a00:2e1c:b0:71e:634e:fe0d with SMTP id d2e1a72fcca58-72030a8ae4bmr10220156b3a.12.1729792841339; Thu, 24 Oct 2024 11:00:41 -0700 (PDT) Received: from localhost ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71ec13ea720sm8218735b3a.157.2024.10.24.11.00.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2024 11:00:40 -0700 (PDT) Date: Thu, 24 Oct 2024 11:00:40 -0700 (PDT) X-Google-Original-Date: Thu, 24 Oct 2024 10:54:46 PDT (-0700) Subject: Re: [PATCH V2 4/4] selftests/mm: skip virtual_address_range tests on riscv In-Reply-To: <20241008094141.549248-5-zhangchunyan@iscas.ac.cn> CC: akpm@linux-foundation.org, shuah@kernel.org, Paul Walmsley , alex@ghiti.fr, Charlie Jenkins , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, zhang.lyra@gmail.com From: Palmer Dabbelt To: zhangchunyan@iscas.ac.cn Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: C3D448001B X-Rspamd-Server: rspam01 X-Stat-Signature: c7h3wh13difwdjnzg9g9y4n53qe189yd X-HE-Tag: 1729792807-636344 X-HE-Meta: U2FsdGVkX1/fe+hIg6DKqCzhScwPLvFQLgY8j/GBj9dqecdgkT8RgjTK4d9T+CaeGZLKpELPtk12iYEimec9bx7cqypjcMDqkBQ5RCnwl0H6CzYjOd2MeEkJ39fbGMki90P54FfTHgbED2258GrnKFBrNHhw5J9vwCN4Y8TKkQMlMIQz1JVxC7duVr/trJucuP3HQUD+nOejUKF6aC4ebd/YsMUmhNJJsYfkhyyS8XEaTgD/kFLPBFWei7qNri0BXVCTyBQB/ku2qapxe7HPeP7BzqJjTLJI9PjrEBlRHuhYjHZSzUkZHrQJVsNgqkWxRTUbdoABDQkXR71tepw9SGkO90lgYH36wXcKMLEaqfzbg1U7TrJqYY4t5w+Fu+PCFQ3eMOiy6AhEC18D8XTFsitW+AteGU4MscKWmotX+m2hxzAkBGK6eYzTyfgd1FWcUDroCSpdl4pjjxWxqLZdibQUvtM08nyft98uZUL7PnP9MnUHDMA7n3c00LTjgYzX9IP1ueQLnc+T8LXiMMEmiDlOV9KGrA3dF7EaSRP8tCqbFHeOA8eGe8yNiToKHb5hqZ87BmgZ+VLW14LUY9i4MV+9zYTfw9uaSQQrEvK3LsBTnZYUmHms+MEkK/o6xqRVQGTNJZ+YLDP30zT3BL8uzeKwBQFWSjaqjZ/o5aX6a4a7ANx0xEsCx1kr9kKc/o8T3/pnDOgZfqj8Uef5TCS+42wp0ahMhebq7Ini682PwL5ScDtV3XKlnXpaAjpyMcPWjxGTKiFvE6GI2uY70LkAc6MBwwrpwrCyVKQpVogqea9INscfv9MigLLq4OPl90KQP/Z5S/freynFabtZWYubsrlRkXiTf90tp0cDQlgNGKB2rIgnnrbR37XYAaCSxITh/riXS49Ipx3LhC151EqAegQTnq4l7/7DhMOq/Zftgi6OMJnrxCuYwH6a2OAnAtSxDtHdOu9cugfPPIPI3Gp 0e4pguDq t28zCOmuFhWqVE+1UcaxOGYK3bQeSefwwb4MMy6rNAMHPtHJc9Xz60mluaW3KUX99MGBhBoMmjUMx97yn+3qI3FfAc2dQVrZAmrdvp+vp1+gENI7zrr+stN/9R7u+knf6yG7AmMIW9GHmQenv2m2YUklndjHUeTJfWhGLMh7CCygfoWv2mGzFZdXh+lCipRiuwp+Iei47lljq5u1M6ff+Vvokbwb2ZllCXPw1UJE3UT9AJ97ZF4AWKjpsVZ6cu642+swhlvygQo5vN/tIUCl50WXLB5dYYkdpkFhH9bGYbXkBLIWbmA2MY/SCBASZjBXEHjyBYcc09Pi0plZxKv0AcO18KdgeyR8VtwBIivVO0lgceHV6wZRONnou0KhGOU5giMkjvgnM+4dTot7ZzZydgXnQB/cMln8GOudn8X0RWoYQ7iodnwQzSwwGhBZwromwtOdtf6wWEcZwkzRhv0VW49i1iuKuWUVJaeqnEWLkN3gVVC1/N6FYRZy1RBfafBjg+X2hN0ZY6zfeBXseuqxiGaJ/R/YPArDwX8b8DOG2bH+r7dVP/j3QaWVQls2lT3BmetcR0Fk2Pl14ci0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000435, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 08 Oct 2024 02:41:41 PDT (-0700), zhangchunyan@iscas.ac.cn wrote: > RISC-V doesn't currently have the behavior of restricting the virtual > address space which virtual_address_range tests check, this will > cause the tests fail. So lets disable the whole test suite for riscv64 > for now, not build it and run_vmtests.sh will skip it if it is not present. > > Reviewed-by: Charlie Jenkins > Signed-off-by: Chunyan Zhang > --- > V1: https://lore.kernel.org/linux-mm/ZuOuedBpS7i3T%2Fo0@ghost/T/ > --- > tools/testing/selftests/mm/Makefile | 2 ++ > tools/testing/selftests/mm/run_vmtests.sh | 10 ++++++---- > 2 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile > index 02e1204971b0..76a378c5c141 100644 > --- a/tools/testing/selftests/mm/Makefile > +++ b/tools/testing/selftests/mm/Makefile > @@ -115,7 +115,9 @@ endif > > ifneq (,$(filter $(ARCH),arm64 mips64 parisc64 powerpc riscv64 s390x sparc64 x86_64 s390)) > TEST_GEN_FILES += va_high_addr_switch > +ifneq ($(ARCH),riscv64) > TEST_GEN_FILES += virtual_address_range > +endif > TEST_GEN_FILES += write_to_hugetlbfs > endif > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > index c5797ad1d37b..4493bfd1911c 100755 > --- a/tools/testing/selftests/mm/run_vmtests.sh > +++ b/tools/testing/selftests/mm/run_vmtests.sh > @@ -347,10 +347,12 @@ if [ $VADDR64 -ne 0 ]; then > # allows high virtual address allocation requests independent > # of platform's physical memory. > > - prev_policy=$(cat /proc/sys/vm/overcommit_memory) > - echo 1 > /proc/sys/vm/overcommit_memory > - CATEGORY="hugevm" run_test ./virtual_address_range > - echo $prev_policy > /proc/sys/vm/overcommit_memory > + if [ -x ./virtual_address_range ]; then > + prev_policy=$(cat /proc/sys/vm/overcommit_memory) > + echo 1 > /proc/sys/vm/overcommit_memory > + CATEGORY="hugevm" run_test ./virtual_address_range > + echo $prev_policy > /proc/sys/vm/overcommit_memory > + fi > > # va high address boundary switch test > ARCH_ARM64="arm64" Acked-by: Palmer Dabbelt (I'm taking the first two as they're RISC-V bits)