From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D552FEB8FCF for ; Wed, 6 Sep 2023 13:16:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2473428001A; Wed, 6 Sep 2023 09:16:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F63C280017; Wed, 6 Sep 2023 09:16:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BE6D28001A; Wed, 6 Sep 2023 09:16:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F09E5280017 for ; Wed, 6 Sep 2023 09:16:16 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B8398120857 for ; Wed, 6 Sep 2023 13:16:16 +0000 (UTC) X-FDA: 81206221152.22.CB170A8 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf23.hostedemail.com (Postfix) with ESMTP id 3F7FE140026 for ; Wed, 6 Sep 2023 13:16:13 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=dabbelt-com.20230601.gappssmtp.com header.s=20230601 header.b=rWhHp9S7; dmarc=none; spf=pass (imf23.hostedemail.com: domain of palmer@dabbelt.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=palmer@dabbelt.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694006173; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=6uld++PB00AvttIUabIU7xcqVSkPz344JqFl8ppv134=; b=vFiB3wy7QUITW7w8oAszyrylnRNscs6bg+Hl9LKh2Y3sBvhCRn309ocybnFAsGXEyeoJo6 PI3K+lbUkpGtKTyrFHZ5upH9wcsHtlMEpCSyZaPus8Gn/mLITU9ToyBdn0ZMFv+3aW/TI/ wQANfVHUaNcBWyZcEd6Ll+iCg1N7SqA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=dabbelt-com.20230601.gappssmtp.com header.s=20230601 header.b=rWhHp9S7; dmarc=none; spf=pass (imf23.hostedemail.com: domain of palmer@dabbelt.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=palmer@dabbelt.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694006173; a=rsa-sha256; cv=none; b=VkfACbVoYc8bVwABXgHWwLWn1YZPXG70ikne1SFhWaQm2jzR3Hr+cjfaW8Gh4keq8llb/k f5FiUhHELTb+sCoHdPfDWO6AigxfsHF4k3XPthH4fAqNLSE+MyZqCbNHLAhJKo39kJ3h+Q eGGofgoBdGiy8E6AXBg5uRebruny52s= Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1bf6ea270b2so19992275ad.0 for ; Wed, 06 Sep 2023 06:16:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20230601.gappssmtp.com; s=20230601; t=1694006172; x=1694610972; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=6uld++PB00AvttIUabIU7xcqVSkPz344JqFl8ppv134=; b=rWhHp9S7vLFu9yP2oRvyBL4hw9HQKtIQlhdXvcoVhLA68bILtaEQIGcQoQmijR0XOE J76TU9faITKKpjjy/Pp9ovK1g+YiPv5me7i37bo8FFG2XkrHaOmXwBCrPU/DgWu84dIB jGHJ85KW4zhPMDtJy+RXQ2iPIe1P/7Y1wKGUxrU1Kem1g0s1YEHHUOGkstA51B42XHqb HQyIaD7arHkjWIJjC+Lpjso4Zq1vwkptWxjckQ8fDogZPpehHkcpAbSnlPzp5AM4NAOa zvOk94p+L6pbb7xLcF35eSXUuupPBgm3stqxlkPvfoRjr8rdpxpxoJYihDDDeLfdyMMP VzTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694006172; x=1694610972; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6uld++PB00AvttIUabIU7xcqVSkPz344JqFl8ppv134=; b=QauCEfxu3B+tgsUWEIxUiQ9jYiRapgwP9opSoDGcLM3dPouoUDSZLwRPVMaufec9Kh 3eIi8X93wpRyezwNdHo1PGTGN4aNIfLr+NPeJTr0MK9QfzM31hJhEG9GLFt3ykc7t5eZ NyZiENT78HG3BBzEgfSJZs4iB32q1W7IMGyqXyE4pEy16Z2aOOgFLkBjQU2cMl/3HR8l nTQ00crIkBXTTMBVZH7rJUwFuR4DaYRjSSrUcHLpJbEf7l022YQ4lS/jIEaSNJl0ljS+ AXm8/ebhEC95Wl5ce1z25wHtyYK+jrIny60yKW6+FELbbdJ8xfOy5cD6fGL40K3lOYNB w8KA== X-Gm-Message-State: AOJu0Yz3RuTflJ5e2TfzxKHvNuN5DqqSptqwLQuqAUiR/AIDcaJar/xq +C0lvMRfL8agh3gx7rCRjFe+eg== X-Google-Smtp-Source: AGHT+IE490DJ0B8HsJUKc5YGg+iZZKcgEd0HmXU6tZkHPl3GceN2Bm3rAS+0TX+wSHA1qhJxq3bR3A== X-Received: by 2002:a17:90b:4c50:b0:271:7a79:ecbb with SMTP id np16-20020a17090b4c5000b002717a79ecbbmr13634747pjb.28.1694006171898; Wed, 06 Sep 2023 06:16:11 -0700 (PDT) Received: from localhost ([135.180.227.0]) by smtp.gmail.com with ESMTPSA id gm15-20020a17090b100f00b002681bda127esm10986823pjb.35.2023.09.06.06.16.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 06:16:10 -0700 (PDT) Date: Wed, 06 Sep 2023 06:16:10 -0700 (PDT) X-Google-Original-Date: Wed, 06 Sep 2023 06:16:08 PDT (-0700) Subject: Re: [PATCH v3 4/4] riscv: Improve flush_tlb_kernel_range() In-Reply-To: CC: prabhakar.csengg@gmail.com, geert+renesas@glider.be, Will Deacon , aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org, npiggin@gmail.com, peterz@infradead.org, mchitale@ventanamicro.com, vincent.chen@sifive.com, Paul Walmsley , aou@eecs.berkeley.edu, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, ajones@ventanamicro.com From: Palmer Dabbelt To: alexghiti@rivosinc.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3F7FE140026 X-Stat-Signature: 11szc6st13agchw9uzgxw9831nztuufx X-HE-Tag: 1694006173-375960 X-HE-Meta: U2FsdGVkX1/T59kxumNg52ykzByTD2mrRK4bfs2xaEyBJfG/iXObM3UQfXiauxfKfnaS1K81XUwzPirJyA+Jc92y/aGtcHGQVQ+5NDkDXc4oN0SJzj2Ij3ZDQ+8Sc9/Karm5Sp2Bvx4VaUTMWrCi4r4/5kvlvdo0lEayapwI0dMkCTEdQS753na4LiY+bSPWV5h/55UvWUWLkxWy7Ty+VKbLbYBF0qNOQ9UJej8yyep126EP501uXwACh/AcD+8W1lhqjvlZUTQqJ+f729Pi5+cVWRGjO29LkNL7MnSnn9kmB7M65ZKiCRF64zQkkbfiJVGj+4xcx7ejkHIbQOopm3o32ah8Iwe0zy3/jG8wk+y8pWHxJjg43HwgOnp8U/x45CTKnzsOGzFZnOc4Mop9+DbCJQxa6xMVCrcro1f4jxeNKihHFCHDDFFttKfdWTg/2zu166cYF8MmOhiYEWJSSjJDETmZCZ7ouInAQ7tLzHTA/h1PkmPbujzbtiS7OE4mNlIzM36XL/Foy2mKdojqOm2GjY6Q1VBd9meYhCMYDvdJYlmtO9wpmGaIQwqhOtuIqx0GJEvFs8ORIbUP9KoIV43x2255EtmExabt1xxyelN0vPJ5Ym3HM4lOuruTlv39gbsIqkXf85LxFaHqRzQL78WEH1iU7HdVCtIwQjfpRGGUwyNLehotazpAvGkFwloEMzLUN2x3BQBYpAkisJ1q1DQy2YvHel7ZIDngA7ASMTYgmA1oZsGM7+Y9MBqT80ACBHHqFl1GF8axIhljqN7YfNAseTLLQ/SMhZv2BQkpBq9UAGTPZanmAT42KHonQMmuehFhAfjzLLco8JhgWX4aeOmk3NboQdLlIPHmQ553gEyUmFyXP2x6CgBnIZfmROW3V9WDo/qKCsXLwOlooEt6BwI7WplTJjE2flh3ipCbPZ92JAc0FISru/uZ3Ih1m1cQDqPpapAF0041/nOs8eX folY3Kt4 pkyjHbD7DMrBH3waRh6wW9k3PnIJpoGbmRQpdV/PEmMLAza+tYFSy3VBZOjf+C/XWN26taKMrs3vJYHriv4auxhJkBoh4E0tIpNBB7xjKDHhRTTmOugFgPtw+Dy9DWiYKCq4VNhOjloR7IhNeiwSWwkENb1SEII9eVLMnRCWolMyf07f9SB5TTmH7qOuyiN74N3mZx2QQS4kyehVM6BCNJvLDBPPbJ6ksN4il9zeTQzEV8vs3yLou+l6jHo7pU7Z7QYMuCUzY+mvEzTGEQkdfynKrisGXLcvUua/8TAK1C4eYp3DzcC8wkqnYf6/s/o/dg9fZD4LG28lK9YGNLUq2xjWAhwlvRgRN4LdDS8c+52R2N6eWo5YKvRtRlme3A/kdWulmoAa220EZz3lBX01AiPDAv1MgGwhtTHHis5H7eqJuuLPpeApgdzBenIHQ7OKpw1OrM5DL4Tc+TFZbnN1Rlc7dTOdU8BW8PvNib5BpQX6UexSOy71j6opeN4l/N0kDHk6MUN6MNEAS1X023Md5KEzKQHgjIPjZvlaGbpKVKwjW1PgEOdlaQMRQ7gN4LI0TFYdESZp1Ivq3afamYbB54w+WgUNbLHoFBjwHpcBV27Bc1Vlc5rGgYrQaln+pLFP3WFBmyPdEutW9ZszfSgco9bZ4Zmkw1p21OywJeTvPywke5w2fGoeb4oVOzeF23Syrkk3HsdqOYrt/G9s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 06 Sep 2023 05:43:46 PDT (-0700), alexghiti@rivosinc.com wrote: > On Wed, Sep 6, 2023 at 2:24 PM Lad, Prabhakar > wrote: >> >> Hi Alexandre, >> >> On Wed, Sep 6, 2023 at 1:18 PM Alexandre Ghiti wrote: >> > >> > On Wed, Sep 6, 2023 at 2:09 PM Lad, Prabhakar >> > wrote: >> > > >> > > Hi Alexandre, >> > > >> > > On Wed, Sep 6, 2023 at 1:01 PM Alexandre Ghiti wrote: >> > > > >> > > > Hi Prabhakar, >> > > > >> > > > On Wed, Sep 6, 2023 at 1:49 PM Lad, Prabhakar >> > > > wrote: >> > > > > >> > > > > Hi Alexandre, >> > > > > >> > > > > On Tue, Aug 1, 2023 at 9:58 AM Alexandre Ghiti wrote: >> > > > > > >> > > > > > This function used to simply flush the whole tlb of all harts, be more >> > > > > > subtile and try to only flush the range. >> > > > > > >> > > > > > The problem is that we can only use PAGE_SIZE as stride since we don't know >> > > > > > the size of the underlying mapping and then this function will be improved >> > > > > > only if the size of the region to flush is < threshold * PAGE_SIZE. >> > > > > > >> > > > > > Signed-off-by: Alexandre Ghiti >> > > > > > Reviewed-by: Andrew Jones >> > > > > > --- >> > > > > > arch/riscv/include/asm/tlbflush.h | 11 +++++----- >> > > > > > arch/riscv/mm/tlbflush.c | 34 +++++++++++++++++++++++-------- >> > > > > > 2 files changed, 31 insertions(+), 14 deletions(-) >> > > > > > >> > > > > After applying this patch, I am seeing module load issues on RZ/Five >> > > > > (complete log [0]). I am testing defconfig + [1] (rz/five related >> > > > > configs). >> > > > > >> > > > > Any pointers on what could be an issue here? >> > > > >> > > > Can you give me the exact version of the kernel you use? The trap >> > > > addresses are vmalloc addresses, and a fix for those landed very late >> > > > in the release cycle. >> > > > >> > > I am using next-20230906, Ive pushed a branch [1] for you to have a look. >> > > >> > > [0] https://github.com/prabhakarlad/linux/tree/rzfive-debug >> > >> > Great, thanks, I had to get rid of this possibility :) >> > >> > As-is, I have no idea, can you try to "bisect" the problem? I mean >> > which patch in the series leads to those traps? >> > >> Oops sorry for not mentioning earlier, this is the offending patch >> which leads to the issues seen on rz/five. > > Ok, so at least I found the following problem, but I don't see how > that could fix your issue: can you give a try anyway? I keep looking > into this, thanks > > diff --git a/arch/riscv/mm/tlbflush.c b/arch/riscv/mm/tlbflush.c > index df2a0838c3a1..b5692bc6c76a 100644 > --- a/arch/riscv/mm/tlbflush.c > +++ b/arch/riscv/mm/tlbflush.c > @@ -239,7 +239,7 @@ void flush_tlb_range(struct vm_area_struct *vma, > unsigned long start, > > void flush_tlb_kernel_range(unsigned long start, unsigned long end) > { > - __flush_tlb_range(NULL, start, end, PAGE_SIZE); > + __flush_tlb_range(NULL, start, end - start, PAGE_SIZE); > } > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE Alex and I were talking a bit. I'm OK just dropping the TLB flush series for this release, that way we can get to the bottom of what's wrong. > >> >> Cheers, >> Prabhakar