From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 115E0C6379F for ; Wed, 15 Feb 2023 03:19:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A3B06B0072; Tue, 14 Feb 2023 22:19:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 554476B0073; Tue, 14 Feb 2023 22:19:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F47D6B0074; Tue, 14 Feb 2023 22:19:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2C9806B0072 for ; Tue, 14 Feb 2023 22:19:21 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EEB39ABA30 for ; Wed, 15 Feb 2023 03:19:20 +0000 (UTC) X-FDA: 80468070480.03.5B8FDBD Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf20.hostedemail.com (Postfix) with ESMTP id 29A521C0011 for ; Wed, 15 Feb 2023 03:19:18 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=dabbelt-com.20210112.gappssmtp.com header.s=20210112 header.b=TDWQ9Pmr; spf=pass (imf20.hostedemail.com: domain of palmer@dabbelt.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=palmer@dabbelt.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676431159; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=hBDtDorWVGGnbAJlstCVLXC4KgZYcpfN89nn0eLodho=; b=2PzPxhLuEXANoHt8W97LoooFbfCN7mt2l4ym2xLbieSgnI72aNEoMdidD0RvepPWCUMv8k ZbsHcVGWo4h5a2ucvlMXD3KfJy23MlYdRUSZFYB2PDsoBNBp8x4Pljm7EvrFoRdpP2j6zr 6SHcdQzccPW0fZHqtDVK8JhRXitohas= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=dabbelt-com.20210112.gappssmtp.com header.s=20210112 header.b=TDWQ9Pmr; spf=pass (imf20.hostedemail.com: domain of palmer@dabbelt.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=palmer@dabbelt.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676431159; a=rsa-sha256; cv=none; b=ENvl1FnRY7jtwBX07rU6H+XaLYwDrsy3dERxcQVNeghEH1aqLpFjcuIFnssIJYaggeYsCP 0ODUiQhItry/xDc+l76sXGk2nNkGObAtnmt4D7oaJFObgrNVN39ifRw6sd4+6FrNyY8nj4 Jl4WPlCPvLGhivX7oWGutgik6QDqAtU= Received: by mail-pj1-f42.google.com with SMTP id bx22so16943401pjb.3 for ; Tue, 14 Feb 2023 19:19:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=hBDtDorWVGGnbAJlstCVLXC4KgZYcpfN89nn0eLodho=; b=TDWQ9PmrwvLUcTo0lBlRuDBs6LfyqBjYoFXCZSj6/7iKJCjhRwcJUbUfI2buPyb9rd xeco65Idbt5F69GXs19eLIIr/E1mdOW2sDO18XzrsZBD+rCxSEr0HrphkGMlLecQRNWE fKVUl2wxjhX+iWtZIZ57DBC+0rBbt0ZIv31fmglw+YVgSA6KxZa6p66Eua+MsJsNGMI8 QUdukJNui/NdiTy6lOPb8nzXYjzh8NSH1P61qaqV/ULSjXcyz1Qe24/S8Er3ohkeZQiP ZlVHKsxbxVvaOFpdk5QC1EZcAOetNy6F/lOwxCTH9nYKnwp5L9U3HtfofiOq7NcIsB2B A1nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hBDtDorWVGGnbAJlstCVLXC4KgZYcpfN89nn0eLodho=; b=RHWh5Na0buVALFgdwps/Nlv2iWqv11GWKjXiFRGR2qGCm4lGx6KWvuL6JFhw31EGdX nYxPNrqBtKTi92c6lcZXQVt5lK7p0i+vHLSk05FWO1aPdFsvbE447ryF9aKHAGg2NV6+ DQ7vQiYL0EYco+ALyaDpZDRLvLUS9iKz4ep0NumoCnTdV3BZaO7cSIpn2/2lQ/1z5pvF SpmXrF+zCTAXEixrciP/iwMcXViODPrhRjw8QRmXFYkiXVzaETYs/eb+s78GfJbmRqu6 TPi0ddEiwoJmO5YUreHpI6MruhRf8ym1qAP1TMPBcwsHoB1uWIdx6PvDbkltjjA2ybSF w7XA== X-Gm-Message-State: AO0yUKUgHqMQkXnMJqg9J1El4RTZ1piWnLu4zgF3g51W4r2ClSsG5eOF 257JbbWTnd2rq02/3/upjHslLDF6Z6I9pY++odU= X-Google-Smtp-Source: AK7set8IZlzKTCD+NS6NLk03tw12Y2YvjAU5Kw+8dpbaSxkri3GTeMpV3jTg9FWVdAem4jZpgiABJg== X-Received: by 2002:a17:902:d2c8:b0:19a:85d9:93fd with SMTP id n8-20020a170902d2c800b0019a85d993fdmr938693plc.22.1676431157460; Tue, 14 Feb 2023 19:19:17 -0800 (PST) Received: from localhost ([135.180.226.51]) by smtp.gmail.com with ESMTPSA id s15-20020a170902b18f00b00189bf5dc96dsm10887390plr.230.2023.02.14.19.19.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Feb 2023 19:19:16 -0800 (PST) Date: Tue, 14 Feb 2023 19:19:16 -0800 (PST) X-Google-Original-Date: Tue, 14 Feb 2023 19:19:13 PST (-0800) Subject: Re: [PATCH] mm: remove zap_page_range and create zap_vma_pages In-Reply-To: <20230104002732.232573-1-mike.kravetz@oracle.com> CC: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org, Christoph Hellwig , david@redhat.com, mhocko@suse.com, peterx@redhat.com, nadav.amit@gmail.com, willy@infradead.org, vbabka@suse.cz, riel@surriel.com, Will Deacon , mpe@ellerman.id.au, borntraeger@linux.ibm.com, dave.hansen@linux.intel.com, brauner@kernel.org, edumazet@google.com, akpm@linux-foundation.org, mike.kravetz@oracle.com From: Palmer Dabbelt To: mike.kravetz@oracle.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 29A521C0011 X-Stat-Signature: pxdc18ete4qckdk1a5iwoecagj38xq6r X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1676431158-967866 X-HE-Meta: U2FsdGVkX1+WsvZfUKlyISHaDR/fYyADJEGKJ1vVkomk9cIS1YD1d3oHcMYrTsxzgaiXtDISPzEZ7c8zBa89za7XP1vP8h2ksnErHPyoXdYDua+Ty9ynL/9Wd4j2R6KOz+diNonzGuBVn0dhSy72jAjcpDrPLKRVUxVz7uQWJXUKeUpQG886kc1hF+YeHvCHh8bMTiXrQ/tKcMy0OhbB6Zxlemu2ooter8G8aVT9OnhXk+54vJ7YTmg+vcTWsyndh5g2VaLbeMkUDmYN7kyv9xg69D+1YzaxiAiBmLaathMcP9QC3JhYdXxkF/zmoZnngQD0mylXvjyTYobSQt9HRdu7ilACGxhwk4i8GxT2/KQBQjvL7qdrMAfJILaz3UmVJhlp9k1cNzTa+syF4OtT9bwhcgmSvW7wy9CVJsciw+lFhbksKddcVmGqhOI79vXnfdKExQv/5hG0z7Kq4tlcuyq/cHyNqSfNHX9sdUnlY1h7lDPDJEhJMWIwGPTAqMdkUiJ7irYV+nX72dLV69TL84nDzs7FnbWoDjMX+hJX+Nwkqd59v79iKAFdhbTEwvY14xTqUOdIGFHYBt8ZfV/mKC/WfAzgiaK8/NgF24yfrIO1UWln8J3OFrsPjdt3gx1Cr17yA1Xv/UtjqHOIPZ5qC5NFMgqrtkH9VqkSwY4RfkONePcxiqNDVVQmOpD3aT+bb49N3MX93Uh0Zk5qwwX9xb67zNdJNx+oP9ldTAH56S1Urb/cYD0LgJFmMAh42tyGQHABJZXlwCS+eX7EnZmtUOy3rT4Phrh0dTEczIBadEWa9QoX62xcf35KbOW6xAJ+5kNMaLXc0yo43M69T8sLIXEXR8ZigvcEdJhldJYl6gVJw6ftU3hYOqRMQIyTeiwuwC7tthDyHxaApjvtT21VvHgdgBaszN5T/pAMPVsB9VkYAyoZnyy3BjnXc+j8L5v5Cv4JdtjiA/9Bxg0uNYF WO+Pifh/ N6601YRc2N6o6B+t95iJ13dHGU8VMzFB6t57LPXXPv21WpPlec/M3HCKrdva3VWy3twvYWYo+dIC61naQqFHM47Kf6TbFF7OYjF5qhR1InmDI0Nesd2UNWfczbLq4RaW6djEfQlRphv2mgjyF85zEbb/wpS/3f2+zBImJmuWCoqX37gOJSysztgXnEYIzr/BUB5fR/iD0buSXKIhq6VfLPtHxGXgr5anqJIYuTrGy7pccihOvIAz2qN894i1ZzJH4cIrKvrzqUZRB8koVR7OsXe7iaWV+IG5D7dsCV9DfbU7b3jQy6NexT1wP5J3PFPHA+oGjVkbgaCUj/mPPsM0nD1lnrVRe6/NiPisKjGHjWQFme5KAttoJx6eZhwXVzUMAylpl1GNTz17uI/jAMCMsG/B9OZzX6BfM/KQMCOEFhjHHL59NArYKjXmKwrMqzct6VKVv5quzLmAUuBHx8+D7aK03p4I8+pueAz93wSedv3+14WcVRaRsK5RBcMVxFcUT1ALyn/oRjTVGaiGaE0JRSJ7sHZjQiQ4hujV5D/2TgNF23yeO9umFzDKAfPQqxAA08ROn3uLOSCiD07/MNX0JWa7q51PTRCIACw38o+09dIipBhMnmXHDLFotsbF4vumqTySac8qHQYs1HQ3/GhYeg2zHAJtOT3eyAi3TfnAlDfepJKhwZJVGsF/5a7A7NXhTx2F7Zpt7Qj3UD7G9RjEbQTxhgA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 03 Jan 2023 16:27:32 PST (-0800), mike.kravetz@oracle.com wrote: > zap_page_range was originally designed to unmap pages within an address > range that could span multiple vmas. While working on [1], it was > discovered that all callers of zap_page_range pass a range entirely within > a single vma. In addition, the mmu notification call within zap_page > range does not correctly handle ranges that span multiple vmas. When > crossing a vma boundary, a new mmu_notifier_range_init/end call pair > with the new vma should be made. > > Instead of fixing zap_page_range, do the following: > - Create a new routine zap_vma_pages() that will remove all pages within > the passed vma. Most users of zap_page_range pass the entire vma and > can use this new routine. > - For callers of zap_page_range not passing the entire vma, instead call > zap_page_range_single(). > - Remove zap_page_range. > > [1] https://lore.kernel.org/linux-mm/20221114235507.294320-2-mike.kravetz@oracle.com/ > Suggested-by: Peter Xu > Signed-off-by: Mike Kravetz [...] > diff --git a/arch/riscv/kernel/vdso.c b/arch/riscv/kernel/vdso.c > index e410275918ac..5c30212d8d1c 100644 > --- a/arch/riscv/kernel/vdso.c > +++ b/arch/riscv/kernel/vdso.c > @@ -124,13 +124,11 @@ int vdso_join_timens(struct task_struct *task, struct time_namespace *ns) > mmap_read_lock(mm); > > for_each_vma(vmi, vma) { > - unsigned long size = vma->vm_end - vma->vm_start; > - > if (vma_is_special_mapping(vma, vdso_info.dm)) > - zap_page_range(vma, vma->vm_start, size); > + zap_vma_pages(vma); > #ifdef CONFIG_COMPAT > if (vma_is_special_mapping(vma, compat_vdso_info.dm)) > - zap_page_range(vma, vma->vm_start, size); > + zap_vma_pages(vma); > #endif > } Acked-by: Palmer Dabbelt # RISC-V Thanks!