From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 003E8FA372B for ; Wed, 16 Oct 2019 19:23:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C708C2053B for ; Wed, 16 Oct 2019 19:23:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C708C2053B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 660F98E0005; Wed, 16 Oct 2019 15:23:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E9878E0001; Wed, 16 Oct 2019 15:23:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B0E98E0005; Wed, 16 Oct 2019 15:23:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0107.hostedemail.com [216.40.44.107]) by kanga.kvack.org (Postfix) with ESMTP id 20B9A8E0001 for ; Wed, 16 Oct 2019 15:23:05 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id D003B2C0D for ; Wed, 16 Oct 2019 19:23:04 +0000 (UTC) X-FDA: 76050620688.09.dog95_72243f7675c52 X-HE-Tag: dog95_72243f7675c52 X-Filterd-Recvd-Size: 3829 Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Oct 2019 19:23:04 +0000 (UTC) Received: by mail-pg1-f196.google.com with SMTP id f14so9743651pgi.9 for ; Wed, 16 Oct 2019 12:23:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=yNrX5NxWK+qA1o6LaqqAm41/yReowE+lc1hULeA+iQo=; b=lOhHwgYJIOTQpOrU8B5oMv/wjKOAp/n7oeI3WnOqhE18/m8x+iwFR98vGZy4ibh7Lq 2XC7W2kUjdYGSGVMpvMmMEWt/K8+RUP/wSY7QbKqL194KpTDMJ/TWArh7x+WFU3HqcQl yGJIvoovVtIhi14/HGR1dSmVMAx4ZitfA+Ev/3BBV9sD7IK9EXIG/oNy3FYQ9CYpU3Px zHo12tRI6bMbcpOWYNKap/YC7FzOESl0CFcvKqIdMp6fy4wYtPZde5LBbRV14Tg72lj6 nlvg11Jf0LZwbBAShqe8qtIAbVGfWkg7B3x9QVAlkydNiB/iZQRTc30lLmaU7vOoaMTU +4mQ== X-Gm-Message-State: APjAAAUSPCzGG2hzn4WKUjttdYebDJAbQDC+YSWtcfFQQcMQOWToLRBT Hr0v//BDVeRCsTcqCbZ1xR/aag== X-Google-Smtp-Source: APXvYqxL7QA2f4fhE3Wl5GbWBvWdaQkuQMrMb1TNzwEQ1pCL0mnhlQdr9u9/Zf+Usvn7SVZWcaa+RA== X-Received: by 2002:a65:500c:: with SMTP id f12mr16812322pgo.233.1571253782761; Wed, 16 Oct 2019 12:23:02 -0700 (PDT) Received: from localhost ([12.206.222.5]) by smtp.gmail.com with ESMTPSA id k6sm26188868pfg.162.2019.10.16.12.23.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Oct 2019 12:23:02 -0700 (PDT) Date: Wed, 16 Oct 2019 12:23:02 -0700 (PDT) X-Google-Original-Date: Wed, 16 Oct 2019 12:22:58 PDT (-0700) Subject: Re: [PATCH v3 1/3] kasan: Archs don't check memmove if not support it. In-Reply-To: CC: alankao@andestech.com, Paul Walmsley , aou@eecs.berkeley.edu, aryabinin@virtuozzo.com, glider@google.com, dvyukov@google.com, corbet@lwn.net, alexios.zavras@intel.com, allison@lohutok.net, Anup Patel , tglx@linutronix.de, Greg KH , Atish Patra , kstewart@linuxfoundation.org, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, nickhu@andestech.com From: Palmer Dabbelt To: nickhu@andestech.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 07 Oct 2019 23:11:51 PDT (-0700), nickhu@andestech.com wrote: > Skip the memmove checking for those archs who don't support it. > > Signed-off-by: Nick Hu > --- > mm/kasan/common.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index 6814d6d6a023..897f9520bab3 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -107,6 +107,7 @@ void *memset(void *addr, int c, size_t len) > return __memset(addr, c, len); > } > > +#ifdef __HAVE_ARCH_MEMMOVE > #undef memmove > void *memmove(void *dest, const void *src, size_t len) > { > @@ -115,6 +116,7 @@ void *memmove(void *dest, const void *src, size_t l= en) > > return __memmove(dest, src, len); > } > +#endif > > #undef memcpy > void *memcpy(void *dest, const void *src, size_t len) I think this is backwards: we shouldn't be defining an arch-specific memm= ove=20 symbol when KASAN is enabled. If we do it this way then we're defeating = the=20 memmove checks, which doesn't seem like the right way to go.