linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Palmer Dabbelt <palmer@dabbelt.com>
To: zhangchunyan@iscas.ac.cn, akpm@linux-foundation.org
Cc: akpm@linux-foundation.org, shuah@kernel.org,
	Paul Walmsley <paul.walmsley@sifive.com>,
	alex@ghiti.fr, Charlie Jenkins <charlie@rivosinc.com>,
	linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	zhang.lyra@gmail.com
Subject: Re: [PATCH V2 3/4] selftest/mm: Fix typo in virtual_address_range
Date: Thu, 24 Oct 2024 11:00:43 -0700 (PDT)	[thread overview]
Message-ID: <mhng-43cbba56-67ba-4f5a-a929-0805662b22bf@palmer-ri-x1c9a> (raw)
In-Reply-To: <20241008094141.549248-4-zhangchunyan@iscas.ac.cn>

On Tue, 08 Oct 2024 02:41:40 PDT (-0700), zhangchunyan@iscas.ac.cn wrote:
> The function name should be *hint* address, so correct it.
>
> Reviewed-by: Charlie Jenkins <charlie@rivosinc.com>
> Signed-off-by: Chunyan Zhang <zhangchunyan@iscas.ac.cn>
> ---
> V1: https://lore.kernel.org/linux-mm/ZuOuedBpS7i3T%2Fo0@ghost/T/
> ---
>  tools/testing/selftests/mm/virtual_address_range.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/mm/virtual_address_range.c b/tools/testing/selftests/mm/virtual_address_range.c
> index 4e4c1e311247..2a2b69e91950 100644
> --- a/tools/testing/selftests/mm/virtual_address_range.c
> +++ b/tools/testing/selftests/mm/virtual_address_range.c
> @@ -64,7 +64,7 @@
>  #define NR_CHUNKS_HIGH  NR_CHUNKS_384TB
>  #endif
>
> -static char *hind_addr(void)
> +static char *hint_addr(void)
>  {
>  	int bits = HIGH_ADDR_SHIFT + rand() % (63 - HIGH_ADDR_SHIFT);
>
> @@ -185,7 +185,7 @@ int main(int argc, char *argv[])
>  	}
>
>  	for (i = 0; i < NR_CHUNKS_HIGH; i++) {
> -		hint = hind_addr();
> +		hint = hint_addr();
>  		hptr[i] = mmap(hint, MAP_CHUNK_SIZE, PROT_READ | PROT_WRITE,
>  			       MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);

Acked-by: Palmer Dabbelt <palmer@rivosinc.com>

In case that helps, but this has nothing to do with RISC-V so you might 
need to re-send it so someone else notices.  Though +Andrew, in case 
that's enough...


  reply	other threads:[~2024-10-24 18:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-08  9:41 [PATCH V2 0/4] A few fixes for RISC-V Chunyan Zhang
2024-10-08  9:41 ` [PATCH V2 1/4] riscv: Remove unused GENERATING_ASM_OFFSETS Chunyan Zhang
2024-10-08  9:41 ` [PATCH V2 2/4] riscv: Remove duplicated GET_RM Chunyan Zhang
2024-10-08  9:41 ` [PATCH V2 3/4] selftest/mm: Fix typo in virtual_address_range Chunyan Zhang
2024-10-24 18:00   ` Palmer Dabbelt [this message]
2024-10-08  9:41 ` [PATCH V2 4/4] selftests/mm: skip virtual_address_range tests on riscv Chunyan Zhang
2024-10-24 18:00   ` Palmer Dabbelt
2024-10-29  8:05     ` Chunyan Zhang
2024-10-24 18:00 ` [PATCH V2 0/4] A few fixes for RISC-V Palmer Dabbelt
2024-10-24 18:10 ` patchwork-bot+linux-riscv
2024-12-11 22:32 ` patchwork-bot+linux-riscv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mhng-43cbba56-67ba-4f5a-a929-0805662b22bf@palmer-ri-x1c9a \
    --to=palmer@dabbelt.com \
    --cc=akpm@linux-foundation.org \
    --cc=alex@ghiti.fr \
    --cc=charlie@rivosinc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=paul.walmsley@sifive.com \
    --cc=shuah@kernel.org \
    --cc=zhang.lyra@gmail.com \
    --cc=zhangchunyan@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox