From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 367CDE7718B for ; Fri, 27 Dec 2024 16:40:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DB0F6B0092; Fri, 27 Dec 2024 11:40:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 68A186B0095; Fri, 27 Dec 2024 11:40:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 551B76B0096; Fri, 27 Dec 2024 11:40:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2F1D86B0092 for ; Fri, 27 Dec 2024 11:40:18 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CAF3EC13FC for ; Fri, 27 Dec 2024 16:40:17 +0000 (UTC) X-FDA: 82941301212.28.9CBE5BC Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf04.hostedemail.com (Postfix) with ESMTP id 149A740014 for ; Fri, 27 Dec 2024 16:39:30 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=dabbelt-com.20230601.gappssmtp.com header.s=20230601 header.b=lkBo5ZaS; dmarc=none; spf=pass (imf04.hostedemail.com: domain of palmer@dabbelt.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=palmer@dabbelt.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735317595; a=rsa-sha256; cv=none; b=jh66fU7s7F0XUUG+tRmUkC/KCtbUeJKggMG97inFHYrWLKhLtdcgHjY17uoxL4NhSaheEp 6uqNIGCoq665W2aiypg2H3JPf84yXEw0CqEw+uoGK4u6sIZsmKsBIaD7SZb6sPEUwheGwU yO0X/BXh7JHPftWqo2wrH9GSEJlxWWo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=dabbelt-com.20230601.gappssmtp.com header.s=20230601 header.b=lkBo5ZaS; dmarc=none; spf=pass (imf04.hostedemail.com: domain of palmer@dabbelt.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=palmer@dabbelt.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735317595; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=J4Xw2EJnY1X4WK+jvdY4voHsewcHZzxXdmJCqhZbsvE=; b=uQ+8H3I43R/tiwmJAXcWujz9W7YqGNOnzGMDWjI5LDGwXtd1yOTOyh1EYMIPsuwhZ1ozqS 5XZXOBlPrG15dE2Kwwt1ab95QfSSBJHyOw+MEpn9fvxpcwm0lSH6icEJMT1LmNaVi0pfvu mdaeK1s1iQ6XipEfwxg1UYJim1fvn44= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-21683192bf9so93579205ad.3 for ; Fri, 27 Dec 2024 08:40:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20230601.gappssmtp.com; s=20230601; t=1735317614; x=1735922414; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=J4Xw2EJnY1X4WK+jvdY4voHsewcHZzxXdmJCqhZbsvE=; b=lkBo5ZaSRsV2XAe+OcMAq2zjCS6YPfbnvCBSF48gsnsRqjqTBRyUz6vO1gAOOoK5gN ZykCjFl+Q57kV2m3h0Mldh6cZYCPOyCLG/9SyyBeVNnZPa4f4YYn11mPxFnQSnw/Oqu1 qVMAlymyC5oq9Jt11240CagWUIhfGjMiM7/xWIhb5/7b6kZwllB/V8COmWDrJoepuxnV nJ+9l3eZYRZ5B1pFrYMGOX5HTtNG+AsufBaRqwc2/oJMMy7fSvfJptmFCToC1BB5kSdg mQ4dajatG/3mFwVOGJ+l0jjJ/bPgPF4qBS2gDZ4ZGENOs07Xes7kVsDhWrnlegFLDPSb TZFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735317614; x=1735922414; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J4Xw2EJnY1X4WK+jvdY4voHsewcHZzxXdmJCqhZbsvE=; b=qsWFVs/VnmBipOIwr1rRzNp8InNYokJT/rNJZ8GsnBz8dcT3CGwijewk4cyN9Xcdg3 XjQdC7l7r5pxomxtOWjgWk8c1jPCc1GvWXXDWt1oMY/jQ+/r7oHvDepxdhHfR5S1LSJU B0q9BxbwpC7mcVJ8lasrN0jok60k70syR5XvKAUTZLmYE9ZNhswRQRRdasVaoorAJQoG 5tbgWxelL34NEUzJRolQGWEZP6ua9U2g+4aiAQ5nxFYe14JevAPfYCEkccVVmr6gJltf HdFuOXxi6yos+DcY0cHm6az3wR4Wgmfb9QYemQW4Ri8RYURDbQA9U3bAVGuNJ3QiCz6+ qKDA== X-Forwarded-Encrypted: i=1; AJvYcCW+wH1rx4z2vrNQLOUskq1FASw+BD5a3OwF5/mwehGey3wntZ5jirULJ66LAcbrIpfuTunxdNnAPA==@kvack.org X-Gm-Message-State: AOJu0YzyEE9cKiZOSiG7zQFBTW6mGx5AYS6I5xmOt4x1vJ3/F7XBk/B9 UK+7D4M54YQA0u/UpgZb5jcCMChQ1l2NVoyOg6I9XbTody0MAZDA7O8Q7MTdhkg= X-Gm-Gg: ASbGncsyjXo0iBMT7J3zcSAdgWHTqgZ3JN2hSiBIaCus/Xn6VuavrNVCpKZurRoyNj7 6361CLwCrZWKmZxCN+CHXdHcJU/NRVvKPdBWFs8x58zNOx96E5Zm88ohhZ8zk+Yx19R7gj7DsCJ qoSh3H1naDgR3MCaVFVDI+lsDqCBHL66s49GF23CUYLNMZPjujz5oUl9qkDud5UnttS3NtBIfEW cP3apw7YaqRxXpd5fL+zZNaiz2gjWEMky3tu9rFM02IRfRP9w== X-Google-Smtp-Source: AGHT+IGj5bTxRBL/TPC4rp9UNK8vWD764vaF6GBCxeBJ0bzTi0HACd7gUMrcV8Bcwh/Ub684hrsLqw== X-Received: by 2002:a17:902:f645:b0:216:5556:8b46 with SMTP id d9443c01a7336-219e70dbcf8mr427204505ad.49.1735317614352; Fri, 27 Dec 2024 08:40:14 -0800 (PST) Received: from localhost ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-89eaa1c4fdfsm7512714a12.60.2024.12.27.08.40.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Dec 2024 08:40:13 -0800 (PST) Date: Fri, 27 Dec 2024 08:40:13 -0800 (PST) X-Google-Original-Date: Fri, 27 Dec 2024 08:40:12 PST (-0800) Subject: Re: [PATCH v3 02/17] riscv: mm: Skip pgtable level check in {pud,p4d}_alloc_one In-Reply-To: <84ddf857508b98a195a790bc6ff6ab8849b44633.1734945104.git.zhengqi.arch@bytedance.com> CC: peterz@infradead.org, agordeev@linux.ibm.com, kevin.brodsky@arm.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, Arnd Bergmann , Will Deacon , aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, rppt@kernel.org, ryan.roberts@arm.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, zhengqi.arch@bytedance.com From: Palmer Dabbelt To: zhengqi.arch@bytedance.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 149A740014 X-Stat-Signature: csdptt5ruk5863nyafkqukafziatxwww X-HE-Tag: 1735317570-346522 X-HE-Meta: U2FsdGVkX18oFJ2hcY1y+mgdVKRAWkhoce7T4qYSHR7Cl9l0FxAg+blKkxPdJp4WTjgfxlwmYzDi5Lg0tTnMyrgaMTh8Z1/pFruuCwnvQn4ZXQ12rYMV0uoul8LNcu1l2dskgUJ2ceX2j/o6MqAVunAOfsn+nRNgpI+hGyGjusZor2XBRA+zDCB+b3HijpFw/prnpwxYEc0yBzoTQZ1eXOEz+mxyU7iyeR6s95fQ7D4qe9MzlAjO73bu2n/io08iA/DCEUDUOlaufqcZJjSqGfjjIo++mQubYqebhWrlPC0nzIw9flXSGaES0ExaSsJLouDj7gV9i+VbHqSIwhhTZ7m29bUuaoMyh2YgwrmBgC6p8zBIxQIq4a/Sp3lfdH1GmmDdkNyVh6EYaEzpCG8oOeh9CeNn5NlrjjvTvA9ZlCOfGrXk9j/DLog6sc0/uq+zErqTDGurLbhu4Ka4QYsnWJD2yhv0OAEYdy05ahNKfCXDIz0Tav8uh/h/q0VTkrqwENO7aAfvCI0JckqXMNQzfjE/OBHDejv1EWxgWWbZEX9M1dZEBIhOaxlWumZtcVEfsc2RgMr+UAZFO2/7v1MeiP/qiCNLoisEFfld1q4uSEI9TZBkmy2J0Tq/qTh0jkxCP7D7C44fFvxbFR2op9BmVAffAGsJnV5EOjylhg3QilGMnVxpKtxvliuuxL8rpwtcKqdr0jT3Dwo0wytCTm6bPVlb74b5q9m5X2uRu4L0Yn7sj+dREmv8rWlGigTKc9U1n+wIt7Su1gILHFZyyDw6UWoEDYTHKvmOX/Wwq7CGNEUihL6/zadX4D4RStHIwSFIHYQ3LhERyIajg6idVLPrVUvU1LMiByPHrIQok25cUUZOs5AZhUVeBfrSfbMTiQnuVAx/qvG9ltZauiJXKGZS6VUrMTeqndrcACg5E7s/wVAzaVOPqeplThJINQFLzhPExwh6lK0Azwzo+xuZkJq vcgYagSr PYWdtMAz2tRAm1iEAsSIh6duWeBVmVOiL6035b8jIg/Wm/1hKnWIql49RGP8hYa0eccLY+f3/RmCDuoExW/jZ4qcy6rAjf9UpoxZ8pMGiN25qXQFmkWDzvcADTwlE00m+aUuRyveABTZTSu6fElX38TDP8eOoz9uJ7M6rqYXgAG+3Uaisq+gGwtIyzYoZO18IOjapW9vvbbKMX2uMQK4DsgxRevV+EDj+HX8BayUn4FGHHHameRUYjIIlVM9Q/w0gtItS/tprPzXQ0Bgy2FGiLZ3jQikB8bDb+HqJS7XIJsZZFURbYmt0EjrxZ9yYkk62WkCB3r2LRhT/IkrlW+ns1zBi6b2yJ+wE9FI7TewGgaRD04Cdmj5QtG4nP2+BsjxZtqRy1rUrnhClohZqgc/9yr9OoiYO3F5K6x1yBPX041OmJOn/tdWLwRquMZY68ciP1lLJjY3oOclLqpd7ePxj5+9tiEAkAErA0bikXSf4xIKYskse3QSZXWpodrHav6Nz5IgZdHp1qWneAFxF0qtvXsAwKUCelfHlKUpDhWYJZ4j5czdAAGoatAlRJkkT2kYcnSgFaaIAshB/1JYPAJDXSaGTR2jRrNrHWJZc64lCZQlCYUk2GcOyAzKEEvG+DzJk6wFvGCs5Xoj/Aeww0g7PH2TYkBpDNrZ9mM/M X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 23 Dec 2024 01:40:48 PST (-0800), zhengqi.arch@bytedance.com wrote: > From: Kevin Brodsky > > {pmd,pud,p4d}_alloc_one() is never called if the corresponding page > table level is folded, as {pmd,pud,p4d}_alloc() already does the > required check. We can therefore remove the runtime page table level > checks in {pud,p4d}_alloc_one. The PUD helper becomes equivalent to > the generic version, so we remove it altogether. > > This is consistent with the way arm64 and x86 handle this situation > (runtime check in p4d_free() only). > > Signed-off-by: Kevin Brodsky > Acked-by: Dave Hansen > Signed-off-by: Qi Zheng > --- > arch/riscv/include/asm/pgalloc.h | 22 ++++------------------ > 1 file changed, 4 insertions(+), 18 deletions(-) > > diff --git a/arch/riscv/include/asm/pgalloc.h b/arch/riscv/include/asm/pgalloc.h > index f52264304f772..8ad0bbe838a24 100644 > --- a/arch/riscv/include/asm/pgalloc.h > +++ b/arch/riscv/include/asm/pgalloc.h > @@ -12,7 +12,6 @@ > #include > > #ifdef CONFIG_MMU > -#define __HAVE_ARCH_PUD_ALLOC_ONE > #define __HAVE_ARCH_PUD_FREE > #include > > @@ -88,15 +87,6 @@ static inline void pgd_populate_safe(struct mm_struct *mm, pgd_t *pgd, > } > } > > -#define pud_alloc_one pud_alloc_one > -static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long addr) > -{ > - if (pgtable_l4_enabled) > - return __pud_alloc_one(mm, addr); > - > - return NULL; > -} > - > #define pud_free pud_free > static inline void pud_free(struct mm_struct *mm, pud_t *pud) > { > @@ -118,15 +108,11 @@ static inline void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pud, > #define p4d_alloc_one p4d_alloc_one > static inline p4d_t *p4d_alloc_one(struct mm_struct *mm, unsigned long addr) > { > - if (pgtable_l5_enabled) { > - gfp_t gfp = GFP_PGTABLE_USER; > - > - if (mm == &init_mm) > - gfp = GFP_PGTABLE_KERNEL; > - return (p4d_t *)get_zeroed_page(gfp); > - } > + gfp_t gfp = GFP_PGTABLE_USER; > > - return NULL; > + if (mm == &init_mm) > + gfp = GFP_PGTABLE_KERNEL; > + return (p4d_t *)get_zeroed_page(gfp); > } > > static inline void __p4d_free(struct mm_struct *mm, p4d_t *p4d) Acked-by: Palmer Dabbelt Are you trying to keep these together, or do you want me to try and pick up the RISC-V bits on their own?