From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1D11C04E69 for ; Thu, 10 Aug 2023 15:14:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3067C6B0078; Thu, 10 Aug 2023 11:14:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B6086B007B; Thu, 10 Aug 2023 11:14:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1575D6B007D; Thu, 10 Aug 2023 11:14:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 067076B0078 for ; Thu, 10 Aug 2023 11:14:01 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D144B1C91BF for ; Thu, 10 Aug 2023 15:14:00 +0000 (UTC) X-FDA: 81108540240.22.ADA1F37 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf25.hostedemail.com (Postfix) with ESMTP id 7AE4FA001F for ; Thu, 10 Aug 2023 15:13:58 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=dabbelt-com.20221208.gappssmtp.com header.s=20221208 header.b=fisx6tDi; dmarc=none; spf=pass (imf25.hostedemail.com: domain of palmer@dabbelt.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=palmer@dabbelt.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691680438; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=0yH1lR7Tmb/121ugTuhyYiipeLnL26qyWyxJS1YHu6k=; b=wJhl9ynwRnyfwzNQJY6cEcYZBBjEb4/SuZQN77gYaIOLn10eQjc8o/ElSU/hiSQw8e0KpJ LWk4a5goCtXqNQ4kV+0PltzZU6RExEHZV2BZAEPhH3I8r2xQ2flFgt9cjcBTgCWHWrGD+b 4Yq/SGhueAXrzF4+6DsyDMXDOXcG+DQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=dabbelt-com.20221208.gappssmtp.com header.s=20221208 header.b=fisx6tDi; dmarc=none; spf=pass (imf25.hostedemail.com: domain of palmer@dabbelt.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=palmer@dabbelt.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691680438; a=rsa-sha256; cv=none; b=nq9XlmxGWaiIv4lP7llt3QRqDYiHKHx5psMTDJppMFcVdh/zuDOf0YIE+CYDNi+QdbpSF/ QaVgqm13pVoEo7VGCvSpUHcajItcA4ZCCfum89OqfBJtjB7SYFtJexJYhOTe/I5DRctS87 whK+HOh6hiqdCys/UDrdkHiE+mL0PQc= Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1bbbbb77b38so7538805ad.3 for ; Thu, 10 Aug 2023 08:13:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20221208.gappssmtp.com; s=20221208; t=1691680437; x=1692285237; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=0yH1lR7Tmb/121ugTuhyYiipeLnL26qyWyxJS1YHu6k=; b=fisx6tDiRoHdpjchdDQDaYu+AxzZRxKXddUGJDrRYeC+Qbbhlm1ZHdlft0uLxKS6NM TtJsKXfhhl/oXRrShuS7fHFpMD5RixmhG+UmSvvcdp17DkCUYlmMJ7LLldWBJvQ0xHH3 uuhveIWbFeP/MWkSzta8InmHES6xMe+s/o0dPooFzmVvgkpk39QTAgL1LdkNN47GuBtl MLs80BAdpDr7OJLH1FUWbQv0qXDenZ8RfFUIM6ngKjdnRaUdKAxTFWquTFLwBp6Vcaxd 5+YEAhzCze10+IlMABH0AR0ovBYrMzI3k81gv2oj8FAUsPa8LnbtzyoI2K2vZvGXFVT2 tXTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691680437; x=1692285237; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0yH1lR7Tmb/121ugTuhyYiipeLnL26qyWyxJS1YHu6k=; b=D9hXpqvwLdwkR4YqlNPs8B/0ZruvFlRcAFUNAW18n/h8iNbb42PUoK07jq8E6dWErq 76iN3xta18mEUHKlB/+xsEIz1cCR6Qh5s5WmmnjAKGlDSVDCmOJDDmGKojiOCOZ57+6B KovD59H+t6WmW6npmyFE+7t1YaXYr+ROKE6O+nCUiNL4rv31Q1rxsEE/bzOZhi+kJUjE WkPaAlYc/w2e4QKQQFKAt58ygDS3AcLvYX8bCo5v8E/8ZrEH0CdTUcuERwhxkpyMjBWa AQTe1o9yrSpdEVcFi8AYhFxgUTjp57adS3SYShJ8pnhndU3kGcuJyatkmA3CCU8ZkIlh p4hg== X-Gm-Message-State: AOJu0Yw/1XLh5pFM7nv9olPeRUQHRdymcKCiD/aPUP3Saa3JHoswlNe8 5ffkmxzkjlgMHCNC04mIgejpvw== X-Google-Smtp-Source: AGHT+IEseVfgJhHs0X3dkW4aAOaplIv6mghWHgV2rrKNruGAQY1FWypVPlIP6PMZUgCShLumnOvQvQ== X-Received: by 2002:a17:902:9681:b0:1b8:5b13:5958 with SMTP id n1-20020a170902968100b001b85b135958mr2145864plp.31.1691680436948; Thu, 10 Aug 2023 08:13:56 -0700 (PDT) Received: from localhost ([135.180.227.0]) by smtp.gmail.com with ESMTPSA id ji1-20020a170903324100b001b9cea4e8a2sm1871565plb.293.2023.08.10.08.13.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 08:13:56 -0700 (PDT) Date: Thu, 10 Aug 2023 08:13:56 -0700 (PDT) X-Google-Original-Date: Thu, 10 Aug 2023 08:13:53 PDT (-0700) Subject: Re: [PATCH -fixes] mm: Add a call to flush_cache_vmap() in vmap_pfn() In-Reply-To: CC: alexghiti@rivosinc.com, akpm@linux-foundation.org, urezki@gmail.com, Christoph Hellwig , lstoakes@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org From: Palmer Dabbelt To: Christoph Hellwig , dylan@andestech.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: gsijw9p469j5yox7dmkasg68jr53y7sm X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7AE4FA001F X-HE-Tag: 1691680438-86572 X-HE-Meta: U2FsdGVkX1/V6QTwy1jnc2n17DtfMEM2sK1elRJGIoYzsejUV9JAjOY13406XUbGgUYE36pt6TyGC6ptFZEY7uY21+56tcRK6FTUMuhQD7fsXSty0SmEn5D86cCrXdiG8Z3HxPbwHQcH1CoP663M9MMvxDs6Y0IBiqo07PlElpXVTLApC1FJbLgGCQ5+PtFvugXD7I5xUXc9pUey+ku0FXgQ90znVjYKiEUfcGq7x2FrURN9U1Mj0ZyJ+a99bjJ353XOgkR79C8GCoefPwqjOn3JBK7E5Mmi/tivxGhh5MnP3nrqSwmcZSX9Vq9gcsnaYWdAZ0ZusGEhYjVqKITPjbhFImYhYXIVf5EAqGGOJUeewbjDsqxuJ+TjvSdNGLRqdFqJp/8bwms636rduc1YEt9F8wzwnJ7yZP6QW+gBKUFXXK/tqf8i+i2WfcksfWIQPZgrqXE22o9E3jQN4R8T99BIbokrPOY/snoHuzEOIcI4Q5DhUKDMq9KlFno2/V3ajZpIuHGeeb7eFOiz4966YZkMJ7VEcB+s9DnLVBLsHZHL/pxXQd28oaw2XTgZpjTgDX8JgZ+UWfA+XOpWHLfgi3g47OeGEV0iYaeEml3xkSbpwP/6h98jXr3K0SDiU8Oe8PMjaYjqhM9nTu48TTyRKQP9/bxl0WCELCojnU13KuksT0KtTEsMnV871BWQ4Z9ptxAoCt9b1eTv4r2ta9FDkKrYTgITC5OBlYsG/qSHzG74jxVHkEbVI5Xr7bpsyu8rhOI6odd9xP2kPXkaj7NUTNR0DZOloBAa67QGoOXbDa/SOa7gI7ZNDcvfWR5ZrN6fH0lVT9aK8WI92kjcHxNjcymPVUjYD+L3jBrFOlDJ68vXP9rgUeP5UPNu2nALzJ5corg/qE+6iB4J98fQ9a23HosieKPed5jlBOM87MFIFCl4foPOhTXPKQVJzWLtFW+LXC3ZlG7ATFH6Uv4eKlX lHVdgdij SbeI2iQb5SHKuchLEapY4yxkJDwjp9/sKeW6apjSlq4HtWkXGo1F4HHDY+SWO9qki7ErpV3swO2jh98o+nUtjm7ogkCXQWOxacKEkQTYHfLd2s1AcRol6IJwZ4WOVDpuYNWH3y2jVCVzXqYgaS0a3AaLEAi9bnZxi2ENlMT9eJzNMv6S5kRrztHFvRxAQ6+SflnSPXMAMUQk4MgHp2WPf1pq5t/qnll1VyoodB9zOdvETuFtySa+hXu1zmhHR8oyu9QrBDfhSrzNlttcwn7DFhdp7qRXGiD/+H+4NGxPIEMfuzd+dFHXhs1SLMn5KOG074VVcz7pyw/zebrq5kQfCF/SiRo8H/ogFicHgm9EJxat8wV0VqM3wnauCcJNrZyFlG5YRf3u09haoBn9v0O08wJwHBhX7jIgSIKpx5LY2CN6jXbabLGd4Flj7Z7v1zvCZMA+ELzh9m9Oe5Zo/Sk1Rx0c6tQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 09 Aug 2023 15:25:19 PDT (-0700), Christoph Hellwig wrote: > On Wed, Aug 09, 2023 at 06:46:33PM +0200, Alexandre Ghiti wrote: >> flush_cache_vmap() must be called after new vmalloc mappings are >> installed in the page table in order to allow architectures to make sure >> the new mapping is visible. > > Looks good. I somehow vaguely remember seing a patch like this floating > around before as part of a series, but if that didn't make it it > certainly should now. > > Reviewed-by: Christoph Hellwig I think we're likely to end up with performance problems around here, but at least it's correct. If someone has performance Dylan: this fixes your breakage as well, right? I've queued it up for testing, but I doubt QEMU would find any issues here. My build box has been slow lately, but it should end up in fixes later today.