From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8DA6C47091 for ; Sat, 29 May 2021 23:08:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4D337610A0 for ; Sat, 29 May 2021 23:08:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D337610A0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=dabbelt.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5CA926B006C; Sat, 29 May 2021 19:08:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5546A6B006E; Sat, 29 May 2021 19:08:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F6D56B0070; Sat, 29 May 2021 19:08:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id EFCC36B006C for ; Sat, 29 May 2021 19:08:17 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8EEE18249980 for ; Sat, 29 May 2021 23:08:17 +0000 (UTC) X-FDA: 78195809034.22.02D018E Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf19.hostedemail.com (Postfix) with ESMTP id 50F069001E49 for ; Sat, 29 May 2021 23:08:05 +0000 (UTC) Received: by mail-pl1-f178.google.com with SMTP id l18so646040plc.12 for ; Sat, 29 May 2021 16:08:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20150623.gappssmtp.com; s=20150623; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=sRVlaEEdmy2fejqm1LOYoX48nSor38C+saK1W6Lf4/s=; b=E1wgVzZGpfyq9t7N8n24R3QZGtn759prQ9Ypv80Idx5khXw3ckZKvEoArXvhg/yXoQ bOIba+tCmn/iOFPQDmOc9EY3VqLAmTqvm/C4b+CGAPfyS2aO1WfPSAQJcVq2gSQf7P6q pxwLT+k0/9sJc7ZYQkKt2YgyV2Lcct2eKmc0vu4wcsMLS7iH5jgEXpAJyGNJLTnCIguW wl6L3ckQ4hBnkmIGXtyHuEiE1RpCBzsp4zd0gXxEteKgo/Jj2jYY0LQNkDL371GamncT ro54HMR92i/U+NZQFKVACEiB0WsYqtR13aljHT+8L4GqF+Y1+r/7U07YI10mV4LgXTF4 9kRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=sRVlaEEdmy2fejqm1LOYoX48nSor38C+saK1W6Lf4/s=; b=TyTE0vjiBOasiocbApdSgAn2bhCdl3ijrtyb+pvBGXHV8mT6BjNzjLGsZ6omegoQNC JlhPsXqu69H3SC2z4mUWnXcbR+SqZd9FbSRaxSsYk+sijOW6N+/Jt64mZKLCd+4zyzrx XK++grlDbe0H6hwrvc3LSXG5DXIxxggaB4D27/D9dMjFw2+4mISc39MiQ8Go9qv0R39G 7/u+M/pxnxXT4H8wo13tHcT+mu7/afO3UEuoelvQiMV7g9i0yQnBYtdjorhhxyt1S/9x 9hiXuka75j7jXl9/UxAWxgonLHkgut/LAAK7Q1q6ognfWyEJoRYt86VW3XkuyHz6kMzX a21Q== X-Gm-Message-State: AOAM532FQlsa0u2yKDuQymN2PCYnPKZhVvjpESfbVrNX7t737LyPs5O5 JZe0XKIH0uiFV3Qj5X6sZKyVJn/u/fu2Hg== X-Google-Smtp-Source: ABdhPJwFfFnBe8aicTdBk4lfp+U758kjADLjg1HfzNkpIgiuq6BLJtEMp3irt06nPnjgz+jn88h+nQ== X-Received: by 2002:a17:90a:a78d:: with SMTP id f13mr11437791pjq.161.1622329695920; Sat, 29 May 2021 16:08:15 -0700 (PDT) Received: from localhost (76-210-143-223.lightspeed.sntcca.sbcglobal.net. [76.210.143.223]) by smtp.gmail.com with ESMTPSA id r11sm7503153pgl.34.2021.05.29.16.08.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 May 2021 16:08:15 -0700 (PDT) Date: Sat, 29 May 2021 16:08:15 -0700 (PDT) X-Google-Original-Date: Sat, 29 May 2021 16:04:50 PDT (-0700) Subject: Re: [PATCH -next] riscv: TRANSPARENT_HUGEPAGE: depends on MMU In-Reply-To: CC: linux-mm@kvack.org, Paul Walmsley , aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, akpm@linux-foundation.org, sunnanyong@huawei.com From: Palmer Dabbelt To: rdunlap@infradead.org, rppt@kernel.org Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=dabbelt-com.20150623.gappssmtp.com header.s=20150623 header.b=E1wgVzZG; spf=pass (imf19.hostedemail.com: domain of palmer@dabbelt.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=palmer@dabbelt.com; dmarc=none X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 50F069001E49 X-Stat-Signature: arroma6x9a6h3kuqkaat1z41eh57s1ay X-HE-Tag: 1622329685-197361 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 25 May 2021 08:40:10 PDT (-0700), rdunlap@infradead.org wrote: > On 5/25/21 3:33 AM, Mike Rapoport wrote: >> On Mon, May 24, 2021 at 05:13:02PM -0700, Randy Dunlap wrote: >>> Fix a Kconfig warning and many build errors: >>> >>> WARNING: unmet direct dependencies detected for COMPACTION >>> Depends on [n]: MMU [=3Dn] >>> Selected by [y]: >>> - TRANSPARENT_HUGEPAGE [=3Dy] && HAVE_ARCH_TRANSPARENT_HUGEPAGE [=3D= y] >>> >>> and the subseqent thousands of build errors and warnings. >>> >>> Fixes: e88b333142e4 ("riscv: mm: add THP support on 64-bit") >>> Signed-off-by: Randy Dunlap >>> Cc: Paul Walmsley >>> Cc: Palmer Dabbelt >>> Cc: Albert Ou >>> Cc: linux-riscv@lists.infradead.org >>> Cc: Andrew Morton >>> Cc: Nanyong Sun >> >> Acked-by: Mike Rapoport >> >>> --- >>> I really think that mm/Kconfig should have "depends on MMU" for >>> TRANSPARENT_HUGEPAGE, but commit 15626062f4a9 from 2012 >>> ("thp, x86: introduce HAVE_ARCH_TRANSPARENT_HUGEPAGE") thought >>> differently. I.e., mm/Kconfig should be protecting all arches >>> against this Kconfig problem. >> >> We could >> >> diff --git a/mm/Kconfig b/mm/Kconfig >> index 02d44e3420f5..85bc8bf32e7b 100644 >> --- a/mm/Kconfig >> +++ b/mm/Kconfig >> @@ -403,7 +403,7 @@ config NOMMU_INITIAL_TRIM_EXCESS >> >> config TRANSPARENT_HUGEPAGE >> bool "Transparent Hugepage Support" >> - depends on HAVE_ARCH_TRANSPARENT_HUGEPAGE >> + depends on MMU && HAVE_ARCH_TRANSPARENT_HUGEPAGE >> select COMPACTION >> select XARRAY_MULTI >> help >> >> but in a sense HAVE_ARCH_TRANSPARENT_HUGEPAGE should imply that MMU is >> selected :) > > Yes, I had this patch before the one that I sent but decided against it > based on history. IMO 15626062f4a9 ("thp, x86: introduce HAVE_ARCH_TRANSPARENT_HUGEPAGE")=20 is really saying "the arches that have transparent huge pages are MMU=3Dy= ,=20 so we don't need the extra check". That seems reasonable as of when the=20 code landed, and while arm has MMU=3Dn and THP it already depends on MMU=20 (via ARM_LPAE, which seems kind of natural there). The generic version seems fine to me, but I'm going to take this one now=20 so we can avoid the build issues. >>> arch/riscv/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> --- linux-next-20210524.orig/arch/riscv/Kconfig >>> +++ linux-next-20210524/arch/riscv/Kconfig >>> @@ -106,7 +106,7 @@ config RISCV >>> select SYSCTL_EXCEPTION_TRACE >>> select THREAD_INFO_IN_TASK >>> select UACCESS_MEMCPY if !MMU >>> - select HAVE_ARCH_TRANSPARENT_HUGEPAGE if 64BIT >>> + select HAVE_ARCH_TRANSPARENT_HUGEPAGE if 64BIT && MMU >>> >>> config ARCH_MMAP_RND_BITS_MIN >>> default 18 if 64BIT >>> >> > > thanks.