From: Palmer Dabbelt <palmer@dabbelt.com>
To: atishp@atishpatra.org
Cc: akpm@linux-foundation.org, lkp@intel.com, linux-mm@kvack.org,
linux-riscv@lists.infradead.org, aou@eecs.berkeley.edu,
Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [linux-next:master] BUILD REGRESSION d01f2f7e35573049673b71e18be7abfe3f80323f
Date: Fri, 26 Feb 2021 12:26:37 -0800 (PST) [thread overview]
Message-ID: <mhng-05f49f73-f1c5-4dab-8043-b8e9be5d23b9@palmerdabbelt-glaptop> (raw)
In-Reply-To: <CAOnJCULoVsPJajC0XD43_Ux9=U1HvYhJcJRTUDyKAkGqvTi_cA@mail.gmail.com>
On Fri, 26 Feb 2021 11:43:21 PST (-0800), atishp@atishpatra.org wrote:
> On Fri, Feb 26, 2021 at 11:13 AM Andrew Morton
> <akpm@linux-foundation.org> wrote:
>>
>> On Fri, 26 Feb 2021 23:45:18 +0800 kernel test robot <lkp@intel.com> wrote:
>>
>> > tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
>> > branch HEAD: d01f2f7e35573049673b71e18be7abfe3f80323f Add linux-next specific files for 20210226
>> >
>> > ...
>> >
>> > page_alloc.c:(.text+0xe028): undefined reference to `node_reclaim_distance'
>> > riscv32-linux-ld: page_alloc.c:(.text+0xe02c): undefined reference to `node_reclaim_distance'
>> >
>> > ...
>> >
>> > |-- riscv-randconfig-p001-20210226
>> > | |-- page_alloc.c:(.text):undefined-reference-to-node_reclaim_distance
>> > | `-- riscv32-linux-ld:page_alloc.c:(.text):undefined-reference-to-node_reclaim_distance
>>
>> I assume the riscv randconfig managed to create a .config with
>> CONFIG_NUMA=n, CONFIG_SMP=y. Configuration doesn't make a lot of
>> sense, unless someone has a single-CPU machine with cpuless nodes...
>>
>> Could the riscv maintainers please test and merge this?
>>
>
> Yeah. This was discussed a week back.
> http://lists.infradead.org/pipermail/linux-riscv/2021-February/004640.html
>
> @Palmer Dabbelt Is the fix merged in the PR ?
Sorry, I thought I'd sent out the fix for this but forgot to. This just got
merged to Linus' tree, and looking at my code I forgot about it because I
wasn't actually seeing these build failures reproduce locally.
Though looking at my patches (which I just sent) I was fixing some
closely-related isuse, so I'm going to just pick this up. I just sent it out,
it's on fixes.
>
>> --- a/arch/riscv/Kconfig~a
>> +++ a/arch/riscv/Kconfig
>> @@ -314,6 +314,7 @@ endchoice
>> # Common NUMA Features
>> config NUMA
>> bool "NUMA Memory Allocation and Scheduler Support"
>> + depends on SMP
>> select GENERIC_ARCH_NUMA
>> select OF_NUMA
>> select ARCH_SUPPORTS_NUMA_BALANCING
>> _
>>
>>
>>
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2021-02-26 20:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 15:45 kernel test robot
2021-02-26 19:13 ` Andrew Morton
2021-02-26 19:43 ` Atish Patra
2021-02-26 20:26 ` Palmer Dabbelt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-05f49f73-f1c5-4dab-8043-b8e9be5d23b9@palmerdabbelt-glaptop \
--to=palmer@dabbelt.com \
--cc=akpm@linux-foundation.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@atishpatra.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox