From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6782C001B0 for ; Thu, 10 Aug 2023 15:58:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FAD36B0071; Thu, 10 Aug 2023 11:58:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AB5A6B0072; Thu, 10 Aug 2023 11:58:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37D326B0075; Thu, 10 Aug 2023 11:58:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 244A26B0071 for ; Thu, 10 Aug 2023 11:58:17 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EFA4E1402A3 for ; Thu, 10 Aug 2023 15:58:16 +0000 (UTC) X-FDA: 81108651792.28.7CD11EF Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf18.hostedemail.com (Postfix) with ESMTP id 0F5B81C001D for ; Thu, 10 Aug 2023 15:58:14 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=dabbelt-com.20221208.gappssmtp.com header.s=20221208 header.b="Loux/lcb"; spf=pass (imf18.hostedemail.com: domain of palmer@dabbelt.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=palmer@dabbelt.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691683095; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=VDBBjEUhdOwGqmMS5EZuk5kV7DmaXVSYKyA1KEjjfTQ=; b=ElaDm9phaD0uSRvMEEHrrmJMBjwLpaDf1EtXl/5D8SOV5Y3ysmtj+Fgj09pCKH8V21HzP5 zPpxEOe71wdbgQSm2ZSr2Hjg1chHLRU3Eh4iyIdOxA759t0YMcDglgZqLeTdfXUYNj9HbB /yo4TR9i5FhwmSTs5+oL6/ppgT28rtU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691683095; a=rsa-sha256; cv=none; b=0zBfCH0A2zlMNqMvWV70/wHfdzqMSOVseF6HPZk2Qc007Lm6LK6ucVgFlU19CS2uoopio9 Dd1RoFLQVgCbe3dyGqzoQzn0hOXMwm+TQlOu8C6o+qExRdvQsQLJXmmgBssv8C6jxzQ7i5 24Z26QM8yKBEAuLn3tpjnkUoGPheOQ0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=dabbelt-com.20221208.gappssmtp.com header.s=20221208 header.b="Loux/lcb"; spf=pass (imf18.hostedemail.com: domain of palmer@dabbelt.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=palmer@dabbelt.com; dmarc=none Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-26948743648so739539a91.0 for ; Thu, 10 Aug 2023 08:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20221208.gappssmtp.com; s=20221208; t=1691683094; x=1692287894; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=VDBBjEUhdOwGqmMS5EZuk5kV7DmaXVSYKyA1KEjjfTQ=; b=Loux/lcbFGKt/PwP6moOiY2xjkOS3vWT1JKnclVLiLOabD41avWWLUPZx/1Iramwr2 tnlCkFCqmZGZMpOCoY4PAIQCMqOKs7nw7JTxkNJFhoeq8Rfc7NVdanAbYNJ2XI0/WnI9 Qh5+I2kq9wQGqQx6LyV9eiwakiwABwd66AAx1JOQfRn/UwawKiYrfedIC5JbdnhPLROJ TsHOnT2zUPQ0AYCoBnjfJkUv9WH9MhSqjCwUeauUagThIRi3w47QqkfUseiR5dOTCKmp 0yBzs2uX24fBdU4gzdyFBKYAJDNqxkbUmwxbHlFA4U6lOLAoMV0Kbvss1TVvBXeXXKbj LWAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691683094; x=1692287894; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VDBBjEUhdOwGqmMS5EZuk5kV7DmaXVSYKyA1KEjjfTQ=; b=bCs6n9fMkHj6Q8irulc7A13QI0B25BkXb0aRnOLz8EPiauT8diwmmkiqIp31Ls+m1a IPq1N67VBnGzzPdIa033rgPJgvstU0FYmMOPWncAxhTc8kdPh3elxgf7+oJQ1mJGr9Sp B/Py2eVxKLiwOHyE1viy7kem27vm9B9Rewt4Ng9FquyR+8PwMwt6y9zgzzn/Xu7MAN4S R9go3tJ/DL/+rAkWxsjTs3X+JPnMu/f4PT5laP4OdLexIsmVg+eyeMY11dATfNpaakqK DPzIYqnYbE4NdvC5UUXVSHZDF/QpZNLKscwc0rGM0tBVQtdawFRRZ3l8JpqKiZOvlWYx Xe4A== X-Gm-Message-State: AOJu0YyrTfn3shciT5yyGE0LQ5bRTLozAxeseJ+EBDlMaHvqRio1zmSD zk1iC3LT6GVWaesZwWa2HWFVqA== X-Google-Smtp-Source: AGHT+IGQgJUoPsyLlnUjbWwQ15bA7rnW1cqZKBxqQSQLdnCfIunbQ7ghC9b7SWjg3YpGttzhK2pkdg== X-Received: by 2002:a17:90b:3e8d:b0:262:ee7d:2d20 with SMTP id rj13-20020a17090b3e8d00b00262ee7d2d20mr2620120pjb.12.1691683093833; Thu, 10 Aug 2023 08:58:13 -0700 (PDT) Received: from localhost ([135.180.227.0]) by smtp.gmail.com with ESMTPSA id 30-20020a17090a001e00b002630bfd35b0sm3827053pja.7.2023.08.10.08.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 08:58:13 -0700 (PDT) Date: Thu, 10 Aug 2023 08:58:13 -0700 (PDT) X-Google-Original-Date: Thu, 10 Aug 2023 08:58:09 PDT (-0700) Subject: Re: [PATCH -fixes] mm: Add a call to flush_cache_vmap() in vmap_pfn() In-Reply-To: CC: dylan@andestech.com, alexghiti@rivosinc.com, urezki@gmail.com, Christoph Hellwig , lstoakes@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org From: Palmer Dabbelt To: Christoph Hellwig , akpm@linux-foundation.org Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: t1n9769wa5tm4daeqdf1rps1geyu7kka X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0F5B81C001D X-Rspam-User: X-HE-Tag: 1691683094-919287 X-HE-Meta: U2FsdGVkX1960oNnzIz1dH+kszbp2Ze1210ueK2d3KtZJZyeakeh1HPVWU3q32myqpm9DCwsaOV8+qcwaUvUiJURjzRVJvdB+HSPj2WmlcwDi4rmReo2q8ukdo4i5PvphjAWcDBZLFtKgXJNFgqN/ss2N0HjWvhsV9MbhZYPXkUqnry0LmpVEw4p5clZ0PYziRzcb5WZc1MSv9qW5mGNt/K5zWu7JwweZF7ymOlKsZ8zLy4cU/cKlWIdBS9s9XYS1254CV6Ru2AhvF/6gOqT7lw3AxcdrqO7h//nDShiAPm4LNTL0RmtJ0kgMFlZ92IopSvVK2N7hL8z31s6I9HceJ7JOwN6SqNTHklO3kMF3TrSI8/Nm0Wim/2cJCIgS3/36/0RrrKpQGxXgj9haxMrqkvdogDQVbzUmV0yTHTdNxpFx/Kvf18P2HJYhk3NF0Lsub3FhBdtqKSk8lI0zfccJlgXTROLmpOW/o/nL+aLr/X/FMVJ38hHDBgXgRlHk0FySXpYCJdepZOkLyCo0truRRAgQW4sAiQOS/a2uiGukCCVo5LPReaY8IDSXisL6JXfwEky93bAyNetLWAGCfXLvpPhluTuMWxHQaKtUG1ek5gDIsKlAdNCNHFubQ/q3Jgkq4TQjpDmEzzHO16SBYffEGd3qprffAYnieMXjuGx87JdyrX0cQrww4lfoevt9C3H4XYgnTSx2qMlPWlOyP/F7ZlmgROKQwOPVQAPdaA0IsFUrpA1+qVLw5G6Ua4l1TKoPpt66e5zNoIkYWxO7HJ9S/HA+CjcUbkRUDg0LuU+9ox9K4IVHCbOJ0HzdDf/uokdwIuWnptwzae62cq5e/0B5o2Kx70iH5ba3NDRDNIniJD3dDOt8LpcZD7pV4sVOInJiNi+VmJLHfpuL5a9EZRPDjsWc4ROldAwFhATXbOsuIUXSjQrTAmgPUBCf1cGNZ11LZcj8I7N8riJ0h3ufY0 fn6RVUdd QvBJGTzEmvAJs/66xgOEjlMyWq/stVjqU1fsdMsKZXJA+oFlPiAijGyejvqBA0AbjY2yKbr25c3483wb8o4XBrqbb2iX+dUEnZXdbvScU5kfrkH4YtQ5KKxlqNx/MWbMdQ7NqU8pUx+Xr5ZciagU52jynykDaDRj+sXXkPTbvgrMwjLtbT3EgoVNX6mlUuCqZyxjC+ChgshF8nKB9kudEFQXcQLlnX6X4edLrcvF3710OOpW8FcYg5CJbuCCn33xTvS+EFhAl/sB6PXpuLICnShl/onSHFeLQBduRyc2A4G+etO2E3sjQ1OcS4Axt9Tlq8qMXDRzjAr72mCg33SLoPBTbrJIwpweefTAY3b3OxTyLeVJI8Vb/v048JQaPXLaqCIpadmnqfP5OkwG3aYF72N5joDIJq7/J2uW5kmt9JlrhhQuocbQc008tG1LFMv4jpJ9UiCdaBmbV8xxhX1fjiOxyurJA1WCey3tr2S7BTsSlwHNYWobTZnYPXcdAPLsKOWTzC+1aGYQ1ypCwVDUpLCNr90DHVq81GLF48zZciiLvzitGvsSv3qSkZTs7GEXZ9Wvvtrli5Swf7uI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 10 Aug 2023 08:13:56 PDT (-0700), Palmer Dabbelt wrote: > On Wed, 09 Aug 2023 15:25:19 PDT (-0700), Christoph Hellwig wrote: >> On Wed, Aug 09, 2023 at 06:46:33PM +0200, Alexandre Ghiti wrote: >>> flush_cache_vmap() must be called after new vmalloc mappings are >>> installed in the page table in order to allow architectures to make sure >>> the new mapping is visible. >> >> Looks good. I somehow vaguely remember seing a patch like this floating >> around before as part of a series, but if that didn't make it it >> certainly should now. >> >> Reviewed-by: Christoph Hellwig > > I think we're likely to end up with performance problems around here, > but at least it's correct. If someone has performance > > Dylan: this fixes your breakage as well, right? > > I've queued it up for testing, but I doubt QEMU would find any issues > here. My build box has been slow lately, but it should end up in fixes > later today. Sorry about that, I'm in the wrong thread -- I meant to be over here . Reviewed-by: Palmer Dabbelt Acked-by: Palmer Dabbelt but I'm not taking this via the RISC-V tree unless someone asks.