linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Palmer Dabbelt <palmer@dabbelt.com>
To: Christoph Hellwig <hch@infradead.org>, akpm@linux-foundation.org
Cc: dylan@andestech.com, alexghiti@rivosinc.com, urezki@gmail.com,
	Christoph Hellwig <hch@infradead.org>,
	lstoakes@gmail.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -fixes] mm: Add a call to flush_cache_vmap() in vmap_pfn()
Date: Thu, 10 Aug 2023 08:58:13 -0700 (PDT)	[thread overview]
Message-ID: <mhng-057e1f9e-8320-43b9-a0fe-282b4beffd13@palmer-ri-x1c9> (raw)
In-Reply-To: <mhng-3d3afb21-bd40-4095-ba62-41cf40b782ca@palmer-ri-x1c9>

On Thu, 10 Aug 2023 08:13:56 PDT (-0700), Palmer Dabbelt wrote:
> On Wed, 09 Aug 2023 15:25:19 PDT (-0700), Christoph Hellwig wrote:
>> On Wed, Aug 09, 2023 at 06:46:33PM +0200, Alexandre Ghiti wrote:
>>> flush_cache_vmap() must be called after new vmalloc mappings are
>>> installed in the page table in order to allow architectures to make sure
>>> the new mapping is visible.
>>
>> Looks good.  I somehow vaguely remember seing a patch like this floating
>> around before as part of a series, but if that didn't make it it
>> certainly should now.
>>
>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> I think we're likely to end up with performance problems around here,
> but at least it's correct.  If someone has performance
>
> Dylan: this fixes your breakage as well, right?
>
> I've queued it up for testing, but I doubt QEMU would find any issues
> here.  My build box has been slow lately, but it should end up in fixes
> later today.

Sorry about that, I'm in the wrong thread -- I meant to be over here 
<https://lore.kernel.org/all/20230725132246.817726-1-alexghiti@rivosinc.com/>.

Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
Acked-by: Palmer Dabbelt <palmer@rivosinc.com>

but I'm not taking this via the RISC-V tree unless someone asks.


      reply	other threads:[~2023-08-10 15:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09 16:46 Alexandre Ghiti
2023-08-09 18:46 ` Andrew Morton
2023-08-10  7:15   ` Alexandre Ghiti
2023-08-09 22:25 ` Christoph Hellwig
2023-08-10 15:13   ` Palmer Dabbelt
2023-08-10 15:58     ` Palmer Dabbelt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mhng-057e1f9e-8320-43b9-a0fe-282b4beffd13@palmer-ri-x1c9 \
    --to=palmer@dabbelt.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexghiti@rivosinc.com \
    --cc=dylan@andestech.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lstoakes@gmail.com \
    --cc=urezki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox