From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86AEFC27C5F for ; Fri, 7 Jun 2024 14:25:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0689F6B009F; Fri, 7 Jun 2024 10:25:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 017816B00A1; Fri, 7 Jun 2024 10:25:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D84C86B00A2; Fri, 7 Jun 2024 10:25:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BB0D86B009F for ; Fri, 7 Jun 2024 10:25:58 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 76A2CC18E5 for ; Fri, 7 Jun 2024 14:25:58 +0000 (UTC) X-FDA: 82204316796.21.CD8176D Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf18.hostedemail.com (Postfix) with ESMTP id 9AFB31C005A for ; Fri, 7 Jun 2024 14:25:41 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=ovhIzsxc; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=BDcLzC3C; dmarc=pass (policy=quarantine) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf18.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717770355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JAcaAUEGb6jaXM4sybKpTRldfgMtDQy4cmg44VXMJPE=; b=D+c9nJ0AusyDcxL3HX/afNkkA7l13OL9/g8ejC5HygN40MUFyS3VhuSwq7mF5nZAhJ+YZY mNEy/+VaxpT5/2RiQWE/IFp9P9zz5bKB1h5AYUZtBc0XDvY8ZhhFgJxwiRDv+20zN21QVA UYFPdmS05NfPPuGkcfCUGBgO2uh+G2U= ARC-Authentication-Results: i=2; imf18.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=ovhIzsxc; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=BDcLzC3C; dmarc=pass (policy=quarantine) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf18.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1717770355; a=rsa-sha256; cv=pass; b=LwrWyoNflpJQFoS4T9zm7NoPLu9mTYkKJQS0vPISybuAwRypzSwt3QpdadeXj3Ki+37OFE nG8+5p5OSmuUTzAMGSitJgBC52E1mKBF4O8sFtbJdpSlDWIIf1p8YdLNADMVMxqA1LCEXj 0RFflELj95g3CeEMzfHLYMYPQRVHqQw= Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 457CuhXF009446; Fri, 7 Jun 2024 14:25:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc : content-transfer-encoding : content-type : date : from : in-reply-to : message-id : mime-version : references : subject : to; s=corp-2023-11-20; bh=JAcaAUEGb6jaXM4sybKpTRldfgMtDQy4cmg44VXMJPE=; b=ovhIzsxcl0LKRwha4zojfz/N6PhMbQRvOQt0oW0FBp34RUb2IUGmLi2EQNnziFgof7aT hrI3z2V5yEM1RjsV+g1K705naAWPINZ3kAj3hHHW3//u7uS2Nw9PqpjgarrU1oL2yDzB ZCs2Uo0JjfupV2eyiFd/3YWHKoUmL4WwFNaUkbPmWltpI9lSSgHSkD85BMBufJFe7Syi /7A55ekB0weiGox5VRO60TKx/WCLXg/TplY28rBoXpSsmRQ5GmwxUQE0QmhrEv2xGk5L E6XugGRPrqrh2rgOgwmQlIysh9BFPUdUDd33Yy8XK3ZRPmIuJFoBced/HauK4d1HJJ5h 1A== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3yjbtwdrn3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 07 Jun 2024 14:25:36 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 457D4hNt023943; Fri, 7 Jun 2024 14:25:35 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2101.outbound.protection.outlook.com [104.47.58.101]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3ygrr29vd7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 07 Jun 2024 14:25:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K61OJZUgwo7zLYPqpxvsi5TsbFQ2k82qyOn/VzHes6kBtVcjHHB+JVmVVUSshW59Fu5H8n68JxmdrxjWYeNUPACpAOh6WmXID5y1PdWGJViP4GkU9uOuHF+aMBGR+BWsqPWiJMgjaGIIFffLbRfl0X0uCagMNXhXhhjvNWkCMuBsvTDT4QCqC/EUyEPJzMZ88+qele6wosZ+gGixii/t3Qunq+4p/h9MpiHp93ArbHHPqCdR3EMQbo3tuwgg3oB5oiLLmj3N/gS+TYe9gNAyZniXvBENZ/xLXmhpCoV7yMiP8U63BUS5CL/kZbt4ottuTcOjDjIOMpR84A89kXR1Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JAcaAUEGb6jaXM4sybKpTRldfgMtDQy4cmg44VXMJPE=; b=dQF0SAmIu3x9NOR9vgINJd6QieU31n74QetSt3DValGzwEailJp/UyBJ+aDbyJa9H1BvTpw26HaTdLu09Yr19hDmQHwXhcfeNyqV0jwDuCpNCvGzCiljmn/w4HQq9ICCqkLtamR1xsooeUorcjtLv1qv1AUXlo4GHABYVNpVjMuZpFkoAkMWafQx9+NHeCk0V35OmhaFqPstjHpBe794LABPFMxotx5TgipZ0sIjNShnyxAy3bNs08p2jQSXiJy3ezMHAIka+bn+gLPprvjlMInbtHeJxznIJeWG3lVIxl6ceH7V8MzGK5yrrU+R6LUqm/rA8ZbO0amtGboPHREHLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JAcaAUEGb6jaXM4sybKpTRldfgMtDQy4cmg44VXMJPE=; b=BDcLzC3CLt+v0m5oNv+RnbB4x6zYqGwa+D/N7TnbqFfklMgjjZM/oL+YuSoUfPKeFYzcrBcTZQRFtYm8tXU2SX4BLmMURbMnPkukVlwu7WJetZ48woG8Xs4FbDm4X5IiIbqu3i32A4QUG+mZtEuKpjIuEMaJCn5MvVgCVv7gwHg= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by MW4PR10MB6322.namprd10.prod.outlook.com (2603:10b6:303:1e3::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.34; Fri, 7 Jun 2024 14:25:33 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%7]) with mapi id 15.20.7633.033; Fri, 7 Jun 2024 14:25:32 +0000 Date: Fri, 7 Jun 2024 10:25:29 -0400 From: "Liam R. Howlett" To: Suren Baghdasaryan Cc: Andrii Nakryiko , Vlastimil Babka , sidhartha.kumar@oracle.com, Matthew Wilcox , Lorenzo Stoakes , linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 1/5] mm/mmap: Correctly position vma_iterator in __split_vma() Message-ID: Mail-Followup-To: "Liam R. Howlett" , Suren Baghdasaryan , Andrii Nakryiko , Vlastimil Babka , sidhartha.kumar@oracle.com, Matthew Wilcox , Lorenzo Stoakes , linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240531163217.1584450-1-Liam.Howlett@oracle.com> <20240531163217.1584450-2-Liam.Howlett@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: User-Agent: NeoMutt/20231103 X-ClientProxiedBy: YT4P288CA0001.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01:d4::7) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|MW4PR10MB6322:EE_ X-MS-Office365-Filtering-Correlation-Id: a460b2e1-0d5d-428e-ec6e-08dc86fdb09f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|376005|1800799015; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dG03S0JHNWhJKzl0RG90Y2tBcXhrRzg3V011TEJDYjdONzRwVmhzMkg2UkN2?= =?utf-8?B?M3NaR0MvYy9xcWR1NEtJa3RhNmNOWW8rT0h1TnQ0N1N6Z1VyWGtqMFBSTGw3?= =?utf-8?B?d2RiOXdMRnVhaGx6RGRtU1RFWlNmaUFkWVpWRjRFb016UTVLOERGSjFUblFM?= =?utf-8?B?dmpoMFFkNDgxODNjZTAzRStKM3BhbTBxcFJQQlkzenN3L2I5RG1BN0Z1bHpB?= =?utf-8?B?bWt5VUdyckFpbU1YVngvTkdRSGIvUEZkbGRwdTU0K1hzSXZRS2N2VElKSmwy?= =?utf-8?B?QThoMU5tK3NRSW0zSkVkYUJZbVhoelBTN1NnMnpTczcrd3NkME1jYm9STUgz?= =?utf-8?B?WWVBM21QMGpFYm1Lc2w0ZTBjRFRSVDR6UlpBRkVBamZJZXNGTFhYdmJ5NlNQ?= =?utf-8?B?cG5WdzBwWmR4Qk9SY2NLUk10WElzTUhjYXVRSzJWandSVG0vY3IyZi9ub2lu?= =?utf-8?B?ZXdvOWh3a205SjIwclorRHJBV0hmZ3QyOFNhZldYYURkamJBdzM5NFp2cXBx?= =?utf-8?B?MUl5WXNYOGphbGg5QzJRbmRaOUR1bXNqcUs4WWtoREZEbTh0ZFBCNXkzazgz?= =?utf-8?B?MERXSVZYK01mQzF3dzNHTnFKc1l2ZUloemkweWd5bXk0SkFNbCtYRU9ZSFpY?= =?utf-8?B?bGhoeDA5YncrVk9mTkFkMmlIb1c2bCtlZ0xqTlREUlhsbHZqZTdtVVJEODNv?= =?utf-8?B?Y1pvNDVzeEhFNkIzSHp5LzlLUEt6VUhnTW93ejVnWlRKTi9Ba3dUK3ZvbDZ0?= =?utf-8?B?ZGlLcmZycE1YMzhZTmxpdStyN1cvaUN4RFlQWDhWcjQ4eFBReTBTelFDdlVa?= =?utf-8?B?dmUzY2hmL1hrKzVqYTV2ZWQwUkYyaGx2b2tsQWQzdjdGTDBhSkZSSURuNzR4?= =?utf-8?B?TGcvZ2lMVGFBK2RBb1o2UFQvUW5ieGZwTDc4dWJhYTVTRWZ0STgrYVhPYmM0?= =?utf-8?B?M3B6dU01UHNDZVRHdWJDamJadlRkSWUwMXVleks4RUl3UE90WmdEb2UyOUdj?= =?utf-8?B?Z2N2cHdzNDUzcFFhQVRRMVZyWEIya1FrQlIyTlhjQjlGaXc1d1hMUmF2eVJH?= =?utf-8?B?T2xKYno3TzE4ajJEMzVtNEVmd3NhOHg1NFpBMlF3YXFkQlZMZllobW1pWXM4?= =?utf-8?B?Vnd6dTc3VmQydGdBVkhHMEE0NnVhTDliQTdmM3drZ2NZR09ZVFBUOVl6c3Rh?= =?utf-8?B?WUVnbmdFa2JhbDQzMkt4bXZ2VHFTTWtGRTlCMFZwMEI3R3JrM25aNjlqN1dv?= =?utf-8?B?UWlqTmYvQWtNT1cvUERDRVRDYjF4RnQ2eWpPMjMva040MlBZUVJBd1p1Z0h1?= =?utf-8?B?SG5yU1JwWWl4QmNNM2I0cmxCZ2VIZmMzTHlpalAwNjdWWFloNDY5M1cvSlBo?= =?utf-8?B?b1NTRi9nODY1N0MwQ2dOTnRTMUNseHd1bk9FNFJhY0d3QURpb2RvZ0U2TTNi?= =?utf-8?B?cjdaajdRWE9rZDFTazZiUWx4TDZkWU9BeitOcWhCbjRkUTRjWWlkTXB4SmFC?= =?utf-8?B?TVI4N2F3T2o5M2NmWUhKa2FkMUhMeVpQRmI5Z3BnNHNsb1UxaVhTYlZ1S2lG?= =?utf-8?B?Y2ZXWFNVc2NmQnhwM1RTR0tDczloODVvZU91WlBMc29maGRpTkNOVk9GTXNS?= =?utf-8?B?RnZLOUVGQlQ3NnhsbWVpeU1XQ1B1T1RGTVl3UncxWTFVU1Y4ZHJ6N3dEVkM2?= =?utf-8?B?dHhhcWo5Tk12M0o1ZzMyT3hScVI3N3NFQzNnZ1crS1UzYmY0bXdMRHk1L0dJ?= =?utf-8?Q?0fcrLW5mcUlxPyRO69OB8OPiSrJnsms6hlpUndi?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?di9IZ1U1ald0SklNekNBNm9nMGtCT21SQUhoRDZ0UjFEOHovMkk1TkhrYTE1?= =?utf-8?B?S1lZRDZla1Zza3NTRm52bXh2RlZXVjdqWG1GSDBMR1ArNGVuRmNtbms5MzdQ?= =?utf-8?B?cnFCUlNlaWNDVHNPT3pub0ZoL3V0MW1TWERxL3BUS3Vkb3NWY1dDb3RZOTJF?= =?utf-8?B?RVh2TFg2ZSt2WUUxT2d0aytVUkwxcEtmb0JTNklSMFBGMEZqYWNtemNXblBx?= =?utf-8?B?Yko2TVJNU00vSGNqejhxeHFUeFVLS3ZSdVFkaGo1bUd1RlM0c3FKTkJRbkIy?= =?utf-8?B?L3F3aWJLNGZ4MVBsVzRaclI3RG1YSi9NenBUbkpQQXRYemh4WnhZN1YvQnpT?= =?utf-8?B?QUx4V3VFaWdiU3RjODFyemFzYmtMRWUra3NxdkRZWVE3Q28wd3FjK1pLTlpl?= =?utf-8?B?M2tvcjUzbE80aUhCK0ZPY3owRUxZbEZGM0JDNy9mVkdSbkxmOTAzZmJGOGNN?= =?utf-8?B?YTNWY1V5eWlVM2tQclliMDJic09ncENhNkY0Nk8zVFhUZ0wvN3Y0ZFBOanVq?= =?utf-8?B?N1lLNXBYTVJvcFpJVDdNZllYa0h4d3Vtd2RHV2k1d2s2Y2ZOTjFyNzRZZ1RB?= =?utf-8?B?TGRKYlpSQlkwdTNwQWp3cWxLYWp5bC94UkEwOTJjSVltVVZucGdWL2Z4ayt2?= =?utf-8?B?OWNZZFl2d09aS1NJTjZncTdJS0x4RlhtdU80dWIzQU9xWDRieVFtdHpTWHR4?= =?utf-8?B?M2prU2pJdDU4R3ZqR1A4VjdqY0pKNmFDOXZPSDVxQnhJU3JCQ09KNURXTzhZ?= =?utf-8?B?djFlMlNOVzJvTjcyK3RuSUhTQkl1R0dBd0NNRDZPSTdZL3gyRENuL2VwWFo0?= =?utf-8?B?VDNTVDVQaTlGQWhidkMwRXliMVQ2cWRuQnk5bTZyZHk2SkNXSWM3NEE0VzNY?= =?utf-8?B?blZUTFArNnJ3bkFkaW1YUWFrclhkL1NrVG1hUmN1QmQwNVpPdWNXdkZqVS9t?= =?utf-8?B?c05kRjBTOGFVRjJQRVFUQkxVMWVSZVdML0s5eSs2ZWtwTUFCYXl0U1ZraVNs?= =?utf-8?B?V2JCeFFJQnNGOHJFMDI4YXQ0dHdNZDNTRGFLZ1NEUllyOWFZYWxCWm1XbkR2?= =?utf-8?B?d3NMY2dGTnd1OVIzNXRpYnFLd1RpQmpMdXBTWmNtTnphcW1qSGRnUkdMVHNq?= =?utf-8?B?NVNLVGU4cmwrbU1YWWIzL1MxT0NPeURjaWhMeDJCbkZpamZVKzV1QVpHaVo5?= =?utf-8?B?M0d2T09XK1N4bUhXOWliUU1DQTBqdzVRWlFkT2xmaW1xRjMrTVc5RXFld0xV?= =?utf-8?B?S1pVdHhoaWtlNXdtRUtlRGZzSDhnNUpScmdMRzNOVDNIanFFK1MvRFpnckpU?= =?utf-8?B?MFQrZGl4RFQydmU0Nk95V3ZCL2o2WE9aVlFzNXZhcG1VTU9xQ3ZUNjNzQU5I?= =?utf-8?B?aXBHcjNFVE9laEJhZEdEbVNKODNrWjdUUW5hNnY4aWtYOCt5MmlqdUIydHhO?= =?utf-8?B?eU92N3Zyc0VtMTZndW9rc29tUVhhdlJRYmFXTThsUFViRXBKU0RTS3hTZXFM?= =?utf-8?B?b00vTkRtZzd6TVJiS1ErUG5ZVENRcFdIcldOQ0lPVVg0bFJRS2dvZUJNUlFY?= =?utf-8?B?N24wWU9KRTlxNWllZGxWaG93bFJKclFzSEhnRDFCamxNSDBNalM5NDN2aEFk?= =?utf-8?B?MFhTR3RqRy9XSHNzRjh6R0RsSkFDbHd6aFh0SVlCM1RJTkhMY2tNbGFSZnhT?= =?utf-8?B?U3JiY25TSDg3YXM0RDd2Mmh6STkrVXUza2JaMWpLM1RDbW5KOERrcTUyUGUv?= =?utf-8?B?bTRGMDFXSEE4TngwRVljVlIvTkZQMUYzeHVNZks0ek55UHdIZHNkaUlTaFJ1?= =?utf-8?B?NEdqWmpSNXNGMVdmRmNaT0pUampweWMwbzM3K1ZJMlJUa2VEUm1BZkNTenMz?= =?utf-8?B?ay9SU2NXNzV2eVBwSG43Y0pXcXc2R0hRc0JuSDI4YVk0WE9tbWFKMmhVR255?= =?utf-8?B?WE9Mb3ZJTG9IK3lqSnh3bkNGQ3RYcU9UczFSbGdXa3pGSTgvd2l1MnJRTTlR?= =?utf-8?B?d0h0WUlMdy9kaGFsaDJLdnRiMGo1RkIvekdoaVdyQVUyR09OejZEUGc1YUtn?= =?utf-8?B?VVlrc0Mwem82M0NGSTl4cVRscng2YkJ0MlVUbTBJamZsT1QrVXBqM29uZEJB?= =?utf-8?B?MzVBVGZHODk5QW1FZkdBakg1aDJtNmx3aVJkZEhtRzZ2b2Q2ZzlyTm9wNC9k?= =?utf-8?B?YXc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 1bXywavaln7YrtRjLY48w3gahtFKyGVk4t4QkzPUGhtGOUM2027jFdqyiafvTuqJ+kFGOi/kRRjfUUWvxyIfOrUjqcGzQUIbpwJLA4XeebDDZ8pC6aGkn7itwGpG7UljjXSDobWnCnz66wMERPG6oM3IzVtwtJVkvxnTnBdgtfczfwhyje+bDMtPr2LX6aQtKS9HKyQ60g4Hf7GzUM0hcDzS40SKSnd2KBHZ3CcUvowAxAMv/XF3hG+0RCWjWBlHIVv+kDSl4lLrtN7er9RdKT0g+JnEfaa4RC6ifBiDK7ia4+GRVPTn3EwBbEYVVXwlZs7f1RmmHbeZKw5cPyDBdNPn+Kcn52RGlSvJXJMN4VwciTYvpjc2qS0L/XuP/jXcPvLXA4kKq5mXm7Evoo4oN/hd5LQGizOasuixLA5suiQpSIvo+aNv3tzaQRqPqX/gqHzDaT+koFZJBEhmT5Opgdh+HH29G8ItFnKcJoJQQhKKWTHiUJjVRFujARwGNOZr+EoahahGeuCkbbOXZzTCPKpeSZyfzQUVxop5Rt/lswRKN7yLIQDmyC/OqvxmmmfUTROYCjrkOm/dZ9TeXyRs/xPCkEHmYD4+nbnEsjDo0kM= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: a460b2e1-0d5d-428e-ec6e-08dc86fdb09f X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2024 14:25:32.9246 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DJC/jt1FM/q26+188xqITZeeEg1JfbET7JTf1RG80h4TtjeRCVzxdEVQWgZaWRBpicxhp95OyzZcRlRPF439KQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6322 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-07_08,2024-06-06_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 adultscore=0 phishscore=0 suspectscore=0 bulkscore=0 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2406070106 X-Proofpoint-GUID: nw2OJqLpBeOjwzld31BTMxdbKR1RzeGd X-Proofpoint-ORIG-GUID: nw2OJqLpBeOjwzld31BTMxdbKR1RzeGd X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 9AFB31C005A X-Stat-Signature: ma3fyibgc4z1w6x1m17wu41rk6jf9xek X-HE-Tag: 1717770341-522405 X-HE-Meta: U2FsdGVkX19H9Z/WAxxGqjuYjJFOrc/EwBbvRbJgRaQFzE2fCxf9MF8cB3oCn7lEiBDLWbJQ4ZkKr7mfOdULrfIBrV5n2P/50pnc0dnZQG+L+ECScm53Olh9khpHYNpuW2DIcdus2Pm7btrA2riqUWyDGGX9DKHqrcnZ0u8t29yA/PuIgLNxwol7vGDplAPIrCwSF8Uu7eB0v6bNQvLEp+sYm09GPS/62aG7QQlZvWgHhOY2RwnH9EH5m2zqSzY3D3mWJNVpr5ac1zE5vqpggxDwuE1OAaVAXS7OleNDDkC3FZ9dE4dl1ogzNWINjXvfGt+Qzs8Wo9+dWBCFZtfmJ4JVuI76E4sgLBvTCEx1Gnq0Zd2qndPSU6MjsN2s3gzxWRo2Rngr8+Mv8ZAAkXzfXnv7j6aAgzs9fPrp6htdSZUZMiUnNvm9DzEntIdX4Kpt/1DgxXvKL/8D5cJuoIiNnr9fjDTh8EhoMMXLyan65aBk0jjPak7X1gxtckvboZ4dfvygf9/RT1JGvnZ04orZ2rFSIpZQeSdDJR0tYgTfwjZ1WEsYD1MfytngKk1EvQ1rCPmxluh1gLe1JEAIkrWPLe+aD9TFfBlOfVRgzWBsn9w54QoriJMN4vFf9g4Bep/XC9OOZKKzlfmyEu54qNg6odFN4jb8WzII9Dg4fHlYLMFLMNDNVgXV3MCa8Yvefxk1tmab4yTuMrqoiXPd+fhaoVo8ZEzzUyRuOZT9+0+8lqXQa1JqJcNen3PN0BnQmL81xgZrbtdlntm3A7x4vs/EcqpyVyUByObtP9Z+ILuyuX5HwBpT37/0DhH1WEoXzUhA/uftqdG2EAXRS+QyKxsDwUMLYMyGba0s6+0JLZfktjf2SphRoRlARrD47X+N0i4EAaZF//nvG8oW0yb+F10JzHg61R3y3Bmyl0TEvcaYuqnA28NAsA0CQs99BKoNdogryZwW21EXO341QTpd+KG 3bGsnj9x 2wbHUYy44fbVzY9xy3XjyghmGYRByxkefmoeXATmTtsWhR84o1U0Qf0DtujmSF05NJIRKnjT8zbuZnKZ26Pc19opJijVIKO2bVffb0pCBsgoHZ83IH0Ehi/ud+jHx/fjRbw7hZJOfEsJdII6FL++wUvzg8YlKv0g6QFqkCAOCQ3Vxqi4jMfa/jKYHNnHLDix8Ycyr4m7egVxHVBN7DqEWDgQ2+OPHS5VZI5xG4Md91en7CDUD2ck2N+ZiI00I5/TpzMYz4sc8n7A69xAklNzC2m2b9xIGj9v90HDL5m5XHbANp2qzkNcAELvn2T0UwP+bRPwY+J6rZ+qiXhhYjSDdpVV+dVQDQHDL7XgqUlbcFK6yRJI10EtyohLeB4cSfEPTZ5/+/sw49oYDxbraqyTUbssOjKbfweiz2RVQtClvi8OgF0OBpoe9gyHDw/GPISliRcmQ0FG3GqTBJxqi0Vj0vsLGGelfQhpo7dff1rAf3rTfRfHCxZNyRasILz7abkyoJcTHpULbVMWsOTwxhmPMkhEf2jU/S78+ZyNmuLfiXiwaTb3rM0K4wWhjkfKlo4BYRCt5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000737, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Suren Baghdasaryan [240605 20:51]: > On Fri, May 31, 2024 at 9:33=E2=80=AFAM Liam R. Howlett wrote: > > > > The vma iterator may be left pointing to the newly created vma. This > > happens when inserting the new vma at the end of the old vma > > (!new_below). > > > > The incorrect position in the vma iterator is not exposed currently > > since the vma iterator is repositioned in the munmap path and is not > > reused in any of the other paths. > > > > This has limited impact in the current code, but is required for future > > changes. > > > > Fixes: b2b3b886738f ("mm: don't use __vma_adjust() in __split_vma()") > > Signed-off-by: Liam R. Howlett > > --- > > mm/mmap.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/mm/mmap.c b/mm/mmap.c > > index 83b4682ec85c..31d464e6a656 100644 > > --- a/mm/mmap.c > > +++ b/mm/mmap.c > > @@ -2442,6 +2442,9 @@ static int __split_vma(struct vma_iterator *vmi, = struct vm_area_struct *vma, > > /* Success. */ > > if (new_below) > > vma_next(vmi); > > + else > > + vma_prev(vmi); > > + >=20 > IIUC the goal is to always point vmi to the old (original) vma? If so, > then change LGTM. Yes, we need the iterator to keep pointing to the original VMAs, I think this makes sense. I will update the function comment in the next revision to state as much. >=20 > Reviewed-by: Suren Baghdasaryan >=20 > > return 0; > > > > out_free_mpol: > > -- > > 2.43.0 > >