From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81C7BC27C4F for ; Thu, 13 Jun 2024 22:20:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F0206B0082; Thu, 13 Jun 2024 18:20:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09DD96B00AC; Thu, 13 Jun 2024 18:20:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA7ED6B00AD; Thu, 13 Jun 2024 18:20:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CC7496B00AB for ; Thu, 13 Jun 2024 18:20:53 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EA7321A0346 for ; Thu, 13 Jun 2024 22:20:52 +0000 (UTC) X-FDA: 82227286344.29.F884F3D Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) by imf12.hostedemail.com (Postfix) with ESMTP id 711EF40004 for ; Thu, 13 Jun 2024 22:20:50 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=aNoYeWqf; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf12.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718317249; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DOjRV2qMXSqa61K018XbloRv0Vr29gi1LjCcbNkndkM=; b=eKiVPOvPcghfu8abjmifCJk9uskSDKrodoRN7w+LC3SRpBUZRPycG1kaaHlTvzBSzxPix2 h6uFgEyBgIvvnkX4pfGxdq87QVXhavtAh6kFPrSjgCesBBOxrOP8UbkOwXnEe24D1+Yn3k B3pwv26HWaO3sEBvD1vabEzm9kY7d0U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718317249; a=rsa-sha256; cv=none; b=wUO8ep9b/BcZtAbPgL+7Eavsz8r/jXozsQukDCMZ65PYXV5jRHgZKiHbj1QpSDf5YCszg2 id+wwttjNyPOaP8VaUECqtnB0eCuOaw8vdEdRyDMZb5jhzo6uf2/eNsSFfoJxssImO/S9C G+lTaIdDaX9pPxklVtFGxjfNqTgqp3U= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=aNoYeWqf; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf12.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev X-Envelope-To: baolin.wang@linux.alibaba.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1718317247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DOjRV2qMXSqa61K018XbloRv0Vr29gi1LjCcbNkndkM=; b=aNoYeWqfAv7EELvNIqwUVRa+eCDyoTAKU1AXQkLcLwIn5g+sWamK7aVT4qvPOhuiTtstCw wfoB7xnTjSrzqyf7+zxF0UD6OvM2xRM26Y2cs0AYPZ5sAs90XKd9dn5kSAQu1TJqKYnC9n PNv8TwtyrDzSAnBHwwFNn2A5InoNh7g= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: hughd@google.com X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: nphamcs@gmail.com X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org Date: Thu, 13 Jun 2024 15:20:42 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Baolin Wang Cc: akpm@linux-foundation.org, hughd@google.com, hannes@cmpxchg.org, nphamcs@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: shmem: fix getting incorrect lruvec when replacing a shmem folio Message-ID: References: <3c11000dd6c1df83015a8321a859e9775ebbc23e.1718266112.git.baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3c11000dd6c1df83015a8321a859e9775ebbc23e.1718266112.git.baolin.wang@linux.alibaba.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 711EF40004 X-Stat-Signature: a3x9e8431bjcfy3k57sxc83j7rfusbgw X-Rspam-User: X-HE-Tag: 1718317250-59861 X-HE-Meta: U2FsdGVkX1+BePMVcc+sDlVJC7r613ZWGKgtlF9JpD/26L+tMQKVUUI3SHfxySU58Ej4QX+kDfU956Z+btI1K1gIVUNI7jisy8zRPYUhnjMm75KJGhvvb2AKxllbpT5ZFrhbfwscvOfz5uPAfU7x4A93QTqAu/B48dVCdS7S2I/Y5SlAHYKe2ATlJJO6OkbKBAmayxEIziOaGbKIkofgGAMd8+3qM7sTRs8KCGdiwtmIe8RJLmLHPojeodDpPNZzAkYrk2uZ9K9+lvObKUBAwl4xy9jcB9IdaJe4hdDbO3ZEgu4PDbFxPJbwk4FSwg7WMCYiC4TzM0QgSo/8yzUfeCXQm3KKbjK6xY0FPGgLF0sgGKTOMjasG9l5cqCD63bBmwG/onj4P8l6WuA+VTzV2jBAVjsQvZ+4L8XLa2hJH8vfggBX6lR7CvluIttxwPIL46cNOcIwDtL/Laf50Yb2tX/vxlWPjcYzbKpiUb9XK0DRYeh+NObXhepjgZZQtLgOEmcn5nkqmaH69yExl0IAftZn6IUzAotQvuFo3CXwLl/DjyWXAyBp1UPn+o7r4iz5FO7ZGwy8NBlfQqpLxFzuaty9gekLZNGf3i6CE0ulUESFZ8AlQ0MRsw8cwg9aH2mzjjwZ7hcsw5xa/HvxGbnCooKKrT1le8NhAhqdr2Liz6E+8gKbAI0oSmgpOCAFeWAswlBlU79EhaK4Tg0idp0ucKo0UIPEd6G2adq6IAIkoqxuvWhPEGDfX6qqRLOB6xm3mgv1R6tE52hx1L9VlcXpydRJLGZ9Ta6g9iebx2VDRjUD1KFZ2PBGoR8BE+EH9beR5OvKAM/fs6YYbAlHeDdh387PDJWBrfqgwz9GP9I+1jzpjlQznXxJfaS7SkYdqQ+5T6hmvx/Can/hS//4eJJA/pYiD8qLBjs+aXeylJIow4TDP6cETXiVZZ1OGHymZ0xTKt6OPMhhCHuULj5eyTi NvIcXUJ/ S1cCehE2C6drN0UIfdm9UPzRPDvzpMPEtSxIm+jhC8IUt3kQuEeTGlJBjSjBFXuX5lo6xATt11QTndslz+ZKxNJHzDm4gBf2nt06QzBzMj9V0GYwJwYgvdzC9cXnwJMofVfNAZsCYU8a2ljGpoDt5UhaRoQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 13, 2024 at 04:21:19PM GMT, Baolin Wang wrote: > When testing shmem swapin, I encountered the warning below on my machine. > The reason is that replacing an old shmem folio with a new one causes > mem_cgroup_migrate() to clear the old folio's memcg data. As a result, > the old folio cannot get the correct memcg's lruvec needed to remove itself > from the LRU list when it is being freed. This could lead to possible serious > problems, such as LRU list crashes due to holding the wrong LRU lock, and > incorrect LRU statistics. > > To fix this issue, we can fallback to use the mem_cgroup_replace_folio() > to replace the old shmem folio. > > [ 5241.100311] page: refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x5d9960 > [ 5241.100317] head: order:4 mapcount:0 entire_mapcount:0 nr_pages_mapped:0 pincount:0 > [ 5241.100319] flags: 0x17fffe0000040068(uptodate|lru|head|swapbacked|node=0|zone=2|lastcpupid=0x3ffff) > [ 5241.100323] raw: 17fffe0000040068 fffffdffd6687948 fffffdffd69ae008 0000000000000000 > [ 5241.100325] raw: 0000000000000000 0000000000000000 00000000ffffffff 0000000000000000 > [ 5241.100326] head: 17fffe0000040068 fffffdffd6687948 fffffdffd69ae008 0000000000000000 > [ 5241.100327] head: 0000000000000000 0000000000000000 00000000ffffffff 0000000000000000 > [ 5241.100328] head: 17fffe0000000204 fffffdffd6665801 ffffffffffffffff 0000000000000000 > [ 5241.100329] head: 0000000a00000010 0000000000000000 00000000ffffffff 0000000000000000 > [ 5241.100330] page dumped because: VM_WARN_ON_ONCE_FOLIO(!memcg && !mem_cgroup_disabled()) > [ 5241.100338] ------------[ cut here ]------------ > [ 5241.100339] WARNING: CPU: 19 PID: 78402 at include/linux/memcontrol.h:775 folio_lruvec_lock_irqsave+0x140/0x150 > [...] > [ 5241.100374] pc : folio_lruvec_lock_irqsave+0x140/0x150 > [ 5241.100375] lr : folio_lruvec_lock_irqsave+0x138/0x150 > [ 5241.100376] sp : ffff80008b38b930 > [...] > [ 5241.100398] Call trace: > [ 5241.100399] folio_lruvec_lock_irqsave+0x140/0x150 > [ 5241.100401] __page_cache_release+0x90/0x300 > [ 5241.100404] __folio_put+0x50/0x108 > [ 5241.100406] shmem_replace_folio+0x1b4/0x240 > [ 5241.100409] shmem_swapin_folio+0x314/0x528 > [ 5241.100411] shmem_get_folio_gfp+0x3b4/0x930 > [ 5241.100412] shmem_fault+0x74/0x160 > [ 5241.100414] __do_fault+0x40/0x218 > [ 5241.100417] do_shared_fault+0x34/0x1b0 > [ 5241.100419] do_fault+0x40/0x168 > [ 5241.100420] handle_pte_fault+0x80/0x228 > [ 5241.100422] __handle_mm_fault+0x1c4/0x440 > [ 5241.100424] handle_mm_fault+0x60/0x1f0 > [ 5241.100426] do_page_fault+0x120/0x488 > [ 5241.100429] do_translation_fault+0x4c/0x68 > [ 5241.100431] do_mem_abort+0x48/0xa0 > [ 5241.100434] el0_da+0x38/0xc0 > [ 5241.100436] el0t_64_sync_handler+0x68/0xc0 > [ 5241.100437] el0t_64_sync+0x14c/0x150 > [ 5241.100439] ---[ end trace 0000000000000000 ]--- > > Fixes: 85ce2c517ade ("memcontrol: only transfer the memcg data for migration") > Signed-off-by: Baolin Wang Reviewed-by: Shakeel Butt One request: please add VM_BUG_ON_FOLIO(folio_test_lru(folio), folio) in mem_cgroup_migrate().