From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81E03D31765 for ; Tue, 5 Nov 2024 16:38:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11A3A6B0085; Tue, 5 Nov 2024 11:38:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C9926B0088; Tue, 5 Nov 2024 11:38:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFBE56B0089; Tue, 5 Nov 2024 11:38:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D0BAA6B0085 for ; Tue, 5 Nov 2024 11:38:43 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7EA6AC163B for ; Tue, 5 Nov 2024 16:38:43 +0000 (UTC) X-FDA: 82752599328.05.FF53AA2 Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) by imf11.hostedemail.com (Postfix) with ESMTP id A353240010 for ; Tue, 5 Nov 2024 16:38:00 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=SGoHfx4t; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf11.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.174 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730824598; a=rsa-sha256; cv=none; b=nfP7adBYRTa+J1ViA5lvcq5Z8N1h0iHPomV54iLvMhy9F2x5bjvGgwcOwOjzdH5nlcSuZD Azn4rmXdE4QMIucwWByiHeQdfjGARFN4z6xxmbSE9pQED+5LAQ8tTRR+LjnI+zyYco6Gvo Z2/BETfTuDlxNVCH9hPiwFv77/pqjL0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=SGoHfx4t; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf11.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.174 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730824598; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GrkQFJvrlknPskvBK6hxqCCGXNIgK5FjJfbgLjTLDOM=; b=MrNO/wTvNYlBE8aORGqgAz+ytF3/qYdLHHwyfQCYw6dFqvSZ+KS7SCdZfoiNX1jtkHKyJc YrXELgajv5w49Th3niQ/NvIqzzr+dvnDOi73P6P8Iy3LgRvAb3YUfX4tDv/MiYfuew2pjn Zw1dDzcGRqeefCWX3x7JvuMdLM1z1bc= Date: Tue, 5 Nov 2024 08:38:32 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1730824719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GrkQFJvrlknPskvBK6hxqCCGXNIgK5FjJfbgLjTLDOM=; b=SGoHfx4tvHYi19QTB+rVHQpL6cPj5CgM6RyXDmIZgAwzuzlNn8wbUNmA9wX9mqHm/OjzPf 1TOEs/yPrJjoeDHyo8QL5NT8Uv4fz06+2ihN+XD2IdYk/6h8yMAMlhprUUlzi0LaDiYpg1 xC2TognkZdzSmwA3JLAoT41YDAsdktA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Keren Sun Cc: akpm@linux-foundation.org, roman.gushchin@linux.dev, hannes@cmpxchg.org, mhocko@kernel.org, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] mm: Replace simple_strtoul() with kstrtoul() Message-ID: References: <20241104222737.298130-1-kerensun@google.com> <20241104222737.298130-5-kerensun@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241104222737.298130-5-kerensun@google.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: A353240010 X-Stat-Signature: 3uwruwj66xxo19wsn1akku14n6o6yiip X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1730824680-442515 X-HE-Meta: U2FsdGVkX1+qGEjofrZzt4a+MwR4ZuBI32j1igZBbDyQv/4lJHiKBCcCpdJ3gAVxWmZFMo9c8FX9WLD30KqT8+JRGe5jwunMEi/pGKE/S1ZORlevgK4aiZ4VBsX+V/meSg0qosAKebVyvYnvtHg8Dpu3ULS1OqQ1evWLVBem0ag0/5aRvEFEg5vn+ZU3QGgtE5QwDijWJ25JYq685larEA/1JCJ6sAmyzv+BksmNI10xrAFhO83ioGsD9jL6UzGodixlRjuKwJn2l3zS2xHDM0q7gxaNgXMLcB+msQu+zX2NP+ZURiyPi7mE9C0evf6Cz3hYUTuQRGxE+o6Rc1dZ9DQPAI6UHdG73bZ05xxMJMJ/mjBLCx2+TiaX1V6qzmoBX1OIunNe67+dvup26hSKOGETWAXtTQziOVyWmVwQXcoah2ePTdDCNJurr39Dg0BdFbeaxAQ/pc/wEjgAA6NpPFdYj2tKtqfJ3BpWBBSQkRnAPgyIoEeffZuqmFwKvaJ2kjDrJLlPDJ0l9Ol3n6TQ2VwsW24Q/0+xh5mqnoRQfJ6ichZ+zJtRH0gmdplkYr+2BXj6UBnCDxzXe9EJMMVN5Lq1rI7pSoZFKykgDzo9YImchoz8nfjRH8sHiQ5kAxKsU2sgUDYV9iaFH77+noF1amx8ne6Tc73fFVt7jg55IGAdhhY2wOuvlcyOWj4/k/sLxkrsFFncVrAWew1vgKtDpE0nBsVYVXRaRrYODIF8zH/qZ42Z11aQEV9NU6yRqJCxodXkMGPhBF2BIkE5gXxun9/PfoBfb3PKsk2eqVg8NhUk5VyRGzwIOm4fgoyOHR7vPPBrs1ZhCaQKKNPCBn6yaQ4d08cmBu2JTMvSxlns2KyXGGpr6C7D2O/10x4hLeHTNJmIGTFvMu2n0wZTkYp/Z0FiAxxfDizITiPCfoa/zLvF7j1vlWsRChM77yN1Hr0oIhpABur3OYim6xqIucw pvd8SW/G 3zjtYCo3NlntzScm7gEhIRtdfut8O59pSRz890ffmuFUyA1Y0Uny01fT+ThQMJK0h+ChNNuQKtIMJ5Tag0OjKLPfgGzZ9Tliib9YLadr5zkI/58AIur3JtJKiN4gUzjH6E+Z5j0Ev0p6Um+UqBt3mK0Cs4GljXXg0LREpKcS3hm7vGQtc0m17xxNDNxDGZFPKfpj6hf0WJEPYFvPjJZPwwhkLSOF/KiFp9NXLgh8aNC/OolHnUSDbfmOjQw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 04, 2024 at 02:27:37PM -0800, Keren Sun wrote: > simple_strtoul() has caveat and is obsolete, use kstrtoul() instead in mmcg. Did you test this patch? I don't think kstrtoul() can be used here as it expects a string containing a single number. > > Signed-off-by: Keren Sun > --- > mm/memcontrol-v1.c | 17 ++++++++--------- > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c > index 5e1854623824..260b356cea5a 100644 > --- a/mm/memcontrol-v1.c > +++ b/mm/memcontrol-v1.c > @@ -1,5 +1,6 @@ > // SPDX-License-Identifier: GPL-2.0-or-later > > +#include "linux/kstrtox.h" > #include > #include > #include > @@ -1922,17 +1923,15 @@ static ssize_t memcg_write_event_control(struct kernfs_open_file *of, > > buf = strstrip(buf); > > - efd = simple_strtoul(buf, &endp, 10); > - if (*endp != ' ') > + kstrtoul(buf, 10, efd); > + if (*buf != ' ') > return -EINVAL; > - buf = endp + 1; > + buf++; > > - cfd = simple_strtoul(buf, &endp, 10); > - if (*endp == '\0') > - buf = endp; > - else if (*endp == ' ') > - buf = endp + 1; > - else > + kstrtoul(buf, 10, cfd); > + if (*buf == ' ') > + buf++; > + else if (*buf != '\0') > return -EINVAL; > > event = kzalloc(sizeof(*event), GFP_KERNEL); > -- > 2.47.0.163.g1226f6d8fa-goog >