linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: SeongJae Park <sj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linux-trace-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>
Subject: Re: [PATCH] MAINTAINERS: Add mmap trace events to MEMORY MAPPING
Date: Sat, 12 Apr 2025 09:17:21 -0400	[thread overview]
Message-ID: <mcz3dhxkjpgp2qv72dx2lttwnzdvujvnosdx5a7lkjpuj3r4iu@jevlyctotoay> (raw)
In-Reply-To: <20250411174734.51719-1-sj@kernel.org>

* SeongJae Park <sj@kernel.org> [250411 13:47]:
> On Fri, 11 Apr 2025 13:33:28 -0400 "Liam R. Howlett" <Liam.Howlett@oracle.com> wrote:
> 
> > MEMORY MAPPING does not list the mmap.h trace point file, but does list
> > the mmap.c file.  Couple the trace points with the users and authors of
> > the trace points for notifications of updates.
> > 
> > Cc:Andrew Morton <akpm@linux-foundation.org>
> > Cc:Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> > Cc:Vlastimil Babka <vbabka@suse.cz>
> > Cc:Jann Horn <jannh@google.com>
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> 
> Aced-by: SeongJae Park <sj@kernel.org>
> 
> > ---
> >  MAINTAINERS | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 4c7fdc41a6bfb..d8e9a10adc81d 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -15571,6 +15571,7 @@ L:	linux-mm@kvack.org
> >  S:	Maintained
> >  W:	http://www.linux-mm.org
> >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> > +F:	include/trace/events/mmap.h
> 
> Should mmap_lock.h also be added here?

Oh, well..

mmap_lock.h (include/trace/events/mmap_lock.h) has to do with
mm/mmap_lock.c, which also isn't listed here.  Both exist for tracing as
well.

There is also include/linux/mmap_lock.h, which is the locking itself.
The mmap lock is used more broadly than just these files: mm/pagewalk.c
and mm/ksm.c, for instance.

So I guess that's a more difficult decision.

Thanks for bringing this up,
Liam


  reply	other threads:[~2025-04-12 13:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-11 17:33 Liam R. Howlett
2025-04-11 17:47 ` SeongJae Park
2025-04-12 13:17   ` Liam R. Howlett [this message]
2025-04-12 15:47     ` SeongJae Park
2025-04-11 18:33 ` Steven Rostedt
2025-04-15  9:05 ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mcz3dhxkjpgp2qv72dx2lttwnzdvujvnosdx5a7lkjpuj3r4iu@jevlyctotoay \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=jannh@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=sj@kernel.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox