Re: [PATCHv7 5/7] kho: don't unpreserve memory during abort

[Pratyush Yadav <pratyush@kernel.org>]

On Tue, Oct 21 2025, Pasha Tatashin wrote:

> KHO allows clients to preserve memory regions at any point before the
> KHO state is finalized. The finalization process itself involves KHO
> performing its own actions, such as serializing the overall
> preserved memory map.
>
> If this finalization process is aborted, the current implementation
> destroys KHO's internal memory tracking structures
> (`kho_out.ser.track.orders`). This behavior effectively unpreserves
> all memory from KHO's perspective, regardless of whether those
> preservations were made by clients before the finalization attempt
> or by KHO itself during finalization.
>
> This premature unpreservation is incorrect. An abort of the
> finalization process should only undo actions taken by KHO as part of
> that specific finalization attempt. Individual memory regions
> preserved by clients prior to finalization should remain preserved,
> as their lifecycle is managed by the clients themselves. These
> clients might still need to call kho_unpreserve_folio() or
> kho_unpreserve_phys() based on their own logic, even after a KHO
> finalization attempt is aborted.

I think you also need to update test_kho and reserve_mem to do this
since right now they assume all memory gets unpreserved on failure.

>
> Signed-off-by: Pasha Tatashin <pasha.tatashin@soleen.com>
> ---
[...]

-- 
Regards,
Pratyush Yadav