From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34533C02198 for ; Thu, 13 Feb 2025 01:43:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9B3D6B0089; Wed, 12 Feb 2025 20:43:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A4BB56B008A; Wed, 12 Feb 2025 20:43:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 913386B008C; Wed, 12 Feb 2025 20:43:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 726746B0089 for ; Wed, 12 Feb 2025 20:43:07 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 224C44C643 for ; Thu, 13 Feb 2025 01:43:07 +0000 (UTC) X-FDA: 83113223214.26.BAD3E69 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf21.hostedemail.com (Postfix) with ESMTP id 34CFA1C000C for ; Thu, 13 Feb 2025 01:43:05 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=dOFAw5FQ; spf=pass (imf21.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.179 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739410985; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T5oGSM/mXRFDYtGHRMEZVTjxUhTtt3uAbcMTieIkRRk=; b=3Xnvr5vxvx7YXRTA3ngK+yc6ctf0WP9YBCgAFKwlpwjXduLXgQC5ZRjjST5cFn5oOnNSDj spkeKYxqTIcx68ZAaH93VIDj3v6MOeKv0Ldb6OBLa/kGwGw6yk+XgVsyQpfX0GcxIBZFHl hmfQpwT51Z5OlqhNhcf2qsOJaflslDk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739410985; a=rsa-sha256; cv=none; b=8S2mXZJZUQTiGnf5ikXyq5HC+KYV4QBkEqihx0iB8EKBL0JJgnBld3E1VRaQkLqLYlo0Uw O1CC08twS2D0cNaaEkjpz4CXCkSntLbPYCZXtONaH58YZESJ1a/OqS4SFkg3s9O8W89bll sc0Qqr4anesISXcZHQJSlEjZf7+cNo4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=dOFAw5FQ; spf=pass (imf21.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.179 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-21f48ebaadfso5490145ad.2 for ; Wed, 12 Feb 2025 17:43:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1739410984; x=1740015784; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=T5oGSM/mXRFDYtGHRMEZVTjxUhTtt3uAbcMTieIkRRk=; b=dOFAw5FQ88+MLLSu3091DSUybqIwiZaGl3Yiu9s0AxYwudGwWDhMbFSkbGSuJb3giH qCQ6hlub98XS1o154W4MQhAsC9kkZKKhjOIcG2MYC8P97chDPlZt70lzqpMf594bOQ5u zdkLzqOw45SlkiueT5tQfeBne9TkocEkp2HBs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739410984; x=1740015784; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T5oGSM/mXRFDYtGHRMEZVTjxUhTtt3uAbcMTieIkRRk=; b=B7jWMb02riHaYJFCPu5CeaFaovnjFU557252VEsQh+/BLzT3IdKUtEam7yn+uZdW1e ehH6jRxKjLyeaB+k0EKxQppHK63iAqrWdxFQ85uHfoZKrYJ+uyo4qlRW69TbSUxlmzjb a75OeTpWUfY3c8rBntZ4zC2HXxvANcyyvlymnPou8nBTnu8yKdEjHunb07Diuk2ThRhk gwhhl9nnZBmIvl3q2d2eD3rWHpyrccOrdzqh0ZUt9g8xSxgZIFKdbPajMv8SsK6+/bNf 8Tb8R2f6ld8yrDD+Z0kgfsXYC3iov7UgIHOwJJfsLu/oku++t6UUGUgaEiWmx0o2JobK daXw== X-Forwarded-Encrypted: i=1; AJvYcCWXrf/IAEBzV5O6OJ7kiTSeQbPdBiycYxJQZK0rSTawiDI22GjIMcSrmUrs3mcv59xKhv82BwSDNw==@kvack.org X-Gm-Message-State: AOJu0YzDYPHfcY1PMWDIOWos8FzyzPY4PyrXN6MFiIx3O5ZIeu3H/Atn eIedw+j7q8+7/3yZbDGfshZNYjZ3XWbJBU591EPt3pKjnMroZPoZ3JWeV2wXSA== X-Gm-Gg: ASbGncuy7DN4kytwntlfcOY4sm2J3CcHvS+JvJE3viFOm/ejQpCRBDhTqzuUdVgCDoC BBe2MvdrE46S5O5jU0azYBoAyIBgZDsEdiddOkxCaP+W12r7uhSnNc0X+Qui+iw6tQINvYKeUEC bun155nkzlfegncAuk0AJ03/218m26E7NQOYbrukpYKbasCm+y2gb+c19Hr6YjZWCz9F2CmfAQZ +f/AzDCFbotsPY/qrF0cwR26+0pWZ5Tm8HJeuqzBfPZem6h/KAC6J5sYLqLsQY91UD8T8Y+y6kd JxGHWAXT+aeyqLkq3+A= X-Google-Smtp-Source: AGHT+IEQkYn7LfEDpm4b84tpMh9IaVyeLMgGUosZu1w3p3j0cQQkmIHAGvjDe9IZBFuwDnNA/Ndrew== X-Received: by 2002:a05:6a00:4650:b0:730:76a1:392c with SMTP id d2e1a72fcca58-7322c383ac4mr7127290b3a.9.1739410984041; Wed, 12 Feb 2025 17:43:04 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:3ed3:97ce:5f5f:1f61]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7324273eac4sm107298b3a.113.2025.02.12.17.43.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 17:43:03 -0800 (PST) Date: Thu, 13 Feb 2025 10:42:56 +0900 From: Sergey Senozhatsky To: Andrew Morton Cc: Yosry Ahmed , Kairui Song , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH v5 01/18] zram: sleepable entry locking Message-ID: References: <20250212063153.179231-1-senozhatsky@chromium.org> <20250212063153.179231-2-senozhatsky@chromium.org> <20250212160830.730a199935e907c2498b28d4@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 34CFA1C000C X-Rspamd-Server: rspam07 X-Stat-Signature: b1ugji869uebwy6j869n7mcxxgj8c6z9 X-HE-Tag: 1739410985-567680 X-HE-Meta: U2FsdGVkX18eirIRCJNPi++rxRSFmfU1jTr0iTlqDEHeIgeOBz1SUGav2oD4BEKtcUFD5UdQFKoCY917rwxzR70Xmq5FAsgL3bV8r6FZFQwvwBT28BUpO0ksRKXmpUsaiqWkO385juG4pPyY3ZVdOrQy/6oHSmJVR19d03PO3Gg5y+0VdrajjX0OmcZK7epgRzDIqYxRndoMD0/ApIkspLINWVgnAj1ITM+fXDC1skAvLxR5iW3y2rc97mq0zIVYP0QaCKp+i59mMhAcfuUEEIaex5Y+b+H1KC92jVGgmG5Z/QK7JpOAzn3N4Z7e0ro0kJrqT7NDC/UCVUfHqrQqRfMDlfNtp/vHOs2YadFxPmNG0uQWCxcY08uzL8CqI5IIbhTSLJHOHhdT719EC6oYbstbuuc2fh2p2Rs6KQIHT0YO3qIRgyNV0zLLO/bUFRZsKfXSR9w30wJjnG+oLtVFKk9RjnPkkVSqEMtCNj+pEqIjhAXYYmC0JrP/jl/68tvFnpQuaNuz87CweRL8n6SiwbJvJrOqQE3Ru7KPMTJkIJJP/MGa1/DJ6bhewroZuJCEe9VJ1VeaOZPMZ/GXtbHb0MIi73I7gbRC2Qpac9KpTxkfUPEWmn2VNG0gmE2eI677ksweGXaiNp/MOw29UUpS3EP7E/fVoUq1Wra0dE1ubufMmnZsHYMSF5rGHDktlanl066d695yBhRd5PFbHU7dL00uJA1LmNnV94hrBDqbaz5JJ7Byrs0X+ipL7YOWwo8iZa0/TQ76wNAomheu05svalqLA+AaJNDY6mMbf+OnfgLiGimBzr8Z0inmq6MU50M9JULo5pvK92dMu4vLvdcDO9gaL/waiz72h8gjif2xMz/Alzo6GBzp9tMEsOrncRwtGYUOVZCDv5ZwmoL7X981//YBytJurmjP+RW+24hqT701cN96u4RZ6I5q4e7d+8JNpPVsNmp54CricvNZpyK PcZ2jY1D VjhluRG/yuxeB0/SyKiL+Q5mUNpyImCbAdnbtQ3kyVSgCqBXSOvcIPQrsSfhAipus6vvvrYPcOtZguJUSmiGT3zGIEJwmyXVfb6tZLi7D9k7RNVm03ZCpnBV5w1zzA/2bqR5vmmGqKyyrv91HwI8yEJjKL4Hm+HnUbIayrdDh1P7nzW+2lVucVVngq3+UUwDsWtYwJ7DMGqzVlAd62uTcVkli1Vais/sd48XznObfdBYEDKAasGlV+tYhXs9xYEGK3q0AqIRBoyCiqzgVf1SBVgIJLOcyBbMaXQaNCdnw9bpPNpjz3NX0ycEy0EWe+JnppyHMr60M+VJO3hE6zfG9W+NNTWwHN/GL0ffFMY58Mq5q9JU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.013260, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/02/13 09:52), Sergey Senozhatsky wrote: > > > -static int zram_slot_trylock(struct zram *zram, u32 index) > > > +static void zram_slot_lock_init(struct zram *zram, u32 index) > > > { > > > - return spin_trylock(&zram->table[index].lock); > > > +#ifdef CONFIG_DEBUG_LOCK_ALLOC > > > + lockdep_init_map(&zram->table[index].lockdep_map, "zram-entry->lock", > > > + &zram->table_lockdep_key, 0); > > > +#endif > > > +} > > > + > > > > > > ... > > > > > > +#ifdef CONFIG_DEBUG_LOCK_ALLOC > > > + lockdep_register_key(&zram->table_lockdep_key); > > > +#endif > > > + > > > > Please check whether all the ifdefs are needed - some of these things > > have CONFIG_LOCKDEP=n stubs. The problem is that while functions have LOCKDEP=n stubs, struct members don't - we still declare table_lockdep_key and lockdep_map only when DEBUG_LOCK_ALLOC is enabled.