* [PATCH] kselftests: cgroup: fix kmem test slab1 check
@ 2023-08-02 18:41 Lucas Karpinski
0 siblings, 0 replies; only message in thread
From: Lucas Karpinski @ 2023-08-02 18:41 UTC (permalink / raw)
To: hannes, mhocko, roman.gushchin, shakeelb, muchun.song, tj,
lizefan.x, shuah
Cc: muchun.song, cgroups, linux-mm, linux-kselftest, linux-kernel
test_kmem_basic creates 100,000 negative dentries, with each one mapping
to a slab object. After memory.high is set, these are reclaimed through
the shrink_slab function call which reclaims all 100,000 entries. The test
passes the majority of the time because when slab1 is calculated, it is
often above 0, however, 0 is also an acceptable value.
Signed-off-by: Lucas Karpinski <lkarpins@redhat.com>
---
tools/testing/selftests/cgroup/test_kmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/cgroup/test_kmem.c b/tools/testing/selftests/cgroup/test_kmem.c
index 258ddc565deb..ba0a0bfc5a98 100644
--- a/tools/testing/selftests/cgroup/test_kmem.c
+++ b/tools/testing/selftests/cgroup/test_kmem.c
@@ -71,7 +71,7 @@ static int test_kmem_basic(const char *root)
cg_write(cg, "memory.high", "1M");
slab1 = cg_read_key_long(cg, "memory.stat", "slab ");
- if (slab1 <= 0)
+ if (slab1 < 0)
goto cleanup;
current = cg_read_long(cg, "memory.current");
--
2.41.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-08-02 18:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-02 18:41 [PATCH] kselftests: cgroup: fix kmem test slab1 check Lucas Karpinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox