From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6277D1268C for ; Tue, 5 Nov 2024 11:30:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 697CD6B008C; Tue, 5 Nov 2024 06:30:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F7B66B0092; Tue, 5 Nov 2024 06:30:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 499206B0098; Tue, 5 Nov 2024 06:30:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 27B936B008C for ; Tue, 5 Nov 2024 06:30:27 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A6910C12AA for ; Tue, 5 Nov 2024 11:30:26 +0000 (UTC) X-FDA: 82751822244.23.4931E45 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf02.hostedemail.com (Postfix) with ESMTP id 3A5348001C for ; Tue, 5 Nov 2024 11:29:21 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ID0Lxhgk; spf=pass (imf02.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730806140; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ULjdb1z4hvBc3B/uvWTCeqNt7HFogThnf3cG0eedTM0=; b=vC6JUv0LQrLdVBJvukmSX2oCRSl+0pADj5up548s2DMMGt7cdjlSS6GBpoEvfuudDp4LRm wNobMM8RnIJHGKUKipENX3QPn14LOLa6YyEfREmUt+80Pv7WRDj2hhe0+OxCn4t0rMs8lM AsyQSNaY2Xxsu/RjVNHIqy7di5PinTg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730806140; a=rsa-sha256; cv=none; b=W6rRHdaZXaKk73lNgICzYv9BteslVsVnMxt8530vsIChqtTpYi2iiadcUF4OKJLG2R8Gx+ nLuYPc7WBSB6YrRSPkMDz1hkmhZMi+zDtPGgnFxSxiIzN1VyhWYkLUX5rvN0mxQFGWvfMK S9N4v+Yjgs3BZhIKQRSL13aFv6RzMFI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ID0Lxhgk; spf=pass (imf02.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=mjguzik@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-539fb49c64aso7434417e87.0 for ; Tue, 05 Nov 2024 03:30:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730806223; x=1731411023; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ULjdb1z4hvBc3B/uvWTCeqNt7HFogThnf3cG0eedTM0=; b=ID0Lxhgk5lr5XKT/rIedUF1GJx0hTM8BjypPZPBWgS3nUqhzmj1kKnNOh8UQWGCppd 3uoB6Xl6uDyh1W80UCmUEdd73LyT7xYWtoEodHqNI4hPTWCceHD9vcx4ArC//Yr80Gg3 wvqqVPKhVpVwXyFk0fr/ZBjX24+fZAtVkLeKP++vcY0SXO/QawJZYu4EgdZ1jT4Cvfm4 YxYO545aGyPQvFRRjdUsZXP98KYpCnorGcVUkVVGHEshzjxmSWEm6A5rNx7/UwapbjVd s+WeYAH9uBfB8BaglURgn+ocbkw3h6tFJXOe+EFHlMwHd7Q7s+TWHpu5YLEDDaAmCgVf tH4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730806223; x=1731411023; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ULjdb1z4hvBc3B/uvWTCeqNt7HFogThnf3cG0eedTM0=; b=sqlHm1dKmqSTUzOhYim4q15wQ5gaKXQvCQqU792aEB8qdBbzjUYIw9SoD/HuEd+WpQ JqkD6Q10hpFWdOGp8AUcwPxFpjzuH+n6d8ePewiXpXxqeTdVO6drghMWu6Z8xK2uE74/ LFTyQa9N7BHHIHo4O4dMcoihlt34uM6oxETNLKC0GYB9KEfk5/3fFsddsz3tYiOzQXwV ul8byhHwllDxxUcqHyO/ab2KTHbqlNRrZxg0nMbUqtG1XnCNesfXlpdUlYgIa4GWn1yo hnW5kEmA8N5/0o6G87hmllN+25acDQjT8Aza7s9dJUBNpBRZfLkRKfUGHvwpGiHusDog yScA== X-Forwarded-Encrypted: i=1; AJvYcCWVVozjHytnJnP3RaICHp92ByIw/+9O0abrHB83zSTReb4cyjii7Ce3drZTY0pfZBOsZrw2bX7flQ==@kvack.org X-Gm-Message-State: AOJu0Yy3wpxXsUNdeF/1B4YB7EWFNgsZlQVvvjhZyXHW6+BBEP/lmG/5 J1ICwXOUYvuCyZhsEQ6xZL6Q+r/s6W85q7j3rrwohAZJvcmod8kb X-Google-Smtp-Source: AGHT+IEewzjwOUa0rMORv/qSPbFJcOM2J3M+HuEFHZyl6X8ycGs368CdUauiNcXUll3WZidrqOWd5A== X-Received: by 2002:a05:6512:3e0d:b0:539:f10b:ff97 with SMTP id 2adb3069b0e04-53d65e16242mr11530316e87.49.1730806222463; Tue, 05 Nov 2024 03:30:22 -0800 (PST) Received: from f (cst-prg-73-86.cust.vodafone.cz. [46.135.73.86]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9eb17cea97sm121225466b.115.2024.11.05.03.30.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2024 03:30:21 -0800 (PST) Date: Tue, 5 Nov 2024 12:30:09 +0100 From: Mateusz Guzik To: Dmitry Antipov Cc: Tycho Andersen , Alexander Viro , Christian Brauner , Jan Kara , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, lvc-project@linuxtesting.org, syzbot+03e1af5c332f7e0eb84b@syzkaller.appspotmail.com, vbabka@suse.cz Subject: Re: [PATCH] exec: do not pass invalid pointer to kfree() from free_bprm() Message-ID: References: <20241105111344.2532040-1-dmantipov@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241105111344.2532040-1-dmantipov@yandex.ru> X-Rspamd-Server: rspam10 X-Stat-Signature: knu7qr3sotcj9gsmhhh1ctssk4kiqztu X-Rspamd-Queue-Id: 3A5348001C X-Rspam-User: X-HE-Tag: 1730806161-746492 X-HE-Meta: U2FsdGVkX1/9a6Mrgi4sHweSt+STorkQy0KQEfdy117K2IsqQ9B6zjtn9LuzaNsSqwN97XEAvDUzvJdoA7nb/X/SPk/conn/Fp9xM8yWYzDiXphsyrMDe2f3JIM9lcq191GmUd9ryNOISfabgnbFnQJT4UI9Ni+cy6zeDUDxzuAQRmtLYgdhY10tXev37hmOm5703K0CeUogFdfsIXNL9mFtoviRACjjOu4CSUsP7UR6p+A+iRJbKFN7/zC9nHtv0NEQsq3NUQcJalhC3MQ1EMMnf5zosKSACYFscCdCHBnkhY3HS0m75cwDdhY6fFHcaGpqB5ts+ZvXzxk3wyDu4XwlInh07SOIsF5rZfY8ULSyQK2OIIiFgdb/AN3CiLhqKZ3y+dF4uWAhYKQULUJuWl7EdY1PN6xAr7mFKIckf7/caq/0efWCIHeXtkZ6ELMc/FqY6Sj5/SrTGnT+robNSGeF+KFC/ZB13Taz/BiySRYkRs/IAYI6hYrFeGv5r+twUUkc2xuLFqJwJYXT6Z6yaJT7BR6IyLVvglPjEP1vdUc6UO8r6R4X+0iRw8FBkhTilnyQNb0ew0hKqmWphGoOrUHuNYH8G86Sx3v2yaVpaeatUNoXPSve+v4h0K43T+mn/IUK4Zhum/5e59l44uTERPVJqsIJpOmJZiD4uf9RC61rVQd/CV4q83W+5yPOE8zhWaTqsGiAx63DiNXX4As9GgM6zf+68qdMLr2jTR2Uy8/4VGv3uj4YvY27viAw2SRfuX6k7PIk9ZOThJ21SaDVAfNYlpGA3vAzzughF70R4tb01qM5ik3UYa+Bz4MOIcbo8DzlQnYTZJyDIww2j82qtyzuDe3FI/pI8ex1fc6fiMwsSyEoukejGiqRbuLOlyaImIyjW2YfF1zrESBCogcHRvJsa8KT41dNHxlOzumY1YCM1O8xmdiRt/L6qj65/SBf09jJoliEu4sB8Cr4wZB TuX+mwFY 20ByCzflWjWqYzKkDTRCSlX7HW10xsdZSeV9VStQ0ylTvRhxyOlNt37FPMBwCIehqFwiwdfUlhx0HE+QR42u9d5TyW+StRNi01J9QQBV7rANGEHFyenckvihVILVhRV+iWR+MFx+FKdijaPLRMjgzFL+BV4K6C+T6V0EIi65EPSID8VTZTlLxX3BbrqIw+1mjWiK5ovVEIKCsp+yEXUYseOBgU9B6nIJEfNsfKRdCudGuFPDijmMBUS60dwUaK0tB31LCXdyN8jdhYasrevNHcfTT8lZRKBh3tedJE8EElbk/gO383oRnPJg8cBwzvn+s01aQ6ONsoPb24WWXqL+/aMKjwj98/Fno+d0k6NAb2ExfmlpW+A1FtZuFtw9MqTjBZor8hjA2382gmQTgc/KmplUsPs27VGbLzXBPeGUXTaDkhgwLXbJAW/HRAy8uURGrv51YjhZprPcoohhEx0xiNl9BFBaZbTh86jAaGnaEMd36/5hjh6esB7a6XKLV1qsABuShwrJTfZVRLRiC6eanAAVzyeuwJkE2UVPO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 05, 2024 at 02:13:44PM +0300, Dmitry Antipov wrote: > Syzbot has reported the following BUG: > > kernel BUG at arch/x86/mm/physaddr.c:23! [..] > Since 'bprm_add_fixup_comm()' may set 'bprm->argv0' to 'ERR_PTR()', > errno-lookalike invalid pointer should not be passed to 'kfree()'. > The specific instance aside, perhaps kfree could get patched up to complain about it (when debug is enabled)?