From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: akpm@linux-foundation.org, maple-tree@lists.infradead.org,
linux-mm@kvack.org
Subject: Re: [PATCH v2] maple_tree: cleanup interface descriptions
Date: Fri, 30 Aug 2024 10:39:26 -0400 [thread overview]
Message-ID: <m4igwwrho3ccgoinjemdjtvgjq2n2qitgvvzpdftwjbmtnwszh@5itregml5ptr> (raw)
In-Reply-To: <20240830143647.bs5bkmkicb4buqjp@master>
* Wei Yang <richard.weiyang@gmail.com> [240830 10:36]:
> On Fri, Aug 30, 2024 at 09:30:37AM -0400, Liam R. Howlett wrote:
> >* Wei Yang <richard.weiyang@gmail.com> [240830 04:47]:
> >> On Fri, Aug 30, 2024 at 12:12:14AM -0400, Liam R. Howlett wrote:
> >> >* Wei Yang <richard.weiyang@gmail.com> [240829 22:57]:
> >> >> This patch tries to cleanup some interface description:
> >> >>
> >> >> * function name mismatch
> >> >> * parameter name mismatch
> >> >> * parameter all end up with ':'
> >> >> * not prefix '*' if parameter is a pointer
> >> >
> >> >Why not use * if the parameter is a pointer?
> >>
> >> This tries to comply with kernel doc format.
> >>
> >> If you prefix a '*' in kenrel doc, ./scripts/kernel-doc would report a
> >> warning.
> >
> >Thanks. I wanted those so that it was overly obvious when they were
> >used wrong but I guess they have to go.
> >
>
> Not fully get your point.
>
> You are fine to keep this change, or prefer me to drop it in next version?
I am fine with the changes. Apologies for not being clear.
Thanks,
Liam
prev parent reply other threads:[~2024-08-30 14:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 2:56 Wei Yang
2024-08-30 4:12 ` Liam R. Howlett
2024-08-30 4:15 ` Liam R. Howlett
2024-08-30 8:47 ` Wei Yang
2024-08-30 13:30 ` Liam R. Howlett
2024-08-30 14:36 ` Wei Yang
2024-08-30 14:39 ` Liam R. Howlett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m4igwwrho3ccgoinjemdjtvgjq2n2qitgvvzpdftwjbmtnwszh@5itregml5ptr \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox