From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: 2.5.64-mm1 References: <20030305230712.5a0ec2d4.akpm@digeo.com> From: Alex Tomas Date: 06 Mar 2003 13:00:30 +0300 In-Reply-To: <20030305230712.5a0ec2d4.akpm@digeo.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-linux-mm@kvack.org Return-Path: To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: As far as I understand this isn't error path. lock_kernel(); sb = inode->i_sb; if (is_dx(inode)) { err = ext3_dx_readdir(filp, dirent, filldir); if (err != ERR_BAD_DX_DIR) return err; /* * We don't set the inode dirty flag since it's not * critical that it get flushed back to the disk. */ EXT3_I(filp->f_dentry->d_inode)->i_flags &= ~EXT3_INDEX_FL; } So, if ext3_dx_readdir() returns 0 (OK path), then ext3_readdir() finish w/o unlock_kernel(). The remain part of ext3_readdir() gets used if ext3_dx_readdir() can't use HTree and returns ERR_BAD_DX_DIR. Am I miss something? >>>>> Andrew Morton (AM) writes: AM> +htree-lock_kernel-fix.patch AM> Missing unlock_kernel() on htree error path -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org