From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25208D0C606 for ; Fri, 25 Oct 2024 12:54:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B21B6B0085; Fri, 25 Oct 2024 08:54:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 961E76B0088; Fri, 25 Oct 2024 08:54:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 829826B008A; Fri, 25 Oct 2024 08:54:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 674836B0085 for ; Fri, 25 Oct 2024 08:54:20 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1D2FD1A09DD for ; Fri, 25 Oct 2024 12:53:43 +0000 (UTC) X-FDA: 82712117586.29.3333D0D Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by imf18.hostedemail.com (Postfix) with ESMTP id 97A031C0012 for ; Fri, 25 Oct 2024 12:54:07 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ir6AYKwy; spf=pass (imf18.hostedemail.com: domain of thehajime@gmail.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=thehajime@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729860803; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5E+5IGmjD5RYhRDoYf+p51x7iks9smyytpRiSxJ79eU=; b=GbCXvfC8FxGOMyUxTHc2gzpSWl92HllRrfmxtNMOYWroIqsgc5OYKQPYyYGHTh8nAC1eN8 mqGPZD60xMffkeyjlzGNtoGScPQER1zR9LtHMMhfNBkhKwHN2wbfAIE9E1u+MkIfLwuclj hsr24i9qc6ox/tDJ91GTKITuaOoCeno= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ir6AYKwy; spf=pass (imf18.hostedemail.com: domain of thehajime@gmail.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=thehajime@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729860803; a=rsa-sha256; cv=none; b=vpPR0m3wq6iM99WtKx6Njkvptos+6JLZJjGgUK0oo8hOQh9BYJrM4CZlkOoOaLHxRHajUx +Xe7Q+Oj0kfVVOjCZS76qIDEiS+gtMB6sqC8CFdlNaggnDG083HWSz+6Gw7HqXIIoOSFgU El7dS+h77kdvy91HxtTSjpSq2xyolOQ= Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-656d8b346d2so1292567a12.2 for ; Fri, 25 Oct 2024 05:54:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729860855; x=1730465655; darn=kvack.org; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:from:to:cc:subject:date:message-id:reply-to; bh=5E+5IGmjD5RYhRDoYf+p51x7iks9smyytpRiSxJ79eU=; b=ir6AYKwyoQctYfprWBGTM2QuZCd3RDRjIuPsRrRRESKmhi+j1TyUU6w0AsZAdU/z8C gOnAeYQF2zFFGXdPL8sk7tmIQ+zyf7fBG0VXK0+JD0E+prQSgmZaWOP/6/Jp/nbK1CQ3 igeZ6UuhRL/EqjDGT49buhzXM5C9uyjU5HNZVbV+5qHKNh0KIZ004S4a3CQ9jmxUQK6j c6n2D/bAMcD8QD2p7AxuKzXFEzQn7+S2JEJeerxL507KZIVAhaH0epELJNqtqaRNXEQf 34F0OvWGmllzgmILlFKOMS+dleUZzJp0cP53fh22yB05uzpRcv4b+zJX+P3YOenqHepo D3Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729860855; x=1730465655; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5E+5IGmjD5RYhRDoYf+p51x7iks9smyytpRiSxJ79eU=; b=WnbyHLhn6CS0+jqIpxafc04dyJEkl/wpVKDdTAaiEFxn75oncReANCS0InIMRGp5oc qVIU4U57CoaNksWGr3XXlwqVqlyocGLikyQyIGB3jehymfsBcvIZ1gvs49cW/MS7obBI 8ZjWXainiG/Ko3pkJEnVKGl5sIcOgUia28QlTTzVrMDgOudPGx7y+05/H/i+moAWQuxE HhcotLGbJx+s9nrgHH8VtMqkvTu8PjyuIRUnh7+05BLuCvHzoeOp0aCYB99r1b+lDRSz qOVUYm6h/tMzGKrZGN3L+bnD/DKvKmlFFtuBqBlfVrDoOAkegDDJpCNWUOZhdesXZEDp EXww== X-Forwarded-Encrypted: i=1; AJvYcCVpfEDlhbgTyyg2HS1kXXgQi9RFizLVGvNxR9ZftHkAv6PF2zuCQgC6VPR4UgOGXUjQhwvv3atVww==@kvack.org X-Gm-Message-State: AOJu0Yysvg2wR9VoNREmSpz9q7dvepRk3nYjkPs3yELH8+093cSnA5QW i/yauC8GLcE1CxfNQETol+1X+9oGk7R7VU8oj3s+76tMnY8/kvf/ X-Google-Smtp-Source: AGHT+IEJsV32RYzl+idFh+LcUZ24o+g7OnwiMcuwcZxoiEpCuqxm4D5Rp6MG7Ye+xrL21cJwGYJ3oQ== X-Received: by 2002:a05:6a20:d808:b0:1d4:fc66:30e8 with SMTP id adf61e73a8af0-1d978aeaee5mr11694975637.10.1729860854632; Fri, 25 Oct 2024 05:54:14 -0700 (PDT) Received: from mars.local.gmail.com (221x241x217x81.ap221.ftth.ucom.ne.jp. [221.241.217.81]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72057a0d025sm991964b3a.101.2024.10.25.05.54.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2024 05:54:13 -0700 (PDT) Date: Fri, 25 Oct 2024 21:54:09 +0900 Message-ID: From: Hajime Tazaki To: johannes@sipsolutions.net Cc: linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, ricarkol@google.com, ebiederm@xmission.com, kees@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [RFC PATCH 02/13] x86/um: nommu: elf loader for fdpic In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/26.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Stat-Signature: 391uy5nbpr9odskxtz9yzn3yu6cd4rz4 X-Rspamd-Queue-Id: 97A031C0012 X-Rspamd-Server: rspam11 X-HE-Tag: 1729860847-807958 X-HE-Meta: U2FsdGVkX1+Xb/g/Fm3C0LpAMH4CpqydDDXpz5pgJ8oPtAowhEwih1Wn8dmBBvGBupQBr8mIF1InQ15VMIXMtUmgnavTh9u7u9g5jAd7zMRhf15wopr7+6vRsOM+7RG/Cwum7Yg+xbaoea1v35UVhuqpxwDMQIbHss1HcYqSqkvzswx0YLDXbxy87Ko+jiCV4mqEjcYtCldZ0EjiKXbBCW/tfsWrfxL2ThY+NKjAUZYJZI9drnaqhVO7RdESCvWzQTgjAA0zrffywjyhhnr3cyfy0JvWxQ331mKEW7+IKcQtFKdqgZPfuTOV2QXOL+Sx+cnOkb+6SUwGSG3+BejmVV9yNgyFi3Kxmn+EbgDI/TQg55wwrFf3LO/5sF5XZKUKMKSymRR2xYPzy+D9T/eqG+3ES4udFwfsv5+Usk/PgZEqiT3nJgpq3E0LOAB3PB4bw8Sc5BShgXfqQNAKHwYCDtW54EU/OrWEfH2wBiVz4OSK3+RQSKuNugH3dVpeRgYD+Pmx3l1d7VBQ6zZMCboXFSGNW2fD9cELGrqUNpWUmubDytMGNoJIOOSjuBOqECK7aTts9EoCzADKApMs+AtFgBbUilBwLlTNn+pkk1OSdscXWdhkbmnxgUdChD5BQiYoITpyZy+u/fo6ZH50CyzXkLSHQHLG2HfexYoRFpXMD4Cx/WeSlTM5vUvrHWEIYU/8Qi1R63KKHcwpwLwQhHQcKOzvZ6I81vZ+f364QJ7B1ZkFzcMmGsmQhyJ4G0dmKz3ZJXWSm4ToFNca0PojiqqrxGHyCDxU6wgw1uOyhZTAsEO5x35Eo9IoKTULqVZICnL1xo7JZSB0Vs8lJI5hWRvphgDBd4CKIlBpbAzFT3jGdn+wcdITASXM+43GLs9GGfZm+PEuaUlbycJz9ZaKnB66Qmvfdo6HwSOsnLQTKTM+hNx3UC1H2p2IuB10gjOQVPaBcfWNGRkYnFZCAv8faqN P5lYa3I6 jiMqKCDwFuv62EWf61ige0ftRMHHSpBnfy0QaHoBFGaAFKjZXOFqPvwz0FYb+PHqxYSXBw11wNaBjPuIkFW1OgSi+12qEGcO2bcGdxXGh92d0b+Vq9js57+hlqyndcrSEEK2clA/PpbcWeA4wvx529Vc1gFAP4jPKy5Y8DrFLjtiZfXEalqTHKIcrzNBHmy3iylXUHX8FLrbuDeFahD6j3Ix/hbQkQ3QKFGS6YqVUq9M1XIrjg2kDDClRbogrm5LA2pcJoLlB1b6XBKfD7yJCu0s+wcq+YoFUyQNVOmmQ28Th9TTeuNlGc6Rq3w1gCHnchDAEsFL6hqPG7BDfNvpMWyhQAjQk/XIuKLUmYKfpZvLXL1U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello Johannes, On Fri, 25 Oct 2024 17:56:51 +0900, Johannes Berg wrote: > > On Thu, 2024-10-24 at 21:09 +0900, Hajime Tazaki wrote: > > > > +#ifndef CONFIG_MMU > > +#include > > Not sure that makes so much sense in the middle of the file, no harm > always having it? agree. > > +static inline const struct user_regset_view *task_user_regset_view( > > + struct task_struct *task) > > What happened to indentation here ;-) > > static inline const ..... * > task_user_regset_view(....) > > would be far easier to read. fine, will fix it in the next revision. > > +++ b/arch/x86/um/asm/module.h > > @@ -2,23 +2,6 @@ > > #ifndef __UM_MODULE_H > > #define __UM_MODULE_H > > > > -/* UML is simple */ > > -struct mod_arch_specific > > -{ > > -}; > > - > > -#ifdef CONFIG_X86_32 > > - > > -#define Elf_Shdr Elf32_Shdr > > -#define Elf_Sym Elf32_Sym > > -#define Elf_Ehdr Elf32_Ehdr > > - > > -#else > > - > > -#define Elf_Shdr Elf64_Shdr > > -#define Elf_Sym Elf64_Sym > > -#define Elf_Ehdr Elf64_Ehdr > > - > > -#endif > > +#include > > > > #endif > > That seems like a worthwhile cleanup on its own, but you should be able > to just remove the file entirely? agree. will add module.h to arch/um/include/asm/Kbuild. -- Hajime