From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8BB9D12D66 for ; Wed, 13 Nov 2024 13:17:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 568E66B00BF; Wed, 13 Nov 2024 08:17:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F0936B00C1; Wed, 13 Nov 2024 08:17:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36A386B00C2; Wed, 13 Nov 2024 08:17:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 138C06B00BF for ; Wed, 13 Nov 2024 08:17:58 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 91025AC3D5 for ; Wed, 13 Nov 2024 13:17:57 +0000 (UTC) X-FDA: 82781123292.30.DFAA5EA Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf21.hostedemail.com (Postfix) with ESMTP id 117441C0010 for ; Wed, 13 Nov 2024 13:16:33 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mJBqlJLu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of thehajime@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=thehajime@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731503745; a=rsa-sha256; cv=none; b=4cogueAtGEAJIDeofKK19g3II98qFcuzDudD/KPA1zrQNfxyD9NE2rqaCwvCFNJ33yzdRl qlFqTFhF3rpqOx03BPYj/oDGpDQ01Gprcj3iKc2OSsSyHUO871CJXBKrp2U9pekI6vqawD 50CU1/6GCkeih2yWm5aFh0yG7vWznNI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mJBqlJLu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of thehajime@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=thehajime@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731503745; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GASOn7QbrM9ZEmoRoXiZ13AI8Ncr2uZ/48itT1ixPSo=; b=XWXUrv1c/G8ShchuRLdhVEMKI2HD4FE853BwtZrdtajDguKh7iUUsAy3OnwMe0A3iXgrjP JM+4wadDxKWpbiHOVc4b1s0LO19T52CAOm49o3Jvfq6EOqafnjlaCgcPRxSRvoCAcoVQac tNleKs8DH1O0SindVOCVM5ORdmL8Qjo= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-20c8b557f91so73002435ad.2 for ; Wed, 13 Nov 2024 05:17:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731503874; x=1732108674; darn=kvack.org; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:subject:cc:to:from:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=GASOn7QbrM9ZEmoRoXiZ13AI8Ncr2uZ/48itT1ixPSo=; b=mJBqlJLumzq3a7X5n/V11BmxAengpieeBj9f4FAtD2qpUjt0kB2aXsZOxggYJ5lmfu KEP4eevGy1pahzPuPPR2AHGKYfnUWbL0VHIIcGaP5juWndKi9AnRjY5zXJpnNZ2yzaYz L9bFKQkckr5jE/f/Ze5BAzBoe7E2oAwI5QMCrn+VcRM4wIOmblxAXNtXmjMYDuKrq8xY Y0uGRoRMeUNChI6QaxM6ouwG3QkIpFJE4earM3XvbIMVYOrKN9oZLZSlwavO6d+xC+xm yDPOJ5QKmYZt8doTjX5TVQbu2Vmj7x6jv+mtn2N6++2CkOh3tLT2YhL4wJ/M/XzIXqd1 AUhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731503874; x=1732108674; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:subject:cc:to:from:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=GASOn7QbrM9ZEmoRoXiZ13AI8Ncr2uZ/48itT1ixPSo=; b=N5JmufvBqo3keMHuP7Fzqx9L/2Gzuww2bb8jU/96zPJWKKon+5E/v9p9EAzinGzpxw zvMAaa0OHT8jAIcM7rNECRE6NTMH0m5T4jBzUDLHRWr3MS7jBhOZzwo04kdetfeZglCF PYUzLY01tn8LeLe/s/LEfN8Y9reO4onDQaOnwkT0PvCZgLP0uT78eBUbzkR+TcokY5HL 6zr04QrGm3WPPe/bH84UB2ZKEwLZVdDGMAtpzttAsEfzQWByz8GpzlSidiHYoDAZzRhe Q74b88UUsQFvCgoZIbOQCZpZTbbn+gEWBA1XpAWgQaPUk6jOeJIEP6JAeMfdMOM/28QS LeEA== X-Forwarded-Encrypted: i=1; AJvYcCXv6QgmKasnszc/vrjzuI/O/9W/Rw3UZqy3N0L+NfF7q/vVqKJzF7eFhuxm0EQ8WLvG3WIpHaceYQ==@kvack.org X-Gm-Message-State: AOJu0YwikJDPlltzPvCRTLvl3ZS3GwkhnLkclm6YzlCZw3O+29IpobcG BAgJCCzVGXvq2P1pRsqb+OKiFO/K0spbR14ZbTBvu8H1UvRVMmSD X-Google-Smtp-Source: AGHT+IFkQjy5RcuzRtl+x2005T/fhBQQsWhUH09XQKI+0v0sV3eMr4pYS4nOBNx708rEayi0aGK5hA== X-Received: by 2002:a17:902:e5c6:b0:20b:57f0:b38b with SMTP id d9443c01a7336-21183c97540mr294341675ad.19.1731503873799; Wed, 13 Nov 2024 05:17:53 -0800 (PST) Received: from mars.local.gmail.com (221x241x217x81.ap221.ftth.ucom.ne.jp. [221.241.217.81]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21177e5d7a6sm109808345ad.215.2024.11.13.05.17.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2024 05:17:52 -0800 (PST) Date: Wed, 13 Nov 2024 22:17:49 +0900 Message-ID: From: Hajime Tazaki To: geert@linux-m68k.org Cc: johannes@sipsolutions.net, linux-um@lists.infradead.org, ricarkol@google.com, Liam.Howlett@oracle.com, ebiederm@xmission.com, kees@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [RFC PATCH v2 02/13] x86/um: nommu: elf loader for fdpic In-Reply-To: References: <8bbfe73f7f1ef9f1a4674d963d1c4e8181f33341.camel@sipsolutions.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/26.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 117441C0010 X-Stat-Signature: ngdtzjcxmfx4pasnbyqn4ao5n5cobjrn X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1731503793-703782 X-HE-Meta: U2FsdGVkX1+atrZT0CuSAnBHf4WnQBN6e0a/WLI895yc5jBNMpge0uhyKXYIxVDbFfcxASADvCWCTwIa2OsP9E5V7IQXl6Usbhrm2g5Y1516JUNAtTzaLRuX+m2FScXH3qh6j7AeZh2P5nKykAWRU2MIJaDIdVGgwZb07WCwPu+zibr88zbY9dtquH5fJFqXLpUuvWqwkVG+S9Wvlw5HaS3Ap6phxmmfIm/w/7BHEBJpl28h/5ZHc8MQqlmusDrK6zb4Gahlo4FoJroXk5lQRwm3nNF6+bMQRqEAFBk5tJTXeVuPJavcJN7A9YEEaUZyZpdHsZat9pOA/C33UDxS03YECdCNT8tKQqRc5/1DeoEIP6TI6TRK/fKj90w6puIXUHSf67JdPwBI/0CeZac5qdoWgfFdommJroBQNh/mp0UznNWis8K9pkHXWCvI4zzSD0lL5WFxY+zC9ZeSbd/YUEqpPSyjIotyNr9Wrzm7EfLCWUe/PROpYyqz3fBg2+++hc5OUKwNM4OitD2C5WhIqPF1zkfDLc3a2ph3oAP7s446fo+sYR3/kLj44oP6C72gh25qzL/jK/k1GlcKw8GOPdF+kGViVWLqwC4jxL1RMVenfbCU6vm+206Kkzk+a4rwfFdwt8oBA3TmLJkkzruQRBqM9cITZcr1X3zIDk6uaPv1gCYLn1IGh1zTvltZgMKHs9pDXb8SsglTLBmLa4kfJYYUsryqKU9fJ1OhrmG7KztDCBU5qmjBxDQLqNbxrfi3XOxEjkC/t0IOWOQbrS2e0n/S/qzS4UzQ1k33lPolp9XDTVQ4QOl5IFWuKRgcB6rS97twnrJAyx7HyLD0NU5Gz0CRjimq0clHA5/280QdP8QdLN3on/dWoPucFk+wVYgFKFhdu4JEONL5IUGE5mXVfbLv1NpfQnWgWOzyZyxtcLeYHEIG46kRa8DkWRODO35LK3fLjTi7T16WRkLsWqy gwqXdPbv iSRL80NJ5lkU5pcNcgfUkQuUX14/BNC6+2sDmEHJL901Q4TzlOQZuOqCyLCW3eGAPmQxZEvChTKKQuGHlJGR9zf5Oy1gk8G8jDchTBgiMxhCzmchC/w1qrg+VsYWsBO0J+UZ+/fHheo2YdfEfSBMx78Lt2gRx8xwYT0ffK3pouAiMfehMLpBbGJSMrhkJn1kDv4OhFg2zBCHU9XGiiK6Cjhc7qRKxy2XP6yp7pvWXWnxRuX+3G2GUC3ab5V+2lPuqhd2Jv/YxhHa8NiLhvP7yoZgug6702HwpRmTGruyRgX6le+0biRBhCVU/YJ3zjbULqXTuoN4apVW7gg+NbhApWV6fJcRqPx7yJlM7Bf+sy7vRr8Bk/1FD+I66LXb9NI8OIM4Q06dz+o5D+Lpex1UguBLLeWhJvShwmA0vYFTrVMkDEFY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, thanks for the inputs Geert, Johannes, On Wed, 13 Nov 2024 19:27:08 +0900, Geert Uytterhoeven wrote: >=20 > Hi Johannes, >=20 > On Wed, Nov 13, 2024 at 9:37=E2=80=AFAM Johannes Berg wrote: > > On Wed, 2024-11-13 at 09:36 +0100, Johannes Berg wrote: > > > On Wed, 2024-11-13 at 09:19 +0100, Geert Uytterhoeven wrote: > > > > > > > > > > > - depends on ARM || ((M68K || RISCV || SUPERH || XTENSA= ) && !MMU) > > > > > > > + depends on ARM || ((M68K || RISCV || SUPERH || UML ||= XTENSA) && !MMU) > > > > > > > > > > > > s/UML/X86/? > > > > > > > > > > I guess the fdpic loader can be used to X86, but this patchset on= ly > > > > > adds UML to be able to select it. I intended to add UML into nom= mu > > > > > family. > > > > > > > > While currently x86-nommu is supported for UML only, this is really > > > > x86-specific. I still hope UML will get support for other architect= ures > > > > one day, at which point a dependency on UML here will become wrong.= .. > > > > > > > > > > X86 isn't set for UML, X64_32 and X64_64 are though. > > > > > > Given that the no-MMU UM support even is 64-bit only, that probably > > > should then really be (UML && X86_64). > > > > > > But it already has !MMU, so can't be selected otherwise, and it seems > > > that non-X86 UML > > > > ... would require far more changes in all kinds of places, so not sure > > I'd be too concerned about it here. >=20 > OK, up to you... Indeed, this particular patch [02/13] intends to support the fdpic loader under the condition 1) x86_64 ELF binaries (w/ PIE), 2) on UML, 3) and with) !MMU configured. Given that situation, the strict check should be like: depends on ARM || ((M68K || RISCV || SUPERH || (UML && X86_64) || XTENSA= ) && !MMU) (as Johannes mentioned). on the other hand, the fdpic loader works (afaik) on MMU environment so, depends on ARM || (UML && X86_64) || ((M68K || RISCV || SUPERH || XTENSA= ) && !MMU) should also works, but this might be too broad for this patchset (and not sure if this makes a new use case). anyway, thank you for the comment. # I really wanted to have comments from nommu folks. -- Hajime