From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 691F1E77180 for ; Fri, 13 Dec 2024 22:21:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E420D6B007B; Fri, 13 Dec 2024 17:21:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DF24B6B0092; Fri, 13 Dec 2024 17:21:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C93276B0093; Fri, 13 Dec 2024 17:21:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A4F056B007B for ; Fri, 13 Dec 2024 17:21:44 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0823E811D3 for ; Fri, 13 Dec 2024 22:21:44 +0000 (UTC) X-FDA: 82891358172.12.CC5D91B Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by imf12.hostedemail.com (Postfix) with ESMTP id B1E464000C for ; Fri, 13 Dec 2024 22:21:30 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gnM35x6S; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of thehajime@gmail.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=thehajime@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734128489; a=rsa-sha256; cv=none; b=OqAis4XwFJX9rp06KgxpOP77zxPPyhttzxF9tvYdRV6yI5JH/XO75KwhbsAJ49+H93CkCw YqKQihMNmQ3i1uUoe2F6EZHnIceTRPtY8ezMmygmGpBntVgCcpgHNoqZbe09PvhbjUAupT I0UUJKj0V0VC99Lu86Igvvcc12Ecf7s= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gnM35x6S; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of thehajime@gmail.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=thehajime@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734128489; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wqLYNgaFsfhCdC6ZHF4qPWqLcHB1iEwLOJKG4uK8Pj0=; b=cegBLUL6j/JI0ouJKcDy93KXnQS4reCtuCGKiiF0dyXDQue6ObkobrqNoyeGR+EyEzEECY evzo67T8c3sTTQxc3iRZgsCnTbJON5CUjdajxtwEUqrXz/xzvIHx5+PgZS9GgwsqklVSQO iOauLkM9H1d3W6oQ2z9rgJ/K1v0Xqec= Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-7ee11ff7210so1646078a12.1 for ; Fri, 13 Dec 2024 14:21:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734128501; x=1734733301; darn=kvack.org; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:from:to:cc:subject:date:message-id:reply-to; bh=wqLYNgaFsfhCdC6ZHF4qPWqLcHB1iEwLOJKG4uK8Pj0=; b=gnM35x6SNdY8yVd5ndrCn2VOLbLs97POe/DaNMc1FC6pSdO2nGJ3/pf83JmHqU4f+v cQFb3LP387bjy80STZ2PCtyhE9KrlN0lMCZ8ugsucoEjfh+IsxgRp0CrmYk2aPXTeM73 0sCFceIfwO6xR1RChOX9ztgfqpaNuA0Xetr77COT5ObmQbSNwhdIk4Tip0dKXP+uL+P8 LN1K0XpIbWTa5MfYnLI1lacPKUogXbFYuatRv6FgjlQsdFjJTpBrClNC6IJbKpat116a QwFwwuQ93PceBwWinsK07WifGUt/xqEs6C9YVBRfa1UkhiFs1u3lYoRp0wWJxygk9ZW/ QHsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734128501; x=1734733301; h=mime-version:user-agent:references:in-reply-to:subject:cc:to:from :message-id:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wqLYNgaFsfhCdC6ZHF4qPWqLcHB1iEwLOJKG4uK8Pj0=; b=AsX2pQmU2ujknIHZR3uTkNgxvE456LV1vGRYeB8OiKAIzFW4di6ljCQPwSbLsA0dGO zzRGP2rVqjKYDSiV8dQqeoxCD6hjxAEXvW/3myY+OaUItr2Ox6R2rLOH7DsoKFT7ecM9 x6LiDWrWSsYWNrbhld9ePYcP10lTFsdu6rpAni0DbqPM1km5Ra4gW9yE/u8Z0GVGPkkc eyoS3tAm+ZTdMJXQ3Q8qY73Sia00UoEvDWuLcMPu+o17ODfCuJauYfi7v9dAyxo3Jfur BH79lq3RSQa4Jly/k+jkCQzexedeI62KUcFNQniMvQLW5TrpCvTmhO+nXfWPa0cLXC/9 fbSw== X-Forwarded-Encrypted: i=1; AJvYcCWaPZ/Q6nKcsl3TQGk9A4HHD5R67B3tTfEzguzpgkQch0368LutlKozlhp95zKzDrotAzV7nwg86Q==@kvack.org X-Gm-Message-State: AOJu0YywTGpW3Ng5+L3NbLyddCRx3tmph9KjrERj6e1Icf5RC529oARY M78wc5iVqTxCS/dgUDCRdWhrt/USBDI3XbqAC2HBtVXCHNl9pSs6 X-Gm-Gg: ASbGnct3oWeVwyiEwEhSr/o2WaithqMxo79vrPZdPY247zBdmrAFjg6w8ZoLSDa0+LU daQG9GbaqR9a2T4N8W8EGVqeIfRVz9e/HHcS6OvuQhdF1si5ECdN13jCQYrcThF58/VIco7QoFy 2fGPEGpP62WCx74pDRdOdl2uq+Qh60KMBw7IPqHIKgmyTehJYclOX5m7pOMxlfsnvEPWt4SNapu MoMMxawZiF/doi9Vzj9ruCMqZoLLhUVzE8Pf18fuf/FQz2DhjDvqZWqo9vKOukrcLTyWn1Me6FK PstLVZRGL5mO1EzD2k0fI0F3fkK9EHi0V6SdVCMmWqM= X-Google-Smtp-Source: AGHT+IFhh015tdWX9bBaiS6A5cK5GzjNQ0bQgLvyZteLyIrbh989ImvXOXFjQPgnbCFgKEhMRO+e0w== X-Received: by 2002:a17:90b:3891:b0:2ee:8ea0:6b9c with SMTP id 98e67ed59e1d1-2f28fc67526mr8230463a91.12.1734128500702; Fri, 13 Dec 2024 14:21:40 -0800 (PST) Received: from mars.local.gmail.com (221x241x217x81.ap221.ftth.ucom.ne.jp. [221.241.217.81]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f2a2449c45sm265640a91.46.2024.12.13.14.21.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Dec 2024 14:21:39 -0800 (PST) Date: Sat, 14 Dec 2024 07:21:35 +0900 Message-ID: From: Hajime Tazaki To: ebiederm@xmission.com Cc: linux-um@lists.infradead.org, ricarkol@google.com, Liam.Howlett@oracle.com, kees@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v5 02/13] x86/um: nommu: elf loader for fdpic In-Reply-To: <87r06bz1uf.fsf@email.froward.int.ebiederm.org> References: <87r06d0ymg.fsf@email.froward.int.ebiederm.org> <87bjxf1he1.fsf@email.froward.int.ebiederm.org> <87r06bz1uf.fsf@email.froward.int.ebiederm.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/26.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B1E464000C X-Stat-Signature: y99ww8oeu4kiuf4i1axzfyt11xajtqb6 X-HE-Tag: 1734128490-814812 X-HE-Meta: U2FsdGVkX1/BzyjEUfjXzAPqCLbBz0saUwrwXtV7lgYY1F9WdnRaaKBw9ktf9Vyt/olZkzjd6hFMzgYgLvqp5b+rGyzS4vzvkm/m06JRz/iydp6+wj94Cs3RKt/YuVnJaz1KNzGR5gqfqaHuq74Ig9WVF0q8UZn0KN6+xFwQuq/FKxzuv0QqEOKPZNomyq88ezeyQ8LDaDshRowVVIfUfg3cqdNg7aXSC8NOYnHj/NlXBGkaTQhCc+fkRg0Zx9sGL5662wIUrwNK1TmYlPyYaTdyJdlqTPF9ZjyQPC5wqQX6zftELbJBPFxsrzMv0ZyAqQVx5ABIIYz7WqYjkSeIm4Kj0mYY/pM37lNW+CEX5EhaUR31LP0D20inj6iD0URBofjqBxCmCeljOqbtmd8tQoBpbdYrQ6lAB3HCNdzRtwkqywJFmmp4EJX8gHFZq6CiQOWk9ThznYrVEqIDPDkX2O+L3L9EeAD7u5ojqgQ8RiAcLjPKFt8nJtuCytB9ForPBwNYZ9M8nRK6ot46fQuDtv40/b3tz3F1PHrkWVV1946UIvjEg7Hm9W8gYiymBAqkWDRTqV2xXlY7+EVKynr1cxp/6jjIIGc2LxHSo7AYUJUdfwXC8x3x38bF9vqTzT3xM4kKGRl5mLtHYKuM5+oo/+7n73meJrZU9YZbGkADx0TC6/OyVJUy3upbTkocQ1gAQvr5TC7zz88zkjhCxN9pWOcmhPGyZ1z223h58YTwFqI3TefC/lg9BUI3ebkJLJcD/y9+p8EVgmZeirfIDJjErR5EJ7K8x4A4CnmdpxBlysWYFOHDkZ/E9WiEKnTF5SgQPw1UVM+BhjST6+80uK/9VAziuoeolV+WRqvgBrt1rDXY4fzbxj9MxDUHn9+uOjrJ1izUfWqHj4O6GqP/2Kej7iHpUSLmMpQbsCGEB3Vn+MUYSQeqZrq3SnKveIji3oXwdTxfY2DTvghfRzH0z/5 USdtX2QO 3OGcKOf5YT4M2KJy7UyAkRZU7+RAiqEaVu4oY7bSgeTH83sJC+jHRwxMiUxUSHq7+c8YfcXAXcvr0f/zL7Ew2Q8ep1FvoT+XHysHCwiGKoKrnocBBlegI7pHZIaIXlHqIJLOczxMdCLBwgqkC22OcAqI2sbQrvE4rrOOQk7LkWxAqrwc8lkSJIo3hBZf129Vsu4NNDrlfJ66npiIyo177Wc42m04zvdqPGCSF0OZJt7hgER/c+OFYE15BCvtDsf2Zxu87Yjv6B4S10cMJ2uUnqIwgP0y0mB/MlvA6+PcpIIvUTtK878O5Q8GDm7VRUKaEtMm/ X-Bogosity: Unsure, tests=bogofilter, spamicity=0.475454, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 14 Dec 2024 06:53:44 +0900, Eric W. Biederman wrote: > > config BINFMT_ELF > > bool "Kernel support for ELF binaries" > > - depends on MMU > > select ELFCORE > > default y > > help > > @@ -58,7 +57,7 @@ config ARCH_USE_GNU_PROPERTY > > config BINFMT_ELF_FDPIC > > bool "Kernel support for FDPIC ELF binaries" > > default y if !BINFMT_ELF > > - depends on ARM || ((M68K || RISCV || SUPERH || UML || XTENSA) && !MMU) > > + depends on ARM || ((M68K || RISCV || SUPERH || XTENSA) && !MMU) > > select ELFCORE > > help > > ELF FDPIC binaries are based on ELF, but allow the individual load > > You have my apologies I was most definitely confused. BINFMT_ELF > currently does not work without an MMU. no problem. > >> I just react a little strongly to the assertion that elf_fdpic is > >> the only path when I don't see why that should be. > >> > >> Especially for an architecture like user-mode-linux where I would expect > >> it to run the existing binaries for a port. > > > > I understand your concern, and will try to work on improving this > > situation a bit. > > > > Another naive question: are there any past attempts to do the similar > > thing (binfmt_elf without MMU) ? > > At this point what I would recommend is: > > Merge your original patch. Get nommu UML working with binfmt_elf_fdpic.c. > I think it is a proper superset of ELF functionality. > > Then I would make it a long term goal to see about removing redundancy > between binfmt_elf.c and binfmt_elf_fdpic.c with a view to merging them > in the long term. > > There is a lot of mostly duplicate code between the two and > binfmt_elf_fdpic.c does not get half the attention and use binfmt_elf.c > gets. thanks for the recommendation. I'll go for this direction. It would be great if nommu arch (at least) UML can use the regular binfmt_elf. -- Hajime