From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx203.postini.com [74.125.245.203]) by kanga.kvack.org (Postfix) with SMTP id C9CB56B0044 for ; Fri, 10 Aug 2012 19:08:11 -0400 (EDT) From: Andi Kleen Subject: Re: [PATCH 1/3] HWPOISON: fix action_result() to print out dirty/clean References: <1344634913-13681-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1344634913-13681-2-git-send-email-n-horiguchi@ah.jp.nec.com> Date: Fri, 10 Aug 2012 16:08:10 -0700 In-Reply-To: <1344634913-13681-2-git-send-email-n-horiguchi@ah.jp.nec.com> (Naoya Horiguchi's message of "Fri, 10 Aug 2012 17:41:51 -0400") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-linux-mm@kvack.org List-ID: To: Naoya Horiguchi Cc: Andi Kleen , Wu Fengguang , Andrew Morton , Tony Luck , Rik van Riel , Jun'ichi Nomura , Naoya Horiguchi , linux-mm@kvack.org, linux-kernel@vger.kernel.org Naoya Horiguchi writes: > action_result() fails to print out "dirty" even if an error occurred on a > dirty pagecache, because when we check PageDirty in action_result() it was > cleared after page isolation even if it's dirty before error handling. This > can break some applications that monitor this message, so should be fixed. > > There are several callers of action_result() except page_action(), but > either of them are not for LRU pages but for free pages or kernel pages, > so we don't have to consider dirty or not for them. Looks good Reviewed-by: Andi Kleen -Andi -- ak@linux.intel.com -- Speaking for myself only -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org