From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: 2.4.14 + Bug in swap_out. References: From: ebiederm@xmission.com (Eric W. Biederman) Date: 21 Nov 2001 06:31:51 -0700 In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-linux-mm@kvack.org Return-Path: To: Rik van Riel Cc: "David S. Miller" , linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: Rik van Riel writes: > On 20 Nov 2001, Eric W. Biederman wrote: > > "David S. Miller" writes: > > > > > I do not agree with your analysis. > > > > Neither do I now but not for your reasons :) > > > > I looked again we are o.k. but just barely. mmput explicitly checks > > to see if it is freeing the swap_mm, and fixes if we are. It is a > > nasty interplay with the swap_mm global, but the code is correct. > > To be honest I don't see the reason for this subtle > playing with swap_mm in mmput(), since the refcounting > should mean we're safe. We only hold a ref count for the duration of swap_out_mm. Not for the duration of the value in swap_mm. Eric -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/