linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Andy Whitcroft <apw@shadowen.org>
Cc: Andrew Morton <akpm@digeo.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: 2.5.69-mm7
Date: 20 May 2003 14:01:56 -0600	[thread overview]
Message-ID: <m1fzn91j63.fsf@frodo.biederman.org> (raw)
In-Reply-To: <535806509.1053435150@IBM-O1F8DZ9MWMH>

Andy Whitcroft <apw@shadowen.org> writes:

> Seems that -mm7, has broken compilation of subarch visws:
> 
> arch/i386/kernel/built-in.o: In function `cpu_stop_apics':
> arch/i386/kernel/built-in.o(.text+0xe511): undefined reference to
> `stop_this_cpu'
> 
> arch/i386/kernel/built-in.o: In function `stop_apics':
> arch/i386/kernel/built-in.o(.text+0xe552): undefined reference to `reboot_cpu'
> arch/i386/mach-visws/built-in.o: In function `machine_restart':
> arch/i386/mach-visws/built-in.o(.text+0x1): undefined reference to
> `smp_send_stop'
> 
> Seems that the culprit is the reboot on boot processor changes, reverting the
> following patches fixes the compilation:
> 
> 	patch -R -p1 <kexec-revert-NORET_TYPE.patch
> 	patch -R -p1 <reboot_on_bsp.patch
> 
> Cheers.

Do you have a machine to test against.  Or is this a test for completeness?

I don't get the subarch factoring.  And as such I cannot see how to
properly fixup the subarch code.

Eric
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

  reply	other threads:[~2003-05-20 20:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-19  8:23 2.5.69-mm7 Andrew Morton
2003-05-19 10:30 ` 2.5.69-mm7 Rudmer van Dijk
2003-05-19 10:38   ` 2.5.69-mm7 William Lee Irwin III
2003-05-19 13:19     ` 2.5.69-mm7 Rudmer van Dijk
2003-05-19 10:58 ` 2.5.69-mm7 Alexander Hoogerhuis
2003-05-20 19:52 ` 2.5.69-mm7 Andy Whitcroft
2003-05-20 20:01   ` Eric W. Biederman [this message]
2003-05-21 12:13 ` 2.5.69-mm7 Ivan Kokshaysky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1fzn91j63.fsf@frodo.biederman.org \
    --to=ebiederm@xmission.com \
    --cc=akpm@digeo.com \
    --cc=apw@shadowen.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox