From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: 2.4.14 + Bug in swap_out. References: From: ebiederm@xmission.com (Eric W. Biederman) Date: 21 Nov 2001 07:21:45 -0700 In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-linux-mm@kvack.org Return-Path: To: Rik van Riel Cc: "David S. Miller" , linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: Rik van Riel writes: > On 21 Nov 2001, Eric W. Biederman wrote: > > > We only hold a ref count for the duration of swap_out_mm. > > Not for the duration of the value in swap_mm. > > In that case, why can't we just take the next mm from > init_mm and just "roll over" our mm to the back of the > list once we're done with it ? Sounds good to me. Unless we have another user for that list. > Removing magic is good ;) Definitely. Things that are locally correct are much easier to verify and trust. I'm satisfied for the moment that it isn't actually broken. But more obvious code is definitely a plus if we can get it. Eric -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/