From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FCEDC02180 for ; Thu, 16 Jan 2025 10:04:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD6BF6B007B; Thu, 16 Jan 2025 05:04:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C86F36B0082; Thu, 16 Jan 2025 05:04:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4E596B0085; Thu, 16 Jan 2025 05:04:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 973086B007B for ; Thu, 16 Jan 2025 05:04:06 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3FEF71609CE for ; Thu, 16 Jan 2025 10:04:06 +0000 (UTC) X-FDA: 83012879292.28.DBADF8D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 883604000C for ; Thu, 16 Jan 2025 10:04:04 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IAgqR2f6; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of joel.granados@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=joel.granados@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737021844; a=rsa-sha256; cv=none; b=yfGWE2B+XenEej4u++sHmXSjPbaF5vTo/I/6WoJyiUQPhCtybaNaL2v2stXfwwSbN1b/Uj Oh7BN/8kpyFpDg5vIAlyh6KnsUYnrfhRjYxUnLlDKj8aYbZeJdQZM8WdqzCqQ2cJVZIXOM 5KdxhlqcsdXNqmdK5c3fYiObc4Gp2fo= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IAgqR2f6; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of joel.granados@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=joel.granados@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737021844; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dbrf7Htcer/HdTV4hDzyVy1uPSZo+jrT3sOaf3NdpWk=; b=VHQiQtvGvmIY8MJAvaNx+As1kPd54pFK3rEFe9TYeHeadKVf+KiS8lgNLOYlAFjaxj4Sau 6yw+IgDsDd0A7x0vzxkTXNZgfaI/07uL2DcHGl0Usv0CZ3TUSCt+XjMlq46wlf/dBN3y/u BMKUOkZB/duGZO+RN3FDod6O4h3/cUE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 92DF15C5C99; Thu, 16 Jan 2025 10:03:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8394EC4CED6; Thu, 16 Jan 2025 10:04:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737021843; bh=vOWQM+I3YRBGjUYDIowHfBe+kql+W0wxpSJ3h1dp89U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IAgqR2f66QLIyDnlJbSk0pURydWNxseM1FJspSLBkNINi0tBhfM9rafMRa8Fh7jXI X/IP3yQAnuTRRWVUMeZreOqI759pDr0UfGfwD6rxNXDM8bopEelBPpsrHjqB0dq8+Z f7INV4NNHfjOuSUxgJvNmSniqiSaAOd/F4iyTma5i6Vp7kMzpIK5WuY4DJjAJYUGV5 SybOjcbKgQOt6adDDGmfohqQAh2Wurvyjc4q5ngWeI4K+I/El+T/pSa1BmM0z6vulg JaRJP2M2hymQq+cuTQPeXzoDhAFUTQvtWiPUncRVXrccXXxEnHYXgKekjrM1OSnKQS grprVO8ZExbiQ== Date: Thu, 16 Jan 2025 11:03:58 +0100 From: Joel Granados To: yukaixiong Cc: akpm@linux-foundation.org, mcgrof@kernel.org, ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, kees@kernel.org, j.granados@samsung.com, willy@infradead.org, Liam.Howlett@oracle.com, vbabka@suse.cz, lorenzo.stoakes@oracle.com, trondmy@kernel.org, anna@kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, okorniev@redhat.com, Dai.Ngo@oracle.com, tom@talpey.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, paul@paul-moore.com, jmorris@namei.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, dhowells@redhat.com, haifeng.xu@shopee.com, baolin.wang@linux.alibaba.com, shikemeng@huaweicloud.com, dchinner@redhat.com, bfoster@redhat.com, souravpanda@google.com, hannes@cmpxchg.org, rientjes@google.com, pasha.tatashin@soleen.com, david@redhat.com, ryan.roberts@arm.com, ying.huang@intel.com, yang@os.amperecomputing.com, zev@bewilderbeest.net, serge@hallyn.com, vegard.nossum@oracle.com, wangkefeng.wang@huawei.com Subject: Re: Re: [PATCH v5 -next 00/16] sysctl: move sysctls from vm_table into its own files Message-ID: References: <20250111070751.2588654-1-yukaixiong@huawei.com> <2asuqwd4rpml6ylxce7mpz2vpvlm2gpdtwpp4lwuf4mdlylig2@dxdj4a73x2sb> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 883604000C X-Stat-Signature: 37egffzk8wh8n4rnd19ijaazxijtnnpk X-Rspam-User: X-HE-Tag: 1737021844-90220 X-HE-Meta: U2FsdGVkX1/Mm393Vds2mzQei05wEh4eSemGoYHmpOg4m7TRZ6SShycjQ0leoipZiJARi7FGWWVgrPNCysV8G4amR0UKN2GeiBKY+KVhnVRFaec9ZQfyE6/eAzge8hc99xt4zIbbrWDzE73kJBA56NZft+Y4xXFy4d+nzoANA6SyjPm18A1OhWzSM5eORFWzoipP4Ws6u0lW1dF5FI5fBvvVOBeMKdeI04KnN6SeLRGP0QROOBICQG8+RYfySVsVlf0kq3HnBfhGD5erRL5kBVoc+00oFMMpd1XS1/TC5/DgONiLoCI0KZdhsdgEdQB57zzRtERXAmEDSmz4pYQx1pjVXBy+MIrjUbP9swI/mwvLh9IiiRLkDC8rve5+wjvHUG/8TIymlTeWaiTXi2NMuJtRBAF5CaP94mWua1aBEvLIvLuWAxhC5ijHEEEONY3R5ZBUof8IyF8kGkjlpa/ilCSqlEabVja01sTgp74FCALAuLQtjfYzXxgKwi6EQLkKQDCbvCRGccbFDpsw6QdLQ2SEBiNY6E0MG9GxgG39gxGoJyOOvWmPj2dZvcGhPg/rVFXM8QHwtjCBG2TUi0FinPfbzG5KGgdLmJsPmFz/vdGxKOLT3BPaJe/G5huBiOeUUc9eJ7PslQFanf7WCKNlYiy1FW0JTjWwQ6ENWWheWRfeyRpLlbCx26fiM+elN2AZuQB0Iw63ujx+tkMlsH8IlW4TAkNCL+gqJN8ErhfNLg4dUaJipL7OTrGtZHqYTj/8XqXrJDzNe+xj2dpujNS1XpVB0kzK9dsQNibJ92iGohNrgcOyuw25MMb3+9VKYwUEim9sP2IO27kU2voRDqwMWW7/Fy1urW6rx4AeRckXQn1vk2iiDWRQMvOyWe6Uczl5bQUgaY3EyiCJnR0VvAA2W5PHtSiNgv5CLzPJEd+Z/JBlTeGjEuJxMf1lK47h5YK48TnOa1p2STJIby9uM1T qo4s7G3+ hV1RDuWW8LRS6mPtwzK4jiw05rY26W0OqU1xk3ZEA5QCDH+kI6IXmcOci81bRiy6nzRZuTyLHjBrtXsanqVCtB6IZ8w6HT6H8yMe6UFjsLB3P+C20UBc5po+LbLi8tk2GMHtktRg9ajlieMS92VzbzqOlFYVWr04efuBXRcxPdhme1+2B+S1NA0FjIF0clYzvuecCSj5EeTa8Nt5K9LZbHhATFO6by6KgypYzPvdhx2HHjV0E3YXlO0KTH686nThOiXR+tnMMGbwzwznCGXPw/A5o0dE4BjRBcLwWbSPBnEUnfxs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 15, 2025 at 09:53:53AM +0800, yukaixiong wrote: > > > On 2025/1/14 21:50, Joel Granados wrote: > > On Sat, Jan 11, 2025 at 03:07:35PM +0800, Kaixiong Yu wrote: > > > This patch series moves sysctls of vm_table in kernel/sysctl.c to > > > places where they actually belong, and do some related code clean-ups. > > > After this patch series, all sysctls in vm_table have been moved into its > > > own files, meanwhile, delete vm_table. > > > > > > All the modifications of this patch series base on > > > linux-next(tags/next-20250110). To test this patch series, the code was > > > compiled with both the CONFIG_SYSCTL enabled and disabled on arm64 and > > > x86_64 architectures. After this patch series is applied, all files > > > under /proc/sys/vm can be read or written normally. > > It is looking good! Here is how I think we should move it upstream: > > > > 1. These should queued in for 6.15 instead of the next merge window. > > It is too late in the current cycle and if we put it in now, it will > > not properly tested in linux-next. > > > > 2. I am putting this in sysctl-testing with the expectation of pushing this > > up for the 6.15 merge window. Please tell me if you want this to go > > through some other tree. > > > > Thx for the contribution > > > > Best > > Thank you! I don't want this to go through some other tree. This was more for the mm, net and security maintainers :) > > Best ... > > > my test steps as below listed: > > > > > > Step 1: Set CONFIG_SYSCTL to 'n' and compile the Linux kernel on the > > > arm64 architecture. The kernel compiles successfully without any errors > > > or warnings. > > > > > ... > > > mm/swap.c | 16 ++- > > > mm/swap.h | 1 + > > > mm/util.c | 67 +++++++-- > > > mm/vmscan.c | 23 +++ > > > mm/vmstat.c | 44 +++++- > > > net/sunrpc/auth.c | 2 +- > > > security/min_addr.c | 11 ++ > > > 23 files changed, 336 insertions(+), 312 deletions(-) > > > > > > -- > > > 2.34.1 > > > > -- Joel Granados