From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D91D5C369AB for ; Tue, 15 Apr 2025 17:01:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2270A2800B5; Tue, 15 Apr 2025 13:01:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D52B2800AF; Tue, 15 Apr 2025 13:01:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09DFC2800B5; Tue, 15 Apr 2025 13:01:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DDBB32800AF for ; Tue, 15 Apr 2025 13:01:16 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8F89412174D for ; Tue, 15 Apr 2025 17:01:17 +0000 (UTC) X-FDA: 83336893794.02.97A75DB Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) by imf25.hostedemail.com (Postfix) with ESMTP id 9A332A001F for ; Tue, 15 Apr 2025 17:01:15 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="iy/SSM2A"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf25.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.182 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744736475; a=rsa-sha256; cv=none; b=OxxrUu7eNpYRhTShxAkZmH2GaLAB3DJBbhDvRKB2h/Og+qAMjPnlXjTMKjvK+jOc9MWsNN pCv7OTnct110bdQr1KhW0BDpafn3s+1+YEQ2I+BV+VEzDeD98nozWRzb7NAJHAPVYBiP0l InoLqgkXWdxQuTSReS9EL1XsbdA3ox4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="iy/SSM2A"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf25.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.182 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744736475; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CmWFqdKuu4gt5mYfCAK/YlboynoixgjtC+GEXND4eKA=; b=dOdOZyLy1K6/NtUXtQvT2r0KfFtU0Me3EA20pJdFL5gqTgpRnK4LM2aJ5w2xIazmiepm/P HoLyeqxko0zQtttvPsHkK6pnik1n4t27lkVQbGRfnlYDmN1Z6aVQEhELcBgQU4oUviAvj0 B1shgWhAeJYMMdTqGPfaBcLD7uiPw5s= Date: Tue, 15 Apr 2025 10:01:07 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1744736473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CmWFqdKuu4gt5mYfCAK/YlboynoixgjtC+GEXND4eKA=; b=iy/SSM2AD+vdcsUwN0V0ojVN6nJYo3xxM8bxqQvsuPlcjPZOm6vcI+v0Cd0DxgLUzNJNMS kimr4OBLSps6BnK2fR6sUaKjFHVPPDPs/SW5Cm6lSaoLsXuq8+bs6dUjJl1qrRGi+QQhp+ 2PTzD1X5CTfFDc7UKa+MKgQ9BDiEZlA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Sebastian Andrzej Siewior Cc: Vlastimil Babka , Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Yosry Ahmed , Waiman Long , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH] memcg: decouple memcg_hotplug_cpu_dead from stock_lock Message-ID: References: <20250410210623.1016767-1-shakeel.butt@linux.dev> <0e9e2d5d-ec64-4ad4-a184-0c53832ff565@suse.cz> <8cce9a28-3b02-4126-a150-532e92c0e7f8@suse.cz> <20250415063054.jerbqGF8@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250415063054.jerbqGF8@linutronix.de> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 9A332A001F X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: zsk39d1oz69n6xt5byujur74meke7or1 X-HE-Tag: 1744736475-514028 X-HE-Meta: U2FsdGVkX1+mZpH2G4vEU7GIGPwAOrtpgf28jlIc7aM4mpz4peVkDvDxBhgJ80xgL31lJWXUeqMQzeCr/w1nbOS5xN4DDsQA328ImA40QWaXGaTNZJnEjWj5GoRDICGB8ksJJOt+bw2hqyCGlbEvn9K2WWmmR71vJO90NPK+sNnHF2pIkimx23XxsS/55O2PGVxmOGBxvKIJvjjnf4IFfhAHuOBckR1HxKe9aO9PuZ6wIfnk/FlFPB7ytCqLwTk+NNxAguZ1dWEGu2vAgZ3sFBvYySharsSVSjLv6jXLS3bZh6jANR1S8omzCDbK4QHBXHKRi2viFvxmZcONFeZt79TqwriHO+Jl/KFNEn+OAQkA0RAyqRL042GBTAquwGykBsJGwN/itM4X2I+S6viFfJ1b7SuHIcGrHk4suCnzYGHhMAvIu1W+1T0/VH7m1EJ6wo5FCMMSalBYx26Kmnszcve5PkGMy0RyQfCH1R4yu7iZQxzQszzvLEgszKnzme6TlqwaKGBfgXZRAgLjzVI3YWRwn2nEo7hnt/gy91k/t4oYlu6hEtoeH7ZgIJ1QjDxK0pseyC/gDsDfym7A5DIr3kQuSTBttCiqx0eGAh3tSnqw+0QVmk0wRilFlqDCC3h/2i3I3z4FzKAdxYalwLhCr4SwQOWeiBMZIZUjpx6D2CBOEZ5HcbaQ4wX+QvgwPR+YrV/1CkRVbTE1Qfd+qZmiZewTTvtU2Dy2sEMXP+IgRgH5JNHiPmR+SNjpkog3aJY3QhXz6W9MqToB3csLfhd1jZGCXuLmO6DhyoTd18kGv7qUWRl6+rWcxT9Mwj90Pg6oLrhA9FOrmAjw3ukBdL94d7Co1+gaCq084cKGsv0g/6ebDgpQhDpggbi6G11GbWxEiyaH/LbwhQSOyzTtY2WxaVmzQv7CfXem+enTaCISxR8lbzB+GZgp5Sm/FxI8jSG6f+2N2upVxwGLNraronM FgoltzeU BMBFx6D//ql+qB65sJp7GSzYVU2eRlm2R9rsFWcAYvk/O7FKDJNlXaZyl22hVhOTRrI2aBK1eBaQ4NkBnzbJw3uKk9cZU245FiWeDQ9OqTlIxWMDlbvy2c+nvUprB46X888uhcoVPpRBGDEFPhQrWbpGQlqDbdWZxKRU1YuwIrwZOrZC3gA6iQo5ynRbgsQOjZ+tQqId6vUVERVrQE1zD7pZWaFUiCeqjDLse/bY2ILWD5+0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 15, 2025 at 08:30:54AM +0200, Sebastian Andrzej Siewior wrote: > On 2025-04-14 10:55:31 [-0700], Shakeel Butt wrote: > > Vlastimil & Sebastian, if you don't have a strong opinion/push-back on > > this patch then I will keep it as is. However I am planning to rework > > the memcg stats (& vmstats) to see if I can use dedicated local_lock for > > them and able to modify them in any context. > > Please don't use local_irq_save(). Sounds good. Andrew, can you please drop this patch (I think it was picked into mm-new). BTW I think using local_irq_save() is not wrong and just not preferred for RT kernel, is that correct?