From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C884C48260 for ; Fri, 16 Feb 2024 23:26:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93FCD6B00A1; Fri, 16 Feb 2024 18:26:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F05E6B00A2; Fri, 16 Feb 2024 18:26:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 790406B00A5; Fri, 16 Feb 2024 18:26:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 62D026B00A1 for ; Fri, 16 Feb 2024 18:26:23 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2B1841601AC for ; Fri, 16 Feb 2024 23:26:23 +0000 (UTC) X-FDA: 81799253046.06.895AB8B Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) by imf13.hostedemail.com (Postfix) with ESMTP id 347EB2000F for ; Fri, 16 Feb 2024 23:26:20 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=C1BPf5NM; spf=pass (imf13.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.174 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708125981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i1dxXMhVUP1rgHFbx3bYUtrQ4Vj3OMrjAfFZh9B2nko=; b=bgH31b7N6mHSJZIs85o9sR/58MMGbgvPOKNcfNFdu/F4ZPnlI/ZQhc9rBGWWEplkQQskSZ FCKbnpCEXMeDyBT3Pe3MbZwFXZ3bHlnDvs9+CEqCJmKFaczzFAl9ghVNgnoxK6z8jtBAl4 2OdN6XrjY/HzfNLWwOeMYhB6eZqsXyM= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=C1BPf5NM; spf=pass (imf13.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.174 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708125981; a=rsa-sha256; cv=none; b=hoHDRDAzN+e484yboO6aLWAM4DgJZxyyNkr/J9zjQOy5eMhPEnqEf6yA9oPlW/c4FxTXkl GlAMu24KiLQKZGrkPDwsFjuEtXjNlL5pCoaKRjJ4Z7sBk7dN+Ft0SozVPTdc3n+PTkV5GI myji/DsfRgmPhcBcCQ4TiyVAHJ+Z4c4= Date: Fri, 16 Feb 2024 18:26:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708125977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i1dxXMhVUP1rgHFbx3bYUtrQ4Vj3OMrjAfFZh9B2nko=; b=C1BPf5NM9g0o4QItUPGRDmMrvEdGWmyuKm4wf1nFggUVoULHG8BShovAlb221Bb8TlJ2Ja KutXp2dyrtywnpnLlJsZyWbMnLgEtGr2j6xQgJwjPAMGkgKbYaLIt/Hwmsmi7ACHkQBytE lKW+kj7xiaratGuJKp1Q6urfXB8QmCo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Kees Cook Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 13/35] lib: add allocation tagging support for memory allocation profiling Message-ID: References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-14-surenb@google.com> <202402121433.5CC66F34B@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202402121433.5CC66F34B@keescook> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 347EB2000F X-Rspam-User: X-Stat-Signature: brf4ofr9cpzz9nbemsqzpecampddsxnu X-Rspamd-Server: rspam01 X-HE-Tag: 1708125980-215606 X-HE-Meta: U2FsdGVkX1/hEYZWgMH6NWqThd2wKH2dBltsK58F32v7CvozdpZcybUGRU57jSQxTEZvdIfzxenWIk3R4dx2/ymO/Om92GS38ukqG+eJk5+g2ZBuKePjkKY0ObGrEqBv/fF9cw2kT9CSitHYigxTWY0QqnEtYD2IPlZJzPJXzlzrjx8PB3tOFUWUyYqBKX1fNUc3oZRFmW3hRfZ1BnaIuZoMmZogTSNeQcisYlh4MdqTQPoC21g+zywOXhFTN07Wz75zN2iJZuNQVx4REFfkR42H6Fat9YUXr1vVaBCOewSceD2wUBNWWK9dE+qzGYw0RLxHacdYrPIw/jYzyQeyJ3ma7SKW435QWPKcxyJZDSy4BTvlExTn/Gbon6fWQWmaGf1IMRdu2k/cqYVEdWt5shq2zxqKiteDsqxUT430tQnr/TrA1+SrvJHhMQX7etEKkLR7HDf1BwioUTPY9cOXOPQu6Hlq05kvIZACXD4ZC3UsxwhWKd8Tky1m9F/eksSZNW077Y6U4t4dyv/mKevU3PkFSZTRNjpztYqT/MfUQIMzPonxepR/Z4z6y+vs8qbqf/rq9s5zMikXXgQrg4m5+iQEJf9NJPsJ5NShdDieikVwgsy6GuC6SMzzgpSq6yfYyRvY0XfQqVmbMnrtHO2o0j1/wwDCO3rz7+9pxgD1iLRV4XPFG9CJCj2AAM9n9zYBYfGnAXAkyAk6M5iIg+01vIu7Qbj0XhUrzchOen13nC8T3XBgVE9DPKvQQpdp1TTFAZjCxVPW2ZCkRXNB8wAblPWJqkMDHcfjeRfmeHNmEQtGmpvYOU1kOVj8TS9McM9sc6ZqKwCeYhI/mcs4hbnodlyE2Uv9QT1P4l+TUETu1IgV1x3VRPPxWgcYvlsGqJkHxPBhqziJujKasnAc8tuOQaWL+fGSpcELtv0wipDbRvTh9IGdyX2b9fD9rSTGq8O5TLHF4+R+G4Lq5/9r7Pb NfvITKVl nsLaWRD+yJYlQpuJVSZYNeTBzcjOixqtEyxvkneLmbJQWuLrHtUpxnk9LijrKyaXjuIOFFLpLtfT6AWlR4Fkn9HzniVJNDHBLSWOSJEmbTHp1zJkQ1HLqv5o0hxNwqFCyy+ObFUkRcBNgs1N6ssFjSjJI+oOedBbumiz7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 02:40:12PM -0800, Kees Cook wrote: > On Mon, Feb 12, 2024 at 01:38:59PM -0800, Suren Baghdasaryan wrote: > > diff --git a/include/linux/sched.h b/include/linux/sched.h > > index ffe8f618ab86..da68a10517c8 100644 > > --- a/include/linux/sched.h > > +++ b/include/linux/sched.h > > @@ -770,6 +770,10 @@ struct task_struct { > > unsigned int flags; > > unsigned int ptrace; > > > > +#ifdef CONFIG_MEM_ALLOC_PROFILING > > + struct alloc_tag *alloc_tag; > > +#endif > > Normally scheduling is very sensitive to having anything early in > task_struct. I would suggest moving this the CONFIG_SCHED_CORE ifdef > area. This is even hotter than the scheduler members; we actually do want it up front.