From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FC41C021B2 for ; Sat, 22 Feb 2025 14:28:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47D796B007B; Sat, 22 Feb 2025 09:28:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 42DA56B0083; Sat, 22 Feb 2025 09:28:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CDAE6B0085; Sat, 22 Feb 2025 09:28:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0F39C6B007B for ; Sat, 22 Feb 2025 09:28:02 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 819901615C0 for ; Sat, 22 Feb 2025 14:28:01 +0000 (UTC) X-FDA: 83147809962.26.214F10F Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf27.hostedemail.com (Postfix) with ESMTP id 8C98140005 for ; Sat, 22 Feb 2025 14:27:59 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=INaxWmM5; spf=pass (imf27.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740234479; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zPvXDuvmRAhrxvOfwR/RABZWu0CVYBLRPN9dNRxz0ZQ=; b=RVKDd5uEizznxLPIo8M1sL3on8dqfj6qft/sw5fYXcUF6JHZS+i33IThNbUNtqbPRhSxy5 bLBwkMvOOmKNBRq872nGaOU0ea8O0kf/hYJb6YKkujtfG5vf/o+P8k4Yj3orpTnpare00R xXJpsr/BAgwcuSnTvExzeB9WbFkaNF0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740234479; a=rsa-sha256; cv=none; b=fmwmW/8PRSkK06wCR+kHukTgPE5ZcibS1/9mpH8StvTMqm8kNSEr+LIDXScY0JUCkm0m1j npQ3yWBOqo6Ke34XalnlM3Omw1xm/QGukdtXCmqU/i9BuhvPaAMpsQ6rqm9wjc+O1Y0EDT 6+S+EyWzy+kymAgwvC18MdV89W+MalM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=INaxWmM5; spf=pass (imf27.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-22114b800f7so59111735ad.2 for ; Sat, 22 Feb 2025 06:27:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1740234478; x=1740839278; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zPvXDuvmRAhrxvOfwR/RABZWu0CVYBLRPN9dNRxz0ZQ=; b=INaxWmM5fuYkzufeYKu+7QsWsZ8shWLQfklmMZSaiKpTyalfpHhR5yXXWNpFhjWWPS 4Pg3/JAO/Y/RW/6H/o4PQ56454j4uMS6hVJTJigOOYqauFh7ELdQbzw95YwmJkEi9Vwr GCnnYe1lKqPv6DRdUf7BRjO1yi4+TiidJ3y0E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740234478; x=1740839278; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zPvXDuvmRAhrxvOfwR/RABZWu0CVYBLRPN9dNRxz0ZQ=; b=ws6PoTHmJPISSBBvOLZQB/cILQF/EVClzsGpYNsTfXkEIsZYNlLOsLAWDcep0lndC/ YZECznnITuONAkpEHtuoToYrAuXQ7suo+wQEuCttsnKjVHdW1yK5aw+1AVDW3ZTf9Nji NMvwfpBdMNMRGtoxaemGkcslsJqsQkZ+SyAUPsRqM7s4stPY1N3qcBc7mUgyQAMCtuXN /GbEV7mkE4uVYTCfaTGG7xh3OxlXGeNU4hl9XbIF34vOUSqyHyAOe1nnRdeEGMpyIHk+ mt7y+JJJaFLhLL8Q/qJIbYIzu5oDxlKgopBccvielAzE6K/QT4QZTStieut64RcN8qIh a2nw== X-Forwarded-Encrypted: i=1; AJvYcCXYg2/NN7b4WhM9hJeUvHDT/Ksh2iPKkUQVjr/KlhIr758knSSYioCXtsmwKX8VV/AQa6y5FqlBfQ==@kvack.org X-Gm-Message-State: AOJu0Ywdc3qPy4iZlyOnJTHyTB43lhPzWOb6Nhwep/rME8fbfzQ6s1n+ EgqIMQP6oElOjl7AumlqWnqWfJUl5Bx/eMK3/Ct3Xso9mHokJbltzgMwCHkWqg== X-Gm-Gg: ASbGncs4ooYPhGlkIViYGfc8uL4XBqDwwiGEIqBBmFRjZng85GQzTbHvz92y8Ir0c+N fpoYtBc2ImX9Gir2FUy4xbY/Ag6SYbvzxkaTZFdXb+rVHJ2DlxAC7I8Zg7o3QDGC7v8YerwmhNK MMfjmRFDEPXvD7RfBA/BeypMsepd4CZtCh1i6fHPvTYMy1/ucQwisZv/TwHlRy3STNh2zlc5ZMU 4+QXmsOB/Dns2Bwypp5au202CvJXVPcbqbPby5UAe5kjA7/SL2owGY/riYMS+Hfuh9wJw7YhMoa zNh2I1Q+sY3GayxdDyc4Z4LYF98X X-Google-Smtp-Source: AGHT+IFPJedH8sKLSfD18g5iptfNHmHTIVM0EgNuwafBBp4M2gx2umVIm3KLNGcBsyHiBaQenJCWGg== X-Received: by 2002:a05:6a21:501:b0:1d9:c615:d1e6 with SMTP id adf61e73a8af0-1eef3b1aa6dmr12909888637.0.1740234478261; Sat, 22 Feb 2025 06:27:58 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:badf:54f:bbc8:4593]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7327fa51eb9sm11016305b3a.166.2025.02.22.06.27.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Feb 2025 06:27:57 -0800 (PST) Date: Sat, 22 Feb 2025 23:27:49 +0900 From: Sergey Senozhatsky To: Barry Song <21cnbao@gmail.com> Cc: Yosry Ahmed , Minchan Kim , Herbert Xu , "Sridhar, Kanchana P" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "ryan.roberts@arm.com" , "akpm@linux-foundation.org" , "linux-crypto@vger.kernel.org" , "davem@davemloft.net" , "clabbe@baylibre.com" , "ardb@kernel.org" , "ebiggers@google.com" , "surenb@google.com" , "Accardi, Kristen C" , "Feghali, Wajdi K" , "Gopal, Vinodh" , Sergey Senozhatsky Subject: Re: [PATCH v5 02/12] crypto: acomp - Define new interfaces for compress/decompress batching. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 8C98140005 X-Rspamd-Server: rspam07 X-Stat-Signature: 91qm5366ozggn6fghehdm5otyr544rf4 X-HE-Tag: 1740234479-571266 X-HE-Meta: U2FsdGVkX1/tyO8o49UXi5tsKIC14Hm5QVExatga49Kl9uPiYMw5hwrq0O7Wg1vF3Kd/MY+utxwbSvnDmIFIN+9z5l+O9K9lwdPYBT41JLDiUGR+UPZHNTivFUGtwfi3eaptLIlHLrPkuNDHELu8bzXD60rUsfx1dsa7nR8VeyV1OtMk/VIfH9PP1JnbYehIFpNlghrtGToKHwRHSzMg3TTlMQxy7Z7RsFDeTdbtVs8bCMw+E2hCI3SqZ1cKWxUWcnfMIs9OsfWdQzQ+xgoQ+NoIB0/6w/F6B8jUyJhNpmEtVW1bIa6dmYQEcCOdwJO/wd6H10gOgX6cqzW63JuVLJQADCDKrZxDbuh9ugAnJGZ/vhjgADcisrk/OeckwFr7DJobujI+iN7e3C81/Vom+NNvJltcKjwDAna873DpFZY6fY+kufvbgbyzZyItdgamp70QBe73xJ9uAeNTQyE988p/ycg6mJREzHrzqXDLDbe65G9QmFMssLitEn84u4t/FyXM/CA8bRCrtZ4rgdkTVOf0aK+C65/+7OGJQFRKzNBt79zVyyBjMgV/EduPZhV8tcTtgxpp9BTeBnNNBi00ddjgRZb9B3P/jitNVk2f2tKVn1zMNnHTXUpNcaHW0e2+X6/2JLRrrV7A6FKWtErfvBM0uCgqhPjcWgf2p7hlwapySvFFotkR4dn9Jaq1lUigDfjpIk3p0aSK5tjps/PNJN2LbdyHK5DvTLlJKj7MTZFtfrCzDT+fH/fHuJGUYEgZkUdIvrAoU4Rowfq/UhmJCoa6TW3Tm4EoARJ4c22O7w+6jcC0CtZj+q3UZKzHnitQjfIyZoWatXWTqwFyP4ljs3G+akAjpH7LIYSI6Qm2xm5he55N+ajDHDxXXtQAfb+wkqLY3yQUyFBTQFTn6Gxaqe/7clpp+jbOCZeRp9DEembdq3LBRFWu9aUXqdZELtF9FFmi3hf9t+LXNws4kDL sYX+Obbm SZK1CxYuhsar68Ovk3h/CSY8EXDN/QpZ7tE65HCnV8+Ico2Nq4snTn/JhExcNDG7+WguD+HbWcMDThVxacvS0vKkSUYcq6bALcCZzV2bDX2GkVpcnkNDvGgZ4na7a4yuwOzNYhrh3LQBz4iXsxEaLVQXIS8rBvLylEqbqo7LpfrbE2u1P/G3VRdr9EoxaMCak3kcM6HgeGG3xuVBashFiND92ykbkMJuUH7xyOdEVtIft+T2VjmB2MzK7l2xRpsA7uwAZqu/+0y+hZtAkNwns7QLMza41I6COZjct4kVsws+0PEAK5Q35Kl4pSPXV+QRpo90USaSgzW8dx9+w0IcZKbfqAbkf5K9Q1PbyLfaW53/T844= X-Bogosity: Ham, tests=bogofilter, spamicity=0.031189, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/02/22 21:31), Sergey Senozhatsky wrote: > > As long as crypto drivers consistently return -ENOSP or a specific error > > code for dst_buf overflow, we should be able to eliminate the > > 2*PAGE_SIZE buffer. > > > > My point is: > > 1. All drivers must be capable of handling dst_buf overflow. > > 2. All drivers must return a consistent and dedicated error code for > > dst_buf overflow. So I didn't look at all of them, but at least S/W lzo1 doesn't even have a notion of max-output-len. lzo1x_1_compress() accepts a pointer to out_len which tells the size of output stream (the algorithm is free to produce any), so there is no dst_buf overflow as far as lzo1 is concerned. Unless I'm missing something or misunderstanding your points.