From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B44AFD3C92A for ; Sun, 20 Oct 2024 21:55:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 138FA6B0083; Sun, 20 Oct 2024 17:55:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09B476B0088; Sun, 20 Oct 2024 17:55:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE13D6B0089; Sun, 20 Oct 2024 17:55:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BD82B6B0083 for ; Sun, 20 Oct 2024 17:55:22 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C1B24C0483 for ; Sun, 20 Oct 2024 21:55:06 +0000 (UTC) X-FDA: 82695337032.11.142F810 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf20.hostedemail.com (Postfix) with ESMTP id E73681C000B for ; Sun, 20 Oct 2024 21:55:01 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=OdwTD9Di; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=K8VT0kXK; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf20.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729461269; a=rsa-sha256; cv=pass; b=WFH7/pnUBNHVb7if/s/SqM64lifT7QEBklGn+v7KhvR/jranH862GopYTku1gRPtp/yse0 p+Tr/Fx6rJkuQ3g2UptSJoyInXANzI4pBBpyw0DHqdYhOpQcPR6Xr+jR+3ISeWsUEQpLbg 6GiLVmGza97SOtq2SwB7/4EqTvGJ/bY= ARC-Authentication-Results: i=2; imf20.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=OdwTD9Di; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=K8VT0kXK; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf20.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729461269; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mOnU6SBa4kuJcasNS7MxLTo/6OI7Tme29tRbdeBHzJY=; b=S2P2s7n0jEil5kOC3BbWr1INmpUFQAoirEL5kGpTBDhslbx4zpKE6oQww7n8spy/XQcHz3 QOHLEOvK/BxpeXVm2WNdtSJmh8isQwkjiv660vZfeDkAFL7Tg5kGExOoY4yk4wNZit3IW0 hjRbciC3x58ZQQKcmr+ycO/Q6kltH5Q= Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49KIhVeE016342; Sun, 20 Oct 2024 21:55:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=mOnU6SBa4kuJcasNS7 MxLTo/6OI7Tme29tRbdeBHzJY=; b=OdwTD9DiY2lx0B2ZJ8ovRfs8/SfTGxt5Ku GUJhhjSjgD6E51W+YO59A+1iCDtXZln9AUb/Rf/rRMp45irnSAmO6GeSl/nRpHUc 931EBkkI448OJCFbkOoGGXv8WYqAG5DFTCfDHXmEiIRtJz0mJQgrLy3uu/fpoI7v nNu51IVV/ojklojfnHCoRejyIFkBfATi8z6ha2szLSlTTnQT6pSJjqk7eBe2ilZF a9p8RDRnA8jm1IiTQqfx9UUjRjIyXPfBDpkVyGmygc5T3q+N595f4Q31V51oNcSO 3aK+7lTY9+fEy2J5pgmpIYyzG/xSpfvebGRQ8aAEe1IgP1/sBjHg== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42ckkqs8hn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 20 Oct 2024 21:55:17 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49KIQMWg011988; Sun, 20 Oct 2024 21:55:16 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2171.outbound.protection.outlook.com [104.47.56.171]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 42c375d0ag-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 20 Oct 2024 21:55:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KHlbNlJXfC5WFRoXLrNtN7DOkcnbm0IdF/uLfFjVPjLy5snOnicEVtd200kY6Bd0f131J4/OB9m5m6smV0IaW0hxhktZHvBpuAj+L3Wld57nsjJJJkRYF3jWhDDXrIVRDK8h/aeIhgCHUmyytaDdOydMLGlpGo9S1g5OVjQPRT0jU15dfjBT/aCVUiDUJXJ00V2JyxA8u7WVGBzV6TTCPNA5J5Z2yvU4koDmTmbLCnm1rwzToQBBMpfq26MgAfqbAXg8ZKRNDk1TxYFKoHCWep4hVhf736HgxjNjb6FxwIXnAmwet4yFBCMDxj9lgxZUf0K6w0bKbY5K5XLOQyZ4hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mOnU6SBa4kuJcasNS7MxLTo/6OI7Tme29tRbdeBHzJY=; b=Z3IFHAwlLVe1WLTiFJXSOsW33EKUjAacz4oXDv9Cg8q8K4y/UC7rNhc7fm+84vsoOYRc6no7tRAlAwE4QpJsC0elU87EYJYOPaWe90LfeIS/6/lyN8Oj9+8J0mG1lJY1OuDdcVESh/g+ZlM1MES6JxPY96//MXn1nGv3Pzb4atMeYztldMXXFpnmBSkSIp2/dwjPGdG0jhRhnRvPYUjtKrzGuoAjdtqq8VRRiWY4XaRTbI+6Q55lNC4K9ZrL187NEZKX92iY5n9kI2K6GlQNlYcHRfw1xFbZ8aKmZx26DB8Rq2i38lMqCAwXGUWpOvtElrc2haHK/TNAfiRTM78OTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mOnU6SBa4kuJcasNS7MxLTo/6OI7Tme29tRbdeBHzJY=; b=K8VT0kXKCEaymE8hm0btwDtqw2lOKbhClFzg04VbmVQ50c/bST8Df5zi+u+k8z+pU7S1G5MM+OCZaBH5AC/tNkJG7BdvkQgkDk4HMg0ejOrxvp20/ZaQS1QoQ7D9bgXxHQEbYqmLM8ymDJtZMAsSigirjZV8/hsuMAZkRQzH728= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by PH7PR10MB6355.namprd10.prod.outlook.com (2603:10b6:510:1b6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.28; Sun, 20 Oct 2024 21:55:14 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%7]) with mapi id 15.20.8069.024; Sun, 20 Oct 2024 21:55:12 +0000 Date: Sun, 20 Oct 2024 17:55:10 -0400 From: "Liam R. Howlett" To: Wei Yang Cc: akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar , Lorenzo Stoakes Subject: Re: [PATCH 1/4] maple_tree: current split may result in deficient node Message-ID: Mail-Followup-To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar , Lorenzo Stoakes References: <20241020024628.22469-1-richard.weiyang@gmail.com> <20241020024628.22469-2-richard.weiyang@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241020024628.22469-2-richard.weiyang@gmail.com> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT1PR01CA0086.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2d::25) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|PH7PR10MB6355:EE_ X-MS-Office365-Filtering-Correlation-Id: ff358cc1-db33-4213-6b00-08dcf151df91 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?On0fwKlYRoFAQoTGtAI5IIM3s4rqfDQH/2klTqhtsCcDnDWBK3NdJ/LuXtLs?= =?us-ascii?Q?AsX1EDbaizirlXcDprC92nwXQ5iT8qvzgyGBS/52tIYtRLeQhNvDXjB0xkIp?= =?us-ascii?Q?tsHEU7u7tTbsrsd1l9L90ObZ/YOkPmrx8HbkkubcvoeJNToBWZ7UA2GTNeuI?= =?us-ascii?Q?ZXuWX2JW7cVxB26KdXG+J4J9MNyhKPfKi+vgzvj3Wz8xv8cJMoiFzSKHbC29?= =?us-ascii?Q?FE5NiNKARbGwOEjef/c5CY6UezukpeOJaU9aTke8NfauyR15NFcjJXt5zb5Z?= =?us-ascii?Q?kAmetkkRzuSSMD2yyEqoYaarKwynqvq0SJublohG64AD3OJlelPF01Yr0+fs?= =?us-ascii?Q?qxT1ETxI3cO/RrtoG6c6hp5PFnqFOYpupHdlL++1b6Gb7Wlxjj95JTD2F4pj?= =?us-ascii?Q?+Eh1kLbAIleDcFm5X+8+2yldjXDdtf+08pLfSHvFnpNxtBojyiO7vaEsTJea?= =?us-ascii?Q?rxL3cXKdLBybBrbMgvMS4XY3xMfAJBQszdDfSHU4wMwyv4s8djdW/aC+5MK5?= =?us-ascii?Q?kf8Ggt9+1dUlea4UB0zTL0jqWX81hK0OIMYUVxmAdrj10/Q8HlkSExuKxCkD?= =?us-ascii?Q?EzPrTn6ZE47Kjo83YmY/fykXsVQyXE3heFSoeYKefI6TXwo+gYD6yTErzVoA?= =?us-ascii?Q?UE7Xilck/2EfkKwm/CEwcYBpbiVO48iV9XHZzBhD2K2aEA3tTjlPezpA7nMf?= =?us-ascii?Q?sZGI20IbwQYtkOnK9zQMwqoRoQM4vil0dByK0xcBkpSbqeETS//am4/sOnbD?= =?us-ascii?Q?C/wti/WqUTdPum1hHe4C0DCJzF13gJ0f9dMyiB13GuD7DxeMFtAVsMH22erG?= =?us-ascii?Q?+W31zQCylGgdbDKDitAGcoMbW7csFBTR9ZAdrJaYUaJvlDVEQUuElXIvjezb?= =?us-ascii?Q?kTWBA7K0AImzkpq/2AvYVxBH1hFtGxjpL3n6SJ7yuQJQyuiL2Sj/6QgN55VL?= =?us-ascii?Q?jEFi2DhE4dOxagUuqUrnEz1o0GH2tLofdphHYtY4pnSZqVexj22LA37FKDBv?= =?us-ascii?Q?+9rirxXQP13/Kz2/7vu8G1du1OkFNc3d+C3d7OaDCOGiE1hDfqhZWMw4jQOC?= =?us-ascii?Q?kPTaUpl725xhE2VFbsG72p8p059zarR9kMSndNcpLbaNznAPsskuaBP6Pj33?= =?us-ascii?Q?C0o9f2nJMM4T7rzQDDpdddUL3LPADOPFqTu6oPdBH3bf9ce96szgormi6/+z?= =?us-ascii?Q?MEpMZzeJT1yE+0x/gXLRi5se2uBGtBvA/ZEero+wCJmrBbWxyGelef/mKq3h?= =?us-ascii?Q?YDTrgS9SEA6iuE4EMB7IzWBxPRDvlOzMUh6Pga0iE7uMaSvL6u472T+maVzI?= =?us-ascii?Q?MO2WnVVWCxVrCf/+xOLlWBIE?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?slQaHPIRhrFl5xAMC3aBGeE2chY9Q3047eULefGCOZQq3PmugY66cSdQS/sj?= =?us-ascii?Q?raOidocTzt5JO3KHgALX0evtElPqoFdmwUs8coPy5Q8Uuigcwt41XpHDZI0/?= =?us-ascii?Q?mm4LI4lMUFml+HiNUqdTaMyj1UVg8ZtCGLy/PxvHA0XzQBEWBcUZXd/F+5AX?= =?us-ascii?Q?YIBGI2oL4zLFT9DxpuyFtst1+UQZjv9Nl38YSz/+p4MtNlGk3z+CS5htW8aS?= =?us-ascii?Q?xAt+Lwqw0VH+6nOjFyDjIZGKGg60V32xMJRei4e44nmUHVg6GG0qn1w9sZJh?= =?us-ascii?Q?KBRjMCf9cJFnF5x6iHWSoZbnfefAn4TKX+8Hd3EA0d3Jjve60VumXSk03lSS?= =?us-ascii?Q?4EAVAoug8kR1YpmSAet+3z8NedPgaYGn+WuYEkqvkMy4N1Y72T8qQIjQehkL?= =?us-ascii?Q?RtMAfciq4hdtkd3Trm9HOBSVL5sbWy2+UyW9Z9saIhIpItmFkl6oeRorfyO5?= =?us-ascii?Q?sqFFQOl88ta9RMS0yBs6aM9qcRaeHIGhBkDs36LzGRJWfYdo7pAdY7Kv6TP3?= =?us-ascii?Q?LVAj5t2It3qJrxc/UYCjqGzG7KGMsw8cLAEuAjkEsxZ6sCmSRz3Bb2oHxlpL?= =?us-ascii?Q?UYbHLvngA8ZbFyHg4untZ+qfBjHCPvGmeBPOhzqJTKkE1QyOvk2E4GSVh8Eg?= =?us-ascii?Q?4BkATG7bfMtbuKd+UPWnITTSQ5ffEdp/Vk5Qo34hFnZexvY6GgXTZ+PZOZYx?= =?us-ascii?Q?qtDpGfZuZAmzQT/m5h317O25Ul0TDSJBXwMs8ZlK/6r2LtFSTIyTnWHLCJAB?= =?us-ascii?Q?7klvv/mB58nNH4N4ucLiRsz3dsMhypzr37eqQrJoeVH6+6Dy8W9diDsuB3mj?= =?us-ascii?Q?Yb5SX+SIsONdp1KjpnCc6Z6OBdmeiMG8sU7XwJtdO/meuD1P9P54U6N/UznK?= =?us-ascii?Q?8aw05SCBLMK05aF9ZLWNhBFYmWcKlX01xgjUiGuZdf5yfVfMupxQen/ifTna?= =?us-ascii?Q?2hi4fdUCao628OSNJpR4s5JEIibRmR/BgGrlsBMs+g/ZaLwSZpiid92NTdb0?= =?us-ascii?Q?1JnQSGIgk+qtZ0tA/NhH07sHlHwk0AZs/nzuV+t1iw4nJ6JEDKcq4T8mQZQj?= =?us-ascii?Q?WbqwzhFPPQlkGLkved/j/d045OogpSsrvdLjGyv7QADmuua724wJ/ub8OPhs?= =?us-ascii?Q?tAVq+TX/YgKjEBBK5KQS216YBTWroxC7p7x8MkYit611zOw/QvnSJYothxHZ?= =?us-ascii?Q?cfd/DFJeq/6NjJM/GHtCaP/rJB2o/FbXjV/QLBHgQmbNt3Hqw+VPeuwBjW5Q?= =?us-ascii?Q?8+VcXYvLIg2eSVQZ5srVgSpQs3Tr/kaLEhK2rTbcbgaPbBSp3zZAnLZ3bJcr?= =?us-ascii?Q?sNr3r77prRkGfO5szpHeHxUtka7455N7pswIcY2mwTexkVMsbX3RnVjswG7A?= =?us-ascii?Q?7p4hBPyNGDKYC2+SW5oQ/Vs/gAKt7L98s4LGfF6U44FbDx7lhNHEZj73SOXE?= =?us-ascii?Q?AQwKd9HjWfT5CycpgDAUEl1rZflVvyaj7bnFg9M43SCCAt7x7wNmdJ6/BJmb?= =?us-ascii?Q?mAYUzPWo3s8YpXeYBg76/Z/OztQf7bonj0IcloPtZezyXLQBCrCNDgt6mZHz?= =?us-ascii?Q?HAnvY508+s7yv0aRk4Fw6ynsNsZauryjeLdfT5Co?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Dq+IdzxIyn1P+7tjOekF7866tkBz2dPDqQ7acoV8uakFk27XWNN1mmNloLd7L1iB7OfcBtNAYfsUOMNWs6RDtI8GFvvqUXDfyHiBIgMuVoHmCSck6uXldDCbl+aw8mOonG9lQpLAeW6tcpqbzc6WCItASarknIXiPcKKdlBXxWfwMkX7vdnhka1o6XaljoraQw6ibg40gKxieb6X+VReVN6tdWOd7tkUX8hV+NDjAF5KcIpulXuzU3OIJGHWfiqYvsTEY5802r5gKVCT0tu38AjNK1FzPRbOZ3zjvw6W7cs/g1m3clL7mbHgab4dYMC717Ck1OfxfI1P0bpBQcoXKNrq9GUj9ydvRuEng/4kN5Rx5cWCWN6G48Hcu5I1BphyBkuYT14V5u7vwS2ful8pE8oo4923HgsfPFJo1xY1+l2QzV4atnh3zdIDVo66AHe08kT6m0EBzPQ2ZMA4kGmig/thOjvjjLsxvWjUn85M5nO+meNrEtqJxD8jabtZ5/a4uXCU/+kceblTWc/l/HXLkUyGWmWXEBI0tMF2fwKG4BByPXG/YXZx4GAQomuk/POPgCOd0RRC0mcR4fBovSwNuYxhRe4LXkj26ALOPLrimdY= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff358cc1-db33-4213-6b00-08dcf151df91 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2024 21:55:12.6726 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ju11tEYffpgGxWTwRuiRqPm5Bo99u7wcrRXNJale87YyLRGBJeOxda4wStPCP0eDYGpz3DzTUK5N1o+iGmyk3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6355 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-20_19,2024-10-17_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 suspectscore=0 adultscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410200158 X-Proofpoint-GUID: 5ldC_9N_0EeyVHAXqr1b4dFU9WI1YW26 X-Proofpoint-ORIG-GUID: 5ldC_9N_0EeyVHAXqr1b4dFU9WI1YW26 X-Rspam-User: X-Rspamd-Queue-Id: E73681C000B X-Rspamd-Server: rspam01 X-Stat-Signature: jyabxmjgnd1huhrkusqkb97zmdpa5zht X-HE-Tag: 1729461301-971843 X-HE-Meta: U2FsdGVkX1+DJrFG5kmFnkxn2Mo9dplq+EZJfBFUfSr7tl2SXZ+F+K//J70S86CiNh5r3BdXXx8ga4iLZ6PrwsXGh1dmSWLQTYI2CsRQ5KS6XFUNUurSs3XHvI7IqbdGZ7fJZmaEoaNlKZIIVaKQI0SCtamcKt4v64UzIlciFrQEkObY9iFaTwFwHnMKFcgbiGSYIXSuaCDZZ1ZCGNkglLuHvq87APWTS11Pm7BWwpyaaIdM/+JghnUVUPKxeLfKvE81hzT6HBlPx/Bm8kYeF0SM3n+snwpzc9NQ5/gFSf6yDcCYUeJvCbxiLnwgYkjenNQldtpqLX87EeZrAnBj+ZFhanuGG21gByHnTf5Np7ppG2sYzftSYfX2DMXF5RO3e5bQAnwKouF+3FuCpMPZtx4EgFhhCsYaKzYbYoaXyCNWOdNCsJyAVRiauHvyvUFTD9hDc2czgEGKN1zrfsYHdqjUnSpEc3KaPckM9uvp9dPvZjGzS0Q1PJ8yig3Poykep8AWsEkdgyLTO9hELfW7QwiKfbypFVASAJ6MxxQvrwiX4l3GdxkPFhIXARoY5rngF4DaktelrVEL7kOX8pWW6bzSk+sPmp2E2EENolpNrkBQ4fiXTrLGduqPyRC/mMoBlrdaysPS7JGnSwI9iEsqrfYqurdgiYGOxtzWxqFKl+nj6UyBLXN1AqEGmz+hjJpjRuXsGD4oXeoq/H5CqcvSAsFoR2+3l0BVMwG6WquXhE5UQwHhgmyo/9Y4te1eL7QThOLUA16UGjc48RARWt+cyPWV8JQ3J7FlvDCN5oGHaXzY1Pj/6MVmlYyDAlSg9tTe+LW3EaCEUUajWnGnFocwkq7H9FUNJumx2OlS0yQsaAkYVrl26u4tVyprX4asZ4NxDNfKLeeyXLX8NNJKgG5PbJo8BoqsQ9jjJkzVNImon/fzMS8eiBQOkZ7TSlYHE9xfh4Ik+2sblvb/LEnGHlf KSN+OjgY UcpjwPp+UUKYkL4XU/f1d/Lx18Zx0yeh9g4ok5+2r/JUQFDx5n/7MGp3grHg6OO0Xdq7PqEyqQqvE17IOzFI2sJOzsfAHYO2ZxmZhmTow78hcPNWfcXe9oLoFAKZRIqegz1yimOC2ziZ+aTiyiFrcCCNZrlpiw9DkPEUe5RMabBTYsbCK4+uHrdRrFNuReTJOZZBdrwcmTrdPlKX/ifq3LTRcFqHamq2ZQYYXdGJCdreabvDOeuOaqffymmLJPwPrWgvf7nTB2D00zmn2G1FoQa2cKQ2uD1jfI7921HvdCJB9WDSPVeJU7jswGBEu/Su2HpddqlkAVdw7mJmqLyVpUolFapodruh+8wQIeNeo6ZszaCg4Tm9VuUQsvqFvC+ed7N0jdAQkH0HiSMpZHcl9CTVxdmGxOIGIAlisj/w8+of3Z5E5j6pFE/DHHEeSa/6MC9ACfBZpYhMBtFbbsJ76yiSG5dqtHlZC7Q2/q4rO2umLdr3cRhJo9I1uVElW2aTa0cWsFWRHXR4e9L01mvuA2+lwxjRbKQ5B3+6ozPFfRgYnuYK0kTm8gPFPEmQNpsWGctcYlQ3WR+fexqc+7VYi/jTv3GoH//nSkJMhn3NNxFqsJwfHiX4Gd9o3GueLXIBvUTxYxU1gv1sEGSb36d7KafmoplTjSfaFcNl4eyZOsfnLHJQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Wei Yang [241019 22:46]: > Current split would result in deficient node in rare case. > > For example: > > mt_init_flags(mt, MT_FLAGS_ALLOC_RANGE) > for (count = 0; count < 10; count++) { > mas_set(&mas, count); > mas_store(&mas, xa_mk_value(count)); > } > > for (count = 20; count < 39; count++) { > mas_set(&mas, count); > mas_store(&mas, xa_mk_value(count)); > } > > for (count = 10; count < 12; count++) { > mas_set(&mas, count); > mas_store(&mas, xa_mk_value(count)); > } > mt_validate(mt); > > The validation would report deficient node. I think you can explain it better than this? If we fill a left node with the right node being already full, the split of the left node will result in the new middle node being insufficient. > > The reason is we don't leave enough room for the right node. The reason is we don't leave enough data for the node on the right of the split. The node on the right has too much room from what I see? > > The deficient check is (end < mt_min_slot[]), which means a node must > have at least (mt_min_slot[] + 1) number of data. The right node's index > range is [split + 1, b_end], which means the number of data in right > node is (b_end - (split + 1) + 1) = (b_end - split). > > Then the check between the number of data and (mt_min_slot[] + 1) is > (b_end - split) > (mt_min_slot[] + 1), which leads to > (b_end - split - 1) > (mt_min_slot[]). Don't state the code, it's stated below. I am still concerned about jitter that this patch set may cause. > > Signed-off-by: Wei Yang > CC: Liam R. Howlett > CC: Sidhartha Kumar > CC: Lorenzo Stoakes > --- > lib/maple_tree.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > index 1205a5208cfe..894dc5e9436e 100644 > --- a/lib/maple_tree.c > +++ b/lib/maple_tree.c > @@ -1831,7 +1831,7 @@ static inline int mab_no_null_split(struct maple_big_node *b_node, > * still be sufficient, then increment the split on NULL. > */ > if ((split < slot_count - 1) && > - (b_node->b_end - split) > (mt_min_slots[b_node->type])) > + (b_node->b_end - split - 1) > (mt_min_slots[b_node->type])) > split++; > else > split--; > @@ -1896,7 +1896,7 @@ static inline int mab_calc_split(struct ma_state *mas, > */ > while ((split < slot_count - 1) && > ((bn->pivot[split] - min) < slot_count - 1) && > - (b_end - split > slot_min)) > + (b_end - split - 1 > slot_min)) > split++; > } > > -- > 2.34.1 >