From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E682C282EC for ; Fri, 14 Mar 2025 15:33:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4167280005; Fri, 14 Mar 2025 11:33:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F233280001; Fri, 14 Mar 2025 11:33:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B911280005; Fri, 14 Mar 2025 11:33:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 702C7280001 for ; Fri, 14 Mar 2025 11:33:30 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6A53E56A74 for ; Fri, 14 Mar 2025 15:33:30 +0000 (UTC) X-FDA: 83220550980.19.745CB64 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) by imf20.hostedemail.com (Postfix) with ESMTP id 82F191C001E for ; Fri, 14 Mar 2025 15:33:28 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=jLXHOc3X; spf=pass (imf20.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741966408; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EQZ1hRUiUX1Uv5De+AMk390tcCYkein0nUGbYfp2WQ8=; b=SqHkfYDhQGQ1uEFMZpZHxmRd2oOoReWjl77qJ8MLLPC9/xQohlWmRt/VQS1gm6NSjupdG5 2Y792shp0B52spseubyC9sU91nsiEUQTAN1nWjarVcjgwd04a4ARtFOzpEKbEzzRMpwpG/ TzF4YZBnFty7mEX0sc4HhCMztDSZ/Qc= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=jLXHOc3X; spf=pass (imf20.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741966408; a=rsa-sha256; cv=none; b=x5ppSFbMc6PrxeTr6tawKJ3g0QEpbaJW0dZYfL4FfF21vvQrqf6iqH/AWdwA/Y+AG/9UXZ 5biNF4vRMgoOfnC72YlhuR1Cw5dcYNBe04OrjhWCq4ULbbWKzCncwhI4dD9ingccBn5eZL 1EvL3KWIfKES3T6yO1j8QdmhWesRGRI= Date: Fri, 14 Mar 2025 08:33:13 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741966405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EQZ1hRUiUX1Uv5De+AMk390tcCYkein0nUGbYfp2WQ8=; b=jLXHOc3XIQYh9KwNdMlyCf7igSJ0+ADyoqyy2+froIq3W+bd9up4RHC4gixK2/KleUBjfC +fDfEoKQNkRidYjQbC83Jp7Co8HS6aW22UwX1MeTJCCN46QMqLmOG/aUpO24oFO2YucoYQ zrWHVqQGmyL0prKATIFtExNZqr6NJXE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Sebastian Andrzej Siewior Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Vlastimil Babka , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [RFC PATCH 09/10] memcg: trylock stock for objcg Message-ID: References: <20250314061511.1308152-1-shakeel.butt@linux.dev> <20250314061511.1308152-10-shakeel.butt@linux.dev> <20250314114700.TiLB4FH0@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250314114700.TiLB4FH0@linutronix.de> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 82F191C001E X-Stat-Signature: 4y7u3f73g6d441qrfg1qayq4zdtrtbaw X-HE-Tag: 1741966408-357277 X-HE-Meta: U2FsdGVkX19IsMa64reoNebaOO49yQMtrmU1JLXBqv+nBqdqcVIP+N8BepfRz6LDprt9HUu+J5J/t3pvu277/EbVeMhpVbDOMeA4jSgAe4yAiBz81Hh2zPzvxg2H8vXjhiq/EkVJt2/O48NvIASbLT098AQH3gNReSndHy1s5zCUkkkbaiaSzeHe/eHj6qnCedZ+BmY68HykGpkN4C4pdW5WKz5IDe6Bwi2ZWjndsCpejfgByCElVJVwDo9kqR1cg6ZDPDO8x3ez8kPEgz9UzkoTzH25PwX2NAegY9w55j0eUqaZGXINFmyXery5tjgzZbhsF4dVAen8gMzICrLaT62d8Lg3sGliSgy2X5AzQ5j+XoQlP1b1nlC7pdZ0M1DbAqCQIrkAm3VP0Pv4nLyGTfAWMCc1LE9PwytMgSg9Nzr1Oq0DkqmyFxXt1U9FEZuLb31vE61216sbRgOqiPnHxa1/wPi4qgUHGUKAuruMYVF9QTBFas4kDnRTn/P7Ud+8+SR8X0bFKrGEjuMNdoXxJjgRrq4PThdN68yeu2acabbBqM3beNnszUQQOd2tujySG5hG0GKip7SruGVktRvYbPKamTU6+lEy8UzZ3cjtpnzyFIAShPrUBM3w8xnY76T5aCnYYTC4s+cWWaP6dnOyO1KHEd4sIqh/+6IEHaHlVl1pKozsg2s9iiqqlTIKS9LPZsRdi8rWPvVzNJy6qpvTgzaF5uky8yO5A1/N0cvu0gjeWSAGKVotdy7NTQRDSVXA7fMgmeAgjZ11s1uOkzXvykZcYVt7zvfxzyR/lWt9HkyG7UFpKLEKTgXwy2Bpw4JmeOTNFqcpUchykwIxT5CNYMq2J8E5+p/6QVex9cdPHQmpVx66LIzS7VDry4lkj3l1HbxV3fUAlui8WUckAgK3+xXH8TC3aWacAmLrJdMKOQ1Gh0wWMUnZDKlpU1HAdXq9U86Hak0O+8+EZVZsNT7 JKQsZzeJ rGoLyfVBk+JysIpjEfTPYFnQ38r1EfYzgUYWSlbnPj7lMEXtXnozCAXrU12fyPIZRfvWgXg5k+tFehKPZlyRsoxUkY42HBo9pk2Xcsu2y1Dfyrov54imRn+7AYbh+6vbD+oTlTmwO+j4i8HWuOb5oabjl6iGqHN0XEAlBqDQU64dIngRehVmqZGdeZmM73EwG4jqNi5P/Syl0LYTmGPvHGhc5OeJz1ZUQ/SHp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 14, 2025 at 12:47:00PM +0100, Sebastian Andrzej Siewior wrote: > On 2025-03-13 23:15:10 [-0700], Shakeel Butt wrote: > > To make objcg stock functions work without disabling irq, we need to > > convert those function to use localtry_trylock_irqsave() instead of > > localtry_lock_irqsave(). This patch for now just does the conversion and > > later patch will eliminate the irq disabling code. > > > > Signed-off-by: Shakeel Butt > > --- > > mm/memcontrol.c | 14 +++++++++++--- > > 1 file changed, 11 insertions(+), 3 deletions(-) > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index c803d2f5e322..ba5d004049d3 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -2764,7 +2764,11 @@ static void mod_objcg_state(struct obj_cgroup *objcg, struct pglist_data *pgdat, > > unsigned long flags; > > int *bytes; > > > > - localtry_lock_irqsave(&memcg_stock.stock_lock, flags); > > + if (!localtry_trylock_irqsave(&memcg_stock.stock_lock, flags)) { > > Don't you need to change the of memcg_stock.stock_lock? Didn't we > introduce an explicit different type for this trylock feature? > Yes, Alexei has already changed the type of this exact lock at [1]. [1] https://lore.kernel.org/r/20250222024427.30294-5-alexei.starovoitov@gmail.com