From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62A7CC25B10 for ; Mon, 6 May 2024 19:45:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D774E6B00A2; Mon, 6 May 2024 15:45:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D27776B00A3; Mon, 6 May 2024 15:45:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEEF26B00A4; Mon, 6 May 2024 15:45:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A17936B00A2 for ; Mon, 6 May 2024 15:45:51 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 45BA8C07A2 for ; Mon, 6 May 2024 19:45:51 +0000 (UTC) X-FDA: 82089001302.16.8C31875 Received: from out-175.mta0.migadu.com (out-175.mta0.migadu.com [91.218.175.175]) by imf14.hostedemail.com (Postfix) with ESMTP id 660C3100011 for ; Mon, 6 May 2024 19:45:48 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=HIkl+1ZF; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf14.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715024748; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m8Yi4qyNfdzjVzdp5Kazo/gjP3lcaKnRlQW++lDgnuo=; b=twNAkVGT8mPrdSIFlDjTcf/AVsMXRU0VjK/ghu9N8n9ofXnmHhgSzBmkH3Us2KQOnlDNzU KIHOkvRSovA79x7C98gHzQtsoxftpRu8ElnrTPegXYrD/BtY9FqCJTuw+Ov2C7BwPdhLu0 dERa5ulceMesfNaLxSq2USVXoYin4kk= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=HIkl+1ZF; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf14.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715024748; a=rsa-sha256; cv=none; b=Q0B7Q0d1iUEwKh8ycjv+LXZmRu7yhzwMmB4rgEzPq7XA3Y3tYt0HYyROZzlj+GszucLWhU ZS+Pgj/z9qTr0lHyg8GfULcqbzEoWVyEZlVx4zi22ici2WRhYEw59IXOa1RapkeOAGp409 R6rGc1VneIJIErY1VZIFFtbfvzrBxX0= Date: Mon, 6 May 2024 12:45:42 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1715024746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m8Yi4qyNfdzjVzdp5Kazo/gjP3lcaKnRlQW++lDgnuo=; b=HIkl+1ZF+1+94HNPJyXD6Uip8vqEnrraN9iTj7qlY5GdlECVSarQLnutAtdAVGKWHPlMO/ uF+o1UVM038jWPB+LSQHPooKQC2/e+uJdVGb6rrx/hWJgJ6a2ISJ/3tw3yXY6NeEE1rKfN 85oRK/aAIitnSwkO8kuj5KxYRvMLdrQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Ivan Babrou Cc: Jesper Dangaard Brouer , Waiman Long , tj@kernel.org, hannes@cmpxchg.org, lizefan.x@bytedance.com, cgroups@vger.kernel.org, yosryahmed@google.com, netdev@vger.kernel.org, linux-mm@kvack.org, kernel-team@cloudflare.com, Arnaldo Carvalho de Melo , Sebastian Andrzej Siewior , Daniel Dao , jr@cloudflare.com Subject: Re: [PATCH v1] cgroup/rstat: add cgroup_rstat_cpu_lock helpers and tracepoints Message-ID: References: <30d64e25-561a-41c6-ab95-f0820248e9b6@redhat.com> <4a680b80-b296-4466-895a-13239b982c85@kernel.org> <203fdb35-f4cf-4754-9709-3c024eecade9@redhat.com> <42a6d218-206b-4f87-a8fa-ef42d107fb23@kernel.org> <4gdfgo3njmej7a42x6x6x4b6tm267xmrfwedis4mq7f4mypfc7@4egtwzrfqkhp> <55854a94-681e-4142-9160-98b22fa64d61@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Stat-Signature: 4dcmb3e6j4mues4aq3ni8aax45aipuhg X-Rspamd-Queue-Id: 660C3100011 X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1715024748-440800 X-HE-Meta: U2FsdGVkX1+OwFphuVjynm5DnRVH22HfSKRk4Qx6KDTG9VFUapEP6Fn7d0jJlihfwjL/SV2yN+gPtCOLFGg1EboyEpo3SEYmMptdf11dqWz4AFiORn8vtgOcwLvstM+DqEGY0zlTCUhnBhnjc7ByxRWvTW6aU602RSmAdqS+9CjmZcfR2x3Dvw3I60avvrAQqpTXc93iiBFzgow8pGGiQDCwwDGltR/RdgufHzkBD2LcftvCOi8lfRCnqtYLkXHuUPuof3iSYatZfXwRy31uwr61CK/UkR/RCpxLSgbPVgamAADDcb2iVJgxpXdn91p3yiaSFz+kjs6irAG45W3Ttz/yzcGWAYZwsyZ939OJ77oc4WlBi198l59nVsybGWHZMAJfcYSSNh5LcXf/rYyPnZijBu7tCTIS0+LkRDmbznpMOTfcN+w84e0hMBvdiy9ghp2xbjYs23mluApOf/66XcZs/Z2E2Lj0Gh8Hu+XGxfHmLg6SXMVLdWuaB77v23B/fIH0vdKjSu8IhCiepxY1+EpEpwHzrHhHwHSRJUPdQYY7U6Ti2dEKaeMYIv6dkz963ZzBcc5cHx3IOgpW3ejSlspXKU9NJ5rEgBJ4hHQ5YRbW1god4I0ESwt3Yvq6iZPk/TTkDqdqnDRY8fbp9trKunaKkntCkjXtrkJGAPhCguoMfXKTxvZz7EpB6fk7KIPFveJvIiKsvTUtZbJwlSRbOoTZ/Aj3YyS6xpuqrzLtCsk1AWFeG40wiYo8gZGra2W0mDBN5b04zXXc4ZVqWsHUupLgiiMclOUrxN5nlnWxdt8aZfoLQifAt05NbMyJ79C7zkFuAN2D1vqiOThFobCviW0IGyac5KMeXM5JzfU7u2nEbSzIU7e2KNZkC+Z6+QZP5QQmJgVqkmE5bsnK4nthaWsU3Bkf8kMLe32e2dTTS4iDFBntwRZLQSz3rDPEhne6rl1GuHz74AHwtV6efy0 Nr97aW6E 42aK7Fs3hhtBCUGkgK6yljrLNmAo/PFTupTtQpP5LBScTcQnb7nuZ9A1Nm1t6qsvDg9GibbMp7UpSiL+zCMPoxRdE34fdxoUfGMuGVNIMJl3REKFhsvl+nKbjbrstIOl+EIzS/0+YHsXocsWIuAYZIuUSTtkYKspWQlVFjrfNsf4PYU5zJXYm+CsRNjKXbJJZpDpoZIApBhWGkB3IzWkVMf7RAR97GyjLHzkrfzLWM1yy8rPq4+YrVV9v/g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.016395, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 06, 2024 at 09:28:41AM -0700, Ivan Babrou wrote: > On Mon, May 6, 2024 at 9:22 AM Shakeel Butt wrote: [...] > > > > The reason I asked about MEMCG_SOCK was that it might be causing larger > > update trees (more cgroups) on CPUs processing the NET_RX. > > We pass cgroup.memory=nosocket in the kernel cmdline: > > * https://lore.kernel.org/lkml/CABWYdi0G7cyNFbndM-ELTDAR3x4Ngm0AehEp5aP0tfNkXUE+Uw@mail.gmail.com/ > Ah another thing we should fix for you folks. Is it possible to repro the issue on the latest linus tree and report back? I will be busy for next 2 weeks but will get back to this after that.