From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20F3EC71135 for ; Thu, 12 Jun 2025 02:26:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 992746B007B; Wed, 11 Jun 2025 22:26:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 942D06B0088; Wed, 11 Jun 2025 22:26:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E5B26B0089; Wed, 11 Jun 2025 22:26:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5FACB6B007B for ; Wed, 11 Jun 2025 22:26:46 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 02CD21CACAE for ; Thu, 12 Jun 2025 02:26:45 +0000 (UTC) X-FDA: 83545160412.21.F9839B8 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2080.outbound.protection.outlook.com [40.107.237.80]) by imf28.hostedemail.com (Postfix) with ESMTP id 4BAB0C000A for ; Thu, 12 Jun 2025 02:26:43 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=izwy7DSp; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf28.hostedemail.com: domain of apopple@nvidia.com designates 40.107.237.80 as permitted sender) smtp.mailfrom=apopple@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749695203; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zB0/jxoQma4/UCPYKsr7V0AJeuucsF5fey2OBWbiObs=; b=oFHFxrYgTFN9TZN6lMS4qzZlfmWhPpDeq9IoCDkR+SJP96sWA3wuOKqwNJNJOMj6XbKTzh OjIs/x2aa5BY9VraNxU6R2DYvRQcP2eUNpS8koTf2trPRP8TyA95KoA00imjebSvxqUbSn LLCiuoWbGf7s0D9Mrz2aUX+ARJDAPYw= ARC-Authentication-Results: i=2; imf28.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=izwy7DSp; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf28.hostedemail.com: domain of apopple@nvidia.com designates 40.107.237.80 as permitted sender) smtp.mailfrom=apopple@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1749695203; a=rsa-sha256; cv=pass; b=gZUn5uxqIry+Q77JJVw1ocVAmgH/+9izu9Fjzl8ZzUr38bPsPuxpllA0b78IqBkgyC651C Ux+8QYKDOa5UCpAGVh2oHzhfOEeKZwYgR3Ugr1uCalhY40pvlEfQJ+1aqIV8BZdW/s8o2t 9aDjeJgAchFN7k4GKpu50ObrgvLkGbQ= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XiaQEUcEIz02Pk9ggPER9FTq6Nui/QgwJ8OAOUSrJqMgax79pp7ht48NVddd7yqvK6nqFOXXqihCcDQKYOjPdt00QhtFVzPuu+OwWJKTMHbFfUNGrnjyxkfvLmGpPpJjffHpMbo7LAtNxAqzjq9FqQDJv3ks4jrKHDReD1wsi+hp0ylivJbUnvP78HW3pcWnaO54DFXN87L6ehmMUhlBAp/2YPcx79kgS1n58PZG+EMLNDVZHBfBDcRC4mn/KIBwpMAokk5vu7z3Z3Du9QegTLBrKXUG8Eq7an0ORN9MxfFvxlCYsr5SvdW2ZQANeGP+vHb+yE6CYBHartvzERwXNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zB0/jxoQma4/UCPYKsr7V0AJeuucsF5fey2OBWbiObs=; b=k9fo1zkE4+Yr9LdzK2gCYI1bF+DygUs2cvLs9bkv2NPZm51js1ghUXzLaw5mFYAuZKt+ePP/1wZUWS+Ea+PUsxHESyQwV2J6NU2rA8Af8g0VlaX7E9K+m3hPo5559atSFO1TA4c91vvTP4PzbxmGknXpB/1KeIAhNiUj0jp4XYSvECgtKCm9DEhUtFMGeq5R4rHq2o2V0GtDU3EAmSIe2V3L07tBIxMP7r/f4RLrRLwdraV7ozcpWe08ydG0GrRIz1x9Eij5h6ovdFUvng32B9HR+pCzWJ47+e3qHr4Dc6nP3gboqV5yJA2NROogU23nSLyufLEVvw2ME2RxpjVX8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zB0/jxoQma4/UCPYKsr7V0AJeuucsF5fey2OBWbiObs=; b=izwy7DSpih27TxLzH9oXcpuYHIAQFh0pp4cW4HBujy3S1sEWYwREMg5zVkRYbDJpsgq7C48lD4MiwwO3JEPq8njDph0gxS931I+K99STmeEFicnaGptyziQMp2GvpREKDBJzDGXmUyEGnR4rt39GLgGipU+o0o2OZfasPN5Fty0bl+fFcTDvBHtFhkT3EkJUoDd9svjNXdS/58fZxNUunYtd/nCPGUVNwVumzQEzWeSWaueYf7fPaA/i9Tnq1QH8sb2w5vplVsBx1z+fUuQWOAcqDn4+TUcxWEzOyYNw5YxBJ/tSXwdQ7OYGTPLdw+zr3rwGEqM4KUHcqV4/uanRQA== Received: from DS0PR12MB7728.namprd12.prod.outlook.com (2603:10b6:8:13a::10) by CY8PR12MB7609.namprd12.prod.outlook.com (2603:10b6:930:99::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.19; Thu, 12 Jun 2025 02:26:39 +0000 Received: from DS0PR12MB7728.namprd12.prod.outlook.com ([fe80::f790:9057:1f2:6e67]) by DS0PR12MB7728.namprd12.prod.outlook.com ([fe80::f790:9057:1f2:6e67%5]) with mapi id 15.20.8835.018; Thu, 12 Jun 2025 02:26:39 +0000 Date: Thu, 12 Jun 2025 12:26:34 +1000 From: Alistair Popple To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Dan Williams , Oscar Salvador Subject: Re: [PATCH v2 0/3] mm/huge_memory: vmf_insert_folio_*() and vmf_insert_pfn_pud() fixes Message-ID: References: <20250611120654.545963-1-david@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250611120654.545963-1-david@redhat.com> X-ClientProxiedBy: SY5P300CA0039.AUSP300.PROD.OUTLOOK.COM (2603:10c6:10:1fd::15) To DS0PR12MB7728.namprd12.prod.outlook.com (2603:10b6:8:13a::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB7728:EE_|CY8PR12MB7609:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f1791ac-6923-4328-895f-08dda9588f9c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?stLJSiOAokOAmxPAY1or7ComlWiLkmHbt3pz2rwwzA9dZA9JHWdkzRu/ouEz?= =?us-ascii?Q?IUREy5lf3LS4GjGSg3W6Q2g11ldKcJzMqvCgOmfiPHX8FyyAaWvQpwagp3vT?= =?us-ascii?Q?O3LsJdm92RnmXWlQMLVj0tD7Lhh0mhn48eHk46JR0MhQevbOhU+xyXMraeR3?= =?us-ascii?Q?Hib7wG0BCWQH5sc6eeeZmmypg682SgrdNFQCm5Tb0hEre86vVYpp8AF6U4jT?= =?us-ascii?Q?hDWF6fbxH27fOae1Gs7dnfZ7QQmBiU5MBLgxCpN9aXnzS39byhnELD6x4Jyr?= =?us-ascii?Q?aRCqRIQ9kiKMt5rwdMUNAPkQI1FdNfJcjSGi5hIcXA+3AXhQXnLAqQulebNl?= =?us-ascii?Q?xbUmHDbSJp1pJjAUS4lIsulQCHez6TRqizsxzHxlVFkHYg9qnlkVepHE2ZEp?= =?us-ascii?Q?rElPGZD0tWim6X6WUD4UvCduexXMdd1xTxfKBj7uVGGpJXXH5nBcYoANFZeR?= =?us-ascii?Q?7Y/H/VdRr5vimAAiNINQ+gwGy1X6ctQaBWigmfRaupXHTR5NaCSK9iZlkXKj?= =?us-ascii?Q?PVz0jvQRF+AMS3JGwXIOJ62+z+sZzUBGnz2Bo2IwoMHHMyEBfpe1TFUtQg+p?= =?us-ascii?Q?/0JUCIY2EaXKoFjDVqT8kW5Z+q3HOqjcRiPj9F63jaQ8ooE8vDOaD7nW21gB?= =?us-ascii?Q?ZERkYX6/Z9u/tsvIC3teJQNCb/IssKBf5jELjjxudUw/+FlcElEYLwlDvHNa?= =?us-ascii?Q?+HAlj7M9mt5jxe548PCR33OZAhls34ir2Sm5jtuk/hv+jDsIkMIc1Bq+cjpv?= =?us-ascii?Q?6FEzWbQ6EUk0piZaAZvVwACGkomMeI66+/GVNGjngjSkebsgHMZdIzROyzt/?= =?us-ascii?Q?L1tp5FEpyWC9urdaVEnjxXeK7LyqpeJO+pvxZIzH9gPHM5qtM5HUb1kL5xbY?= =?us-ascii?Q?nhzGCYGZnj1FfW/SPZ2jGaiXzXuoZrhbVhMV137tbmzvaUjPPfWcSzkeQlcG?= =?us-ascii?Q?mS3ln0a/nBrHdbaYkOtAwFvnLrkB80kQ93iR5wO1qr7nwoIbnJzGCApc43NQ?= =?us-ascii?Q?rSRbdWJcc/KvECEgniw5d9zFC/aZ/DHmH6sIKylCjGSxstYze/p7cGu3oaRC?= =?us-ascii?Q?3ZFArkVnpGMM5ByrtQYuTl5wO9E6ZgAUwCutKQj9k8YVKOfL/UZ+4MeXfy78?= =?us-ascii?Q?sDTG4WzR+yKpCwcs9XYkeiEomazSb6H1Ho0vWxlB5GKhijpyiPhMs6tVYj2M?= =?us-ascii?Q?rxj5GhHgoTFPhdypAYF0tNSpLY/Ns0jZ3VlQKNvuiYDwQBUjo49OvWabsNEA?= =?us-ascii?Q?OHxuQ4ChScHWawmIbQMe2bfb+NBD2L4aDZEFdqG+gAfGkbSfldxgmHVrVjzI?= =?us-ascii?Q?kTOR5U+w78yxY3EUeOn34cBBbCY98tF+mJoWHlqgwe8AtiRgJbHDUaXXeGc8?= =?us-ascii?Q?4GzSVaVusUkXy7QLJjc5fYrdZr5caCHokOiD6MxQwo7YPN0OGhVc5xvTTLlP?= =?us-ascii?Q?qT0BVMxRDNo=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB7728.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yvSDFopklreaLGyR3Pqx8WNa/KhKgVP+jXciU156EY2KXWh2xs1y3bKPuMcN?= =?us-ascii?Q?oeK5KXB1JBb4s9+6vMjbX5xdj6j1GFygSRdruKxosvoOU8mI1DYbY3ZXB2A+?= =?us-ascii?Q?kDJqikkY4SP2TYBL0Sq5S0z1EoUD6JQSMH6s/rFaInRCv+q1/48vTDIi0rb/?= =?us-ascii?Q?t+sSXSANNIMIg8ubcS4AuCsGW4+7fj7f3fiWrwJ6FCC3q3OHr1U+NdryPmgE?= =?us-ascii?Q?tb3nVe8U02Z4F018euybTnBQ1eZkVFGER9IBC0qKWgMNXO/rxkjFxFmPxSdz?= =?us-ascii?Q?ZL52scq7FQ5Oy/uY3x2bXaeE4SihmtezAMgkLtTQkV03u0n+BppmhvOaxC6X?= =?us-ascii?Q?JrNNeUkVc8kpf02OBbsmfiaqhNrlSCJXNM30EhUx3J0cynoPMLulzA27uaPm?= =?us-ascii?Q?lJSKUoDv5nAKVXIMe4YBu/wAGR6gi3V0rdXQ0egjCDQw2MQQPRbyeTAmwgEl?= =?us-ascii?Q?bIxouLxnpCqswrRYoRMl232RChK0Uq8dOLWm6qSYQlipZCT111dcBaMSgpO0?= =?us-ascii?Q?0c8QKZvmhGmQOfnxPU6OTLSwiO9tZ11MkHhMVKHyiHDt9Q75vL2o4Y6lGnYX?= =?us-ascii?Q?56gqXssO7M+20Df79FsW9htCn7pQn/CQTkJhP5mpTr91LGpEk7cCaF9la/c1?= =?us-ascii?Q?v1kkA9gLPfZWoVctjTMYZCnW9KZjxk7BYrAY/IOAtOyIAkbd+25YIdzbhxD4?= =?us-ascii?Q?yu+h6P0v3HX4/83WF2PDZ5BJGWb6UUCJ7EYzgk2YtK4L90G7lQmX+JOkkDHe?= =?us-ascii?Q?hjgtULZEy0zykwF4Ss3sIpCkfWnBqS2EIlTpf7gsYyxF719wJTDxo/vRYYoA?= =?us-ascii?Q?XgEDrNyIyyNIz8hWZOQDXD2EEaY6Iu+sIqZi9dv0UlPkTk7bKdbKIuqUfuGw?= =?us-ascii?Q?H63M5l8nCwW8QJXpM65Y4c0BjzlXFrOoL0ZyiZxoVeCo6lN+4kvjZPJjuyHL?= =?us-ascii?Q?UZ7SfbAaciiDoM6L48/OeDt1ox8EUahyJB/QpmhB/Enxz1R4L0Mp0FKjr3FI?= =?us-ascii?Q?08kZ8JqA1/39NH1zaUGlR/MNoj78dBokVah9oG+hOFtWumGBe7PFjY1Xlad2?= =?us-ascii?Q?c8uoLeaTZq0HFbo2cFU7+8zmlMmYfRAK23s3LIEC/Ss1LwgHgZXtZwBkcxv3?= =?us-ascii?Q?JgE6/oNnj/cb8sbU+YyrNREg5H/0VncAQhV2+phpQuKH316SuBA6GnLLhQTl?= =?us-ascii?Q?eZ2aPw4ieoVE9VoL3atslXfOGK3MdSzT7l3abpSvRkZvvSPPxvXmfUH84hEh?= =?us-ascii?Q?ddnjEyJGOooKeYeLtcYA55VYveSHyyFmT1u20oQQvrpy+5YtJTjY1snB3tkz?= =?us-ascii?Q?jq4hFoXSHygf544rm8acvQr98QWZuvuj7y6FKERBtJKCE5T1zGxEFuNiegH3?= =?us-ascii?Q?tY95I7NQsECRaAp/or+3tw3UBrjDQgIHAuyCY/thExwNUNlZvVK4MbUH3KLq?= =?us-ascii?Q?gX/0Pka9w0BwSYQRzs3gPAl4Vag/XbSlTjFop5Tdjjh/e2G7RNZlXyYhSEU1?= =?us-ascii?Q?ZqWgHxR5HHCEh8toGoFtsUoZ4nFmo3seUhCLzZshT+yCsDhGuVcsIFimnKa8?= =?us-ascii?Q?7rHud48yrqAI69r0zdJDudcdbfTyetwkWnYT9evU?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f1791ac-6923-4328-895f-08dda9588f9c X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB7728.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2025 02:26:39.4538 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KlxFAe6UlwfktbMGQP33p/AfA5ESB8Z+KyLkN875lgYC/GtxzrkbWQCBh7lmakZ6DSYPiXqY2ATL31YjOzwGtw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7609 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4BAB0C000A X-Stat-Signature: kjohpq1pz1ywoounox8iiubq8u937pm5 X-Rspam-User: X-HE-Tag: 1749695203-243638 X-HE-Meta: U2FsdGVkX1+mI7SHToPSE7DQbAxmROdOBYyzVNWulIDMjTA2E1CVmDqXut0SisPk1n4nzPrCnwyL2GaxGpAoGtAubygTdfeHCTsHlLzgcd12HwnYoisl4tizKIltIV3sVZHMA1ZISo07RPPx8dO2FRRZ4wKBcDw0Uzt8Pp8ccY+yYxDZgPYvI9evG7ppurchW7eUuXFrSSNOyax54V13jpEr73LObRUJAADECd1OL+pOUK9SXEJ5eGsMJWma0cvU7XDCMAOKlgvdpgCBFTjR67nh2IWcno31aFivUYMji0l3VDZs7FoOMrS5W74j+0VGcrwznBk0l5VnG4KxC4WAUPsq3j5L4KjQd/XyPMdM4wskGBMM9CJkSc4xxWxOppJlVhX5Bt12Ks1ndJEzj1ZZAnTUXKb8GZ4gc0xLCbvNdRHOseADwV5coaQpGpQGPJC2ZDTKPgCQ+PhtKxj2iJzofMJZExBhH7f0syFi+Op1zQHuvrc6HbMfUs8B5LoxvNfARz7HUxQ5jmTxhqK3g1376LisegkGWWgM9PsHh2BfZZFpNVmzMKNKyYa9N3GaHk1t5iHtoxYqdUYyZZxn2RwVeH51zZRDqBhrF+LcTb0Kgeo8f9oG7LM4IlAkar6v1u56s2oHqxgug6/C2al+LWVA/rdcLyFeMFXHBsI3xi/1g0KAVW2dCw2/2adQvXkYkDYfBKQUMVAsjnr5udsCtBz1hkh4SPTimlUCUP/h0vaKvXN84Z+ajIzcG8P6DNdns19iGdC8B3j3X66tAvZVcQCEeEYBuohlyrC75HA867Jq62os6HG25oBHsh/lSeJ6ptcAo70/xncZl1Iq8+nQggxu1QTmTB38p0ed0ERMf9ab7Qvq3jaPXmc5E7+UA+sA12GriMMfSgXfEnH6UgR2TLOmVCNIrQKMVmqciJBuk8DdQnjtR1hWucOaOF7E9QFMUOWaWukgN1oW07nVzdWDg4i Cy3BwEAN eiYRMSkVRHPkdiMZix2pjMLJQV2bfkVsoE3pumyR1wsZfI5XUoZD3qq5F/F2bscyyN+UoG7PubjgoRx104ue1ipaZwepoQx3XVKL/EKLt7JDUrSF8wkfNvYuZ9QH3F5F+mw1QVT9YTpd+WehLBSJald5kXet71K6wvsRmWnE8KM+qC7oqo1/X4A6scDFwF3llW7LssAhX878yrW34/FOWPYAtAzOe1emBttBnwtVCRp7dGwrHAfoOj5HisVVg8uJjFAdhWHPRC9PMxi9yriZGHiz1U7g3tCMMkWiv76LLM+5PWDH8t7isEAN1G6+8eNbg/n1t0BslE8kiTWoXCEkViyH/GJ8ShHmdAhP4vdLOXo593fNni1PQ6RJtJJgq2PZrGDDbsGAISHFhS7HEVCfVZFzrACDfP3+8kUcpISDXFQDRIM1bapgH/LUwKT4cl6KQK9L8XstRu1X47/Y3x7amiLq23vesNAzNQ/O8RS8z62W4/7njaoWtIKqyQicTzojuTyW4aY0KTUYxp+rQVUysiXp5Go/Yd4O5cVLmvejUwhqCjDJezl5uoO1Q0DIcWwA8BJxBu8/uWhnmaD8amENw2n9gbjlH96oQJn+DBDh+14ew5sPzQrZn/BRpDce8jmtdwUTvmgzZ4hwFU9TiwGFnXqouW7p5lgKzi5ICpPVuLeu4T+teLI18b4Jft5UDl9zst1pRr5XaYlgKgWQWoxphRI/9Cgi3oMLLN1S9iSSIGU7Xa1LsNwqM8s5YwJpKMglUVXkWs8/MoxAo4xN63dhFu2IrxndrTyQTCWlLqLufB0D3qNavPxAH7ymzG7GVz8ag5e2x0GlPHfFtrTKZnAtr3SVtgg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 11, 2025 at 02:06:51PM +0200, David Hildenbrand wrote: > This is v2 of > "[PATCH v1 0/2] mm/huge_memory: don't mark refcounted pages special > in vmf_insert_folio_*()" > Now with one additional fix, based on mm/mm-unstable. > > While working on improving vm_normal_page() and friends, I stumbled > over this issues: refcounted "normal" pages must not be marked > using pmd_special() / pud_special(). > > Fortunately, so far there doesn't seem to be serious damage. > > I spent too much time trying to get the ndctl tests mentioned by Dan > running (.config tweaks, memmap= setup, ... ), without getting them to > pass even without these patches. Some SKIP, some FAIL, some sometimes > suddenly SKIP on first invocation, ... instructions unclear or the tests > are shaky. This is how far I got: FWIW I had a similar experience, although I eventually got the FAIL cases below to pass. I forget exactly what I needed to tweak for that though :-/ > # meson test -C build --suite ndctl:dax > ninja: Entering directory `/root/ndctl/build' > [1/70] Generating version.h with a custom command > 1/13 ndctl:dax / daxdev-errors.sh OK 15.08s > 2/13 ndctl:dax / multi-dax.sh OK 5.80s > 3/13 ndctl:dax / sub-section.sh SKIP 0.39s exit status 77 > 4/13 ndctl:dax / dax-dev OK 1.37s > 5/13 ndctl:dax / dax-ext4.sh OK 32.70s > 6/13 ndctl:dax / dax-xfs.sh OK 29.43s > 7/13 ndctl:dax / device-dax OK 44.50s > 8/13 ndctl:dax / revoke-devmem OK 0.98s > 9/13 ndctl:dax / device-dax-fio.sh SKIP 0.10s exit status 77 > 10/13 ndctl:dax / daxctl-devices.sh SKIP 0.16s exit status 77 > 11/13 ndctl:dax / daxctl-create.sh FAIL 2.61s exit status 1 > 12/13 ndctl:dax / dm.sh FAIL 0.23s exit status 1 > 13/13 ndctl:dax / mmap.sh OK 437.86s > > So, no idea if this series breaks something, because the tests are rather > unreliable. I have plenty of other debug settings on, maybe that's a > problem? I guess if the FS tests and mmap test pass, we're mostly good. > > Cc: Andrew Morton > Cc: Alistair Popple > Cc: Lorenzo Stoakes > Cc: "Liam R. Howlett" > Cc: Vlastimil Babka > Cc: Mike Rapoport > Cc: Suren Baghdasaryan > Cc: Michal Hocko > Cc: Zi Yan > Cc: Baolin Wang > Cc: Nico Pache > Cc: Ryan Roberts > Cc: Dev Jain > Cc: Dan Williams > Cc: Oscar Salvador > > > v1 -> v2: > * "mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud()" > -> Added after stumbling over that > * Modified the other tests to reuse the existing function by passing a > new struct > * Renamed the patches to talk about "folios" instead of pages and adjusted > the patch descriptions > * Dropped RB/TB from Dan and Oscar due to the changes > > David Hildenbrand (3): > mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud() > mm/huge_memory: don't mark refcounted folios special in > vmf_insert_folio_pmd() > mm/huge_memory: don't mark refcounted folios special in > vmf_insert_folio_pud() > > include/linux/mm.h | 19 +++++++- > mm/huge_memory.c | 110 +++++++++++++++++++++++++++------------------ > 2 files changed, 85 insertions(+), 44 deletions(-) > > -- > 2.49.0 >