From: Kautuk Consul <consul.kautuk@gmail.com>
To: linux-mm@kvack.org
Subject: Re: [PATCH] ARM: sparsemem: Enable CONFIG_HOLES_IN_ZONE config option for SparseMem and HAS_HOLES_MEMORYMODEL for linux-3.0.
Date: Wed, 24 Aug 2011 12:31:51 +0000 (UTC) [thread overview]
Message-ID: <loom.20110824T142225-279@post.gmane.org> (raw)
In-Reply-To: <CAFPAmTS8-qQ4ZzBeJeKuG2jvyyfkwnqbtSjPX2TLddDPtSmF7g@mail.gmail.com>
Hi Mel,
Kautuk Consul <consul.kautuk <at> gmail.com> writes:
>
> Ok, I analyzed the code and it seems that this alignment problem has
> been solved by the changes made
> to the free_unused_memmap() code in arch/arm/mm/init.c.
>
> I backported those changes to free_unused_memmap_node() in
> linux-2.6.35.9 and I don't see any more
> crashes. This solves my problem.
>
> Thanks for all the help.
As per the email below, you might remember that I found a temporary
solution by back-porting the free_unused_memmap_node() function in the
arch/arm code.
The original issue was a crash in the move_freepages() function.
The crash was happening because the pageblock pages was partially
within one memory bank.
Can we solve this issue by modifying the check in move_freepages_block()
in the following manner:
if (end_pfn >= zone->zone_start_pfn + zone->spanned_pages ||
!PageBuddy(end_page))
return 0;
This should take care of the crash situation as we will return 0 if
the end_page is lying outside a valid memory bank.
Do you agree with this change ?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-08-24 15:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 12:08 Kautuk Consul
2011-08-03 11:05 ` Mel Gorman
2011-08-03 12:29 ` Kautuk Consul
2011-08-03 13:28 ` Mel Gorman
2011-08-04 9:36 ` Kautuk Consul
2011-08-04 10:09 ` Mel Gorman
2011-08-05 5:57 ` Kautuk Consul
2011-08-05 8:47 ` Mel Gorman
2011-08-05 11:40 ` Kautuk Consul
2011-08-24 12:31 ` Kautuk Consul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20110824T142225-279@post.gmane.org \
--to=consul.kautuk@gmail.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox