Re: OOM killer, page fault

[Jody Belka <jody+lkml@jj79.org>]

Norbert Preining <preining <at> logic.at> writes:
> Don't ask me why, please, and I don't have a serial/net console so that
> I can tell you more, but the booting hangs badly at:

<snip>

> 
> > diff --git a/mm/memory.c b/mm/memory.c
> > index 7e91b5f..47e4b15 100644
> > --- a/mm/memory.c
> > +++ b/mm/memory.c
> > @@ -2713,7 +2713,11 @@ static int __do_fault(struct mm_struct *mm,
> > struct vm_area_struct *vma,
> >        vmf.page = NULL;
> > 
> >        ret = vma->vm_ops->fault(vma, &vmf);
> > -       if (unlikely(ret & (VM_FAULT_ERROR | VM_FAULT_NOPAGE)))
> > +       if (unlikely(ret & (VM_FAULT_ERROR | VM_FAULT_NOPAGE))) {
> > +               printk(KERN_DEBUG "vma->vm_ops->fault : 0x%lx\n",
> > vma->vm_ops->fault);
> > +               WARN_ON(1);
> > +
> > +       }
> >                return ret;
> > 
> >        if (unlikely(PageHWPoison(vmf.page))) {
> 

Erm, could it not be due to the "return ret;" line being moved outside of the
if(), so that it always executes?


J

ps, sending this through gmane, don't know if it'll keep cc's or not, so
apologies if not. please cc me on any replies

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>