From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D908DE77188 for ; Tue, 14 Jan 2025 21:55:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 717DA280006; Tue, 14 Jan 2025 16:55:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C843280004; Tue, 14 Jan 2025 16:55:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5905F280006; Tue, 14 Jan 2025 16:55:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3A00E280004 for ; Tue, 14 Jan 2025 16:55:18 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C8C82140DB4 for ; Tue, 14 Jan 2025 21:55:17 +0000 (UTC) X-FDA: 83007413874.01.19E812F Received: from out-189.mta1.migadu.com (out-189.mta1.migadu.com [95.215.58.189]) by imf15.hostedemail.com (Postfix) with ESMTP id 4D5C5A0009 for ; Tue, 14 Jan 2025 21:55:14 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=lFWi7HBc; spf=pass (imf15.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.189 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736891716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x8ff54+0fr/9rfuy6Lml03OR+cA5iBkChIyVOWCs3ew=; b=lke0AV8OcMzRtv1uWPpmv5E0j+DmnIs2MyOSwFUykmUo3qRIlDzQRspHyTQcg0ZQGr2dmN tgywaSu282pJ2iRXuClullH3HvR+JCBtg3hPu1nhMmHGD81zDtg2m4WznG0GghSg9VihSR SPmFzacXeZfGXX54Wnb9biCHauG1OIU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736891716; a=rsa-sha256; cv=none; b=HFRkk/8hTCAqFdzFuzFWQEn89HahyVDQY1SDzIv847KLxnyViIg+mvnm8scHwFsfxV1hAh 19ivQKDMLn4EBktIhhJDRrBW+Nb6PQV+kS9JibNo4fw9FaaywT5zyokbMQCllUEFSD7TV7 SQUZ2x+0lxAeylVfOX/XHcJLtk8Jnj0= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=lFWi7HBc; spf=pass (imf15.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.189 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Tue, 14 Jan 2025 13:55:03 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1736891711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x8ff54+0fr/9rfuy6Lml03OR+cA5iBkChIyVOWCs3ew=; b=lFWi7HBcEa0O48lSIqH3GtSNrFdpPHFD1wnx5TSdgENpujqhwGeEt6HMG97jVEYWk6V3vN 2tmQoL+dxINOjUb2itfapAtcehMSrsSeai2TKMb8bAOV62gN8SsN4arVRS8kdiIAZCpYRc AH8/yZ7zHxBmfm6oxHASIhWQ5NkEHOg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Lorenzo Stoakes Cc: SeongJae Park , David Hildenbrand , Liam.Howlett@oracle.com, Vlastimil Babka , Andrew Morton , Jens Axboe , Pavel Begunkov , damon@lists.linux.dev, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH] mm/madvise: remove redundant mmap_lock operations from process_madvise() Message-ID: References: <20250111004618.1566-1-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 4D5C5A0009 X-Stat-Signature: chm43yparrjfaoctyhg59euqz5ahw6pn X-Rspam-User: X-HE-Tag: 1736891714-711713 X-HE-Meta: U2FsdGVkX19cpznepin57fjWIG2AkjKUQ7MwtBDhm7HTvGDMKFMhlgA56yQH/I6x/xmJsAvxz5FAqfzdiCUI4+6DGtEk3sKF8uKPxRy8oU676tnBcV5g5H1bnr/oKb2+OBxbz346/tM9t40qvDQv2U7/CS0iMalvTtbqp4f57O74fS4ue3i+vvjyd3Y+Loh15RU7AvDrQd1GVytPQHwbVWFLschvNmZi7sRV3a89V45/lgpDVHVJiCSp3fKeJe+4lJ1zD7m0gK8Q/DpGqhKkcjJNwwagBGJ1J/UcmafwuTnpJAE+enWfxogYDqTT3bVGiyKoL+ft7nlTOD3w98FHzk7a6NxjVUWNvcmBc01tNC/NisEi/gb1gGw8XAYGiD24RN0uRQgLlnQtk2IapBjkOjoEfFbF7I5earUhptx3LmFw9gNx2sdkBbyJi66mMtxNdbsly+74Rwu7aZanTvK4eg1Mtra1vN/i6jahNdsETRtAzS+REqEtl5AXzTGQpS+sX9BMijhu8eqPO+86zpmxe3NJ/4Q0/Pw5wLP2o7xhqbayJDsEIdRsAaordP35LcnsMs0+2X00Acc/DVltbGfmOCM0twaVO+TTkk5uV8Yq0Qr99jzFZdZo1rqSuvMpBeaz+XnKn+pE/b5y1kyz6CueO245LQaRgZHEn/k0aKn9etJat6p1NDr6ul5IEuvm/n9wakyaUIQRdOGvU3Neacy1cocWrPbj8Ic3d+rUSkAoyf7Vs6IFtb3Oad4NdswE4tiMyo9nu0IDkY11xAFcCoGukiZVIeBFQFOuERqRky0RNEOQMWG7/A7xzS86G1PaQAxV1x2WpiKY2pmBGUjDqmo3BUYLbL5h1goOnwBHjS3IRKYGHRqDLyq8OB24DmU+txTvLtm72OjS01uzLRXZXmzpQt+d03oS7QkB9ajFy3xt1eyDHpXNGo17LxEiHzvWr1aVW+1CVXoMkkcd7cYpv/b VQP2HoId XF7Qt1YzOapVqigjwJ5l7tMVKl8N+calcBU08iHhratavDi9agAJjr13L59AF1vwzd+WgCH4q3onqmeSt2d0oFhfEMHIWM0Yu8+bDHK2svVd2FjW6btaWF4d8ysl1zko6oP2nYKy+ThttTnnemDYNLx9Y+5yKhIj4emNWzLcisRb7l9mBS7IpjkoD39vxvvxIdAKWDpbTX+B5SpCWHzyWrRYlK90a2xj8Vt0Bp8w3dXwrnUtWMWFvPbw3Z7jUuxxov/7wFV9gcLRFfig= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 14, 2025 at 06:47:15PM +0000, Lorenzo Stoakes wrote: > On Tue, Jan 14, 2025 at 10:13:40AM -0800, Shakeel Butt wrote: > > Ccing relevant folks. > > Thanks Shakeel! > > A side-note, I really wish there was a better way to get cc'd, since I > fundamentally changed process_madvise() recently and was the main person > changing this code lately, but on the other hand - > scripts/get_maintainers.pl gets really really noisy if you try to use this > kind of stat - so I in no way blame SJ for missing me. > > Thankfully Shakeel kindly stepped in to make me aware :) > > SJ - I will come back to you later, as it's late here and my brain is fried > - but I was already thinking of doing something _like_ this, as I noticed > for the purposes of self-process_madvise() operations (which I unrestricted > for guard page purposes) - we are hammering locks in a way that we know we > don't necessarily need to do. > > So this is serendipitous for me! :) But I need to dig into your actual > implementation to give feedback here. > > Will come back to this in due course :) > SJ is planning to do couple more optimizations like single tree traversal (where possible) and batching TLB flushing for advices which does TLB flushing. It is better to coordinate the work than orthogonally repeating the work. Thanks Lorenzo for your time. Shakeel