From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FEA0C369AB for ; Thu, 24 Apr 2025 23:00:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A0C56B00AD; Thu, 24 Apr 2025 19:00:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 950896B00AE; Thu, 24 Apr 2025 19:00:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F1656B00B1; Thu, 24 Apr 2025 19:00:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5E4A76B00AD for ; Thu, 24 Apr 2025 19:00:43 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2A61FBAC48 for ; Thu, 24 Apr 2025 23:00:43 +0000 (UTC) X-FDA: 83370458766.15.817D1A1 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) by imf02.hostedemail.com (Postfix) with ESMTP id 36F1B80013 for ; Thu, 24 Apr 2025 23:00:41 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=U8qVdmDT; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf02.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745535641; a=rsa-sha256; cv=none; b=ms9QdanmzD14WR7KLco1SqGGUBXYM91xC83KUSSpYAQF8LsPsXT+fJUr/GUOrBVRfNUA43 fixERFFjaXGyIeMRM9zKa4m7rp+YoMY7ETA+IELht7S+VLzND8gKYfR6LPe+7ZXStG08al ElxKtBZ+flr/A8ISR4LTniCudgjNuBM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=U8qVdmDT; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf02.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745535641; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RJVvQHLAm1I3auOzUVRa8UOMSKBiN+sklpD1+b2kdV4=; b=W901dT74JccACE23zsmV24zFmcf6WxR98Zbh5/KK7cxxevt2B3NQRzKIna1zEvPih0ghjB 7KHUPPmloFviWYr7c401manbTv08rHb+Twn779QDjT4sb4xaA4R3NAHpRdfYlg4LtIVk0w 6GnMKddlZiPHBgo5/ZsHK7cmb9Xq7OA= Date: Thu, 24 Apr 2025 16:00:30 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1745535638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RJVvQHLAm1I3auOzUVRa8UOMSKBiN+sklpD1+b2kdV4=; b=U8qVdmDTnXgyPjaOJj2SSPNteNgcAnqAj8hRfxofzZKxdBuOckUnzbmlqjFQihRGxq4/cp Z1JKuS2dF/qW6IhLHo6SsRT5jdTGSuwGSTHrcDvnvh+u+wHBx8mSIB2vQyn0uG7R/UqMI6 liq8C4bc/gCXL9ESX4+eiIFqNtHnGGo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Huan Yang Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , Petr Mladek , Sebastian Andrzej Siewior , Francesco Valla , Huang Shijie , KP Singh , "Paul E. McKenney" , Rasmus Villemoes , "Uladzislau Rezki (Sony)" , Guo Weikang , Raul E Rangel , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Boqun Feng , Geert Uytterhoeven , Paul Moore , "Mike Rapoport (Microsoft)" , opensource.kernel@vivo.com Subject: Re: [PATCH v2 3/3] mm/memcg: introduce mem_cgroup_early_init Message-ID: References: <20250424120937.96164-1-link@vivo.com> <20250424120937.96164-4-link@vivo.com> <2u4vpqa6do7tgtukqb7orgxmlixguexsxilhnsiwv7atssnht4@o4cwziz26wrs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2u4vpqa6do7tgtukqb7orgxmlixguexsxilhnsiwv7atssnht4@o4cwziz26wrs> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 36F1B80013 X-Stat-Signature: kgxipdtcot5bbonn7zd47irbd6stcjhk X-HE-Tag: 1745535641-458353 X-HE-Meta: U2FsdGVkX18xN/gF8pd+GvzZpMysPLFS64HBfUorGpO/okDY4aeXDhYW79xxHazt1xj4AAHLvGMWOilEi+BTjM1XyhNFKXNOCSn0ijiQnwPypIxKawQMXUII+ZtXAG54PQWWmIRscs0u2bNpYYk5bFeMWt7FJxoH4IVhzS8ozbOpXSIZR48LDTTP1kZP7rNJVk3ykxfNrl5v4ViL0B2+gqKgt/M8xsB/P1knE2OL9Sz5RsGpUR4hOgyNJPZ/lsbrjAxchbLqtyFudVV3eunim1lDw50ToYbiPF9AHU2XXHbzdT+AcVJhkt/HcEIK4TQi3l3OjGdE9zqABtObl0ONJsOt9cjDR4n9chMRxzbRYZWCBFSNmGnhHTzsnt/2w2238Z0Q3c0q2AZOWd7Cy1hyJY8xsdsBGRHoXeJchSGGp1ltLX2hx2OWlmG5MHeEFbwrcmQz0ZEc2Nw8JNJUdnvnTURXYJBmCE+VE+Fcxu545UCsgjKAjQyhyTFc0D8cFolJUdibk0NIfGeuUSrtGxkdiUuX5riMrV4dFur7BgFdiMvbgiBBmFmNl2pOpFIEz3PmlFylzBxem4Dt72ob1CxAYjugkrQ51mtKuRXqgt5ZAoi7OjIPMRBUZe6D767V1hbaJJi6GogNq5uzAuJVKhbgHOZc/1hMlWEzDUFroH+Dq75beEkwkvphOAP3TFg+9O5cZayBv9sGyeZaYLxvEfmUw2qqWn7rXxvxJxssLeVXjh7lzW8LPJt6ykdew7pcY0jrzfVuOfJnQVXtdsDja3kfUr5wgl4zNws6rA3H59Y7m0usMdF2xT6WMs7MkNd8QqwnidMTy1fL76aHdEgBKWQolpTC9N/ZSXknigwxiHgyNaN436kV8Ma0KtKcGrex6+acdzrqD5u4dK451tWwKyCdtSNZAFcD89un459sActUp9SqlKrPshAblIEN+wL6mmfjKxZQKpJgCuSvWKl2hz/ YK06QsEr 66ExcG/H0vY408NQraDfvIuJbxXqY0fw0f1W0jn5lo8q5v274jJEfjrPw9sB+sIvzh+UJMiqYHA4Dozl9GKTkQG4Op1nMpOGHYMXB5vCP5lmehHHMLNF89WNlxJPHZ83yVsCCS7IXDS8oDTJSRTXIVlLiE07Xf2E7K/4toEbJSeftIwJ4emcsZ5Cj2URrRUoYpA9fwfywrG1dTThoLSXfxVQX6t7u5dMqBvUzUBMyPRyrLzSf5URRSyjbkpmT9TKLXtJRXPyotrNT8Qfo6OMTBuPWXQZdrEgam4X/Y+BF4/kIQtfQxIIcc8ehjHr4s/bfkRqW5zTx7Rurh1s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 24, 2025 at 09:00:01AM -0700, Shakeel Butt wrote: > On Thu, Apr 24, 2025 at 08:09:29PM +0800, Huan Yang wrote: > > When cgroup_init() creates root_mem_cgroup through css_online callback, > > some critical resources might not be fully initialized, forcing later > > operations to perform conditional checks for resource availability. > > > > This patch introduces mem_cgroup_early_init() to address the init order, > > it invoke before cgroup_init, so, compare mem_cgroup_init which invoked > > by initcall, mem_cgroup_early_init can use to prepare some key resources > > before root_mem_cgroup alloc. > > > > Signed-off-by: Huan Yang > > Suggested-by: Shakeel Butt > > Please move this patch as the first patch of the series and also remove > the "early" from the function name as it has a different meaning in the > context of cgroup init. Something like either memcg_init() or > memcg_kmem_caches_init(). BTW I think just putting this kmem cache creation in mem_cgroup_init() and explicitly calling it before cgroup_init() would be fine. In that case there would be a single memcg init function.