From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56222C36002 for ; Mon, 24 Mar 2025 17:48:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7ABAB280003; Mon, 24 Mar 2025 13:48:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 73323280001; Mon, 24 Mar 2025 13:48:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53C5D280003; Mon, 24 Mar 2025 13:48:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2DF18280001 for ; Mon, 24 Mar 2025 13:48:07 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 331ADB90B6 for ; Mon, 24 Mar 2025 17:48:07 +0000 (UTC) X-FDA: 83257178214.05.EF8D4DD Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf15.hostedemail.com (Postfix) with ESMTP id 2FD8DA000D for ; Mon, 24 Mar 2025 17:48:04 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=OGm99cIm; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf15.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742838485; a=rsa-sha256; cv=none; b=y5WKF2EmVTVbMZFJd9oJZeCiVmJc+KTxeqDiaFxUwnV88Lzy4zm1CDO6J+T0dq2+zs8akk SK21mqcdreEujDgs53BKDZW3C7MVzx0DOOuLCeerZuq9/oolnmQ2YEF1RIOH6HlTaqz4su yBUwREa9Dqww370xfJb6yST9J6mhdCo= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=OGm99cIm; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf15.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742838485; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W/iivi4IReVWYmwVNehv3u9PvixYASh+cW9mV7NVv4E=; b=tYAB2cahDhdkiqQJrp4FuXZmzZfOSj0GTBWn+dHD83t69C8y+TqxEsa0mIO9y0NuDCj9iA 9f50jRzdlx8bQdis7z+9BNI/qoXyTWW5k42k/8aT7wdIrDJjYhrIUgNELFblUTMLAJxuKR idPP6O7ZTK+sSllsUqF5ypegVR6R3Yg= Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-43690d4605dso33220665e9.0 for ; Mon, 24 Mar 2025 10:48:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1742838484; x=1743443284; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=W/iivi4IReVWYmwVNehv3u9PvixYASh+cW9mV7NVv4E=; b=OGm99cImbjQ3Xg3tjk9lWBHoEanfVYTB/0lYZjPK1Mx6GeUMllM2KkAbnVBTpcKF6A mIuGSKk97r8wWDo7GIjmBwvMxet4UN8ClmEbXA66/O0SO8v0rrbEOW40mMverqbDnRG9 rnDCAOIoTa+iZzb2USq2JmpSXYwae+jv/i1Qadl3+JC7B5kPELe3zrwqN1n5ulW/zGAx SGVjaduJy8TxMNa4qkKn5Pnwyn6mh5tpxg4LuIJjKTG8uhRwkaIVt4vIjJf1mOraud9w sMEIpDGeWPgZ6g+Os5zUYjyf1KzuzYeX5teBSJOvDxvpriucL1qy8UniZ6WSgtSfC2q6 wpjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742838484; x=1743443284; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=W/iivi4IReVWYmwVNehv3u9PvixYASh+cW9mV7NVv4E=; b=GKppMZdX343nRcJwmhGRNa+zO+8qjuh1lvvtfRpdzJVkPz20hBeSjxxCwTJvLvCkd1 kUhaVLgiYRsh1O6UTPqoU0AOhC6+0DTmyNLAxQgiWHFM2CdgBoR3GFYf3F+yq2oG5HQV jvM/6V71DKZodPno9yeqGy+H+34aHpTSvw02gYvJi8J/i0nbpjErwgRsyeWBDM0goo73 7KO5k2Z87Qb9xOMpz1J4ttaUc/R66nFu/4uZCj1yZmFIG+fPEoxsfaLfZAbHNkd8Cinq ScM6FWOs45h2IjEc9BAH69sj2ZYd2xBd0UEgtZIDQ5N37myf49KVlvdcLHIDtpilBgdZ ZeVA== X-Forwarded-Encrypted: i=1; AJvYcCUA5MkS8s556itCUiSfRoJ+zaZh27HLAJXe+248PsoYprABitEnUIW9KZLRoLvaToyBseq/dVodQg==@kvack.org X-Gm-Message-State: AOJu0YxeSKzPQUPKkr3VpgLyF7RQWRtYyPW03SnWch71FmJhs7w36jI8 zCxmrNWgy2wqrWCH70oO2nTFrEVIm5+pqfa9cM5no17JANVERum1Yw7I4RIIacc= X-Gm-Gg: ASbGncucXeUK8gUkOolQbunCvKdJeih1td7FH5oeeQNHxCyjQhqgBEXisiR9erej7Ps rE7QtjV+u5/jHKfni+E9A1gdscjySAGmwDmbJVQqCaJILGg2VqUbSaa6/7eFohKTcLJG44WDqBw /yCsI17sPwBq6wIDAGQLV2kWUEX8CIpEOVYa/IIw1NDuAC+HNjSYJSC317Rs+dDfsqe+L1qqJSI RanHlaVgoHSep6abeAzQTrQitQ2ddonf5gVXvWunK2yvYNZpdW7WugGVWDNL9RGbp2+VHrHDB77 lqPat7+0QfDMu9J5Oi7FJu5AOfBEJCQmNNG8uC5ftvktCJI= X-Google-Smtp-Source: AGHT+IFq2OWbDN0VDKe6dxJ/5hKnNsuOPodW587cuYJsSJqE9sOupt9Mw2DZ2TerpViAf0fJkvB2VA== X-Received: by 2002:a05:600c:1989:b0:43d:9d5:474d with SMTP id 5b1f17b1804b1-43d50873c28mr121472035e9.0.1742838483624; Mon, 24 Mar 2025 10:48:03 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d4fd18621sm129426465e9.12.2025.03.24.10.48.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Mar 2025 10:48:03 -0700 (PDT) Date: Mon, 24 Mar 2025 18:48:01 +0100 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: JP Kobryn Cc: tj@kernel.org, shakeel.butt@linux.dev, yosryahmed@google.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 2/4 v3] cgroup: use separate rstat trees for each subsystem Message-ID: References: <20250319222150.71813-1-inwardvessel@gmail.com> <20250319222150.71813-3-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uo6755wetz5yix27" Content-Disposition: inline In-Reply-To: <20250319222150.71813-3-inwardvessel@gmail.com> X-Rspamd-Queue-Id: 2FD8DA000D X-Stat-Signature: dci5xipz4wz6x3a1kfiuef9yet87dtrf X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1742838484-133267 X-HE-Meta: U2FsdGVkX19Tc9l8AVnumukRKb4tcxMRlWJNyhG137zb+gEeyi7zpqiC+teviGZQF9s+T8Y+1VRFYzeaRUnS16g16F2HbaolStYZii0SlCWSCzJOh4lzNE3n/c63yOK06PHG/9Dzm4nQ1K/lYOXEVxiqC8cloVdGNyLhnXBXsgh4mfUmQgTkTYDPLACN5sZQGdC3f5nCUQ+Rciqv/NOntyrWn7G3BcwAsKGfHAP2oAHmOI+ex0dIDUPKBxplmPmEezAfyiyYwzCcluf4T2aPIBg1Duc/qChGPg7zCJaaTWnl7UVm7xN2iw+ovvR9chrAy/w5uHLpA9WAUcQ3YLgyR6o+mbceDJ11jR5190C5o6Lqk1fGbdpo27v6MGtk3lkAc9ESd5hsmooEeoI0muErnUvaeqO7rGas/4d64pDt68Hp9dGXNv99lNKXrkmoU54QV6kDLg8F4/u+PxycEj0u0NlRzKWIkHJc99r7lRwBUcMQ7p5V+0Z9HP8gS/g0EiF0wM23OCQx6itqRUd8x1J+20qfGhyA0WrhnWfqdrebk1UnH96/1n3jzDfNdQW1ScKd/48Pk3AfZVjnwillMEfnUMCqGO7OmbdmDcopDTzldBl5Lr/7jCtqt7cwFX+wullcF6sjleWFNkiBudU3CZXiki5RRRfHNC/XtypYh9xncZcb61t46pxZuvjlV3gGP9aFFhHR8sAa5O/+fY753nNqxQ9U2y1tUN2NG+YmnWbEZXN1pZErVizjJLlbaP5/9aTVx/muNOduvSfzjF0UsyZQWziV4EGEp0uXvzhr7xrAs3FnxSTj10AAXeCtqet5gXR8NQU1DdBMy83ag+JVyEHNdz+2MKYIFQ5BM3e5SI7AFQkd2qtPE4bKBpodVBpYtdE4wcXKV8Wr8I97kr1uL1M4chYPDeKZEATvJ3U1aiSQP6wNQouNQ6+ZlG4MdskN20e6NBdkDRBm/12MIFZuE/O nvpk+piY s5ISLS+ROJissoWYT3R50RhEj2zY+7MltY76MC9JuU6QWUsE4Nv8874c1IhfEivZO3PSTlnyvyngK5ipTJulhcD4aTVZg0tWpE9zsEA9IIGfu9he01rhIYi9O4PO+L4fUSs+8xYzE4YkHwoHa4q64herqMi4iCDESJFX+1aSN5VrDJ1llVjrx/QicTpdVgm8xSqPRabpEfceESH8ULnklz3BgdO5mnwbOO6iJNf+xMdllOfbgyFWn0k2EbTEM63koLdlIMrmv1imhDPkhgkHjCibf2Q7t2RqAj8K7EIDaZVirI0hfyFj8p+1ojUyiCTNRfImA7ynEPW1f6g00+Fe0/H39f5E5WbQYuevAvGGIE4gZKA9ZOaUc3+TvBBFU0s5r0ZL2KhFqXSKMnAEvPVGBVQEc3VAWISTila4vQeG4sz+60op8dDoBkNL20QfxRZd0qtDf8VU+5ovhCqQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --uo6755wetz5yix27 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH 2/4 v3] cgroup: use separate rstat trees for each subsystem MIME-Version: 1.0 On Wed, Mar 19, 2025 at 03:21:48PM -0700, JP Kobryn wrote: > --- a/kernel/cgroup/cgroup.c > +++ b/kernel/cgroup/cgroup.c > @@ -161,10 +161,12 @@ static struct static_key_true *cgroup_subsys_on_dfl= _key[] =3D { > }; > #undef SUBSYS > =20 > -static DEFINE_PER_CPU(struct cgroup_rstat_cpu, cgrp_dfl_root_rstat_cpu); > +static DEFINE_PER_CPU(struct css_rstat_cpu, root_self_rstat_cpu); root_base_rstat_cpu cgrp_dfl_root_base_rstat_cpu (not a big deal, it's only referenced once next to definition) > --- a/kernel/cgroup/rstat.c > +++ b/kernel/cgroup/rstat.c =2E.. > -static struct cgroup *cgroup_rstat_push_children(struct cgroup *head, > - struct cgroup *child, int cpu) > +static struct cgroup_subsys_state *cgroup_rstat_push_children( > + struct cgroup_subsys_state *head, > + struct cgroup_subsys_state *child, int cpu) Forgotten rename? > diff --git a/tools/testing/selftests/bpf/progs/btf_type_tag_percpu.c b/to= ols/testing/selftests/bpf/progs/btf_type_tag_percpu.c > index 38f78d9345de..f362f7d41b9e 100644 > --- a/tools/testing/selftests/bpf/progs/btf_type_tag_percpu.c > +++ b/tools/testing/selftests/bpf/progs/btf_type_tag_percpu.c > @@ -45,7 +45,7 @@ int BPF_PROG(test_percpu2, struct bpf_testmod_btf_type_= tag_2 *arg) > SEC("tp_btf/cgroup_mkdir") > int BPF_PROG(test_percpu_load, struct cgroup *cgrp, const char *path) > { > - g =3D (__u64)cgrp->rstat_cpu->updated_children; > + g =3D (__u64)cgrp->self.rstat_cpu->updated_children; > return 0; > } There are also some comments above needing an update. Michal --uo6755wetz5yix27 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCZ+GazwAKCRAt3Wney77B SVhXAP4z12Zh/dNNDSm1avF6MFhShIyCd6WfB7mEgr4Rk9uQLAD/ShgqnWpUdSbj qHh6FyfWS0LwtJaXCYuV0o6kcDDj4AQ= =n5p+ -----END PGP SIGNATURE----- --uo6755wetz5yix27--