From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B68C6E7545D for ; Tue, 3 Oct 2023 18:11:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F3DE6B0128; Tue, 3 Oct 2023 14:11:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A44A6B0136; Tue, 3 Oct 2023 14:11:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED5CB6B0137; Tue, 3 Oct 2023 14:11:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DEF5C6B0128 for ; Tue, 3 Oct 2023 14:11:08 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A34C11603AF for ; Tue, 3 Oct 2023 18:11:08 +0000 (UTC) X-FDA: 81304941816.28.265B93D Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf06.hostedemail.com (Postfix) with ESMTP id B0E2C180009 for ; Tue, 3 Oct 2023 18:11:06 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="HjXqxe8/"; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf06.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696356667; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yYYOS2Rb4Gft46HT9a3Ew+hqjRkAXefJxlOoM/tdWIY=; b=6BEKtcNaLIH0Tm/uDTOLghJVwutMzpvSKHh7rcA1/WIK3E8HxYdnYyGq8rM1YYyx7vITwi h7mXG3AocKX4RunklEWNuZW6ZzYgwhNqkLw23OXq8D3oUn50HRHe5xOGoYFObjtXhTN7wp pSxFeJCwLwL/Tl73AFNg6f/VaxLWG5Q= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="HjXqxe8/"; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf06.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696356667; a=rsa-sha256; cv=none; b=TSnj52Zp4YzV8em+mMeU1Fa0nrv2kQXMOubeWMgpGeHHucOXwp65xqdyLGi/7C2ytDZ/LF SWQPo3otc62lUerWXs3cqTuyAw6/r6mNPA7NS1+bGtbyHFM8dLwt7YiVFREutueCOHWb1B hKzmUetdcTZxhpSpVWHQ5fgrqxDWybc= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 96A882188F; Tue, 3 Oct 2023 18:11:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1696356664; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yYYOS2Rb4Gft46HT9a3Ew+hqjRkAXefJxlOoM/tdWIY=; b=HjXqxe8/wntTzrvTsNfrdAnyH44mpAxBB6GfxJpG+O5R+e4+dnQHgqK9G5JCIrOIEjL3NE T23x25vBLUDKeflfuTNYE0yyZKiN856A+VVR4uA/Gw1qrQopSUditko2I6uEw7eWU4tcMN NGDPRRnyZbYrxIO2LKxocUmkG14coDI= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6DEFB139F9; Tue, 3 Oct 2023 18:11:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lc4wGjhZHGVCNwAAMHmgww (envelope-from ); Tue, 03 Oct 2023 18:11:04 +0000 Date: Tue, 3 Oct 2023 20:11:03 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Yosry Ahmed Cc: Andrew Morton , Shakeel Butt , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm: memcg: refactor page state unit helpers Message-ID: References: <20230922175741.635002-1-yosryahmed@google.com> <20230922175741.635002-2-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="i3qdsoh2u6z4zu32" Content-Disposition: inline In-Reply-To: <20230922175741.635002-2-yosryahmed@google.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B0E2C180009 X-Stat-Signature: 7p5augdusx6o8egzyet84jb5wqq84fei X-Rspam-User: X-HE-Tag: 1696356666-939271 X-HE-Meta: U2FsdGVkX1/x0mNdlbOyz/fbP2bMTHc4ha+ItdIEn/+cxX7xehFg5gpxZxlPIweFZJknsularf4lQHRyt4BWTHjLHKo84G30ofNXICerhpwROoosDmoa/ockSQL3yzHriguQKkPZCqTKgLUS7frI+D8fiiwGreGDKVf+R6RcJQFehC7u3zL72J/6b58NZDtkxq4pmD8pJ0D2nJvfpcLnSix01dxTk3x4jVghg2NX+0dxSMbOIR35tNkfzwcsnsympGvDTJ5XX9pFegokpbImt3IRFVprL3nT2zIwKZppp9F70tyiTnAoiUh0tep7OpTPdIs2CYtCJisvRTZ9TLBTZ6l5GqitW7MpAjiFh+8qHkSLK33PNUJ9QINRhr/Zaj7edNbe7gQM2pnVouY/VEh3iJNW6geYMici8f9OLXj4Op++eRv1b6ybY/jIrJTZn0PgJDPhxFaaDaT0qF7KB6LPEZbT0nEd0p+e/Z9kAsBXiqRVRWSlkAdYlT/zxjCnIoaK1PIv1EetGLBUvRDZleHm7nlYBsmWSbqJg5pnkipdJVJLDEi8Aw8UHn31w+xpT3L0CMEbKz1BncZLn3zQUnDodydUXKHXP3Pn6Zb94sYzE0/ufIbTUKA061TrUg4NG2XL7YsQF2n8yNFmpM4rEdsTyfxRJdk5PvuAednB/dwuRyhs4+GJ4KNJjb5mrr0BtYPaMhI12goe8Y20uJ85sMnT6o/MZcvZrAHxwRR3fnduoASh6ZG5rJwWCReezLfZx+TQuEuP/QsqkEPI80dS1U4tiao2Zawq86FEbr+pC6hIWbH7bDqjmaAKHAprbtpF6lO0FWglXPWgx43xqwqNBI4FeSf01cHeiAXDCZGO4SzMMkHajX7h20/R4B31vMVufJkJrRh5Aq4oGnrm0ocnRem0tARdu6+KliX4lKQDwZkI465s7ZCDzqYvXFQxg725mIF4bxovomrVJ0pSnosVPZL adleW7tw lV6+F7Ag0aHGByZtBuUM27WOnT8sSt4Unb666q0LTEEwqZ55PKKo7FNXzS3ZyuuxTI12Yp8uf+YS6cXDv2TeYqm4YYZl1SuCqZP0bUsJw97VxeUZ5vcyDVquoPbibB2GQLwdPMZ0LrB7DqbbTnVk9/xT3u828nFNz/5XVNDhdisAcqlm9nICoTJowRj5+U5ISQH5+1ytoBaoJvJnWxbEZdzN6JXceL399WWLnS+fWK0P1ggw4GjqpcILA9U/KuzrAyWUeMQIdQPxfVCVnfiIoz/SJu3zTEG05ME9F35w7SF3f+b29B36qa/MFv/P2JNd01Np+UdkROZKUXP4Z9LfFBomjlg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --i3qdsoh2u6z4zu32 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 22, 2023 at 05:57:39PM +0000, Yosry Ahmed wrote: > memcg_page_state_unit() is currently used to identify the unit of a > memcg state item so that all stats in memory.stat are in bytes. However, > it lies about the units of WORKINGSET_* stats. These stats actually > represent pages, but we present them to userspace as a scalar number of > events. In retrospect, maybe those stats should have been memcg "events" > rather than memcg "state". Why isn't it possible to move WORKINGSET_* stats under the events now? (Instead of using internal and external units.) Thanks, Michal --i3qdsoh2u6z4zu32 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZRxZNQAKCRAGvrMr/1gc jgo0AQDb9lpy0zerQzFtiZH/g19b+bqmEZBBe46qnjohE+hXYgD/WBCdV4mnuxTI vnNNETrx33ndymulCkeglLV+sj3sYwc= =mr+D -----END PGP SIGNATURE----- --i3qdsoh2u6z4zu32--