From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BFCBC61D97 for ; Wed, 22 Nov 2023 01:01:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB7096B051F; Tue, 21 Nov 2023 20:01:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D674A6B0521; Tue, 21 Nov 2023 20:01:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C07896B0522; Tue, 21 Nov 2023 20:01:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B24FA6B051F for ; Tue, 21 Nov 2023 20:01:27 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 56368B5DF6 for ; Wed, 22 Nov 2023 01:01:27 +0000 (UTC) X-FDA: 81483787014.20.4AD2479 Received: from beige.elm.relay.mailchannels.net (beige.elm.relay.mailchannels.net [23.83.212.16]) by imf19.hostedemail.com (Postfix) with ESMTP id AAC1F1A0027 for ; Wed, 22 Nov 2023 01:01:23 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=NTu6l2de; spf=pass (imf19.hostedemail.com: domain of dave@stgolabs.net designates 23.83.212.16 as permitted sender) smtp.mailfrom=dave@stgolabs.net; arc=pass ("mailchannels.net:s=arc-2022:i=1"); dmarc=none ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1700614884; a=rsa-sha256; cv=pass; b=WN+zFi3iKZtSpyam11/ksTL91gi4UmQqi1oP5UnIgxXfO8/06YB/wpBRbKqEFXwJ5z/ZbK SHH3MKPqQ+JcG5fsawAlsrmYD/Qqtk4Kyj/5Uf1oCNuXtUyOrnihVjLRhl9lUsabZqXoPK dWTNCnhRRnARbvYbl8UmvYsz9s6Jbe4= ARC-Authentication-Results: i=2; imf19.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=NTu6l2de; spf=pass (imf19.hostedemail.com: domain of dave@stgolabs.net designates 23.83.212.16 as permitted sender) smtp.mailfrom=dave@stgolabs.net; arc=pass ("mailchannels.net:s=arc-2022:i=1"); dmarc=none ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700614884; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pBG5QBQev1WUx8qgrxc7+absFmgUQXr+R05r/UhTqT8=; b=e6vBnds5PXYAaNs1xfqnCeXsfqJP9c+jVeah1iQhNcjVZsgcJrKNMpghv3qGYyfVRjW0Zm mT4KXWdR6Yo5r0kUzCn43pb8a1c1t1ngu6pnBQTmtX+8UtJKEHvzoFE2LPfc2JtROdWAgP x3CQIjRiEDaJsu1Oyhs+82V1GwL+S4o= X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 5045D81BB6; Wed, 22 Nov 2023 01:01:22 +0000 (UTC) Received: from pdx1-sub0-mail-a211.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 60E9681AF4; Wed, 22 Nov 2023 01:01:20 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1700614880; a=rsa-sha256; cv=none; b=uDrlXBrGErJayNHHMxGqLoqHrW+Crrh0EwSeMwROyucg2k9wpmk43KMVDnlIKiBIk/CRcM hmeKsvsOC1HjOD+kZdYj7mDlXZzMzj5Pk60zPrP/kb39xv5KN/Ccb3XUKha5I3WXaqJoP3 ZoG4WKuh4q+LUHn7p0SlRNolWYNe8H0QrE68yiGo0TrXSH1a/AoAV3VTDe9MgfPaoTfgG6 IkQCP3CR0F/vYX8l+qs8Mn5v8AEm1sTrInPbV6VwQVsbzOO3GsOmqOzdsnKXqVW3jFcP0C IjRQ7plBDwnoOQT2N6+vhmckLlyD4bS/2gSBYQypsaWA9OE+BrJ3BxNSYbjwoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1700614880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pBG5QBQev1WUx8qgrxc7+absFmgUQXr+R05r/UhTqT8=; b=ktwRbYz9T60ih0byWBdI5OZr2RotJMLyXo2/Crla3sDBX5jvfzTPwI1/OsParfKZRQBlnQ VMDojCSZ4BFu0Fo7MuTbVWOQGa2W0Pzf8k+Nnp3shodc5XXgH1WC7jZqEHSFDx31HETeXv X6/sgAZKAMCwINAUz63viKngVrUzuNZieOWJg00EGoj5bW1dk5/uYuPux0vqHk8NVjNk69 nSbzPmn7yYbP4Kfpm4cx4Vui0kygLSQ8YMCCuqEsgzznVuohnneI+V/12qlJF9goEy8HF7 6vROcvAUQQxgXm2ww2IbKznmsCxQneV9Xoh+xqWlMTwWlKPYVwX7Jgs924nBmw== ARC-Authentication-Results: i=1; rspamd-645fb96b5-hzw8k; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Absorbed-Abortive: 11f349ac07025e80_1700614882126_1858017920 X-MC-Loop-Signature: 1700614882126:3891613807 X-MC-Ingress-Time: 1700614882126 Received: from pdx1-sub0-mail-a211.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.104.134.218 (trex/6.9.2); Wed, 22 Nov 2023 01:01:22 +0000 Received: from offworld (unknown [104.36.30.214]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a211.dreamhost.com (Postfix) with ESMTPSA id 4SZjcG0xmwzXs; Tue, 21 Nov 2023 17:01:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1700614880; bh=pBG5QBQev1WUx8qgrxc7+absFmgUQXr+R05r/UhTqT8=; h=Date:From:To:Cc:Subject:Content-Type; b=NTu6l2dendzv7UQwdOaVWOyt3UvJbIAWI8OJeKZ1PqMdooZF3s1umV2DF3UcQPOfn +RSExkcNV9UZdGM/iJVp8HTDbmsCALUjDIo3F9jycbP3sha6EQIREVcynth+TrOTAU PEC65yyHactoisFgWMl/UvprSu22zfPNe4OCugP0POhgQleUBNd/QuDvQqCZ9ew04w 915OPd2aYtAvcWcsAS9BvTQkp5RCKluB/hqPmFdr+jQk2yu/qJ2HrzAnj2I2PBZxEC 5sylbnjLL1lzUaNf2SJsI40vpJY2vpQqRr331is/JKTb6er8bisuuqUJ6pEW9FaADW sJYLkNlqvcpAg== Date: Tue, 21 Nov 2023 17:01:14 -0800 From: Davidlohr Bueso To: shiju.jose@huawei.com Cc: linux-cxl@vger.kernel.org, linux-mm@kvack.org, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, dan.j.williams@intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, tony.luck@intel.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, rafael@kernel.org, lenb@kernel.org, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, mike.malvestuto@intel.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com, fan.ni@samsung.com, a.manzanares@samsung.com Subject: Re: [PATCH v2 03/10] cxl/mbox: Add SET_FEATURE mailbox command Message-ID: Mail-Followup-To: shiju.jose@huawei.com, linux-cxl@vger.kernel.org, linux-mm@kvack.org, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, dan.j.williams@intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, tony.luck@intel.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, rafael@kernel.org, lenb@kernel.org, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, mike.malvestuto@intel.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com, fan.ni@samsung.com, a.manzanares@samsung.com References: <20231121101844.1161-1-shiju.jose@huawei.com> <20231121101844.1161-4-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20231121101844.1161-4-shiju.jose@huawei.com> User-Agent: NeoMutt/20231006 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: AAC1F1A0027 X-Stat-Signature: 4r31m4b5ocw3wei7qouoggb9ja5xunka X-Rspam-User: X-HE-Tag: 1700614883-636781 X-HE-Meta: U2FsdGVkX1+Cy8Pj/XGlzSNn9k0xIucfG6b3bjxmrmQoZ9vJlvkZiT7HrKiPeUSsgCYz/E77i5G29yQcDqP+nVuhNUQxL8WFt3+hhG/TJMuJtVJAoJbXW8mlxkXFCjU6T0aW+qe4p+p+emM3UjRNaFx7wiZQaPHCkJLHIBApBxuULNuG50E+UeGQrbL4Ge9jUrWJ89S+VPlLM/xRhMIKHm3/RhZ76fDIna6bf3IIb02f9xhWfUK19axaGea1tjA/yq0HSsB0qjD2RU8OdDoCLPB37tLrXRztjp6OYa71ogtP4gNSU7jHyJnE3hZ/DDfpJcnWlAyZO3tcukBKramq70nQ0w76TbY+IgJmmzuQw5KZHO3VzKWH6Bo9tIkVQ7Et3qQreVObdbVqkUr29b/veXZS1QkSKPZH/m5K8qcBqPztlrPMyTZIo4r3GgJuBMqknr/JXKASgD7LDa5gVcWBuJf2eV6Qc+K2lQXIlj18dcQLkkKK8+rX8ABe7PPvxmUDMyNYrWT2oybhrbSmfM9jE/mV/4TUByNdX3SHquN61jL6mLlWJShdqM+wAj/Fi4ZnJJ4VZKfb1uJ1yaD0FO7hPW1leFFK21yzCqSGhFr/jP6RrbxPlNIDY6RVAAjbzN390dCzZr2qE4ltHTUQFhoDRB8qjp9HdkC5aWhmMeGmrMPUf0cv0raKOdEX5R7UgEF/z5BPVnSEhknMSUoNUE/B/PAN5g+j+vCm7w6qmJDg8Tuzh5WINnb3W1SOrXM9cgzz9ZApdKPzHH5U/lsaB+SyZfeuoYiyxTUoJOUda942QnLOIctXen5aXgmlM5PUglnDUrMRASDzRgy62KToImdEXXatwY97yllW917L4DGgNIxD6eEwuYQXUJgQgUCm4UyP8G6q9jM0AAzKZK+DFCXjkdq5/c0A3u/02bNtITxg/s6T0H9L6ezsxZJf83DMvLm1XopTos6Tf8x/3nPD2yV 3eiv4ZKv fnZFumwVcUrdlnXEkeE/z19oh/mgEscbyQHZQvi3VrmDzUvWYR6CMpk2Kd+1LhHUx9pVF+zX+l5PzfXdRu3OImClbN6mCECdmgXP7dpdGqeKM3Z62wvF2RRU1bYxsC9u09+Reoupq1sHJl1x7mAsHAOPsta3/OZ2cDKxB3xFrXdZCI+SKeJ+XUa5PXOdZyg9Y5h+ulPD58RoDU2Bp+plmg9n7ndPZQsqbBllwKfJE8BweCxCMyA5raJbvwdGF/5SmPOSW9vANS3V/TYkgGTiNv0y+MTFlhMY+I3V9CfE+hV40PzXLCxcikUGvt+XkTsvpMjTU8G/cEK+seAtnSn92EZ9/ff7mcD7vRooV5FbvcQSiqTYx/TbQL1yZ37gN/btVMB3o X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 21 Nov 2023, shiju.jose@huawei.com wrote: >From: Shiju Jose > >Add support for SET_FEATURE mailbox command. > >CXL spec 3.0 section 8.2.9.6 describes optional device specific features. >CXL devices supports features with changeable attributes. >The settings of a feature can be optionally modified using Set Feature >command. > >Signed-off-by: Shiju Jose >--- > drivers/cxl/core/mbox.c | 15 +++++++++++++++ > drivers/cxl/cxlmem.h | 27 +++++++++++++++++++++++++++ > include/uapi/linux/cxl_mem.h | 1 + > 3 files changed, 43 insertions(+) > >diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c >index 2675c616caec..d892b07446ca 100644 >--- a/drivers/cxl/core/mbox.c >+++ b/drivers/cxl/core/mbox.c >@@ -65,6 +65,7 @@ static struct cxl_mem_command cxl_mem_commands[CXL_MEM_COMMAND_ID_MAX] = { > CXL_CMD(GET_SCAN_MEDIA_CAPS, 0x10, 0x4, 0), > CXL_CMD(GET_SUPPORTED_FEATURES, 0x8, CXL_VARIABLE_PAYLOAD, 0), > CXL_CMD(GET_FEATURE, 0x15, CXL_VARIABLE_PAYLOAD, 0), >+ CXL_CMD(SET_FEATURE, CXL_VARIABLE_PAYLOAD, 0, 0), > }; > > /* >@@ -1350,6 +1351,20 @@ int cxl_get_feature(struct cxl_memdev_state *mds, > } > EXPORT_SYMBOL_NS_GPL(cxl_get_feature, CXL); > >+int cxl_set_feature(struct cxl_memdev_state *mds, void *feat_in, size_t size) >+{ >+ struct cxl_mbox_cmd mbox_cmd; >+ >+ mbox_cmd = (struct cxl_mbox_cmd) { >+ .opcode = CXL_MBOX_OP_SET_FEATURE, >+ .size_in = size, >+ .payload_in = feat_in, >+ }; >+ >+ return cxl_internal_send_cmd(mds, &mbox_cmd); >+} >+EXPORT_SYMBOL_NS_GPL(cxl_set_feature, CXL); >+ > int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, > struct cxl_region *cxlr) > { >diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h >index 92c1f2a44713..46131dcd0900 100644 >--- a/drivers/cxl/cxlmem.h >+++ b/drivers/cxl/cxlmem.h >@@ -508,6 +508,7 @@ enum cxl_opcode { > CXL_MBOX_OP_GET_LOG = 0x0401, > CXL_MBOX_OP_GET_SUPPORTED_FEATURES = 0x0500, > CXL_MBOX_OP_GET_FEATURE = 0x0501, >+ CXL_MBOX_OP_SET_FEATURE = 0x0502, > CXL_MBOX_OP_IDENTIFY = 0x4000, > CXL_MBOX_OP_GET_PARTITION_INFO = 0x4100, > CXL_MBOX_OP_SET_PARTITION_INFO = 0x4101, >@@ -817,6 +818,31 @@ struct cxl_mbox_get_feat_in { > u8 selection; > } __packed; > >+/* Set Feature CXL 3.0 Spec 8.2.9.6.3 */ >+/* >+ * Set Feature input payload >+ * CXL rev 3.0 section 8.2.9.6.3; Table 8-81 >+ */ >+/* Set Feature : Payload in flags */ >+#define CXL_SET_FEAT_FLAG_DATA_TRANSFER_MASK GENMASK(2, 0) >+enum cxl_set_feat_flag_data_transfer { >+ CXL_SET_FEAT_FLAG_FULL_DATA_TRANSFER = 0x0, >+ CXL_SET_FEAT_FLAG_INITIATE_DATA_TRANSFER = 0x1, >+ CXL_SET_FEAT_FLAG_CONTINUE_DATA_TRANSFER = 0x2, >+ CXL_SET_FEAT_FLAG_FINISH_DATA_TRANSFER = 0x3, >+ CXL_SET_FEAT_FLAG_ABORT_DATA_TRANSFER = 0x4, >+ CXL_SET_FEAT_FLAG_DATA_TRANSFER_MAX >+}; >+#define CXL_SET_FEAT_FLAG_MOD_VALUE_SAVED_ACROSS_RESET BIT(3) >+ >+struct cxl_mbox_set_feat_in { >+ uuid_t uuid; >+ __le32 flags; >+ __le16 offset; >+ u8 version; >+ u8 rsvd[9]; >+} __packed; >+ > /* Get Poison List CXL 3.0 Spec 8.2.9.8.4.1 */ > struct cxl_mbox_poison_in { > __le64 offset; >@@ -949,6 +975,7 @@ int cxl_get_supported_features(struct cxl_memdev_state *mds, > void *feats_out); > int cxl_get_feature(struct cxl_memdev_state *mds, > struct cxl_mbox_get_feat_in *pi, void *feat_out); >+int cxl_set_feature(struct cxl_memdev_state *mds, void *feat_in, size_t size); > int cxl_poison_state_init(struct cxl_memdev_state *mds); > int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len, > struct cxl_region *cxlr); >diff --git a/include/uapi/linux/cxl_mem.h b/include/uapi/linux/cxl_mem.h >index b20de60bfc71..8c89d323cc41 100644 >--- a/include/uapi/linux/cxl_mem.h >+++ b/include/uapi/linux/cxl_mem.h >@@ -48,6 +48,7 @@ > ___DEPRECATED(GET_SCAN_MEDIA, "Get Scan Media Results"), \ > ___C(GET_SUPPORTED_FEATURES, "Get Supported Features"), \ > ___C(GET_FEATURE, "Get Feature"), \ >+ ___C(SET_FEATURE, "Set Feature"), \ I don't think we want to export this to userspace, and you are already using the scrub driver for setting feat attributes. > ___C(MAX, "invalid / last command") > > #define ___C(a, b) CXL_MEM_COMMAND_ID_##a >-- >2.34.1 >