From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDE0EC71157 for ; Tue, 17 Jun 2025 10:08:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 717DF6B00A8; Tue, 17 Jun 2025 06:08:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C7F16B00AA; Tue, 17 Jun 2025 06:08:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56F036B00A8; Tue, 17 Jun 2025 06:08:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4316F6B00A8 for ; Tue, 17 Jun 2025 06:08:22 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EAF0CBF39B for ; Tue, 17 Jun 2025 10:08:21 +0000 (UTC) X-FDA: 83564467602.30.7BE47AB Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf26.hostedemail.com (Postfix) with ESMTP id B36AD140013 for ; Tue, 17 Jun 2025 10:08:19 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BFxWl3Ea; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=SBOIzyjo; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BFxWl3Ea; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=SBOIzyjo; spf=pass (imf26.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750154900; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+KN9MaeqSHl9HVwIoddN2qqMWW+hXSSVzIEAt9aXyiA=; b=BAF2X4XupMvH8k/c3Z0VNXK7MlXTYeTe+G2xu6+VTysYbmYoAlbIytVTFgZWH1YDA8cTZA aAjZrBVX6ciNdUT30VmnkefQsGK4gZEciLDwUpSf4+LxUMubDaNNN1kqNA+rqs8Y6IZyyO pCAIkzOPBVxDthUT5Eou+Q1XwwKj0Zk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BFxWl3Ea; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=SBOIzyjo; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BFxWl3Ea; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=SBOIzyjo; spf=pass (imf26.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750154900; a=rsa-sha256; cv=none; b=pGrjvR54c+XX8jQhgGV1klujvk+pzYJfNrMwx3Eq4kQEd5BbXeqMnTHWNIwgHOputJVm6O bJvOGzM2D151jE+tt2IZXhYK9W/sxxDh44ydJAD+KQVHQAhbTmVoum7E2pyJhtrxbRrv4O XyqGEbMNBr9r7LkL5dmFYT+sN1P+SAo= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 396E2211BF; Tue, 17 Jun 2025 10:08:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750154898; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+KN9MaeqSHl9HVwIoddN2qqMWW+hXSSVzIEAt9aXyiA=; b=BFxWl3EanIJvzCoMFuCoJxkj0gAsdQZE7hw1XhSy1nbMZTkaRDiA1b0hI3GXl4f/MvyfyV Vgj0hPOQwQM8eCTvqUXeohMucxrc+c/xMO/X9kCCPSP1ukBaPJ0KWCWnZJPEEloR81K1Ci 0OgK36M68lUZ8jSY1FnTe483u2hsBUA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750154898; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+KN9MaeqSHl9HVwIoddN2qqMWW+hXSSVzIEAt9aXyiA=; b=SBOIzyjoL1hV4dTxalfy2DzNiQoIlHduO9Qsz9VkAnCu7glFAk22G0mRK89A6leFQTwMJe mzbJXmoC2AWz7rCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750154898; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+KN9MaeqSHl9HVwIoddN2qqMWW+hXSSVzIEAt9aXyiA=; b=BFxWl3EanIJvzCoMFuCoJxkj0gAsdQZE7hw1XhSy1nbMZTkaRDiA1b0hI3GXl4f/MvyfyV Vgj0hPOQwQM8eCTvqUXeohMucxrc+c/xMO/X9kCCPSP1ukBaPJ0KWCWnZJPEEloR81K1Ci 0OgK36M68lUZ8jSY1FnTe483u2hsBUA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750154898; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+KN9MaeqSHl9HVwIoddN2qqMWW+hXSSVzIEAt9aXyiA=; b=SBOIzyjoL1hV4dTxalfy2DzNiQoIlHduO9Qsz9VkAnCu7glFAk22G0mRK89A6leFQTwMJe mzbJXmoC2AWz7rCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1D72513A69; Tue, 17 Jun 2025 10:08:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id kWorB5I+UWiDFwAAD6G6ig (envelope-from ); Tue, 17 Jun 2025 10:08:18 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id C6B34A29F0; Tue, 17 Jun 2025 12:08:13 +0200 (CEST) Date: Tue, 17 Jun 2025 12:08:13 +0200 From: Jan Kara To: Lorenzo Stoakes Cc: Christoph Hellwig , Andrew Morton , "Liam R . Howlett" , Jens Axboe , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Christian Brauner , Jan Kara , Benjamin LaHaise , Miklos Szeredi , Amir Goldstein , Kent Overstreet , "Tigran A . Aivazian" , Kees Cook , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Namjae Jeon , Sungjong Seo , Yuezhang Mo , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , David Woodhouse , Dave Kleikamp , Trond Myklebust , Anna Schumaker , Ryusuke Konishi , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Zhihao Cheng , Hans de Goede , Carlos Maiolino , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Dan Williams , Matthew Wilcox , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-aio@kvack.org, linux-unionfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev Subject: Re: [PATCH 03/10] fs: consistently use file_has_valid_mmap_hooks() helper Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B36AD140013 X-Stat-Signature: nbbs6gw4f9s15kqapfkrgiyjr9wea7y6 X-Rspam-User: X-HE-Tag: 1750154899-707849 X-HE-Meta: U2FsdGVkX1/3J2hwrK+H4ViL85IHrjTPMAxB3Dpbv2ReaWw4StsP779MC0l5WV75IrvMsJqG1RRA9/zzQZBHQqxVl9VRxuZKBbMXB20Uqd98HJgv3nqa4GSVIj1D5bbUcEzsS5sfpIFwkReQNsd+RV7wyYMEg2oAptsBNAnz0i41NzWxod31pfsuoTy5qBXp2F7Q+z+bYerk6EGr83B6B75RIePcrI67urzdXJBpmBgTkJbW9qitqLqFLkR2g64d0PG/3SR4Ht5eiIQmoharM69LnqduvgA0JOWdd0fEdCt3ukmiuQBy9+rv3V9S2V9wF0paAVgKdSbL33poftg5GZ1Dr/qMmKXX2KAiBrgzn9l1IHBBrOttROJV3LKVMtlFNG9d8Lm04B/PylT680yjaiH6osvSrWX61C+t+SkcelBNs4z757wDjWJZF9G8B9FMFNnxyF5ij8IEh106IfogP9r0JJ0cxpyfTRPY5bhUUHu8gz90bnYPWdzuajDNSIWd5+Cx0JEZQ1+Lcl1t1DvfaQHlGNH9wdrbyoPnzwstTLTWVvn7f4Dk70089gsZJX7rC4AUCxXUFk9aFFoiwflTBYXOMKIqyAPN3ZBtB3o8MXAzkbb1wLFvPPey3KAM+XhUwITSmhhqAOSs8FZJm930iheX+ihe5MsobObwJ0RHV36+1b032+UO7Ib4SMW+eKWtzNK79x1JXUD8q038qDcCk2RxiR/ts7qODriqgfQx9zQN2p4T1i0IHYrht0H8LZbVWyoELlX3Zn8gvzlsmJtBXNaIIwz384FWrG6zyfA7O0Z0F7HBgsrg2SeiW3vjEQ1JbYJ6NsARsQ3DQv3TSdOISwXs4CQVPG1FcwjdpvXVVZEWH3U6LgF3JdopYHMEATGipuCYyNWm30NcMrMLFgBmI70uUGNd7E1uCCe3+HnK9b8O+VRSNfTn2JiCSxPbwUBYMAW8zg0DAir4tcJ5lMh +sGDLBnX Sqg0rMFgjkfBtQG/UB9ujQPIstbk2ERKevajDaC/yFM98KThfjGlsECqwf5lY46/zwE6tWEv8L3ZMPN8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 17-06-25 06:25:34, Lorenzo Stoakes wrote: > On Mon, Jun 16, 2025 at 10:11:28PM -0700, Christoph Hellwig wrote: > > On Mon, Jun 16, 2025 at 08:33:22PM +0100, Lorenzo Stoakes wrote: > > > Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file > > > callback"), the f_op->mmap() hook has been deprecated in favour of > > > f_op->mmap_prepare(). > > > > > > Additionally, commit bb666b7c2707 ("mm: add mmap_prepare() compatibility > > > layer for nested file systems") permits the use of the .mmap_prepare() hook > > > even in nested filesystems like overlayfs. > > > > > > There are a number of places where we check only for f_op->mmap - this is > > > incorrect now mmap_prepare exists, so update all of these to use the > > > general helper file_has_valid_mmap_hooks(). > > > > > > Most notably, this updates the elf logic to allow for the ability to > > > execute binaries on filesystems which have the .mmap_prepare hook, but > > > additionally we update nested filesystems. > > > > Can you please give the function a better name before spreading it? > > file operations aren't hooks by any classic definition. > > > > can_mmap_file()? I like this name more as well :). With this patch looks good to me. Again a note that Fixes tag would be probably appropriate for this patch... Honza -- Jan Kara SUSE Labs, CR