From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75843C83F1A for ; Mon, 14 Jul 2025 15:17:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A2EB8D000A; Mon, 14 Jul 2025 11:17:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 17AE98D0001; Mon, 14 Jul 2025 11:17:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 042988D000A; Mon, 14 Jul 2025 11:17:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E91268D0001 for ; Mon, 14 Jul 2025 11:17:29 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A089B1A01F8 for ; Mon, 14 Jul 2025 15:17:29 +0000 (UTC) X-FDA: 83663224218.10.C1F2443 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf23.hostedemail.com (Postfix) with ESMTP id 74C49140014 for ; Mon, 14 Jul 2025 15:17:27 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TMbY1MfK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zVYdg2Ze; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TMbY1MfK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zVYdg2Ze; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf23.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=pfalcato@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752506247; a=rsa-sha256; cv=none; b=Yfjtxlt2M0P/LqrL+1Yy3b0dOuafnrX4EN+JfVthd5BQAtAVuW2uimjaafeJYT6rDnimGb im7MAqheHdjQohiEkKn/I3D7QCaDRi73v+BW4mr8c7jPQ+6pIn4YYthaELiw3ksUa3aLND bIZUK1MMcQWFfhU2xo0wFsj2CoCuzbk= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TMbY1MfK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zVYdg2Ze; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TMbY1MfK; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=zVYdg2Ze; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf23.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=pfalcato@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752506247; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=01705O/qpAXgfDjMNMcfb/7BJ30UiGgLyw1fsG6kHyc=; b=B9ss24s+fOQkKdCstDIu14yWkwXKvtE9Gl6LPy6K5CIWVup9+grZ3Q/W4usArpPQ4jOT4N iVgmNmeqFbdc0d1WonrrbrrbLXQtSFl2wY4DoOduWNhjj1xmg74pl4B81db/QRgs75eG3g ltZFPf1zzp8tYy3AXjYK0I7pmvtHpcg= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1F0E21F798; Mon, 14 Jul 2025 15:17:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752506246; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=01705O/qpAXgfDjMNMcfb/7BJ30UiGgLyw1fsG6kHyc=; b=TMbY1MfKHhUcAXOR5da6cdsvh+oxEVnMjyvc5DRsvdLKWSd4Nu5pojzUUNqtJxOvKYxiO6 3IfJFNu1phpXZqp1TmUvoHrL60PLZ7yyJESTr7nRhmRLA/tjv0JGsEbV+BD/jtExHZJWMH pt15mAN2oxjwrDcpc/LSJGGy/on72qM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752506246; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=01705O/qpAXgfDjMNMcfb/7BJ30UiGgLyw1fsG6kHyc=; b=zVYdg2Ze1q8ei92tN7s0DY/8YEMOmO8CuOMZ1YFKfex0mrWBSGl2+7Mn0i0ooapDq8HCFI DR2pgh7NqV+Kw3CA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752506246; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=01705O/qpAXgfDjMNMcfb/7BJ30UiGgLyw1fsG6kHyc=; b=TMbY1MfKHhUcAXOR5da6cdsvh+oxEVnMjyvc5DRsvdLKWSd4Nu5pojzUUNqtJxOvKYxiO6 3IfJFNu1phpXZqp1TmUvoHrL60PLZ7yyJESTr7nRhmRLA/tjv0JGsEbV+BD/jtExHZJWMH pt15mAN2oxjwrDcpc/LSJGGy/on72qM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752506246; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=01705O/qpAXgfDjMNMcfb/7BJ30UiGgLyw1fsG6kHyc=; b=zVYdg2Ze1q8ei92tN7s0DY/8YEMOmO8CuOMZ1YFKfex0mrWBSGl2+7Mn0i0ooapDq8HCFI DR2pgh7NqV+Kw3CA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 64784138A1; Mon, 14 Jul 2025 15:17:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id syvNFIUfdWgXMgAAD6G6ig (envelope-from ); Mon, 14 Jul 2025 15:17:25 +0000 Date: Mon, 14 Jul 2025 16:17:23 +0100 From: Pedro Falcato To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , David Hildenbrand , Vlastimil Babka , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jeff Xu Subject: Re: [PATCH 4/5] mm/mseal: separate out and simplify VMA gap check Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 74C49140014 X-Stat-Signature: ujzkr444ccersj46y6bpegpdbabrxiqn X-Rspam-User: X-HE-Tag: 1752506247-936462 X-HE-Meta: U2FsdGVkX1/nWjoQXF8XOJEYvIPJGEmAUqdsqUwkRQE5Ojckk5F289jkmJBB0XFdTRC/jSVEYemx0m4tFBQag6gNkHucGcZu2r1O7jORXzyEF3ApAdw32FQ2TB6uGcV9WILHOEZjPOr7AZdtsIelB4PoBBbshnOhrRMo7f6dBJakFxR3q1l/xtR+BrtejUaY4LgPYBY3YEgcYjVOsbKgvcPh7589pHoUMp59x35UUd1lKXHLhmXer87DGxZcKSsP9x7OrPmKI0xd3cX6b6WVmpNr1iAW0gGPJQF9pE7cmvP27/6Vl7+jCCkddVVPormLNYR29zYnqY1s0SImGgJiyxV0meBcdeKfAxJWHCWNyHFa5OifOonrcAsm/eFeWtDFa6fI7Y5TlJL4A/geTVetVhZmm0R5VJohLdRJOgxHxDbChSKwB/wWc+MO3MZUS3rQJjQkGcnR4pBogKgiAdW7+UJLJGpJ+qXT95GARjx9dZcdvsFM5eiigSj452dvYTRKM4veDQ8Jtox0C9SBniac4APdc/9BrzsscvyooPQcAcYdesqgIZfII2NhR6fdCg1gwEjvVBGhGMDLx65IkhUL1p/w2mcUc3L21r5BJt1kI1c8sx3wZ903gqVFCAopjf4vwuxed91g4uqSWES8cs3nuBI6rUoBc50E76y4qLhKlYzCf0xdOWa32JX1PgMsttO5mbZjFPVuIaWVl1EHLX2MLXEjqAP25wMoJhKxVoR6qj71BlzMbXB9JJIWBN5aZv7D0bscLWqkY18bjPiRNR+QsLyyUKaETsSlEmisqX3D2NW4OOB+4WD8oaGqUuqMIREkvP+Oqf4ErkT3eglnTq+FL6qmIK9mZ3zTodTtqD/Ke0Cy7RS1htQfihw66hnzAqsl8wm5meAsZMSbv4r+yu1ihlX4mpSfCrP27i39POnSrR7HEaS/HIq0rWNJ6/+ixOSxsZeTh4QD3tnh2CcxCy8 KrlTjuC/ gErEgBOYaNvbtDWa24G9aylXQ23Zf4C+HQoIhjszefWE4dnYH4W9GwufNZKYyduElaZJk56UP8b2t5cgvJMr353GLZphNffa7KOZlPWs/bKx2HIL/FEacPyBuhU9gBkQG33BCDBj5fCyuQ93cM391ESePcKh2dxYLLK9kEiZ6YzlqDGIsL/7qfjJepcz702AAprJfJPD+uDNg3wXb8LHJALJk16BInxhB/Cv2i+QRWnPvOhhngrnf80lkyZS/bHKQ8nspnA78xDDgyVuv+OqIfUHBV/hZXWQgvOO6dKvSsYAcC9EzKiZ8BrowZA9FYoj5szHp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 14, 2025 at 02:00:39PM +0100, Lorenzo Stoakes wrote: > The check_mm_seal() function is doing something general - checking whether > a range contains only VMAs (or rather that it does NOT contain any unmapped > regions). > > Generalise this and put the logic in mm/vma.c - introducing > range_contains_unmapped(). Additionally we can simplify the logic, we are > simply checking whether the last vma->vm_end has either a VMA starting > after it or ends before the end parameter. > I don't like this. Unless you have any other user for this in mind, we'll proliferate this awful behavior (and add this into core vma code). I have some patches locally to fully remove this upfront check, and AFAIK we're somewhat in agreement that we can simply nuke this check (for various reasons, including that we *still* don't have a man page for the syscall). I can send them for proper discussion after your series lands. -- Pedro