From: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
To: Kirill Tkhai <ktkhai@virtuozzo.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Roman Gushchin <guro@fb.com>, Shakeel Butt <shakeelb@google.com>,
Chris Down <chris@chrisdown.name>,
Yang Shi <yang.shi@linux.alibaba.com>, Tejun Heo <tj@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Konstantin Khorenko <khorenko@virtuozzo.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>
Subject: Re: [PATCH] mm: fix hanging shrinker management on long do_shrink_slab
Date: Thu, 5 Dec 2019 03:29:03 +0000 [thread overview]
Message-ID: <ktsvqama80oloksicov5tvsg.1575516522432@email.android.com> (raw)
In-Reply-To: <8717b035-e082-992b-d9b1-4b4887ef596b@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
> The approach looks OK for me, and despite it does not solve the problem
> completely, it improves the isolation. Also, we may use this to finally
> make shrink_slab() iterations lockless (or you may just send couple of
> patches on top of that :).
If you mean replacing rwsem with srcu it looks like a good idea, but it can be done later separately on top of it (if we succeed with this patch =).
>
> Small cosmetic note. I'd removed comments in prealloc_shrinker() and
> free_preallocated_shrinker() since they just describe obvious actions,
> and we do not need to comment every line we do. But a small comment
> is needed about that synchronize_rcu() is to make wake_up on stable
> memory.
I've just tried hard to make my patch as self explaining as possible, I can remove these (or some more) comments In next versions if they are excess.
Best regards, Tikhomirov Pavel.
[-- Attachment #2: Type: text/html, Size: 1543 bytes --]
next prev parent reply other threads:[~2019-12-05 3:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 21:45 Pavel Tikhomirov
2019-12-02 16:36 ` Andrey Ryabinin
2019-12-03 0:13 ` Shakeel Butt
2019-12-03 11:03 ` Kirill Tkhai
2019-12-05 3:13 ` Pavel Tikhomirov
2019-12-06 2:09 ` Dave Chinner
2019-12-06 10:09 ` Michal Hocko
2019-12-06 17:11 ` Shakeel Butt
2019-12-10 1:20 ` Dave Chinner
2019-12-19 10:35 ` Pavel Tikhomirov
2019-12-03 11:38 ` Kirill Tkhai
2019-12-05 3:29 ` Pavel Tikhomirov [this message]
2019-12-04 8:35 ` Michal Hocko
2019-12-19 10:20 ` Pavel Tikhomirov
2022-10-18 3:48 ` Zhang Tianci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ktsvqama80oloksicov5tvsg.1575516522432@email.android.com \
--to=ptikhomirov@virtuozzo.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=cgroups@vger.kernel.org \
--cc=chris@chrisdown.name \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=khorenko@virtuozzo.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=shakeelb@google.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vdavydov.dev@gmail.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox