From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9370C83F2D for ; Thu, 29 Aug 2024 15:50:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D6856B0093; Thu, 29 Aug 2024 11:50:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5869C6B0095; Thu, 29 Aug 2024 11:50:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49D096B0096; Thu, 29 Aug 2024 11:50:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 228316B0093 for ; Thu, 29 Aug 2024 11:50:45 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9AD03A0A3A for ; Thu, 29 Aug 2024 15:50:44 +0000 (UTC) X-FDA: 82505720808.12.E110C36 Received: from out-185.mta0.migadu.com (out-185.mta0.migadu.com [91.218.175.185]) by imf22.hostedemail.com (Postfix) with ESMTP id 9F72BC0018 for ; Thu, 29 Aug 2024 15:50:42 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Y98tF+x9; spf=pass (imf22.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.185 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724946622; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NPvXQD4BCJq+MDpwmNo5dOSJNnMv53fu4MweHVYAXuM=; b=FOBIaCbKfIGTQjDfujk8pfxT1yP11cqqqC+WLQfDH+Ek4JPs1UX5Z4vnr5Zj8tZvo5hS1F g45G8KbVpyO5zrW4NGzMU7rF5LQdNMSCJgquyvwp5wzXNo3JSu4JWv7oqVRLyKNCllhS8s U+yC8zj3RMwen1+Zy4e2TP5iyx2x9Ro= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Y98tF+x9; spf=pass (imf22.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.185 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724946622; a=rsa-sha256; cv=none; b=bje8GVjNCaxTpJ4cRXz+5l1vmu0JP9bZhgr5NOTMGOgA4SWzrclwk4P3ObNLufK1O98nnI 7s1YQ+FfXjFMUR6xO6r+sck6raoA7wwn8yfj+FRorMyTINLQ24igc+o087Lu35hEu0f8i6 EykwFUI7gxouHdz6H19WXY7WMEPyk1k= Date: Thu, 29 Aug 2024 08:50:35 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1724946641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NPvXQD4BCJq+MDpwmNo5dOSJNnMv53fu4MweHVYAXuM=; b=Y98tF+x9Bup3yWhEkcT4ZeQ6FDxNx/2jeVpecnAHOk7/2BELrk6vJjAXtG0Z62It7ykFYV y4AzX5zl7qEqB1fMYgg7ZE6LkVoHlM9aFK3l3FOdyrRGY3dHLt8Bmi8JunAbNLLtoqnf26 txufsS0ND+4fhyXs/asLPeao5/6gqSM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Vlastimil Babka Cc: Yosry Ahmed , Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , David Rientjes , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Eric Dumazet , "David S . Miller" , Jakub Kicinski , Paolo Abeni , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Meta kernel team , cgroups@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2] memcg: add charging of already allocated slab objects Message-ID: References: <20240827235228.1591842-1-shakeel.butt@linux.dev> <22e28cb5-4834-4a21-8ebb-e4e53259014c@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <22e28cb5-4834-4a21-8ebb-e4e53259014c@suse.cz> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: mm1udrissbggssbmxmjqmbzfqfne63eu X-Rspamd-Queue-Id: 9F72BC0018 X-Rspamd-Server: rspam11 X-HE-Tag: 1724946642-943038 X-HE-Meta: U2FsdGVkX19atx/5b6CQBcXjprSdGFQUWK6d94+k2MldUqM/321Sx9s4RNFk35OIDR2RyFXvJ/Du719wvf6OqpnHpTt0UCnSRt6t9O4eCpw/azdVEH2kUX6/Xo509RpOerLUM2a4jUFduWNv3Ys7dUhYG488093GXqvxhKRmWyuiJWazqJgI4XEc+OubRFacXAI3LAtmLDRyXExrrUS2Ei3Lwl1JV6OO+L4pmIb8Fk4veYOYjBG8xtQLd0lwJoWsD4mjGg9Dv1rerEq+NfZ4EoBefPabV3WOSxfUYeKsVltfTRT3qujQyQkcN4K3Zr5GL9KJeBwpzSJEecyUiyAKCCrq2tV5J6AkVtrHdHRQjYcomITuLFBK2K+zyPPPjSbl85noE56hTtfL4mRjAl4UOrUrN7XrA2ZRHYU2bO9iT3oCa1t+ck16/c6o4EThD0l9AO2vyBnVKN4wx2qa8rRM4SGZm3u02hmOFaBb264hbiBcirY2z4ZP4XnYtDjXRFZ7wF06Rw1F/rhaoFIm2z227l6aklLVsAka5P6yBLtNsy2cwEa8NzaqoYBeqvZxPKwp/BcR7X/GRKWF2VD5iHS2dmqvMuSQCLz0vwPUk37/s4YwVig1p9dM431OhbMRpOznjqVhnh/UNfB6Ue3RtHy7ukY1zRHgFlTTa9uokYUnb+eZtnqYzTVThRIZMIJG2f1Vok6wFf5ETryrOpMiWOdOx1e6eX8BF1QYl20Q8dHD/X0+Dnx8xADeR/GXm+123A8SYkKae5pFubYv80k68kACeQW44nl9uKlw0b/0SJfiFZMgkhW0KbKvaVbarZ+Xk8xzwgkicfH+8kwtmdcq1miN/oiNfDvrxkwgX7kajvpxMkXdfuJlsLphjLaV/nDc4CjfsanlXUZ+wRCYRtdcPDDgiPDhp7qlJozsy2nQMn4ts4rRZwNV/9UB5zo0Ul0DAzFpb0lGu4g7cj/iXjY5wKb eLa1vUON qj9D8rHcdYuuOVq5NwaULaid2+GDm5MMiOAbu9DXZpodwyTgF6O7llOIIFW1+pISsV8XrI5c7F6veUu7dVkUWAxrpaTpK/JO9h+y3smbW6qyoCh5DLFHAXAAUWmqUrz9scqTnYibmPkTHwwHWy0TQ80a7DkK7KdF2Y9ACpZOeeIYF1L3sBuK8GCaUoEjnmSffzNJmM9AwtwYjZowfmdtGGIwRZ4zzPaRi/QIv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 29, 2024 at 10:42:59AM GMT, Vlastimil Babka wrote: > On 8/29/24 02:49, Yosry Ahmed wrote: [...] > > > > Personally, I prefer either explicitly special casing the slab cache > > used for the objcgs vector, explicitly tagging KMALLOC_NORMAL > > allocations, or having a dedicated documented helper that finds the > > slab cache kmalloc type (if any) or checks if it is a KMALLOC_NORMAL > > cache. > > A helper to check is_kmalloc_normal() would be better than defining > KMALLOC_TYPE and using it directly, yes. We don't need to handle any other > types now until anyone needs those. > Sounds good, will update in v3.