From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C783DCFC501 for ; Tue, 15 Oct 2024 02:04:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 568236B0092; Mon, 14 Oct 2024 22:04:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 515DD6B00A2; Mon, 14 Oct 2024 22:04:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31BD06B00A0; Mon, 14 Oct 2024 22:04:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0E7CF6B00AE for ; Mon, 14 Oct 2024 22:04:03 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 54646AC2F1 for ; Tue, 15 Oct 2024 02:03:46 +0000 (UTC) X-FDA: 82674191082.14.5C8698F Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf22.hostedemail.com (Postfix) with ESMTP id 4C101C000B for ; Tue, 15 Oct 2024 02:03:51 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=JgCASOnk; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=CDXxQPkN; spf=pass (imf22.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728957792; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n0McvGH/dIitVNzMLQpMaGWl80CykPAit3X6fMMbleU=; b=TXZAxWfBgCEOMEbzcuda0rqayqgG4wusVQ8pmBHtQDxY8Doh50lBKxfsxfPwSx8O/iOGR7 upZM26wkeBqB+L0onaDcRXCrhNme3qkpd4aS9BWMj4hGC2NTdAZJXJYs+KGqiRRrU3qkRa rS8hM+hV5M3ccO7cWa+kAmDE9OOKeZQ= ARC-Authentication-Results: i=2; imf22.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=JgCASOnk; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=CDXxQPkN; spf=pass (imf22.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1728957792; a=rsa-sha256; cv=pass; b=jmsh5O3G3WdoHxdFXMvka6YrvpHlOfHCxp57gn581UH1+PO72llrzIye/uDkhVokqhJcgt GKIasiboofxXD/8QZg/00I9NwWMQHppe32++QzrVZP19gLqvCBbJF1WLj6S7BlzqZNE2Uz RO4K+i/C0ihRIls4Nelt+oak0YNCScg= Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49F1Bj5h018933; Tue, 15 Oct 2024 02:03:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=n0McvGH/dIitVNzMLQ pMaGWl80CykPAit3X6fMMbleU=; b=JgCASOnkI+L2QKhNBGF4TdGerBhsKq2J1B 6Kaxyo7I5XHLWzjpmtVBf+K/dyCvS8CMc3RzbqN4EW1ZV+Nc3Z9bdho1ge8IgG3L lihw7QvHnBU7OmTI9TbYKkp3ZEsiibHQQSFV6vtDSk62RTFPHMRah7oXDkj4xJDx tdmifSJDliXdDumbsdiujAouROVEeNrGnhz1ODuxp88ljNnHkiLTT9oG89vvc+zp HLrULoDQ9XWYA12rUkXWS9+6gVwrwQLmtzRLhKWR+9ueItkNBjx03TFVJBM/Cuof xELmuF8jFiQI25ir+3Rd9hOm9tpPqnIDGa3fdaciIzpGH2kN1DAQ== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 427g1afhhc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Oct 2024 02:03:52 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49F1dhRW026283; Tue, 15 Oct 2024 02:03:51 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2175.outbound.protection.outlook.com [104.47.59.175]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 427fj6tb09-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Oct 2024 02:03:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HJF+Yb5n06FwmT1n2K82iBtwn4P9Mv4b37yhaTxIhoZ2a4GB/ppy5WZ85uqZIwPadHjVxQ23BS7Uesb5Y5xKDzYceL3XONAOwRAQ6sQG4Jw9L3jACbY8ZNx/ZEEUXUKiPpeEi4HmR1o/mf6ZEaZPHQgIm+6dcwdaArxHCX5x2sa2O/+E2klNbJ81ZXMFc/DnObAi6e1VZ/yUjPXyMwX/TpXjAs9P/FuMwur0dkyjzlRQK6inw/LqsGEGqB/h0m/vppVycsDkQxFJ6gX71vU9qyUagWaYX/fRnwBd2LPjHue/br9pJYEyUdGvaefaXtvBrcVcba0fKebEPSC+uMEwNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n0McvGH/dIitVNzMLQpMaGWl80CykPAit3X6fMMbleU=; b=WJWiMygCfH9itEMbNpwrPh59KBQGhBD7aiUmHgi0KXpIbMWnCaxemIglhReGinPExdTYJcx8/61wsq3K775s+MJTgmX70dL5unJ/HYPYS9KbKckV9I2sMTZ6sESMre84uBxOqZ3z3ER+GTXWsszaSB79sDC46ASeuWe3Xaq76HplBcLohsaygblO8odQGCw8pWJ/WbqQOEOJPpAkrxO/57nT3zfa4V7psNFUGLxwFRdkgoiT2ZECVIv/5D+zY7l9sNqaRt6RVFian9ukKrpsoqsn6rU+I0rBWRS5FBJKdjPQPDRW1TCEVv7Mw/qMA+QLPXaJdi3P1S6ZSrtk1cWeUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n0McvGH/dIitVNzMLQpMaGWl80CykPAit3X6fMMbleU=; b=CDXxQPkNXZvDa6tylqvP/oRwKLsggPCAlqWHB9NN2fK8T6U7KInc8gJZIdUFojOwwafNeXWyeOsuAgmZUzktsUcWI4FqqE8QDGlGSAXBI5JECfQj4ylkgOyqWhYPfWvM888qdmRb1z20nJrOeW+ChiXOt5MQRFJtTPP01dOoOA0= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by CH2PR10MB4278.namprd10.prod.outlook.com (2603:10b6:610:7f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.27; Tue, 15 Oct 2024 02:03:48 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%6]) with mapi id 15.20.8048.020; Tue, 15 Oct 2024 02:03:48 +0000 Date: Mon, 14 Oct 2024 22:03:46 -0400 From: "Liam R. Howlett" To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, akpm@linux-foundation.org, willy@infradead.org, richard.weiyang@gmail.com Subject: Re: [PATCH 1/2] maple_tree: check for MA_STATE_BULK on setting wr_rebalance Message-ID: Mail-Followup-To: "Liam R. Howlett" , Sidhartha Kumar , linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, akpm@linux-foundation.org, willy@infradead.org, richard.weiyang@gmail.com References: <20241011214451.7286-1-sidhartha.kumar@oracle.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241011214451.7286-1-sidhartha.kumar@oracle.com> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT4PR01CA0170.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:110::10) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|CH2PR10MB4278:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e6ffaa5-a61d-4967-2e25-08dcecbd9b7a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?mQtWKCG7g0IZ2ccJynYayLSp7ZpMEdshgsr0F04RAQqFDTgkq82vgymmH5jf?= =?us-ascii?Q?iya5IJBnTksVGa0oHvyxA5fPo6NVF1AQSfyxhEQORkqSu7NX4mt/AaeqDxox?= =?us-ascii?Q?6NcLGT0cTWGwcy90qcqnXdjJksn8wROHbfHV4Bdltu6oRrIH8gayKcIorRBD?= =?us-ascii?Q?PFYhDhLhUWFZYKC2G1vu6vPxt14w7iq2LdvkNWHvj6EH3VUQdLSJoApC6GW9?= =?us-ascii?Q?QIA+o3AHz0vPGpQ0IAA+N4AELJSNEv2/nqPQ6zmxuRuu7fDjHDLUntSb5G5v?= =?us-ascii?Q?t11qcrUtpfiF77IxfEif++jQH487x5VjkFD3voPM9OoOxX0SXv3SuMXWRzcA?= =?us-ascii?Q?qnSvxw3JJJ5C+O0THLSJJ6puLoAfbJPKGF0iMVhP24E8TCbtEFeQA2eiJWvI?= =?us-ascii?Q?4TpnkueyTh5GT2e3l8gYI6f9MOwBMiN90t8KOXx36yGdmMSGJEhMDwnmzgzM?= =?us-ascii?Q?48dpFiF0gTJgPoFhIdkJxMUxmr4FGbH12c6WrSn+tJpW5r2y4ZQcqMBzP/Kz?= =?us-ascii?Q?bjF+jQCoF3ITAjzw9Gs3X6Re3649uyvKCHMvNatwvwSOl7z84HDDHWh5uBk2?= =?us-ascii?Q?zyNl4cLjhuwZoJ+p9jBlQF1PbgdrZxGErRE1oIF+5ks2qJrik8FW7HP5gltp?= =?us-ascii?Q?4LI3CoibCJYVCE0nNFobrPw4+i6kMeiowdJtHmVVoa77rGOPtjQHDa+UGd6o?= =?us-ascii?Q?Mqjg0s4kkjoUjZoKXDpaN4IZjJr3uiJeyNyDQCqFM2kcr7FLMU7+2GuvDDog?= =?us-ascii?Q?TrGSt4462zwVq7GjXsTVJTtb+ITWiJcuXKsbWubFKm72JMDa+93Own9STxNd?= =?us-ascii?Q?Zg09E+XJWvEzGo3GZ9VbeKaB1LOzkc2oRlJT0wmT9s/zl+DTnzF+DrV8A8hV?= =?us-ascii?Q?NrH2rExLF0lLQjW1KfnzBniYw83WrIJAfnmc1my7KpqfPj28z9x6KwVUuz30?= =?us-ascii?Q?I3beNGPf5eJQdi6hGw2tVO5t95nS8VJg/5Nv65OPygJiPKo4NGcxsD8A77n9?= =?us-ascii?Q?SY/Mg0ptEK5b1DDMTZ8KASKDCVCBpcVohe3qR2MhavHmq3yhRbAWA2mBOrfO?= =?us-ascii?Q?HdYL6ncp8qieoDryEgc18XjunnbqxJ7Z+NPd+wEArXWZ6rEtE/QNT/c9yq01?= =?us-ascii?Q?Ea6GGYMLWPiW8L3Wca84uvMG5UDNAe7el3NIcYc5dCc+tHtJJTnWck1wXZHB?= =?us-ascii?Q?49W5nJwdvpstTWm9T4gJFWvKz95d/dF+cWTbGk+LX5kvucvmLts4db52fVx+?= =?us-ascii?Q?tpN5vqOiRpwtQHCjb75ArqzSnrxr6LKZxeaDdGdWKA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0okguWmwU2tztkXPNfUK8zFyAPk2gu37uyOcHiS1pz6wR3MmNF76Y/aRzKQ8?= =?us-ascii?Q?5fV1K0wLUf36GvJq07Ao8h50jQxZE8mXqIIJousO8zGFC/Fd/lN7OJHGBMCQ?= =?us-ascii?Q?dp9+JvsNi9EhYyGUHitnNuLAB5zLeX2zW65Zy1HBWzKNW1x+I9LCrzvT9Irq?= =?us-ascii?Q?m69nOUkOCbysgXiagd+D0/FOESxJweOranTSPskYenSKTzVwggnIjOFo3Tg8?= =?us-ascii?Q?ft6o75/Y8/Arzme29VyHC5ofGsKd9ehJo31zcD0CVCIJgETRrX+D+6QyUyfi?= =?us-ascii?Q?FmFVkmy3U4UNjC8GK7TbQ7Qt1VdmzJzE4i49WpQQdpThlGD7R5N73/APdVU6?= =?us-ascii?Q?r3PGqNlQTupPF4BxJaMZsgvmEOETTka4RD9esaZ63ob0XwflNYrPd55+AyF8?= =?us-ascii?Q?9363Q5uzWt7TXU3HmKSVXBcg+w0jeOiCsKMtf6sCFobQBABQuD773XPjfz7t?= =?us-ascii?Q?466Eq+FBT88YQkFRZryPnh1fmJYKkMj5iqN9pHrSOU5LS7QPD9LOivwtjSjl?= =?us-ascii?Q?WimzD2ShvusVZWXOSY9yR8zwFI5z2vnndXrxBPQ1cYowDf1K1Vwew1Do5kgb?= =?us-ascii?Q?cY6jHP+PZQhpGQZ01mydPSnWB9XUgYPA/hOOGFjc6cpWHAqg9S99fAP8HqFj?= =?us-ascii?Q?sGhwtYo7DMp4Ch9IXErvKMWWJnZv0Y4ZekVnPZhXdQZeVetx95jetjG86iz1?= =?us-ascii?Q?DZ4tBjLeZ9rSVECosmTVBDu3Zr3huGfbgxH8z3IzyLKbxjPYDJby/Hb/4n9q?= =?us-ascii?Q?0PbRDmsJROEgNm6gpMBXqDO2fX0J8GnSfUfk3QRMVLcrKS2I2I30r1mgwW1k?= =?us-ascii?Q?Wu1wd9MzdinZpCWw0EBPRRUJGtQdH76uHl0GzZyQddjt3kc1CBa2HKBBLeio?= =?us-ascii?Q?ftXZHfu5E+kBz/SW5o5msBkep1hInaB8ylwMc01mm1qEA4/ZWsmgYmhZrq0m?= =?us-ascii?Q?ugLTeYd22WeJ1dSn8cVeDJRe1ckYvXOfMACfBNuvNmydNZHxW7I/ZZNX/pOZ?= =?us-ascii?Q?reymunHyRKFDWPo+5BqslxoX1pL6iAFvWnrOqzd42hXQxlfUvZynEXU9TTG4?= =?us-ascii?Q?GgJb7knds5NxUh9X3X8+JOpmMcJlWM0TyPLe7xfWy8IZFpmOHDh+rGT2vago?= =?us-ascii?Q?QFUceozO09dDKA1Rg4wYh8wPJ7YKBUYcqbzO8iT3/MnZNIipkd3M+JZ4WNdh?= =?us-ascii?Q?v+c416cQy7F8xXS8yjHB6TTYBSJrkVppqeIn/HoSv7lzFFAsUziBje+ZHHPI?= =?us-ascii?Q?pn1v2VLi4kawn30+pVLouccsshcHZFukA/Y3zFxXz2uIHG+zvWvEjqqPMkoO?= =?us-ascii?Q?QIR2JeGvY8xh0IUs0wD6dH0aJ2vFpnGjVQItY1tqjsxc15v9sj0Zyr4wTUci?= =?us-ascii?Q?jL1eEHTb7enWuwLjRtPHSxSDW6Y1gbjMuI0CyYLenYQ5+SKmjvzkJAi5YMod?= =?us-ascii?Q?JzRwBJ2c5tkiaFPNgkMIvYhGEgEAJpMAaG1k4ZF36LfdSkEExif5xyx9z9hf?= =?us-ascii?Q?q9E52aAuPv4vcW+7WnK6Jefc4fRDoCRJ7xVHHbDyrRH+PcBh44Zx1jgjWRQg?= =?us-ascii?Q?XLkFo1fu2V9onZhsFJLL8/I+wUGb74uRXdKmDCyn?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: BJBksf7K4Eoa1hSrJqayku5+67FlU0QCKyepox7lxq0G2QZVlH3vzutktOuDvOUsptq/mdQpr4PpAW89zKU+qA5xVkXLwcZqcTlif7a8NaGTuHUhPd8noC/BrhnSigTXUTzzV68jQtvK78RTNg1qA7pWzrG8R3hY4dZ0PXWnpso6XFbWuh4Hg6BdEWUBx4/hgc/Lj18rn0UX6ZLSeoFW7aCbtqnvBkMTzFpIXA0WrrXV2DiQa09pJ+dYSZ+SX9n6xplp8O3XBI+Md47+RfRHo6cz5DU4V7qp36choLr7JNCTFRaKmBepK9AiCh568mmDPa2hAbys/PNErhakrU0HaCul2xSLJeg9l7c6BCD0zDmcgDRy2vET4pmbEaLLmx9C3ruzKcWiwgWlcVPEtPWg/XAeTCgiWcL2UIqY4ee/KpehpUtayLq5OERCNN3VGCKUaMNfRkQ/7DW3E9eOEwTVZBufA+r5Y56Z0Rp+WGF30P1wbWURMO5ldjtHpOJg4L6PHq+6QYl/VzpRtpSJIohrqYR6z3HQesI3+0sVRFyYhXFeM7B6F+2FIjdoUdammSDAgNBJxL3KAQjX+rb+Rw0wJ4NkkdE0YU4ZPC6UI1+HUfc= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e6ffaa5-a61d-4967-2e25-08dcecbd9b7a X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2024 02:03:48.2039 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FjhmmV7xab7K0BDQDYXBAgEB2HvvztkWTMu/Rr11/lwq3lcrEPM3ISZ2SqLwOpdQ5nV3UE9eSuHxTW6KJkQyYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4278 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 adultscore=0 bulkscore=0 spamscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410150013 X-Proofpoint-GUID: 1X-Jz4MwHcgur9MrbFIPoNssa81ACWkq X-Proofpoint-ORIG-GUID: 1X-Jz4MwHcgur9MrbFIPoNssa81ACWkq X-Rspam-User: X-Stat-Signature: 8ejwa1jhyhf3ypj985dsb5of1tuyoxjk X-Rspamd-Queue-Id: 4C101C000B X-Rspamd-Server: rspam11 X-HE-Tag: 1728957831-514639 X-HE-Meta: U2FsdGVkX18Q0dt/+rWY3YAhga29nSeYqig8a6QhoEWNYnjLfo7ObaRnlnjHNhoL3VyYRFfLmx4YxYCD+sPYmO6qohBDeJOXPFFdc9ej+O7DBL7pJZZcRju4etzQdqQjGZ6KGdmFtbflfPZCyQMjibWEbqrd07qiAnIRWj9dnObqAxxT11SmuaR1zhWhoKp+F6j2QWdAS4LwgIhRAyFEbPHhLN+NGVxhwwqM0RHvHSpncmeBqfrHELBpfK0V5znnY57IhaxNzr5bkmpyrk2eL4gT4yfjPho1RMJsydHcL5VKV1n109KRvWAfxemPEyQC9Yn8PuLxJ23yVkyeLR8dqcwoVfIgFO3lrmjmVhbznIi8aWz6BSHsrhcUmDrn5uk+4W3X8MKpL8OiPs2Sf801vyWoNzPI5gBoCAFfucqbPWNKLx1SZve3P+b1gD5wx5Bz3CkrRJO56M1mv3Grmxa1yW+PlM0+ijcipyKf0NpPtcXd/XEeu4JG35BPneNHk9pMm/s6YjxMVBizKe5YBJss9ylL8lfb2ZyIyorB6gbpHoXLZssFt6+mgt6VSZUVrWOJfCIExsSf6Dk/DpQE63ZllAUGb40SfS4aHbpgMmOHSNvu5XFQR9F13vwTdyMW/G9n8v6fPH0Lph7JM9EcO1K3GSRDGaE6p9Fl7zEWsU+kXH2PBCnK6ypTFTM9nzUAK7cHioqrXvPZkXyyh8cWzX4LnjiKro5FGZE+D1p3kxh+iTWl+KctODtdGFYaoPrUF9VGxFRo+cZNIQX5yujgpVAvsKzrU+hGBLWR1wNFg4DHIl7FNovtk1oHlFq24QjQwcJ3wvCM0D1cezwmIQ5nF4bGXR1e6oCeWxZ6w3zGMAOBzeK5q6aqtdiE3t+S1+1yfTckfflKxYCn7jF9g2E4IWaD5wT2MnGyvnFD3e1qqfWI9JMVJjzS+ySzWuSlkh6i8OsqE1WgfPt/HnGlSRevLue eGiMwKFm L44DsJMBIgzpJTPN9DPtYGm9YYjZFCNjvDXiLg0xVWgbpw5fdswoReQeXxThnHIwTCoQl/hxOwqaBIXfneoRKi8vJ5HK1DZhp+7Rc/mEu561iTDAt5JmNZbM2bQ2KrtWgYAUkTvSFULG1VoHtxNS9uvAqUqZ5jxi7BmwcEu6CSLU4QF0h8vYomYRrh0wLmFVsrtbWZCXQDypiptgamhRzdR/K1JIoz1cNV72tOr8jHeuMKe0erk2XanQUQHhcnzisb5BYOdsbE3WYj17CTWPMacw6zZShi/abT6/QR7t8cLAzAVFcpe2K8kZxfIy9IpDYT9ycO/i9g/5+J2J42dt+lm160PNTsWgh4PojpVcrJ307Un8ImzGZM91lzwe26tKVWWSxNEFflZapcQJ4eLPYiLNIQLRtnRk2wjY74cxQTEhd2esTu68/mgoGwBP+2b3vAKBU/z6dkNxnxxvbELcrUuwbpxiLn38pGHqoElIOuyXWtaoqJd4MyyoWfSdzgSe8iHOPtSyPgNZpqvhUzTPkDN9aaDxnhQ37UdOsRjg50fW92RRUNdE4XVyn0yEHCJQmbGY9Gv21Tv/5pGZBtADAcO5lxhm/ebsHrHgFeo8lJsgvgvsYu5W2ZLAdh5Ry33AnUfU8tjQBT8SrGZTxGf3Hy9DDw3DjPpGVP3MWoYLnWtWvY64= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Sidhartha Kumar [241011 17:44]: > It is possible for a bulk operation (MA_STATE_BULK is set) to enter the > new_end < mt_min_slots[type] case and set wr_rebalance as a store type. > This is incorrect as bulk stores do not rebalance per write, but rather > after the all of the writes are done through the mas_bulk_rebalance() > path. Therefore, add a check to make sure MA_STATE_BULK is not set > before we return wr_rebalance as the store type. > > Also add a test to make sure wr_rebalance is never the store type when > doing bulk operations via mas_expected_entries() > > Fixes: 5d659bbb52a2 ("maple_tree: introduce mas_wr_store_type()") > Suggested-by: Liam Howlett > Signed-off-by: Sidhartha Reviewed-by: Liam Howlett > --- > > Hi Andrew, this commit is a hotfix for this rc however it has no userspace > effects as there are no users of the bulk instertion mode. > > lib/maple_tree.c | 2 +- > tools/testing/radix-tree/maple.c | 26 ++++++++++++++++++++++++++ > 2 files changed, 27 insertions(+), 1 deletion(-) > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > index 4b423330d83c..b3b1d4b8126b 100644 > --- a/lib/maple_tree.c > +++ b/lib/maple_tree.c > @@ -4228,7 +4228,7 @@ static inline void mas_wr_store_type(struct ma_wr_state *wr_mas) > > /* Potential spanning rebalance collapsing a node */ > if (new_end < mt_min_slots[wr_mas->type]) { > - if (!mte_is_root(mas->node)) { > + if (!mte_is_root(mas->node) && !(mas->mas_flags & MA_STATE_BULK)) { > mas->store_type = wr_rebalance; > return; > } > diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c > index 5fde09999be4..551ae6898c1d 100644 > --- a/tools/testing/radix-tree/maple.c > +++ b/tools/testing/radix-tree/maple.c > @@ -36317,6 +36317,28 @@ static inline int check_vma_modification(struct maple_tree *mt) > return 0; > } > > +/* > + * test to check that bulk stores do not use wr_rebalance as the store > + * type. > + */ > +static inline void check_bulk_rebalance(struct maple_tree *mt) > +{ > + MA_STATE(mas, mt, ULONG_MAX, ULONG_MAX); > + int max = 10; > + > + build_full_tree(mt, 0, 2); > + > + /* erase every entry in the tree */ > + do { > + /* set up bulk store mode */ > + mas_expected_entries(&mas, max); > + mas_erase(&mas); > + MT_BUG_ON(mt, mas.store_type == wr_rebalance); > + } while (mas_prev(&mas, 0) != NULL); > + > + mas_destroy(&mas); > +} > + > void farmer_tests(void) > { > struct maple_node *node; > @@ -36328,6 +36350,10 @@ void farmer_tests(void) > check_vma_modification(&tree); > mtree_destroy(&tree); > > + mt_init(&tree); > + check_bulk_rebalance(&tree); > + mtree_destroy(&tree); > + > tree.ma_root = xa_mk_value(0); > mt_dump(&tree, mt_dump_dec); > > -- > 2.43.0 >