From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 544F7C71148 for ; Fri, 13 Jun 2025 17:00:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4B806B007B; Fri, 13 Jun 2025 13:00:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FC906B0089; Fri, 13 Jun 2025 13:00:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EBC56B008A; Fri, 13 Jun 2025 13:00:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 755926B007B for ; Fri, 13 Jun 2025 13:00:31 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1DA3EC0D52 for ; Fri, 13 Jun 2025 17:00:31 +0000 (UTC) X-FDA: 83550991062.27.3627EFA Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf03.hostedemail.com (Postfix) with ESMTP id 38C722000D for ; Fri, 13 Jun 2025 17:00:27 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="u9aG/XAy"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ocT+pKRE; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="u9aG/XAy"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ocT+pKRE; spf=pass (imf03.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=pfalcato@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749834029; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UievMDUraOnDMl0JUSi8sCjrJFjc+fcUJjXG5uHY0QQ=; b=gZ8u3iyE2KUIMQUvCvCQygl71Y5yDAuU4K73InroHzwRhmG/zlY6K/dsC/rZi8NsimI8a5 X9Shs52CermhDHMajCAGWGZGncY2VzJj4xyr0zp2PXA+79oRAQtTpo8W95oexncege7X2j 5nqo/ZHeOfBPdifPnuyhgV9WkCn6jmw= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="u9aG/XAy"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ocT+pKRE; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="u9aG/XAy"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ocT+pKRE; spf=pass (imf03.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=pfalcato@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749834029; a=rsa-sha256; cv=none; b=j5V5HDxiQJevVq0Wkv8wATE6TztSux8ibwvbSoYQ+BjS0ubKm0P1+zFWyNcROM3vX23XOu PyJeymMuJCSRFzONjChuacf3XFUfgHVUvzjxfjTt4kS2Klbj6wSU0PkXjxxT+TtyfXyrbA fZqN/RWGmxYR556D4eeYB2a+11oJf1s= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9339C1F892; Fri, 13 Jun 2025 17:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749834026; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UievMDUraOnDMl0JUSi8sCjrJFjc+fcUJjXG5uHY0QQ=; b=u9aG/XAy248ET//vYRdstDzkp9e1gMhJ9a1HNBFgWBgkqQ+DzLQHTCdDuzdjJXNyc8sQsj tJc3ghB024EctTUGHt0guaki0rPUDLxL5DFjJKiMw905+EiBJYUwcxBNeS8E/WWZh42zr6 W+MEoKdKBOaRPeamP6LjmhCF59/urCQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749834026; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UievMDUraOnDMl0JUSi8sCjrJFjc+fcUJjXG5uHY0QQ=; b=ocT+pKRE0yIBuDKH/NadiAPPUhisX2hRv3LVIi3nXKaMqJ6vwZH5DwuI1Zki5i8j1KTFCd UVHFb9xm6+EPziCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749834026; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UievMDUraOnDMl0JUSi8sCjrJFjc+fcUJjXG5uHY0QQ=; b=u9aG/XAy248ET//vYRdstDzkp9e1gMhJ9a1HNBFgWBgkqQ+DzLQHTCdDuzdjJXNyc8sQsj tJc3ghB024EctTUGHt0guaki0rPUDLxL5DFjJKiMw905+EiBJYUwcxBNeS8E/WWZh42zr6 W+MEoKdKBOaRPeamP6LjmhCF59/urCQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749834026; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UievMDUraOnDMl0JUSi8sCjrJFjc+fcUJjXG5uHY0QQ=; b=ocT+pKRE0yIBuDKH/NadiAPPUhisX2hRv3LVIi3nXKaMqJ6vwZH5DwuI1Zki5i8j1KTFCd UVHFb9xm6+EPziCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id ABD6713782; Fri, 13 Jun 2025 17:00:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id LSjlJilZTGgwRAAAD6G6ig (envelope-from ); Fri, 13 Jun 2025 17:00:25 +0000 Date: Fri, 13 Jun 2025 18:00:23 +0100 From: Pedro Falcato To: Lorenzo Stoakes Cc: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, Andrew Morton , Alex Williamson , Zi Yan , Jason Gunthorpe , Alex Mastro , David Hildenbrand , Nico Pache , "Liam R. Howlett" , Vlastimil Babka , Jann Horn Subject: Re: [PATCH 1/5] mm: Deduplicate mm_get_unmapped_area() Message-ID: References: <20250613134111.469884-1-peterx@redhat.com> <20250613134111.469884-2-peterx@redhat.com> <1fa31b8c-4074-45c7-ad59-077b9f0ab8fb@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1fa31b8c-4074-45c7-ad59-077b9f0ab8fb@lucifer.local> X-Rspamd-Queue-Id: 38C722000D X-Rspamd-Server: rspam03 X-Rspam-User: X-Stat-Signature: 3u616zngboxeddrh4n9gep87696sh76p X-HE-Tag: 1749834027-91775 X-HE-Meta: U2FsdGVkX182/cN+Uri18OiAwpD2aoBoF92XbSnglsxRdQniIeFWJmmYTYaWSXXdrxwu2QdjyrAzYWGjmMQ22jqLFmVgndjd3ftyb/v2dd8tdsZwhFKy/jEozYrY/mIwpU/BN3jJTGVGwnL8BWgPTQMIL0W0F/BhnY8zv404HCBsgHcYRM2lcrpO3DUjKp3egP1IeIsyvpiwWWvjJyIOtLbTAtzLIg6Nv3FzclynJs9tIHD3/spWfXOb/XVWrQLaN3mq7l+pO0oGiSi4glD2Iz/OSboa1Dx0PqpXkhoUc5wB63N/Kpn1Jai4j6qapRrfQMoqsr/S1NLUp9PwrkvIAwIUWo3iv7Yk5RbcnEwaAQd6qFzMgYtdTCLmpvLIOm9UixrUFX6OKyceOyi69ftH5m7EHVly1EIzwusmQcbGivEWk+ztXioMLMXMfAJAC1kVAeGdr49Tp/v9tJVWpdueRcRLVwxZ5HYSTsT5n7KueWSpK7B+vPBw4LAEYn5GqkhO110QTs1V1KrynLlmTgJ1fJxXqB1UpVkH7uQfvHFY4Hko5seoSNTCqZHXbFUkcz/DOpXXO89B6LFaJRNeP1xRgfHq0y1iuRJRoZCihJ/XWdSbdGpa4Bgnl1SLgc6JK/unSjdrpkX7XxjNHfY4tB6y9kTSqtNmYQnz1gOEHEXiKRO5DklK/pbHr563lMCNvmwnMM8huuWo1gDNQUZWQ/X+3T8VVCB+bEw5ouKVbRZNtYXpr9tTVhIHngvmswAQDi+pgTvgG+vli+Y+sL2i6nrMEDt4zS3aJz832F+g+bBFWi3aDjw3Op5mjL/91+jVCnCfbTdxNy+MdkoLa0G0h0hnJ/OgHE0Sgcj3FI85uR+zzYp3SawuZydki36JmrDojfjMMQ7PHUUeijJmv5o5qo9IbYX+5yIuAzb3IoJu68J5lWp8zCy007Yl4mRsn6N1fhwV3BLWzT3jp99wPVD0GGG o2In77vo LeZ5kcPQo4UNisyz6hTEZil9F+rdsprVH5k4mciAYHM78X5jHKt0H2P3a5MnIqKBJpXvQW29DZfJ2X0ZXgSUfT9V4hKLb30vKoLnZxqw8ghZ7l8DJEv0HuFKNj8MlGROXPJotsWRDHQ21u6/ShBXtsLfOtjTQ5cJLXiVluS9zk6pLP4xoTAmYIHhFbeBcvFlEzMx4is3o2xXd63AnrhzaKDNDWv+ls+aB3x8wHJU9IRWfq4V7YeLAoWw23pxDL75KF8kutdEW9uSSRumA1bvPY8c18ddiO6qtL7795jwVlR+CwMU5qjIdKtVx8Kthk6qYPxQ7omimCyWyZ7XpuhTKaNt0Mrk3VqMEw7x8+AKUYV7BFE15tWsovG6Gph9jhs34ybgfnc+7cH4Ffwy8B0p41AKVtw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 13, 2025 at 04:57:12PM +0100, Lorenzo Stoakes wrote: > You've not cc'd maintainers/reviewers of mm/mmap.c, please make sure to do so. > > +cc Liam > +cc Vlastimiil > +cc Jann > +cc Pedro > > ...! > > On Fri, Jun 13, 2025 at 09:41:07AM -0400, Peter Xu wrote: > > Essentially it sets vm_flags==0 for mm_get_unmapped_area_vmflags(). Use > > the helper instead to dedup the lines. > > > > Signed-off-by: Peter Xu > > This looks fine though, so: > > Reviewed-by: Lorenzo Stoakes Reviewed-by: Pedro Falcato Looks good, thanks! -- Pedro